[Lldb-commits] [PATCH] D13617: Fix ref-counting of Python objects

2019-10-07 Thread Zachary Turner via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rGf8b22f8fea18: Fix ref counting of Python objects. (authored by zturner). Herald added a project: LLDB. Changed prior to

[Lldb-commits] [PATCH] D17492: Case sensitive path compare on Windows breaks breakpoints

2019-10-07 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG47c03462f52a: Some fixes for case insensitive paths on Windows. (authored by zturner). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D17492?vs=48871&id=223585#toc Repo

[Lldb-commits] [PATCH] D27780: Make OptionDefinition structure store a StringRef

2019-10-07 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG182b4652e542: [StringRef] Add enable-if to StringLiteral. (authored by zturner). Herald added subscribers: llvm-commits, dexonsmith. Herald added a project: LLVM. Changed prior to commit: https://review

[Lldb-commits] [PATCH] D55574: Remove else statements after returns

2019-10-04 Thread Zachary Turner via Phabricator via lldb-commits
zturner added inline comments. Comment at: source/Commands/CommandObjectTarget.cpp:2569 + } + StreamString strm; + module_spec.GetUUID().Dump(&strm); aprantl wrote: > Can you manually double-check this one? For large complex cases like

[Lldb-commits] [PATCH] D67168: [Windows] Add support of watchpoints to `ProcessWindows`

2019-09-04 Thread Zachary Turner via Phabricator via lldb-commits
zturner added inline comments. Comment at: lldb/source/Plugins/Process/Windows/Common/RegisterContextWindows.cpp:82 -bool RegisterContextWindows::ClearHardwareBreakpoint(uint32_t hw_idx) { - return false; -} + if (!size || size > 8 || size & (size - 1)) +return false; --

[Lldb-commits] [PATCH] D60152: Fix and simplify PrepareCommandsForSourcing

2019-04-03 Thread Zachary Turner via Phabricator via lldb-commits
zturner added inline comments. Comment at: lldb/tools/driver/Driver.cpp:492-496 #ifdef _WIN32 - _close(fds[WRITE]); - fds[WRITE] = -1; + _close(fd); #else - close(fds[WRITE]); - fds[WRITE] = -1; + close(fd); #endif labath wrote: >

[Lldb-commits] [lldb] r357513 - [NativePDB] Don't fail on import modules.

2019-04-02 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Apr 2 12:39:45 2019 New Revision: 357513 URL: http://llvm.org/viewvc/llvm-project?rev=357513&view=rev Log: [NativePDB] Don't fail on import modules. A recent patch to LLD started emitting information about import modules. These are represented as compile units in the PD

[Lldb-commits] [PATCH] D59911: Don't abort() in lldb_assert and document why.

2019-03-28 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. In D59911#1446942 , @jingham wrote: > In D59911#1446745 , @davide wrote: > > > My (maybe unpopolar) opinion on the subject is that "soft assertions" are a > > way to cleanse your conscience

[Lldb-commits] [PATCH] D59854: [Host] Add LibraryLoader abstraction around dlopen/LoadLibrary

2019-03-26 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. In D59854#1443906 , @jingham wrote: > In D59854#1443904 , @JDevlieghere > wrote: > > > In D59854#1443891 , @jingham wrote: > > > > > It isn't safe t

[Lldb-commits] [PATCH] D59651: Move DebugRanges() function from SymbolFileDWARF to DWARFContext

2019-03-21 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added reviewers: JDevlieghere, clayborg, labath, aprantl. This should be the last non-dwo dependent piece to get over to `DWARFContext`. After this there will need to be some careful refactoring to get all knowledge of DWO-ness into the `DWARFContext`, ult

[Lldb-commits] [PATCH] D59611: Move the rest of the section loading over to DWARFContext

2019-03-21 Thread Zachary Turner via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rL356682: Move the rest of the sections over to DWARFContext. (authored by zturner, committed by ). Herald added a project

[Lldb-commits] [lldb] r356682 - Move the rest of the sections over to DWARFContext.

2019-03-21 Thread Zachary Turner via lldb-commits
Author: zturner Date: Thu Mar 21 09:34:58 2019 New Revision: 356682 URL: http://llvm.org/viewvc/llvm-project?rev=356682&view=rev Log: Move the rest of the sections over to DWARFContext. This is mostly mechanical, and just moves the remaining non-DWO related sections over to DWARFContext. Differe

[Lldb-commits] [PATCH] D59611: Move the rest of the section loading over to DWARFContext

2019-03-21 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. In D59611#1437044 , @clayborg wrote: > Use reference to DWARFContext instead of pointers? Apply to entire patch and > good to go Done. Since you conditionally LGTM'ed it based on that and I made that change I'll go ahead and s

[Lldb-commits] [PATCH] D59611: Move the rest of the section loading over to DWARFContext

2019-03-20 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added reviewers: clayborg, JDevlieghere, labath, aprantl. Herald added a subscriber: jdoerfert. This gets all of the remaining sections except those that are DWO-dependent. That will be a bit harder to do since we'll somehow have to get knowledge of DWO-ne

[Lldb-commits] [PATCH] D59562: [SymbolFileDWARF] Introduce DWARFContext

2019-03-20 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL356612: Introduce DWARFContext. (authored by zturner, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D59562?vs=1

[Lldb-commits] [lldb] r356612 - Introduce DWARFContext.

2019-03-20 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Mar 20 13:49:25 2019 New Revision: 356612 URL: http://llvm.org/viewvc/llvm-project?rev=356612&view=rev Log: Introduce DWARFContext. LLVM's DWARF parsing library has a class called DWARFContext which holds all of the various DWARF data sections and lots of other informati

[Lldb-commits] [PATCH] D59562: [SymbolFileDWARF] Introduce DWARFContext

2019-03-20 Thread Zachary Turner via Phabricator via lldb-commits
zturner marked an inline comment as done. zturner added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:552 + data.Clear(); + m_obj_file->ReadSectionData(section_sp.get(), data); } clayborg wrote: > clayborg wrote: > > ```

[Lldb-commits] [PATCH] D59562: [SymbolFileDWARF] Introduce DWARFContext

2019-03-20 Thread Zachary Turner via Phabricator via lldb-commits
zturner marked 2 inline comments as done. zturner added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.cpp:50 + +const DWARFDataExtractor *DWARFContext::getOrLoadArangesData() { + return LoadOrGetSection(m_module, m_dwarf_data, eSectionTypeDWARFD

[Lldb-commits] [PATCH] D59562: [SymbolFileDWARF] Introduce DWARFContext

2019-03-20 Thread Zachary Turner via Phabricator via lldb-commits
zturner updated this revision to Diff 191510. zturner marked an inline comment as done. zturner added a comment. Updated based on suggestions, including removal of the `m_dwarf_data` member variable which holds the contents of the `__DWARF` segment on MachO. CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D59562: [SymbolFileDWARF] Introduce DWARFContext

2019-03-20 Thread Zachary Turner via Phabricator via lldb-commits
zturner marked 5 inline comments as done. zturner added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.cpp:17 +static const DWARFDataExtractor *LoadOrGetSection( +Module &module, const llvm::Optional &mapped_dwarf_data, +SectionType sectio

[Lldb-commits] [PATCH] D59562: [SymbolFileDWARF] Introduce DWARFContext

2019-03-19 Thread Zachary Turner via Phabricator via lldb-commits
zturner updated this revision to Diff 191421. zturner added a comment. I went ahead and just removed the const `get` version entirely, while changing the other function name to `getOrLoad` as you suggested. I have another patch while I'll upload after this one that converts all of the rest of t

[Lldb-commits] [PATCH] D59562: [SymbolFileDWARF] Introduce DWARFContext

2019-03-19 Thread Zachary Turner via Phabricator via lldb-commits
zturner marked an inline comment as done. zturner added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.h:30 + + const DWARFDataExtractor *maybeLoadArangesData(); + JDevlieghere wrote: > Why do we need these two methods? I presume

[Lldb-commits] [PATCH] D59562: [SymbolFileDWARF] Introduce DWARFContext

2019-03-19 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added reviewers: JDevlieghere, aprantl, clayborg. Herald added subscribers: jdoerfert, mgorny. LLVM's DWARF parsing library has a class called `DWARFContext` which holds all of the various DWARF data sections and lots of other information. LLDB's on the ot

[Lldb-commits] [lldb] r356509 - Delete more dead code.

2019-03-19 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Mar 19 13:08:56 2019 New Revision: 356509 URL: http://llvm.org/viewvc/llvm-project?rev=356509&view=rev Log: Delete more dead code. All of this is code that is unreferenced. Removing as much of this as possible makes it more easy to determine what functionality is missin

[Lldb-commits] [lldb] r356495 - Remove some dead DWARF enum -> string conversion functions.

2019-03-19 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Mar 19 11:32:43 2019 New Revision: 356495 URL: http://llvm.org/viewvc/llvm-project?rev=356495&view=rev Log: Remove some dead DWARF enum -> string conversion functions. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFDefines.cpp lldb/trunk/source/Plugins

[Lldb-commits] [PATCH] D59276: Delete dead code

2019-03-19 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356490: Delete dead code. (authored by zturner, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D59276?vs=190350&id=191356#toc Repository: rLLDB LLD

[Lldb-commits] [lldb] r356490 - Delete dead code.

2019-03-19 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Mar 19 11:06:32 2019 New Revision: 356490 URL: http://llvm.org/viewvc/llvm-project?rev=356490&view=rev Log: Delete dead code. Most of these are Dump functions that are never called, but there is one instance of entire unused classes (DWARFDebugMacinfo and DWARFDebugMacin

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

2019-03-19 Thread Zachary Turner via Phabricator via lldb-commits
zturner accepted this revision. zturner added a comment. This LGTM, but let's give it a day to see if anyone else chimes in with comments. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59291/new/ https://reviews.llvm.org/D59291

[Lldb-commits] [PATCH] D59498: [DWARF] Remove a couple of log statements

2019-03-19 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356469: Remove a couple of log statements. (authored by zturner, committed by ). Herald added a subscriber: abidh. Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D594

[Lldb-commits] [lldb] r356469 - Remove a couple of log statements.

2019-03-19 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Mar 19 09:26:08 2019 New Revision: 356469 URL: http://llvm.org/viewvc/llvm-project?rev=356469&view=rev Log: Remove a couple of log statements. These log statements have questionable value, and hinder the effort of separating the high and low level DWARF parsing interface

[Lldb-commits] [PATCH] D59498: [DWARF] Remove a couple of log statements

2019-03-18 Thread Zachary Turner via Phabricator via lldb-commits
zturner marked 4 inline comments as done. zturner added a comment. In all cases, I think the question worth asking is not "could it be used for X", but rather "how often is it actually used for X". Otherwise, it's just technical debt IMO. There's a lot of things that are possible in theory, bu

[Lldb-commits] [PATCH] D59498: [DWARF] Remove a couple of log statements

2019-03-18 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added reviewers: JDevlieghere, aprantl. Herald added a subscriber: jdoerfert. I don't find these specific log statements particularly high value, as they appear more just like simple function tracing calls (i.e. they log low level implementation details, no

[Lldb-commits] [PATCH] D59430: Update DwarfDebugInfoEntry to use llvm::Error and llvm::Expected

2019-03-18 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59430/new/ https://reviews.llvm.org/D59430 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D59276: Delete dead code

2019-03-18 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59276/new/ https://reviews.llvm.org/D59276 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D59433: Fix UUID decoding from minidump files.

2019-03-15 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. "MinidumpNew" is a little bit vague. What's "new" about it? Is there a way we could come up with a better name? As an aside, since there's no interactivity in these tests, they seem like a good candidate for lit/Minidump, with 1 file for each test. Something like:

[Lldb-commits] [PATCH] D59427: [lldb] [API] Split SBRegistry into smaller files

2019-03-15 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. Or better yet, make it a static method on each SB class. E.g. `SBTarget::InitializeReproducerRegistry();` etc, one for each class. Random thought, but this all seems like a very high maintenance strategy, having to manually update this registry when methods are added o

[Lldb-commits] [PATCH] D59430: Update DwarfDebugInfoEntry to use llvm::Error and llvm::Expected

2019-03-15 Thread Zachary Turner via Phabricator via lldb-commits
zturner marked 3 inline comments as done. zturner added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:218 + assert(offset < cu->GetNextCompileUnitOffset() && + debug_info_data.ValidOffset(offset)); aprantl wr

[Lldb-commits] [PATCH] D59430: Update DwarfDebugInfoEntry to use llvm::Error and llvm::Expected

2019-03-15 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added reviewers: clayborg, aprantl, labath. Herald added a subscriber: jdoerfert. This hits the next batch of classes and adds better error handling and recovery to them. After this, the only remaining case is the line table stuff, at which point we should

[Lldb-commits] [lldb] r356284 - Abbreviation declarations are required to have non-null tags.

2019-03-15 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Mar 15 11:00:43 2019 New Revision: 356284 URL: http://llvm.org/viewvc/llvm-project?rev=356284&view=rev Log: Abbreviation declarations are required to have non-null tags. Treat a null tag as an error. Modified: lldb/trunk/source/Plugins/SymbolFile/DWARF/DWARFAbbrevia

[Lldb-commits] [PATCH] D59381: Change CompileUnit and ARanges interfaces to propagate errors

2019-03-15 Thread Zachary Turner via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rL356278: Return Error and Expected from more DWARF interfaces. (authored by zturner, committed by ). Herald added a proje

[Lldb-commits] [lldb] r356278 - Return Error and Expected from more DWARF interfaces.

2019-03-15 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Mar 15 10:32:05 2019 New Revision: 356278 URL: http://llvm.org/viewvc/llvm-project?rev=356278&view=rev Log: Return Error and Expected from more DWARF interfaces. This continues the work of introducing Error and Expected into the DWARF parsing interfaces, this time for th

[Lldb-commits] [PATCH] D59400: [lldb-vscode] Fix dangling pointer in request_evaluate.

2019-03-14 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. Another option would be to just assign it to a `std::string`, but this is fine too. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59400/new/ https://reviews.llvm.org/D59400 ___ lldb-commit

[Lldb-commits] [PATCH] D59381: Change CompileUnit and ARanges interfaces to propagate errors

2019-03-14 Thread Zachary Turner via Phabricator via lldb-commits
zturner marked 2 inline comments as done. zturner added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFCompileUnit.cpp:25 + lldb::offset_t *offset_ptr) { + assert(debug_info.ValidOffset(*offset_ptr)); + clayborg w

[Lldb-commits] [PATCH] D59381: Change CompileUnit and ARanges interfaces to propagate errors

2019-03-14 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added reviewers: clayborg, labath, aprantl. Herald added a subscriber: jdoerfert. This is a continuation of D59370 for compile units and aranges. https://reviews.llvm.org/D59381 Files: lldb/source/Plugins/SymbolFile/DWA

Re: [Lldb-commits] [PATCH] D59370: Return llvm::Error and llvm::Expected from some DWARF parsing functions

2019-03-14 Thread Zachary Turner via lldb-commits
On Thu, Mar 14, 2019 at 11:48 AM Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote: > clayborg accepted this revision. > clayborg added a comment. > This revision is now accepted and ready to land. > > As long as there is not a large performance regress when parsing large > DWARF file

[Lldb-commits] [PATCH] D59370: Return llvm::Error and llvm::Expected from some DWARF parsing functions

2019-03-14 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB356190: Return llvm::Error and llvm::Expected from DWARF parsing code. (authored by zturner, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D59370?vs=

[Lldb-commits] [lldb] r356190 - Return llvm::Error and llvm::Expected from DWARF parsing code.

2019-03-14 Thread Zachary Turner via lldb-commits
Author: zturner Date: Thu Mar 14 12:05:55 2019 New Revision: 356190 URL: http://llvm.org/viewvc/llvm-project?rev=356190&view=rev Log: Return llvm::Error and llvm::Expected from DWARF parsing code. The goal here is to improve our error handling and error recovery while parsing DWARF, while at the

Re: [Lldb-commits] [lldb] r356171 - [Python] Start eradicating unneeded LLDB_DISABLE_PYTHON guards.

2019-03-14 Thread Zachary Turner via lldb-commits
Make sure to run the test suite after these kinds of changes. You might be surprised. On Thu, Mar 14, 2019 at 10:21 AM Davide Italiano via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: davide > Date: Thu Mar 14 10:23:08 2019 > New Revision: 356171 > > URL: http://llvm.org/viewvc/l

[Lldb-commits] [PATCH] D59291: [Object] Add basic minidump support

2019-03-14 Thread Zachary Turner via Phabricator via lldb-commits
zturner added inline comments. Comment at: include/llvm/Object/Minidump.h:77 + ArrayRef Streams, + std::unordered_map StreamMap) + : Binary(ID_Minidump, Source), Header(Header), Streams(Streams), jhenderson wrote: > Are you delibe

[Lldb-commits] [PATCH] D59370: Return llvm::Error and llvm::Expected from some DWARF parsing functions

2019-03-14 Thread Zachary Turner via Phabricator via lldb-commits
zturner updated this revision to Diff 190654. zturner added a comment. Fix half-written comment and add comments to other extraction function declarations. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59370/new/ https://reviews.llvm.org/D59370 Files: lldb/source/Plugins/SymbolFile/

[Lldb-commits] [PATCH] D59370: Return llvm::Error and llvm::Expected from some DWARF parsing functions

2019-03-14 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added reviewers: labath, clayborg, aprantl, probinson. Herald added a subscriber: jdoerfert. The goal here is to improve our error handling and error recovery while parsing DWARF, while at the same time getting us closer to being able to merge LLDB's DWARF

[Lldb-commits] [PATCH] D59276: Delete dead code

2019-03-12 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. In D59276#1426972 , @aprantl wrote: > One one hand this seems fine to remove, but on the other hand — won't these > functions come in handy to compare and debug differences between the LLDB and > LLVM DWARF parsers, while we are

[Lldb-commits] [PATCH] D59276: Delete dead code

2019-03-12 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added reviewers: clayborg, aprantl. Herald added subscribers: jdoerfert, mgorny. Most of these are Dump functions that are never called, but there is one instance of entire unused classes (DWARFDebugMacinfo and DWARFDebugMacinfoEntry) which are also unrefer

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

2019-03-12 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355975: Remove support for DWARF64. (authored by zturner, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D59235?vs=190173&id=190326#toc Repository:

[Lldb-commits] [PATCH] D59165: Remove DWARFDIECollection

2019-03-12 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355974: Remove DWARFDIECollection. (authored by zturner, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D59165?vs=189961&id=190325#toc Repository:

[Lldb-commits] [PATCH] D59164: [SymbolFileDWARF] Move ElaboratingDIEIterator into implementation file

2019-03-12 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB355973: Move ElaboratingDIEIterator into implementation file. (authored by zturner, committed by ). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D59164?vs=189959&id

[Lldb-commits] [lldb] r355975 - Remove support for DWARF64.

2019-03-12 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Mar 12 13:51:05 2019 New Revision: 355975 URL: http://llvm.org/viewvc/llvm-project?rev=355975&view=rev Log: Remove support for DWARF64. LLVM doesn't produce DWARF64, and neither does GCC. LLDB's support for DWARF64 is only partial, and if enabled appears to also not wor

[Lldb-commits] [lldb] r355973 - Move ElaboratingDIEIterator into implementation file.

2019-03-12 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Mar 12 13:50:29 2019 New Revision: 355973 URL: http://llvm.org/viewvc/llvm-project?rev=355973&view=rev Log: Move ElaboratingDIEIterator into implementation file. This is not used outside of the private implementation of the class, so hiding in the implementation file is

[Lldb-commits] [lldb] r355974 - Remove DWARFDIECollection.

2019-03-12 Thread Zachary Turner via lldb-commits
Author: zturner Date: Tue Mar 12 13:50:46 2019 New Revision: 355974 URL: http://llvm.org/viewvc/llvm-project?rev=355974&view=rev Log: Remove DWARFDIECollection. This is a very thin wrapper over a std::vector and does not seem to provide any real value over just using a container directly. Differ

Re: [Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

2019-03-12 Thread Zachary Turner via lldb-commits
+1. I’ve seen some of the changes in llvm that have changed asserts to return a default value. IMHO these should be changed to return Expected instead On Tue, Mar 12, 2019 at 1:16 PM Jonas Devlieghere via Phabricator < revi...@reviews.llvm.org> wrote: > JDevlieghere added a comment. > > In D59235#

Re: [Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

2019-03-12 Thread Zachary Turner via lldb-commits
Fair enough, a FIXME sounds reasonable. On Tue, Mar 12, 2019 at 10:33 AM Jan Kratochvil via Phabricator < revi...@reviews.llvm.org> wrote: > jankratochvil added inline comments. > > > > Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.cpp:263 >uint64_t length

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

2019-03-12 Thread Zachary Turner via Phabricator via lldb-commits
zturner marked an inline comment as done. zturner added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFFormValue.cpp:170 case DW_FORM_sec_offset: assert(m_cu); + m_value.value.uval = data.GetMaxU64(offset_ptr, 4); jankrato

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

2019-03-12 Thread Zachary Turner via Phabricator via lldb-commits
zturner marked an inline comment as done. zturner added a comment. It seems like we're mostly in agreement on the direction of the patch, so if there's no outstanding comments I'll submit at the end of the day. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugRanges.

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

2019-03-11 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. In D59235#1425436 , @clayborg wrote: > My main concern with the LLVM DWARF parser is all of the asserts in the code. > If you attempt to use a DWARFDIE without first checking it for validity, it > will crash on you instead of ret

Re: [Lldb-commits] [PATCH] D59217: Fix/unify SBType comparison

2019-03-11 Thread Zachary Turner via lldb-commits
On Mon, Mar 11, 2019 at 4:15 PM Jim Ingham via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Just to be precise: TypeImpl stores a TypePair for the static type and a > CompilerType for the dynamic type. These two have different meanings. > There's no assumption about the relationship betwe

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

2019-03-11 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a subscriber: jankratochvil. zturner added a comment. In D59235#1425417 , @clayborg wrote: > What part of parsing DWARF64 wasn't working? I think the SPARC compiler was > the only one producing DWARF64. This patch originated from a thread

[Lldb-commits] [PATCH] D59235: Remove Support for DWARF64

2019-03-11 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added reviewers: clayborg, jasonmolenda, aprantl. Herald added a subscriber: jdoerfert. LLVM doesn't produce DWARF64, and neither does GCC. LLDB's support for DWARF64 is only partial, and if enabled appears to also not work. It also appears to have no tes

[Lldb-commits] [PATCH] D59217: Fix/unify SBType comparison

2019-03-11 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. SBType storing a pair of CompilerType and TypeSP seems like a very confusing interface and like it will be very easy to misuse or violate assumptions (perhaps even assumptions that nobody knows exists). Why exactly is this necessary? As far as I can tell, `SBType` use

[Lldb-commits] [PATCH] D59200: Fix a crasher in StackFrame::GetValueForVariableExpressionPath()

2019-03-11 Thread Zachary Turner via Phabricator via lldb-commits
zturner added inline comments. Comment at: source/Target/StackFrame.cpp:644-645 if (error.Fail()) { error.SetErrorStringWithFormatv( "Failed to dereference sythetic value: %s", deref_error); return ValueObjectSP(); No

Re: [Lldb-commits] [PATCH] D59165: Remove DWARFDIECollection

2019-03-08 Thread Zachary Turner via lldb-commits
Yes, it’s not the case here but even it were, just because the Python interface exposes this api doesn’t mean we have to use it internally. Regardless, this particular class is completely private and has no analogue in the SB API On Fri, Mar 8, 2019 at 4:53 PM Adrian Prantl via Phabricator < revi.

[Lldb-commits] [PATCH] D59165: Remove DWARFDIECollection

2019-03-08 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added reviewers: clayborg, aprantl. Herald added subscribers: jdoerfert, mgorny. This is a very thin wrapper over a std::vector and does not seem to provide any real value over just using a container directly. https://reviews.llvm.org/D59165 Files:

[Lldb-commits] [PATCH] D59164: [SymbolFileDWARF] Move ElaboratingDIEIterator into implementation file

2019-03-08 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added a reviewer: clayborg. This is not used outside of the private implementation of the class, so hiding in the implementation file is a nice way of simplifying the external interface. https://reviews.llvm.org/D59164 Files: lldb/source/Plugins/Sy

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

2019-03-08 Thread Zachary Turner via Phabricator via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Ahh yea, sorry. Got confused for a second :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59158/new/ https://reviews.llvm.org/D59158 ___

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

2019-03-08 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. Interesting, I had looked at fixing this one once before but I didn't realize we had a class named `EvaluateExpressionOptions` that contained just the right set of information, and it felt gross to invent a new one just for this purpose (It's a good thing I didn't too,

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

2019-03-08 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. I think maybe part of the problem is that this patch looks like actually 2 things. 1) A move of the include files from `lldb/source/Commands` to `lldb/Include/lldb/Commands`, and 2) The dependency changes. So it makes it hard to see what changes are actually needed fo

[Lldb-commits] [PATCH] D59158: Break cycle lldb/Commands [3->] lldb/Expression [1->] lldb/Commands

2019-03-08 Thread Zachary Turner via Phabricator via lldb-commits
zturner added inline comments. Comment at: lldb/include/lldb/Commands/CommandObjectBreakpoint.h:36 - static void VerifyBreakpointOrLocationIDs(Args &args, Target *target, -CommandReturnObject &result, I think the cla

[Lldb-commits] [lldb] r355730 - Remove dependency edges from Host to Target/Core.

2019-03-08 Thread Zachary Turner via lldb-commits
Author: zturner Date: Fri Mar 8 12:56:10 2019 New Revision: 355730 URL: http://llvm.org/viewvc/llvm-project?rev=355730&view=rev Log: Remove dependency edges from Host to Target/Core. After recent changes, Host is now dependency-free. Modified: lldb/trunk/source/Host/CMakeLists.txt lldb/

[Lldb-commits] [PATCH] D59114: [lldb-vscode] Don't hang indefinitely on invalid program

2019-03-07 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL355656: [lldb-vscode] Report an error if an invalid program is specified. (authored by zturner, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to comm

[Lldb-commits] [lldb] r355656 - [lldb-vscode] Report an error if an invalid program is specified.

2019-03-07 Thread Zachary Turner via lldb-commits
Author: zturner Date: Thu Mar 7 16:11:27 2019 New Revision: 355656 URL: http://llvm.org/viewvc/llvm-project?rev=355656&view=rev Log: [lldb-vscode] Report an error if an invalid program is specified. Previously if an invalid program was specified, there was a bug which, when we attempted to launc

[Lldb-commits] [PATCH] D59114: [lldb-vscode] Don't hang indefinitely on invalid program

2019-03-07 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added a reviewer: clayborg. When you configure your launch settings, if you pass a path to an invalid program, we would previously hand indefinitely. This is because a combination of two bugs working together. The first is that we did not attempt to detec

[Lldb-commits] [PATCH] D59104: [lldb-vscode] Make server mode work on Windows

2019-03-07 Thread Zachary Turner via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL355637: [lldb-vscode] Support running in server mode on Windows. (authored by zturner, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: htt

[Lldb-commits] [lldb] r355637 - [lldb-vscode] Support running in server mode on Windows.

2019-03-07 Thread Zachary Turner via lldb-commits
Author: zturner Date: Thu Mar 7 13:23:21 2019 New Revision: 355637 URL: http://llvm.org/viewvc/llvm-project?rev=355637&view=rev Log: [lldb-vscode] Support running in server mode on Windows. Windows can't use standard i/o system calls such as read and write to work with sockets, it instead needs

[Lldb-commits] [PATCH] D59104: [lldb-vscode] Make server mode work on Windows

2019-03-07 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added a reviewer: clayborg. Herald added a subscriber: mgorny. For historical reasons, Windows unfortunately doesn't support using sockets in standard system calls like read/write, which means that they also can't be buffered with a `FILE*`. This violates

[Lldb-commits] [lldb] r355559 - Pass /bigobj for SBReproducer.cpp with MSVC

2019-03-06 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Mar 6 14:42:34 2019 New Revision: 39 URL: http://llvm.org/viewvc/llvm-project?rev=39&view=rev Log: Pass /bigobj for SBReproducer.cpp with MSVC /BIGOBJ is used to bypass certain COFF file format limitations and is used with, unsurprisingly, very big object files.

[Lldb-commits] [lldb] r355557 - [lldb-vscode] Correctly propagate errors back to VS Code.

2019-03-06 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Mar 6 14:30:06 2019 New Revision: 37 URL: http://llvm.org/viewvc/llvm-project?rev=37&view=rev Log: [lldb-vscode] Correctly propagate errors back to VS Code. Modified: lldb/trunk/tools/lldb-vscode/lldb-vscode.cpp Modified: lldb/trunk/tools/lldb-vscode/lldb-v

[Lldb-commits] [PATCH] D59043: [lldb-vscode] Correctly propagate errors back to VS Code

2019-03-06 Thread Zachary Turner via Phabricator via lldb-commits
zturner created this revision. zturner added a reviewer: clayborg. I tried installing this, and I couldn't get it working. VS Code would launch the adapter and then it would get stuck waiting for something to happen. Eventually, I tracked this down to the fact that it couldn't locate lldb-serv

[Lldb-commits] [lldb] r355536 - Try again to fix OSX compilation failure.

2019-03-06 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Mar 6 11:14:41 2019 New Revision: 355536 URL: http://llvm.org/viewvc/llvm-project?rev=355536&view=rev Log: Try again to fix OSX compilation failure. Modified: lldb/trunk/source/Plugins/SymbolVendor/MacOSX/SymbolVendorMacOSX.cpp Modified: lldb/trunk/source/Plugins/S

[Lldb-commits] [lldb] r355531 - Try to fix OSX compilation failure.

2019-03-06 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Mar 6 10:44:27 2019 New Revision: 355531 URL: http://llvm.org/viewvc/llvm-project?rev=355531&view=rev Log: Try to fix OSX compilation failure. Modified: lldb/trunk/source/Plugins/Process/MacOSX-Kernel/ProcessKDP.cpp Modified: lldb/trunk/source/Plugins/Process/MacOS

[Lldb-commits] [lldb] r355528 - Resubmit "Don't include UnixSignals.h from Host."

2019-03-06 Thread Zachary Turner via lldb-commits
Author: zturner Date: Wed Mar 6 10:20:23 2019 New Revision: 355528 URL: http://llvm.org/viewvc/llvm-project?rev=355528&view=rev Log: Resubmit "Don't include UnixSignals.h from Host." This was reverted because it breaks the GreenDragon bot, but the reason for the breakage is lost, so I'm resubmit

Re: [Lldb-commits] [PATCH] D58972: Introduce the "Formats" module and move LinuxProcMaps parser to it

2019-03-05 Thread Zachary Turner via lldb-commits
How about SerializationFormats? On Tue, Mar 5, 2019 at 12:22 PM Pavel Labath via Phabricator < revi...@reviews.llvm.org> wrote: > labath added a comment. > > FileFormats wouldn't be generic enough to capture the gdb-remote or > debug-info-server protocol code. However, even calling gdb-remote prot

[Lldb-commits] [PATCH] D58985: Fix core files for 32 bit architectures that are supported in ProcessELFCore.cpp

2019-03-05 Thread Zachary Turner via Phabricator via lldb-commits
zturner added inline comments. Comment at: source/Plugins/Process/elf-core/ThreadElfCore.cpp:276 +else + return sizeof(ELFLinuxPrStatus) - 10 * 4; } subtracting 40 from the header size seems a bit magical to those not in the know (such as myself). C

[Lldb-commits] [PATCH] D58971: Move MemoryRegionInfo into the Utility module

2019-03-05 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. One idea for a new module name could be `AbstractProcess`, but I can't think of anything else better at the moment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58971/new/ https://reviews.llvm.org/D58971 ___ lldb-

[Lldb-commits] [PATCH] D58972: Introduce the "Formats" module and move LinuxProcMaps parser to it

2019-03-05 Thread Zachary Turner via Phabricator via lldb-commits
zturner accepted this revision. zturner added a comment. This revision is now accepted and ready to land. Great idea, this is a nice analogue to LLVM/BinaryFormat. But, "Formats" is a little generic. What about FileFormats or something? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D589

[Lldb-commits] [PATCH] D58976: Introduce core2yaml tool

2019-03-05 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. In D58976#1418621 , @clayborg wrote: > Strong ownership is needed for this class IMHO because it hands out pointers > to native data I disagree here, see my previous comment. Binaries grow large very quickly, and if we always

[Lldb-commits] [PATCH] D58842: Move ProcessInstanceInfo and similar to Utility

2019-03-04 Thread Zachary Turner via Phabricator via lldb-commits
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rL355342: Move ProcessInfo from Host to Utility. (authored by zturner, committed by ). Herald added a project: LLVM. Herald

[Lldb-commits] [lldb] r355342 - Move ProcessInfo from Host to Utility.

2019-03-04 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon Mar 4 13:51:03 2019 New Revision: 355342 URL: http://llvm.org/viewvc/llvm-project?rev=355342&view=rev Log: Move ProcessInfo from Host to Utility. There are set of classes in Target that describe the parameters of a process - e.g. it's PID, name, user id, and similar. Ho

[Lldb-commits] [lldb] r355329 - Fix Windows build after UserIDResolver patch.

2019-03-04 Thread Zachary Turner via lldb-commits
Author: zturner Date: Mon Mar 4 11:57:04 2019 New Revision: 355329 URL: http://llvm.org/viewvc/llvm-project?rev=355329&view=rev Log: Fix Windows build after UserIDResolver patch. That patch added a function to HostInfo that returns an instance of UserIDResolver, but this function was unimplement

[Lldb-commits] [PATCH] D58838: Remove tautological #ifdefs

2019-03-01 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. Yea it would be nice if we could remove all of the `LLDB_CONFIGURATION_xxx` macros and just use either the LLVM ones or standard ones such as NDEBUG CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58838/new/ https://reviews.llvm.org/D58838

[Lldb-commits] [PATCH] D58792: Add "operator bool" to SB APIs

2019-03-01 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. Out of curiosity, are there known, specific examples of users who rely on the exact mangling not changing? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58792/new/ https://reviews.llvm.org/D58792 ___ lldb-commits m

[Lldb-commits] [PATCH] D58842: Move ProcessInstanceInfo and similar to Utility

2019-03-01 Thread Zachary Turner via Phabricator via lldb-commits
zturner added a comment. In D58842#1415526 , @labath wrote: > Hmm.. I think I've thought of (or remembered, because I have been thinking > about Utility too) a reason why it might be better to keep these in Host. > ProcessLaunchInfo cannot be trivially m

  1   2   3   4   5   6   7   8   9   10   >