[Lldb-commits] [PATCH] D114862: Replace StackID's operator "<" with a function returning FrameComparison

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: labath, jasonmolenda. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: JDevlieghere. tatyana-krasnukha requested review of this revision. Herald added a subscriber: lldb-commits. "false" result of the op

[Lldb-commits] [PATCH] D114861: Don't consider frames with different PCs as a loop

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: labath, jasonmolenda. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: JDevlieghere. tatyana-krasnukha requested review of this revision. Herald added a subscriber: lldb-commits. A compiler can produce F

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. LGTM, but I would wait for one more approve. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111899/new/ https://reviews.llvm.org/D111899

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

tatyana-krasnukha added inline comments. Comment at: lldb/test/API/functionalities/breakpoint/breakpoint_command/TestBreakpointCommand.py:269 self.expect(side_effect.bp_loc, exe=False, -patterns=["1.* where = .*main .* resolved, hit count = 1"]) +

[Lldb-commits] [PATCH] D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack

tatyana-krasnukha added a comment. Added inline comment Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2842 - OverrideExecutionContext(m_debugger.GetSelectedExecutionContext()); - auto finalize = llvm::make_scope_exit([this]() { -RestoreExecutionContext(); +

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

tatyana-krasnukha abandoned this revision. tatyana-krasnukha added a comment. D96952 is landed instead. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96817/new/ https://reviews.llvm.org/D96817 ___ lldb-commit

[Lldb-commits] [PATCH] D96952: CRTP-based version of D96817

tatyana-krasnukha added inline comments. Comment at: lldb/source/Interpreter/OptionValueFileSpecList.cpp:169 std::lock_guard lock(m_mutex); - return OptionValueSP(new OptionValueFileSpecList(m_current_value)); + return std::make_shared(*this); } JDevliegher

[Lldb-commits] [PATCH] D96952: CRTP-based version of D96817

This revision was automatically updated to reflect the committed changes. tatyana-krasnukha marked 2 inline comments as done. Closed by commit rGf0f183ee4ad9: [lldb/Interpreter] Fix deep copying for OptionValue classes (authored by tatyana-krasnukha). Herald added a project: LLDB. Herald added a s

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

tatyana-krasnukha added a comment. clang-tidy would not be happy;) Comment at: lldb/source/Plugins/Process/FreeBSD/NativeProcessFreeBSD.cpp:665 +return SetHardwareBreakpoint(addr, size); else return SetSoftwareBreakpoint(addr, size); Redundant `else

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

tatyana-krasnukha added a comment. I created D96817 - a demonstrative example of the CRTP-based version of this patch. Please, take a look. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96817/new/ https://reviews.llvm.org/D96817 __

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

tatyana-krasnukha updated this revision to Diff 324435. tatyana-krasnukha added a comment. Removed explicit conversions to StringRef from the test with respect to D96861 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96817/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

tatyana-krasnukha added a comment. CRTP was my first implementation, however, I discarded it as more bug-prone. Virtual Clone function at the interface is so common that, I believe, everyone knows it must be overridden by a new derived class. The necessity of inheriting from base_clone_helper i

[Lldb-commits] [PATCH] D96817: Fix deep copying for OptionValue classes

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, JDevlieghere, labath, teemperor. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: mgorny. tatyana-krasnukha requested review of this revision. Herald added a subscriber: lldb-commits. Some impl

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha added a comment. In D92164#2536036 , @werat wrote: > I think your test case is even better, the one in D95761 > doesn't try to run commands. Ok, then I'll replace it if you don't mind. CHANGES SINCE L

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha updated this revision to Diff 320560. tatyana-krasnukha added a comment. Removed test since the same case was added by D95761 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92164/new/ https://reviews.llvm.org/D92164 Files: lldb/inc

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha updated this revision to Diff 320548. tatyana-krasnukha edited the summary of this revision. tatyana-krasnukha added a comment. It turns out that the Debugger recalculated the selected stack frame without taking the Process's run lock. I replaced the whole context evaluation wit

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

tatyana-krasnukha added a comment. D92164 was intended for fixing the "settings set" issue, however, it revealed some deadlocks and data races, and had to be reverted temporarily. Currently, I'm working on those multithreading issues and will submit a patch as

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha added a comment. In D92164#2463734 , @labath wrote: > With this version of the patch, I am unable to reproduce the issue using the > approach I described in the previous comment. However, it still reproduces > when issuing the equivalen

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha updated this revision to Diff 312770. tatyana-krasnukha added a comment. Fixed CommandInterpreter::GetProcessOutput to avoid deadlock in Windows process plugin. This should also fix the problem @labath described above. Pavel, could you please check whether it works for you? C

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa01b26fb51c7: [lldb] Make CommandInterpreter's execution context the same as debugger's one. (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[Lldb-commits] [PATCH] D93052: "target create" shouldn't save target if the command failed

This revision was automatically updated to reflect the committed changes. Closed by commit rG2634ec6ce900: [lldb] "target create" shouldn't save target if the command failed (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D93052: "target create" shouldn't save target if the command failed

tatyana-krasnukha updated this revision to Diff 311128. tatyana-krasnukha added a comment. Removed `do_select`'s default value. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93052/new/ https://reviews.llvm.org/D93052 Files: lldb/include/lldb/Target/TargetList.h lldb/source/API/SBDe

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha updated this revision to Diff 31. tatyana-krasnukha added a comment. Thanks for pointing to the nested command problem! Replaced pointer to the execution context with the stack of contexts. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92164/new/ https://reviews.l

[Lldb-commits] [PATCH] D93052: "target create" shouldn't save target if the command failed

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, JDevlieghere, jingham, teemperor. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: emaste. tatyana-krasnukha requested review of this revision. Herald added a subscriber: lldb-commits. TargetLi

[Lldb-commits] [PATCH] D92164: Make CommandInterpreter's execution context the same as debugger's one.

tatyana-krasnukha updated this revision to Diff 310927. tatyana-krasnukha retitled this revision from "Make SBDebugger internal variable getter and setter not use CommandInterpreter's context" to "Make CommandInterpreter's execution context the same as debugger's one.". tatyana-krasnukha edited t

[Lldb-commits] [PATCH] D92164: Make SBDebugger internal variable getter and setter not use CommandInterpreter's context

tatyana-krasnukha updated this revision to Diff 308325. tatyana-krasnukha added a comment. Removed refactoring to make the changes clearer. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92164/new/ https://reviews.llvm.org/D92164 Files: lldb/packages/Python/lldbsuite/test/python_api/d

[Lldb-commits] [PATCH] D92164: Make SBDebugger internal variable getter and setter not use CommandInterpreter's context

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: jingham, JDevlieghere, labath. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. tatyana-krasnukha requested review of this revision. SBDebugger asks CommandInterpreter for execution context

[Lldb-commits] [PATCH] D88769: [trace] Scaffold "thread trace dump instructions"

tatyana-krasnukha added inline comments. Comment at: lldb/source/Plugins/Process/Trace/ProcessTrace.h:18 + +class ProcessTrace : public lldb_private::Process { +public: clayborg wrote: > So one issue is how do we eventually deal with debugging a live process that

[Lldb-commits] [PATCH] D88906: [lldb/docs] Clarify python/swig version incompatibility

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. I used Swig 3.0.12 + cherry-picked commit that fixes that bug (https://github.com/swig/swig/issues/1321) on Windows. It worked well with both Python 3.7 and 3.8. The on

[Lldb-commits] [PATCH] D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe97c693bb0ec: [lldb/Process/Windows] Attempting to kill exited/detached process in not an… (authored by tatyana-krasnukha). Changed prior to commit:

[Lldb-commits] [PATCH] D84957: [lldb/Process/Windows] Attempt to kill exited/detached process in not error

tatyana-krasnukha added a comment. Thank you! I fixed the commit title and description as you suggested. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84957/new/ https://reviews.llvm.org/D84957 ___ lldb-

[Lldb-commits] [PATCH] D84954: [lldb] Make Target::CleanupProcess consistent for breakpoints and watchpoints

tatyana-krasnukha updated this revision to Diff 282030. tatyana-krasnukha added a comment. TestAddressBreakpoints.py fails on the last check - it expects hit count to be saved after re-launching the process. Removed that check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D84957: [lldb/Process/Windows] Trying to kill exited/detached process in not error

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: asmith. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. tatyana-krasnukha requested review of this revision. Don't report an error, just log this happened. This fixes a lot o

[Lldb-commits] [PATCH] D84954: [lldb] Make Target::CleanupProcess consistent for breakpoints and watchpoints

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: jingham. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. tatyana-krasnukha requested review of this revision. Target clears watchpoints hit count but doesn't do the same for

[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda0bba5c9abb: [lldb/Breakpoint] Rename StoppointLocation to StoppointSite and drop its… (authored by tatyana-krasnukha). Changed prior to commit:

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

tatyana-krasnukha added a comment. Ups... Pushed it occationaly with the other patchs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84257/new/ https://reviews.llvm.org/D84257 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGebaa8b1c6074: [lldb] Don't use hardware index to determine whether

[Lldb-commits] [PATCH] D84255: [lldb] Make process plugins check whether a hardware breakpoint is required

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb352e62feadd: [lldb] Make process plugins check whether a hardware breakpoint is required (authored by tatyana-krasnukha). Repository: rG LLVM Git

[Lldb-commits] [PATCH] D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf7ec3e3be70d: [lldb] Skip overlapping hardware and external breakpoints when writing memory (authored by tatyana-krasnukha). Repository: rG LLVM G

[Lldb-commits] [PATCH] D84311: [lldb/test] Put hardware breakpoint tests together, NFC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc114352edfe0: [lldb/test] Put hardware breakpoint tests together, NFC (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGE

[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

tatyana-krasnukha updated this revision to Diff 281600. tatyana-krasnukha added reviewers: JDevlieghere, jingham. tatyana-krasnukha added a comment. Addressed comments. > It's also a little weird that we're clearing watchpoint hit counts when a > process dies, but not breakpoint hit counts. If w

[Lldb-commits] [PATCH] D84255: [lldb] Make process plugins check whether a hardware breakpoint is required

tatyana-krasnukha updated this revision to Diff 281598. tatyana-krasnukha added reviewers: labath, JDevlieghere. tatyana-krasnukha added a comment. Un-skip TestRequireHWBreakpoints.py on Windows, now it works as expected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

tatyana-krasnukha added a comment. I went further than just moving m_hardware_index from StoppointLocation. Please, take a look at D84527 and let me know what you think about that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

tatyana-krasnukha updated this revision to Diff 280448. tatyana-krasnukha added a comment. @omjavaid, thank you for verifying this! Added the checks that IsHardware is consistent with m_hardware_index. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D84527: Rename StoppointLocation to StoppointSite and drop its relationship with BreakpointLocation

tatyana-krasnukha created this revision. Herald added subscribers: lldb-commits, yaxunl, mgorny. Herald added a project: LLDB. Working on the patch D84257 I noticed that both BreakpointLocation and BreakpointSite were inherited from StoppointLocation. Also, I n

[Lldb-commits] [PATCH] D84311: [lldb/test] Put hardware breakpoint tests together, NFC

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: JDevlieghere, labath. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. Create a common base class for them to re-use supports_hw_breakpoints function in decorators. This is a preparatory

[Lldb-commits] [PATCH] D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory

tatyana-krasnukha updated this revision to Diff 279777. tatyana-krasnukha added a comment. `BreakpointSite::IntersectsRange` returns `false` for hardware breakpoints, that's why the assertion fails. Since my bare-metal target loads process's memory via Process::WriteMemory, I have 200+ unresolv

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

tatyana-krasnukha added a comment. Comment at: lldb/source/Breakpoint/BreakpointLocation.cpp:73 + if (m_bp_site_sp) +return m_bp_site_sp->IsHardware(); + JDevlieghere wrote: > Should we sanity check that this is true when `m_hardware_index != > LLDB_INVA

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

tatyana-krasnukha added a comment. Probably fixes llvm.org/PR44659, though I cannot check on arm/aarch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84257/new/ https://reviews.llvm.org/D84257 ___ ll

[Lldb-commits] [PATCH] D84257: [lldb] Don't use hardware index to determine whether a breakpoint site is hardware

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: clayborg, labath, JDevlieghere. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, arphaman. Most process plugins (if not all) don't set hardware index for breakpoints. They even are not able

[Lldb-commits] [PATCH] D84255: [lldb] Make process plugins check whether a hardware breakpoint is required

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: clayborg. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, emaste. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84255 Files: lldb/source/Plugins/Process/FreeBSD/Proce

[Lldb-commits] [PATCH] D84254: [lldb] Skip overlapping hardware and external breakpoints when writing memory

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: clayborg. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes the assertion `assert(intersects);` in the Process::WriteMemory function. Repository: rG LLVM Github Monorepo ht

[Lldb-commits] [PATCH] D76593: [lldb-vscode] Convert launch_info and attach_info to local variables

This revision was automatically updated to reflect the committed changes. Closed by commit rGa92673fe9a08: [lldb-vscode] Convert launch_info and attach_info to local variables (authored by anton.kolesov, committed by tatyana-krasnukha). Changed prior to commit: https://reviews.llvm.org/D76593?

[Lldb-commits] [PATCH] D76351: [lldb-vscode] Don't use SBLaunchInfo in request_attach

This revision was automatically updated to reflect the committed changes. Closed by commit rG0b18b568e91a: [lldb-vscode] Don't use SBLaunchInfo in request_attach (authored by anton.kolesov, committed by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D75979: [lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame

This revision was automatically updated to reflect the committed changes. Closed by commit rG332edcc6bd1d: [lldb] Remove unimplemented StackFrame::BehavesLikeZerothFrame (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7

[Lldb-commits] [PATCH] D75975: [lldb] Copy m_behaves_like_zeroth_frame on stack frame update

This revision was automatically updated to reflect the committed changes. Closed by commit rG0a840ef80059: [lldb] Copy m_behaves_like_zeroth_frame on stack frame update (authored by tatyana-krasnukha). Changed prior to commit: https://reviews.llvm.org/D75975?vs=249561&id=250549#toc Repository:

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

tatyana-krasnukha added a comment. `platform.module-cache-directory` should be fixed by rGfe74df01a909 . Regarding `script-lang`, its default value is `eScriptLanguagePython` in CoreProperties.td and I'm not sure that I should

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

tatyana-krasnukha added a comment. Thank you for details, I'm looking at these failures, however, I'm not able to debug on the macOS. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537 _

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

This revision was automatically updated to reflect the committed changes. Closed by commit rGdf90a15b1ac9: [lldb] Clear all settings during a test's setUp (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ http

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

tatyana-krasnukha updated this revision to Diff 249902. tatyana-krasnukha added a comment. Addressed comments Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py ll

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

tatyana-krasnukha updated this revision to Diff 248404. tatyana-krasnukha added a comment. Removed TestFixIts.py as those changes relate to the parent revision. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537 Files: l

[Lldb-commits] [PATCH] D74903: [lldb][testsuite] Create a SBDebugger instance for each test

This revision was automatically updated to reflect the committed changes. Closed by commit rGa31130f6fcf2: [lldb][testsuite] Create a SBDebugger instance for each test (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D749

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

tatyana-krasnukha updated this revision to Diff 248213. tatyana-krasnukha added a comment. Added `--all` property to `settings clear` + added a test Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75537/new/ https://reviews.llvm.org/D75537 Files: lldb/packages

[Lldb-commits] [PATCH] D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint

This revision was automatically updated to reflect the committed changes. Closed by commit rG6c17cc531f9f: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to… (authored by tatyana-krasnukha). Changed prior to commit: https://reviews.llvm.org/D74557?vs=244727&id=248166#toc R

[Lldb-commits] [PATCH] D74903: [lldb][testsuite] Create a SBDebugger instance for each test

tatyana-krasnukha updated this revision to Diff 247928. tatyana-krasnukha added a comment. Moved settings clearing to the separate patch D75537 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74903/new/ https://reviews.llvm.org/D74903 Files: lldb/bind

[Lldb-commits] [PATCH] D75537: Clear all settings during a test's setUp

tatyana-krasnukha created this revision. tatyana-krasnukha added a reviewer: labath. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. tatyana-krasnukha added a parent revision: D74903: [lldb][testsuite] Create a SBDebugger instance for each test. Move

[Lldb-commits] [PATCH] D74903: [lldb][testsuite] Create a SBDebugger instance for each test

tatyana-krasnukha updated this revision to Diff 247908. tatyana-krasnukha added a comment. Clear all settings during a test's setUp Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74903/new/ https://reviews.llvm.org/D74903 Files: lldb/bindings/interface/SBPlat

[Lldb-commits] [PATCH] D74903: [lldb][testsuite] Create a SBDebugger instance for each test

tatyana-krasnukha planned changes to this revision. tatyana-krasnukha added a comment. As Pavel wrote, there are global properties that all debuggers share. That's why this approach doesn't work for me. I'm going to add `settings clear` mode without arguments that will revert all the settings to

[Lldb-commits] [PATCH] D74903: [lldb][testsuite] Create a SBDebugger instance for each test

tatyana-krasnukha updated this revision to Diff 247842. tatyana-krasnukha retitled this revision from "[lldb][test] Add two wrapper functions to manage settings in test-suite" to "[lldb][testsuite] Create a SBDebugger instance for each test". tatyana-krasnukha edited the summary of this revision.

[Lldb-commits] [PATCH] D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint

tatyana-krasnukha added a comment. @jingham Is it Ok with you? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74557/new/ https://reviews.llvm.org/D74557 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [PATCH] D74903: [lldb][test] Add two wrapper functions to manage settings in test-suite

tatyana-krasnukha added a comment. I like this idea and ready to implement, but I'm not aware of the reasons why the current implementation was chosen. Suppose that initializing the Debugger for each test will slow down the test-suite significantly. Repository: rLLDB LLDB CHANGES SINCE LAST

[Lldb-commits] [PATCH] D74903: [lldb][test] Add two wrapper-functions to manage settings in test-suite

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: JDevlieghere, labath. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, teemperor. Some tests set settings and don't clean them up, this leads to side effects in other tests. The patch adds

[Lldb-commits] [PATCH] D74558: [lldb] Make shared_from_this-related code safer

tatyana-krasnukha closed this revision. tatyana-krasnukha added a comment. Closed by commit b624b7dfd087 Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74558/new/ https://reviews.llvm.org/D74

[Lldb-commits] [PATCH] D74556: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor

tatyana-krasnukha closed this revision. tatyana-krasnukha added a comment. Closed by commit 185ef697ef5c Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74556/new/ https://reviews.llvm.org/D74

[Lldb-commits] [PATCH] D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint

tatyana-krasnukha updated this revision to Diff 244727. tatyana-krasnukha added a reviewer: jingham. tatyana-krasnukha added a comment. Just realized that BreakpointResolverScripted::CreateImplementationIfNeeded should work when m_breakpoint == nullptr. GetBreakpoint with assertion is not suitabl

[Lldb-commits] [PATCH] D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint

tatyana-krasnukha updated this revision to Diff 244645. tatyana-krasnukha added a comment. Moved assertion into GetBreakpoint(). > Were there any places you found where it was legit to ask for the Breakpoint > for a resolver and not have one? I didn't find any, however, it seems to be possible

[Lldb-commits] [PATCH] D70847: [lldb-vscode] Ensure that target matches the executable file

This revision was automatically updated to reflect the committed changes. Closed by commit rG21d09ccf268d: [lldb-vscode] Ensure that target matches the executable file (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D708

[Lldb-commits] [PATCH] D74558: [lldb] Make shared_from_this-related code safer

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: JDevlieghere, teemperor. tatyana-krasnukha added a project: LLDB. Herald added subscribers: lldb-commits, abidh. The idea is: the fewer classes make an assumption that a target object is already managed by a shared_ptr -

[Lldb-commits] [PATCH] D74556: [lldb] Don't call CopyForBreakpoint from a Breakpoint's constructor

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: JDevlieghere, teemperor. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. Some implementations (BreakpointResolverScripted) try calling the breakpoint's shared_from_this(), that makes LLDB

[Lldb-commits] [PATCH] D74557: [lldb] Make BreakpointResolver hold weak_ptr instead of raw pointer to breakpoint

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: JDevlieghere, teemperor. tatyana-krasnukha added a project: LLDB. Herald added a subscriber: lldb-commits. This prevents calling Breakpoint::shared_from_this of an object that is not owned by any shared_ptr. The patch is

[Lldb-commits] [PATCH] D74244: [lldb] Delete register info definitions in the x86_64 ABI classes

tatyana-krasnukha added inline comments. Comment at: lldb/source/Plugins/ABI/X86/ABISysV_x86_64.cpp:938 + .Case("R8", LLDB_REGNUM_GENERIC_ARG5) + .Case("r9", LLDB_REGNUM_GENERIC_ARG6) + .Default(LLDB_INVALID_REGNUM); Typo? It should be uppercase, I

[Lldb-commits] [PATCH] D71906: [lldb][tests] Make it possible to expect failure for a whole category

This revision was automatically updated to reflect the committed changes. Closed by commit rG3eea082535e2: [lldb][tests] Make it possible to expect failure for a whole category (authored by tatyana-krasnukha). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards

This revision was automatically updated to reflect the committed changes. Closed by commit rGe4d672971030: [lldb][tests] Take into account all parent's categories when traverse folders… (authored by tatyana-krasnukha). Changed prior to commit: https://reviews.llvm.org/D71905?vs=237079&id=237294

[Lldb-commits] [PATCH] D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards

tatyana-krasnukha updated this revision to Diff 237079. tatyana-krasnukha added a comment. Stop iterating when reach the top-level test folder Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71905/new/ https://reviews.llvm.org/D71905 Files: lldb/packages/Pytho

[Lldb-commits] [PATCH] D71906: [lldb][tests] Make it possible to expect failure for a whole category

tatyana-krasnukha updated this revision to Diff 236374. tatyana-krasnukha added a comment. Increased number of lines of context. Jonas, yes, it is. Pavel, names are consistent (if I understand your comment correctly). The "--xfail-category" is singular like the "--skip-category". Repository:

[Lldb-commits] [PATCH] D71905: [lldb][tests] Take into account all parent's categories when traverse folders upwards

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: labath, teemperor. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. This is needed to not "re-write" parent's categories by categories of a nested folder, e.g. commands/expression/comple

[Lldb-commits] [PATCH] D71906: [lldb][tests] Make it possible to expect failure for a whole category

tatyana-krasnukha created this revision. tatyana-krasnukha added reviewers: labath, teemperor. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. There already are decorators and "--excluded" option to mark test-cases/files as expected to fail. However, when a new

[Lldb-commits] [PATCH] D69589: [lldb] Refactor all POST_BUILD commands into targets

tatyana-krasnukha added inline comments. Comment at: lldb/CMakeLists.txt:114 + COMMAND ${CMAKE_COMMAND} -E make_directory ${ARG_DEST_DIR}) +foreach(src_file ${ARG_FILES}) + if(ARG_DEST_FILE_NAME) This is quite off-topic, but it would be great if thi

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

tatyana-krasnukha added a comment. I mean, when a process is not able to allocate memory, it cannot JIT, but still can interpret. Should the test report failure in this case? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67227/new/ https://reviews.llvm.org/D67227 ___

[Lldb-commits] [PATCH] D67227: [lldb] Extend and document TestIRInterpreter.py

tatyana-krasnukha added a comment. Another problem of the `test_ir_interpreter` is that it fails even when JIT fails despite it should test the interpreter. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67227/new/ https://reviews.llvm.org/D67227 _

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

This revision was automatically updated to reflect the committed changes. Closed by commit rGfaf6b2543e47: [ARC] Basic support in gdb-remote process plugin (authored by tatyana-krasnukha). Changed prior to commit: https://reviews.llvm.org/D55718?vs=225432&id=225437#toc Repository: rG LLVM Gi

[Lldb-commits] [PATCH] D55724: [ARC] Add SystemV ABI

This revision was automatically updated to reflect the committed changes. Closed by commit rG92e498d58cf4: [ARC] Add SystemV ABI (authored by tatyana-krasnukha). Changed prior to commit: https://reviews.llvm.org/D55724?vs=225433&id=225438#toc Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D55724: [ARC] Add SystemV ABI

tatyana-krasnukha updated this revision to Diff 225433. tatyana-krasnukha added a comment. Herald added a subscriber: JDevlieghere. Rebased on the current trunk. Updated according to the last revision of D55718 . Repository: rLLDB LLDB CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D55718: [ARC] Basic support in gdb-remote process plugin

tatyana-krasnukha updated this revision to Diff 225432. tatyana-krasnukha added a comment. Herald added a subscriber: wuzish. Removed any ARC-specific logic from the ProcessGDBRemote.cpp. It seems, there is nothing to test now;) Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://revi

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

tatyana-krasnukha accepted this revision. tatyana-krasnukha added a comment. This revision is now accepted and ready to land. Build and installation completed successfully! LGTM, though it would be good if anyone tests this with Xcode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

tatyana-krasnukha added a comment. F10259577: D68858d.diff @hhb, please, take a look. Slightly changed your patch to make it work for Visual Studio. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68858/new/ htt

[Lldb-commits] [PATCH] D68858: [lldb] Creates _liblldb symlink from cmake

tatyana-krasnukha added inline comments. Comment at: lldb/CMakeLists.txt:228 +function(create_relative_symlink target dest_file output_dir output_name) + get_filename_component(dest_file ${dest_file} ABSOLUTE) + get_filename_component(output_dir ${output_dir} ABSOLU

[Lldb-commits] [PATCH] D68719: Fix issue when building with Visual Studio

tatyana-krasnukha added inline comments. Comment at: finishSwigPythonLLDB.py:380 -strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) -strRelSrc = os.path.relpath(strSrc, os.path.dirname(strTarget)) tatyana-krasnukha wrote: > hhb wrote: > >

[Lldb-commits] [PATCH] D68719: Fix issue when building with Visual Studio

tatyana-krasnukha abandoned this revision. tatyana-krasnukha added a comment. Fixed by reverting the initial commit. Comment at: finishSwigPythonLLDB.py:380 -strSrc = os.path.normcase(os.path.join(strPrefix, vstrSrcFile)) -strRelSrc = os.path.relpath(strSrc, os.path.d

[Lldb-commits] [PATCH] D68728: [lldb] Put site-packages into a sub dir of CMAKE_CFG_INTDIR

tatyana-krasnukha added a comment. Please see my comment D68719#1703785 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68728/new/ https://reviews.llvm.org/D68728 _

  1   2   3   >