https://github.com/weliveindetail commented:
Yes, I believe there was a condition like that in my patch that introduced the
check. And then I simplified it.
So, now the problem is that FreeBSD has both, make and gmake, and when we pick
up make, the tests fail right? Wouldn't it be sufficient t
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/115318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
weliveindetail wrote:
@mstorsjo Any thoughts/concerns about this?
https://github.com/llvm/llvm-project/pull/115318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
weliveindetail wrote:
Yes, the pre-merge test failure wasn't related to my change, but still I prefer
landing patches with a green light :) Was out of office last week. Let's give
it one last try.
https://github.com/llvm/llvm-project/pull/115177
___
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/115177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/115177
From 2c8f5571a4fbe87b50d395fe93f7c4657685e683 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 8 Nov 2024 17:16:20 +0100
Subject: [PATCH] [lldb] Infer MSInheritanceAttr for CXXR
https://github.com/weliveindetail ready_for_review
https://github.com/llvm/llvm-project/pull/115318
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
weliveindetail wrote:
Pre-merge checks failed due to an unrelated test error. The one on Windows was
fine actually, but let me squash and rebase to try this again.
https://github.com/llvm/llvm-project/pull/115177
___
lldb-commits mailing list
lldb-com
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/115177
From b12300bcd0b801348267a1b2a00e7ee774620099 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 8 Nov 2024 17:16:20 +0100
Subject: [PATCH] [lldb] Infer MSInheritanceAttr for CXXR
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/115177
From 32d7b7d5261e651851e5a36c5fd5ae9d927a9fb3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Wed, 6 Nov 2024 15:45:03 +0100
Subject: [PATCH 1/8] [lldb] Infer MSInheritanceAttr for
@@ -2771,8 +2771,14 @@ static bool GetCompleteQualType(clang::ASTContext *ast,
ast, llvm::cast(qual_type)->getModifiedType(),
allow_completion);
- case clang::Type::MemberPointer:
+ case clang::Type::MemberPointer: {
+auto *MPT = qual_type.getTypePtr()->c
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/115177
From 32d7b7d5261e651851e5a36c5fd5ae9d927a9fb3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Wed, 6 Nov 2024 15:45:03 +0100
Subject: [PATCH 1/6] [lldb] Infer MSInheritanceAttr for
@@ -2,23 +2,58 @@
// Itanium ABI:
// RUN: %clang --target=x86_64-pc-linux -gdwarf -c -o %t_linux.o %s
-// RUN: %lldb -f %t_linux.o -b -o "target variable mp" | FileCheck %s
+// RUN: %lldb -f %t_linux.o -b -o "target variable s1 s2 m1 m2 v1 v2 v3 v4" |
FileCheck --check-prefix
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/115318
This test checks the thread backtrace for entries of intermediate frames that
aren't aligned to 16 bytes. In order to do that, it sets a single breakpoint
and makes sure we stop there. It seems sufficien
weliveindetail wrote:
We see a few tests failing for this reason downstream in swift-lldb:
https://github.com/swiftlang/swift/pull/76894#issuecomment-2441139173 I filed a
ticket to investigate the actual issue
https://github.com/swiftlang/llvm-project/issues/9540
It would be great to unblock
@@ -2,23 +2,58 @@
// Itanium ABI:
// RUN: %clang --target=x86_64-pc-linux -gdwarf -c -o %t_linux.o %s
-// RUN: %lldb -f %t_linux.o -b -o "target variable mp" | FileCheck %s
+// RUN: %lldb -f %t_linux.o -b -o "target variable s1 s2 m1 m2 v1 v2 v3 v4" |
FileCheck --check-prefix
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/115177
From 32d7b7d5261e651851e5a36c5fd5ae9d927a9fb3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Wed, 6 Nov 2024 15:45:03 +0100
Subject: [PATCH 1/5] [lldb] Infer MSInheritanceAttr for
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/115177
From 32d7b7d5261e651851e5a36c5fd5ae9d927a9fb3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Wed, 6 Nov 2024 15:45:03 +0100
Subject: [PATCH 1/3] [lldb] Infer MSInheritanceAttr for
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/115177
Following up from https://github.com/llvm/llvm-project/pull/112928, we can
reuse the [approach from Clang
Sema](https://github.com/llvm/llvm-project/blob/release/19.x/clang/lib/Sema/SemaType.cpp#L9039)
weliveindetail wrote:
Hi @rastogishubham thanks for acting on this! The log of this particular run
was deleted already, but
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/13958
likely failed for the same reason:
```
lldb-build/bin/clang --driver-mode=cl
--target=specify-a
weliveindetail wrote:
I fixed the test and it now passes for me on macOS. Hope the bots are good now.
https://github.com/llvm/llvm-project/pull/112928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
Author: Stefan Gränitz
Date: 2024-10-24T13:47:15+02:00
New Revision: 76edf72501cd6f66788c631fada95972a797a4a6
URL:
https://github.com/llvm/llvm-project/commit/76edf72501cd6f66788c631fada95972a797a4a6
DIFF:
https://github.com/llvm/llvm-project/commit/76edf72501cd6f66788c631fada95972a797a4a6.diff
weliveindetail wrote:
Yes, for devs it might be too much of a burden and eventually bot maintainers
should be aware. If we want the error behavior back, we could make it
conditional on `LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS`. For now I didn't want
to make it more complicated than necessary.
h
Author: Stefan Gränitz
Date: 2024-10-23T14:32:58+02:00
New Revision: ba19e98ca5e4fbc05429edd96e09b5c75df57e3c
URL:
https://github.com/llvm/llvm-project/commit/ba19e98ca5e4fbc05429edd96e09b5c75df57e3c
DIFF:
https://github.com/llvm/llvm-project/commit/ba19e98ca5e4fbc05429edd96e09b5c75df57e3c.diff
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/112928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/112928
From bb66f56138cab9651aff4ac09096ede975c90701 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 18 Oct 2024 17:44:26 +0200
Subject: [PATCH 1/7] [lldb] Fix crash due to missing MS
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/112928
From bb66f56138cab9651aff4ac09096ede975c90701 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 18 Oct 2024 17:44:26 +0200
Subject: [PATCH 1/6] [lldb] Fix crash due to missing MS
@@ -0,0 +1,46 @@
+// Itanium ABI:
+// RUN: %clang --target=x86_64-pc-linux -gdwarf -c -o %t_linux.o %s
+// RUN: %lldb -f %t_linux.o -b -o "target variable mp1 mp2 mp3 mp4 mp5 mp6 mp7
mp8 mp9" | FileCheck %s
+//
+// CHECK: (char SI2::*) mp9 = 0x
+
+// Microsoft ABI
@@ -0,0 +1,48 @@
+// REQUIRES: lld
+
+// Microsoft ABI:
+// RUN: %clang_cl --target=x86_64-windows-msvc -c -gdwarf %s -o %t_win.obj
+// RUN: lld-link /out:%t_win.exe %t_win.obj /nodefaultlib /entry:main /debug
+// RUN: %lldb -f %t_win.exe -b -o "target variable mp1 mp2 mp3 mp4 mp5
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/112928
From bb66f56138cab9651aff4ac09096ede975c90701 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 18 Oct 2024 17:44:26 +0200
Subject: [PATCH 1/5] [lldb] Fix crash due to missing MS
weliveindetail wrote:
I think it's valuable to get the full config log on buildbots. If this check
becomes too much of a burden, I'd rather propose to either turn the error into
a warning or revisit the option to guard it by
`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS` (see my original patch for de
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/112928
From bb66f56138cab9651aff4ac09096ede975c90701 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 18 Oct 2024 17:44:26 +0200
Subject: [PATCH 1/4] [lldb] Fix crash due to missing MS
weliveindetail wrote:
> This might be related to https://github.com/llvm/llvm-project/issues/56458
> even though my repro is different.
Actually, rather this one: https://github.com/llvm/llvm-project/issues/56449 It
adds `MSInheritanceAttr` support in NativePDB. The patch in this PR is about
@@ -0,0 +1,48 @@
+// REQUIRES: lld
+
+// Microsoft ABI:
+// RUN: %clang_cl --target=x86_64-windows-msvc -c -gdwarf %s -o %t_win.obj
+// RUN: lld-link /out:%t_win.exe %t_win.obj /nodefaultlib /entry:main /debug
+// RUN: %lldb -f %t_win.exe -b -o "target variable mp1 mp2 mp3 mp4 mp5
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/112928
From bb66f56138cab9651aff4ac09096ede975c90701 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 18 Oct 2024 17:44:26 +0200
Subject: [PATCH 1/3] [lldb] Fix crash due to missing MS
weliveindetail wrote:
Ok right, member function pointers are more than just offsets. So, hard-coding
`clang::Type::MemberPointer` to the system pointer size wouldn't work there.
https://github.com/llvm/llvm-project/pull/112928
___
lldb-commits mailing
weliveindetail wrote:
Thanks for the feedback! Yes, I think fixing the crash is a valuable addition
on its own. It broke use-cases where we just want to set a breakpoint and
encounter this type on the way, but don't actually care about its byte size.
> I guess a follow-up question is how to se
https://github.com/weliveindetail ready_for_review
https://github.com/llvm/llvm-project/pull/112928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
weliveindetail wrote:
The test caused a crash in the past:
```
> bin/lldb.exe
> llvm-project-build-main/tools/lldb/test/Shell/SymbolFile/DWARF/x86/Output/ms-abi.cpp.tmp.exe
> -b -o "target variable mp1 mp2 mp3 mp4 mp5 mp6 mp7 mp8 mp9"
Exception Code: 0x8003
...
#6 0x7ffabb6be846 clang:
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/112928
From bb66f56138cab9651aff4ac09096ede975c90701 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Fri, 18 Oct 2024 17:44:26 +0200
Subject: [PATCH 1/2] [lldb] Fix crash due to missing MS
weliveindetail wrote:
This might be related to https://github.com/llvm/llvm-project/issues/56458 even
though my repro is different.
https://github.com/llvm/llvm-project/pull/112928
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://list
weliveindetail wrote:
This PR isn't complete yet, but early feedback is welcome. Next step is to get
test coverage. There are similar cases for types like `CXXRecord`, `Enum` or
`ObjCInterface` that attempt to query the complete type on the fly. Maybe we
should do that for `MemberPointer` as w
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/112928
In the MS ABI, member pointers to `CXXRecordDecl`s must have a
`MSInheritanceAttr` in order to be complete. Otherwise we cannot query their
size in memory. This patch checks `MemberPointer` types for com
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/112360
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
weliveindetail wrote:
Bots are fine and `functionalities/completion` kept passing:
* https://lab.llvm.org/buildbot/#/builders/141/builds/3195
* https://lab.llvm.org/buildbot/#/builders/162/builds/8408
* https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/6753
It affects quite a numb
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/112360
Following up from https://github.com/llvm/llvm-project/pull/112342, we roll out
the fix and quote nested `make` invocations in all API tests.
From 80688469060b8956a36797d2b75863545df75801 Mon Sep 17 00:0
https://github.com/weliveindetail edited
https://github.com/llvm/llvm-project/pull/112342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/112342
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
weliveindetail wrote:
Great, thanks. I will give this a try and if `functionalities/completion` keeps
passing on the bots, I roll it out to the other Makefiles.
https://github.com/llvm/llvm-project/pull/112342
___
lldb-commits mailing list
lldb-commit
weliveindetail wrote:
Yes, agree I think that both symlinking and Makefile templating make things
worse, because they get even more complicated.
We shortly discussed the dotest escape approach in
https://github.com/llvm/llvm-project/pull/111531#review-thread-or-comment-id-1146601373,
but back
weliveindetail wrote:
If this approach is accepted, I'd like to roll it out to 32 more affected tests
(upstream). I listed them here:
https://gist.github.com/weliveindetail/9a3cfcfc698f8814f5924ead7ba68bf3
I only tested this on Windows so far, but I expect it be fine on all other
platforms. S
weliveindetail wrote:
Thanks for the quick feedback! Yes, the buildbot in
https://lab.llvm.org/buildbot/#/builders/141 isn't affected.
Debug output (in swiftlang lldb) is:
```
Reading makefiles...
Updating goal targets
File `all' does not exist.
File `a.out' does not exist.
File `l
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/112342
In recent PR https://github.com/llvm/llvm-project/pull/111531 for Windows
support, we enabled tests that require the `make` tool. On Windows default
install directories likely contain spaces, in this cas
weliveindetail wrote:
In fact, I ran into that on Friday myself. I checked `LLDB_INCLUDE_TESTS=Off`
in my setup and it appeared to be incompatible with `LLDB_ENABLE_PYTHON=On` if
`lldb-python` is part of `LLVM_DISTRIBUTION_COMPONENTS`. The error said
something like `lldb-python-scripts` is lac
https://github.com/weliveindetail approved this pull request.
Interesting! Your changes look fine, as they are symmetric with what we do here
for dsymutil. I just wonder why I didn't hit that. Is this a separate test
driver for Linux?
https://github.com/llvm/llvm-project/pull/111980
__
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/111531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -250,6 +250,9 @@ def delete_module_cache(path):
if is_configured("dsymutil"):
dotest_cmd += ["--dsymutil", config.dsymutil]
+if is_configured("make"):
+dotest_cmd += ["--make", config.make]
+
weliveindetail wrote:
Changed in follow-up patch
https:
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/111531
From c7356d3c265869ff387c977dd18e9c617dc31c8d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Tue, 8 Oct 2024 15:40:37 +0200
Subject: [PATCH 1/7] [lldb] Add early CMake check for 'm
@@ -272,6 +272,8 @@ def parseOptionsAndInitTestdirs():
configuration.make_path = "gmake"
else:
configuration.make_path = "make"
+if ' ' in configuration.make_path:
+configuration.make_path = f'"{configuration.make_path}"'
welivei
weliveindetail wrote:
Fixed as part of the earlier PR linked above.
https://github.com/llvm/llvm-project/pull/111744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/111744
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -29,6 +29,22 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
"`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`")
endif()
endforeach()
+
+ # On Windows make is not part of the MSYS tools that llvm-lit takes care of
+ if(LLDB_TEST_MAKE)
+set(LLDB_DEFAULT_TEST_MAKE
https://github.com/weliveindetail deleted
https://github.com/llvm/llvm-project/pull/111531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
weliveindetail wrote:
No worries, we have it now. Thanks for the quick review!
https://github.com/llvm/llvm-project/pull/111747
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/111747
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -29,6 +29,22 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
"`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`")
endif()
endforeach()
+
+ # On Windows make is not part of the MSYS tools that llvm-lit takes care of
+ if(LLDB_TEST_MAKE)
+set(LLDB_DEFAULT_TEST_MAKE
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/111747
This module is used in various helper scripts since
https://github.com/llvm/llvm-project/pull/93712
From 6abfaf205142ffeaec76e72fcaf33bac72d2c51d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/111744
This is a draft. Only the last 2 commits will remain after rebase.
From c7356d3c265869ff387c977dd18e9c617dc31c8d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Tue, 8 Oct 2024 15:
@@ -29,6 +29,22 @@ if(LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS)
"`LLDB_ENFORCE_STRICT_TEST_REQUIREMENTS=OFF`")
endif()
endforeach()
+
+ # On Windows make is not part of the MSYS tools that llvm-lit takes care of
+ if(LLDB_TEST_MAKE)
+set(LLDB_DEFAULT_TEST_MAKE
https://github.com/weliveindetail approved this pull request.
Yes agree, LGTM
https://github.com/llvm/llvm-project/pull/111729
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/111531
From c7356d3c265869ff387c977dd18e9c617dc31c8d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Tue, 8 Oct 2024 15:40:37 +0200
Subject: [PATCH 1/3] [lldb] Add early CMake check for 'm
https://github.com/weliveindetail edited
https://github.com/llvm/llvm-project/pull/111531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -250,6 +250,9 @@ def delete_module_cache(path):
if is_configured("dsymutil"):
dotest_cmd += ["--dsymutil", config.dsymutil]
+if is_configured("make"):
+dotest_cmd += ["--make", config.make]
+
weliveindetail wrote:
`--make` is added if `LLDB_TEST_MA
https://github.com/weliveindetail commented:
Two notes inline
https://github.com/llvm/llvm-project/pull/111531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -272,6 +272,8 @@ def parseOptionsAndInitTestdirs():
configuration.make_path = "gmake"
else:
configuration.make_path = "make"
+if ' ' in configuration.make_path:
+configuration.make_path = f'"{configuration.make_path}"'
welivei
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/111531
From c7356d3c265869ff387c977dd18e9c617dc31c8d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Tue, 8 Oct 2024 15:40:37 +0200
Subject: [PATCH 1/2] [lldb] Add early CMake check for 'm
weliveindetail wrote:
Thanks for the quick feedback. Yes, makes sense. Here we go.
https://github.com/llvm/llvm-project/pull/111531
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/111531
Around 400 of LLDB's dotest.py based tests require the `make` tool to be found
in Path. If it's not found, they fail with an obscure error and show up as
`UNRESOLVED`. llvm-lit takes care of MSYS based t
weliveindetail wrote:
@labath @kendalharland Here is an attempt to fix this in the bindings
themselves: https://github.com/swiftlang/llvm-project/pull/9370 What do you
think?
https://github.com/llvm/llvm-project/pull/104514
___
lldb-commits mailing l
https://github.com/weliveindetail closed
https://github.com/llvm/llvm-project/pull/70793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -791,11 +791,10 @@ void ObjectFilePECOFF::AppendFromCOFFSymbolTable(
for (const auto &sym_ref : m_binary->symbols()) {
const auto coff_sym_ref = m_binary->getCOFFSymbol(sym_ref);
auto name_or_error = sym_ref.getName();
-if (auto err = name_or_error.takeError())
https://github.com/weliveindetail edited
https://github.com/llvm/llvm-project/pull/70793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -271,9 +271,9 @@ void ObjectFileCOFF::ParseSymtab(lldb_private::Symtab
&symtab) {
const auto COFFSymRef = m_object->getCOFFSymbol(SymRef);
Expected NameOrErr = SymRef.getName();
-if (auto error = NameOrErr.takeError()) {
- LLDB_LOG(log, "ObjectFileCOFF: fa
weliveindetail wrote:
Sorry, I had a few unrelated patched in the pipe. I force-pushed to fix that.
https://github.com/llvm/llvm-project/pull/70793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/70793
From a4fecdd4bd9b12b1151d62892bcad7bab6833ce0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Tue, 31 Oct 2023 13:12:21 +0100
Subject: [PATCH] [lldb] Fix missing comsumeError() with
https://github.com/weliveindetail created
https://github.com/llvm/llvm-project/pull/70793
I actually ran into it with a downstream fork:
```
llvm::Error::fatalUncheckedError(), llvm-project\llvm\lib\Support\Error.cpp,
line 117
ObjectFilePECOFF::AppendFromCOFFSymbolTable(),
llvm-project\lldb\so
Author: Stefan Gränitz
Date: 2023-08-18T13:57:50+02:00
New Revision: af2eb838309d88f046d34bca6055f1de6078fa3b
URL:
https://github.com/llvm/llvm-project/commit/af2eb838309d88f046d34bca6055f1de6078fa3b
DIFF:
https://github.com/llvm/llvm-project/commit/af2eb838309d88f046d34bca6055f1de6078fa3b.diff
Author: Stefan Gränitz
Date: 2023-05-17T13:56:01+02:00
New Revision: 0b6264738f3d3688719b23c5d272725d3d9bf4e0
URL:
https://github.com/llvm/llvm-project/commit/0b6264738f3d3688719b23c5d272725d3d9bf4e0
DIFF:
https://github.com/llvm/llvm-project/commit/0b6264738f3d3688719b23c5d272725d3d9bf4e0.diff
Author: Stefan Gränitz
Date: 2023-05-17T10:37:38+02:00
New Revision: 4241ac542d691289f08c3229cfc58641f5659ec7
URL:
https://github.com/llvm/llvm-project/commit/4241ac542d691289f08c3229cfc58641f5659ec7
DIFF:
https://github.com/llvm/llvm-project/commit/4241ac542d691289f08c3229cfc58641f5659ec7.diff
Author: Stefan Gränitz
Date: 2023-04-29T17:34:39+02:00
New Revision: 64a2520bacb59dac43bb4fd19ff1788d785102de
URL:
https://github.com/llvm/llvm-project/commit/64a2520bacb59dac43bb4fd19ff1788d785102de
DIFF:
https://github.com/llvm/llvm-project/commit/64a2520bacb59dac43bb4fd19ff1788d785102de.diff
Author: Stefan Gränitz
Date: 2023-04-13T14:32:15+02:00
New Revision: cc6ab268d89b27723f62517a07e86df85e999c89
URL:
https://github.com/llvm/llvm-project/commit/cc6ab268d89b27723f62517a07e86df85e999c89
DIFF:
https://github.com/llvm/llvm-project/commit/cc6ab268d89b27723f62517a07e86df85e999c89.diff
Author: Stefan Gränitz
Date: 2023-03-21T19:05:23+01:00
New Revision: 32baf5c1c29b6b2f282354c9f5919865bc1ff958
URL:
https://github.com/llvm/llvm-project/commit/32baf5c1c29b6b2f282354c9f5919865bc1ff958
DIFF:
https://github.com/llvm/llvm-project/commit/32baf5c1c29b6b2f282354c9f5919865bc1ff958.diff
Author: Stefan Gränitz
Date: 2023-03-17T17:09:31+01:00
New Revision: ef006eb0bc5e8d069deee7e7d93d7cf5d55fd791
URL:
https://github.com/llvm/llvm-project/commit/ef006eb0bc5e8d069deee7e7d93d7cf5d55fd791
DIFF:
https://github.com/llvm/llvm-project/commit/ef006eb0bc5e8d069deee7e7d93d7cf5d55fd791.diff
Author: Stefan Gränitz
Date: 2023-03-17T14:40:17+01:00
New Revision: c9987f0ac81a3d00be7627022372551bed61e6c1
URL:
https://github.com/llvm/llvm-project/commit/c9987f0ac81a3d00be7627022372551bed61e6c1
DIFF:
https://github.com/llvm/llvm-project/commit/c9987f0ac81a3d00be7627022372551bed61e6c1.diff
Author: Stefan Gränitz
Date: 2022-11-27T11:45:26+01:00
New Revision: c1a419c6cf6db04008b416a58332777fb6887e2d
URL:
https://github.com/llvm/llvm-project/commit/c1a419c6cf6db04008b416a58332777fb6887e2d
DIFF:
https://github.com/llvm/llvm-project/commit/c1a419c6cf6db04008b416a58332777fb6887e2d.diff
Author: Stefan Gränitz
Date: 2021-09-22T14:46:19+02:00
New Revision: 9689c1b7bb77d65e8acc9a13e5e416803d38b02f
URL:
https://github.com/llvm/llvm-project/commit/9689c1b7bb77d65e8acc9a13e5e416803d38b02f
DIFF:
https://github.com/llvm/llvm-project/commit/9689c1b7bb77d65e8acc9a13e5e416803d38b02f.diff
Author: Stefan Gränitz
Date: 2021-03-09T14:10:52+01:00
New Revision: 2ff533cba18af853fa0688c101f7ac7e7b594db7
URL:
https://github.com/llvm/llvm-project/commit/2ff533cba18af853fa0688c101f7ac7e7b594db7
DIFF:
https://github.com/llvm/llvm-project/commit/2ff533cba18af853fa0688c101f7ac7e7b594db7.diff
Author: Stefan Gränitz
Date: 2020-11-10T11:37:53+01:00
New Revision: 203b4774b88322de22c99881a3e1e4c78a9d5a0e
URL:
https://github.com/llvm/llvm-project/commit/203b4774b88322de22c99881a3e1e4c78a9d5a0e
DIFF:
https://github.com/llvm/llvm-project/commit/203b4774b88322de22c99881a3e1e4c78a9d5a0e.diff
98 matches
Mail list logo
