weliveindetail wrote:

Thanks for the feedback! Yes, I think fixing the crash is a valuable addition 
on its own. It broke use-cases where we just want to set a breakpoint and 
encounter this type on the way, but don't actually care about its byte size.

> I guess a follow-up question is how to set the MSInheritanceAttr. Infer it 
> from the class DIE? Or add a new DWARF attribute?
Well, maybe, but not sure. I believe it has a set of attributes that convey the 
information that MSInheritanceAttr has in the MS ABI. Would such duplication be 
accepted? And as long as it's just about member pointers, it might not be worth 
the effort. Let's see.

I did some more digging and now I wonder: Couldn't 
`TypeSystemClang::GetBitSize()` just return the pointer-size in bits for 
`clang::Type::MemberPointer`? That shouldn't even depend on the object it 
refers to, right?

https://github.com/llvm/llvm-project/pull/112928
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to