[Lldb-commits] [PATCH] D141907: [CMake] Ensure `CLANG_RESOURCE_DIR` is respected

sebastian-ne added inline comments. Comment at: cmake/Modules/GetClangResourceDir.cmake:15 + else() +string(REGEX MATCH "^[0-9]+" CLANG_VERSION_MAJOR ${PACKAGE_VERSION}) +set(ret_dir lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION_MAJOR}) This fails in ou

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbb7940e25f6c: [llvm] Make llvm::Any similar to std::any (authored by sebastian-ne). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

sebastian-ne added inline comments. Comment at: lldb/include/lldb/Core/RichManglingContext.h:90-91 assert(parser.has_value()); -assert(llvm::any_isa(parser)); +assert(llvm::any_cast(&parser)); return llvm::any_cast(parser); } barannikov88 wro

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

sebastian-ne updated this revision to Diff 483975. sebastian-ne marked 2 inline comments as done. sebastian-ne added a comment. > It is surprising to me that std::any can work without RTTI. Never thought it > could be implemented. It seems like libstdc++ and libc++ both implement it the way llvm

[Lldb-commits] [PATCH] D139973: [llvm] Make llvm::Any similar to std::any

sebastian-ne created this revision. sebastian-ne added reviewers: jloser, MaskRay, dblaikie, jsilvanus. Herald added subscribers: ormris, StephenFan, wenlei, hiraditya. Herald added a project: All. sebastian-ne requested review of this revision. Herald added projects: clang, LLDB, LLVM. Herald adde

[Lldb-commits] [PATCH] D132608: [CMake] Clean up CMake binary dir handling

sebastian-ne added a comment. I’m not sure if it’s the case for all places (as `CMAKE_CFG_INTDIR` is not defined at install time), but I think the `CMAKE_BINARY_LIBDIR` introduced here serves the same purpose as the already existing `LLVM_LIBRARY_DIR`. Same for `CMAKE_BINARY_INCLUDEDIR`, which i

[Lldb-commits] [PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

sebastian-ne added a comment. This is probably caused by using `CMAKE_CFG_INTDIR` (indirectly) in more places. Seems like it expands to `$(Configuration)` for Visual Studio. Searching more about it, it’s only set at build time, but not at install time, which is a problem as well. On top of all,

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

sebastian-ne added a comment. In D130586#3731021 , @Ericson2314 wrote: > Anyone have any idea what this Debian test failure is about? I haven’t seen a passing debian pre-merge check for months now, so I usually ignore it (the failures seems to be relat

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

sebastian-ne accepted this revision. sebastian-ne added a comment. Looks good to me, thanks! Comment at: utils/bazel/llvm-project-overlay/clang/include/clang/Config/config.h:70 /* Multilib suffix for libdir. */ +#define CLANG_INSTALL_LIBDIR_BASENAME "lib" T

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

sebastian-ne added inline comments. Comment at: clang/CMakeLists.txt:100 set(LLVM_RUNTIME_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin) - set(LLVM_LIBRARY_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) + set(LLVM_LIBRARY_OUTPUT_

[Lldb-commits] [PATCH] D130586: [cmake] Use `CMAKE_INSTALL_LIBDIR` too

sebastian-ne added inline comments. Comment at: clang/CMakeLists.txt:100 set(LLVM_RUNTIME_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/bin) - set(LLVM_LIBRARY_OUTPUT_INTDIR ${CMAKE_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) + set(LLVM_LIBRARY_OUTPUT_

[Lldb-commits] [PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited, part 2

sebastian-ne accepted this revision. sebastian-ne added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D132316: [CMake] Avoid `LLVM_BINARY_DIR` when other more specific variable are better-suited

sebastian-ne added a comment. The build afterwards succeeded again. Seems like every ~20th build on that windows machine fails. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132316/new/ https://reviews.llvm.org/D132316 ___

[Lldb-commits] [PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

sebastian-ne added inline comments. Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:91 set(LIB_DIR ${LLVM_BINARY_DIR}/${CMAKE_CFG_INTDIR}/lib${LLVM_LIBDIR_SUFFIX}) set(LIB_NAME ${LIB_DIR}/${CMAKE_SHARED_LIBRARY_PREFIX}LLVM) Ericson2314 wrote: > sebastian

[Lldb-commits] [PATCH] D132316: [CMake] `${LLVM_BINARY_DIR}/lib(${LLVM_LIBDIR_SUFFIX})?` -> `${LLVM_LIBRARY_DIR}`

sebastian-ne added inline comments. Comment at: llvm/tools/llvm-shlib/CMakeLists.txt:89 - set(LLVM_EXPORTED_SYMBOL_FILE ${LLVM_BINARY_DIR}/libllvm-c.exports) The lib here is not used as a folder, so this should probably not be replaced? It should probably in

[Lldb-commits] [PATCH] D128465: [llvm] add zstd to `llvm::compression` namespace

sebastian-ne added a comment. This breaks builds when LLVM is included with CMake’s `add_subdirectory`. I think the zstd target needs to be marked as imported. The following patch fixes the problem, although I’m not familiar enough with CMake to know if this is the right way to go: diff --git