sebastian-ne added inline comments.
================
Comment at: cmake/Modules/GetClangResourceDir.cmake:15
+ else()
+ string(REGEX MATCH "^[0-9]+" CLANG_VERSION_MAJOR ${PACKAGE_VERSION})
+ set(ret_dir lib${LLVM_LIBDIR_SUFFIX}/clang/${CLANG_VERSION_MAJOR})
----------------
This fails in our downstream project.
We use add_subdirectory() to include LLVM and our parent project already sets
PACKAGE_VERSION to something that is not the LLVM version.
Parsing PACKAGE_VERSION only if CLANG_VERSION_MAJOR is not already known seems
to work:
```
if (NOT CLANG_VERSION_MAJOR)
string(REGEX MATCH "^[0-9]+" CLANG_VERSION_MAJOR ${PACKAGE_VERSION})
endif()
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D141907/new/
https://reviews.llvm.org/D141907
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
