[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled

rZhBoYao added a comment. Thank you all for spending time reviewing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116217/new/ https://reviews.llvm.org/D116217 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG633b002944b9: [lldb] Fix PR52702 by fixing bool conversion of Mangled (authored by rZhBoYao). Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing bool conversion of Mangled

rZhBoYao updated this revision to Diff 396395. rZhBoYao retitled this revision from "[lldb] Fix PR52702 by fixing Mangled::operator!" to "[lldb] Fix PR52702 by fixing bool conversion of Mangled". rZhBoYao edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing Mangled::operator!

rZhBoYao added inline comments. Comment at: lldb/source/Core/Mangled.cpp:87 // { ... -bool Mangled::operator!() const { return !m_mangled; } +bool Mangled::operator!() const { return !m_mangled && !m_demangled; } labath wrote: > rZhBoYao wrote: > > Should we

[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing Mangled::operator!

rZhBoYao added inline comments. Comment at: lldb/source/Core/Mangled.cpp:87 // { ... -bool Mangled::operator!() const { return !m_mangled; } +bool Mangled::operator!() const { return !m_mangled && !m_demangled; } Should we remove `Mangled::operator!` altogeth

[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing Mangled::operator!

rZhBoYao updated this revision to Diff 396263. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116217/new/ https://reviews.llvm.org/D116217 Files: lldb/include/lldb/Core/Mangled.h lldb/source/Core/Mangled.cpp lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp lldb/unittests/C

[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing Mangled::operator!

rZhBoYao updated this revision to Diff 396261. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116217/new/ https://reviews.llvm.org/D116217 Files: lldb/include/lldb/Core/Mangled.h lldb/source/Core/Mangled.cpp lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp lldb/unittests/C

[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing Mangled::operator!

rZhBoYao added inline comments. Comment at: lldb/source/Core/Mangled.cpp:79-81 Mangled::operator void *() const { return (m_mangled) ? const_cast(this) : nullptr; } clayborg wrote: > Looks like there is a similar bug here in this function as well. We should

[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing Mangled::operator!

rZhBoYao created this revision. rZhBoYao added reviewers: clayborg, wallace, JDevlieghere. rZhBoYao added a project: LLDB. rZhBoYao requested review of this revision. Herald added a subscriber: lldb-commits. Mangled::operator! claimes to be true if the object has an empty mangled and unmangled na

[Lldb-commits] [PATCH] D106837: Create synthetic symbol names on demand to improve memory consumption and startup times.

rZhBoYao added a comment. Hi all, I found this patch causing PR52702 in that the parent of this commit and LLDB 12 worked fine. When disassembling a hello world C program on Linux, LLDB used to show `callq 0x4010