rZhBoYao added inline comments.
================
Comment at: lldb/source/Core/Mangled.cpp:87
// { ...
-bool Mangled::operator!() const { return !m_mangled; }
+bool Mangled::operator!() const { return !m_mangled && !m_demangled; }
----------------
labath wrote:
> rZhBoYao wrote:
> > Should we remove `Mangled::operator!` altogether? I find it less confusing
> > without.
> Does `!mangled` work without it? Would it be sufficient to implement the `!`
> operator in terms of bool conversion function?
Yes, I tried removing it and the unit test I added (`TEST(MangledTest,
LogicalNotOperator)`) passed. Keeping it this way is fine tho.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116217/new/
https://reviews.llvm.org/D116217
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
