[Lldb-commits] [PATCH] D109464: gn build: Add support for building lldb-server on Android.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG883e93cb280e: gn build: Add support for building lldb-server on Android. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D109

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9449f441fc9b: gn build: Add support for building LLDB on Linux. (authored by pcc). Changed prior to commit: https://reviews.llvm.org/D109463?vs=37

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

pcc added inline comments. Comment at: llvm/utils/gn/secondary/BUILD.gn:15 "//lld/test", +"//lldb", "//llvm/test", thakis wrote: > pcc wrote: > > thakis wrote: > > > Does this build fine on windows? > > > > > > Generally this only depends on the te

[Lldb-commits] [PATCH] D109464: gn build: Add support for building lldb-server on Android.

pcc updated this revision to Diff 371465. pcc added a comment. Move to data_deps Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109464/new/ https://reviews.llvm.org/D109464 Files: llvm/utils/gn/build/libs/xml/enable.gni llvm/utils/gn/secondary/

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

pcc updated this revision to Diff 371464. pcc added a comment. Move to data_deps Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109463/new/ https://reviews.llvm.org/D109463 Files: llvm/utils/gn/secondary/BUILD.gn llvm/utils/gn/secondary/lldb/in

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

pcc added inline comments. Comment at: llvm/utils/gn/secondary/BUILD.gn:15 "//lld/test", +"//lldb", "//llvm/test", thakis wrote: > Does this build fine on windows? > > Generally this only depends on the test targets which in turn depend on the > b

[Lldb-commits] [PATCH] D109464: gn build: Add support for building lldb-server on Android.

pcc created this revision. pcc added a reviewer: thakis. Herald added a subscriber: danielkiss. pcc requested review of this revision. Herald added a project: LLVM. The cross-compiled lldb-server targets are added to the top-level lldb target if Android cross compilation is enabled. Repository:

[Lldb-commits] [PATCH] D109463: gn build: Add support for building LLDB on Linux.

pcc created this revision. pcc added a reviewer: thakis. Herald added a subscriber: emaste. pcc requested review of this revision. Herald added a project: LLVM. On Linux, LLDB depends on lldb-server at runtime (is it different on Mac?), so I created a top-level lldb target that will build both lld

[Lldb-commits] [PATCH] D103127: lldb: Don't check for CMAKE_SYSTEM_NAME==Android.

pcc added a comment. In D103127#2985203 , @labath wrote: > How exactly are you building this? CMAKE_SYSTEM_NAME is set in the official > android cmake toolchain file > (https://android.googlesource.com/platform/ndk/+/refs/heads/ndk-release-r23/build/cma

[Lldb-commits] [PATCH] D105178: [lldb][AArch64] Annotate synchronous tag faults

pcc added a comment. > Programs must enable the tagged address ABI to > receive these signals and are also opting into the > presence of these tag bits. This is actually independent of the tagged address ABI. For siginfo data structures read via `ptrace(PTRACE_GETSIGINFO)` we will always have th

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

pcc added a comment. In D103626#2796554 , @DavidSpickett wrote: > The side effect here is that you do "memory read " and you see > untagged addresses for the lines. It's not really that confusing but maybe > something we should make a general decision

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

pcc added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:15 #include "lldb/Host/common/NativeProcessProtocol.h" #include "lldb/Utility/DataBufferHeap.h" Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

pcc added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:633 + + if (SendPacketAndWaitForResponse(packet.GetString(), response) != + PacketResult::Success || Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D103127: lldb: Don't check for CMAKE_SYSTEM_NAME==Android.

pcc created this revision. pcc added reviewers: JDevlieghere, labath. Herald added subscribers: danielkiss, krytarowski, mgorny. pcc requested review of this revision. Herald added a project: LLDB. CMAKE_SYSTEM_NAME seems to be unreliable for detecting whether the target is Android. At least on my

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

pcc added inline comments. Comment at: lldb/source/Target/Process.cpp:5569-5570 + + if (m_code_address_mask == 0) +return -1; // All bits are used for addressing. + jasonmolenda wrote: > pcc wrote: > > JDevlieghere wrote: > > > jasonmolenda wrote: > > > > pc

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

pcc added inline comments. Comment at: lldb/source/Target/Process.cpp:5569-5570 + + if (m_code_address_mask == 0) +return -1; // All bits are used for addressing. + JDevlieghere wrote: > jasonmolenda wrote: > > pcc wrote: > > > Is this part correct? (Same be

[Lldb-commits] [PATCH] D100515: [lldb] Add GetCodeAddressMask and GetDataAddressMask to Process

pcc added inline comments. Comment at: lldb/source/Target/Process.cpp:5569-5570 + + if (m_code_address_mask == 0) +return -1; // All bits are used for addressing. + Is this part correct? (Same below.) In D100521 you have ``` if (pc & pac_sign_extension)

[Lldb-commits] [PATCH] D98886: Pass pointer authentication code mask from minidump and use to strip pac from pc.

pcc added inline comments. Comment at: lldb/include/lldb/Target/Process.h:79 void SetExtraStartupCommands(const Args &args); + uint64_t GetPointerAuthenticationAddressMask() const; + void SetPointerAuthenticationAddressMask(const uint64_t mask); omjavaid wro

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

pcc added a comment. In D98529#2631946 , @DavidSpickett wrote: > TCR_ELx begins at 1 (see `D13.2.123 TCR_EL1, Translation Control Register > (EL1)` in the armarm) and covers EL0 and 1. Looking at the pseudocode access > to this is undefined at EL0. > >

[Lldb-commits] [PATCH] D93438: ObjectFileELF: Test whether reloc_header is non-null instead of asserting.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc314f5ede824: ObjectFileELF: Test whether reloc_header is non-null instead of asserting. (authored by pcc). Repository: rG LLVM Github Monorepo C

[Lldb-commits] [PATCH] D93495: CrashReason: Add MTE tag check faults to the list of crash reasons.

pcc added inline comments. Comment at: lldb/source/Plugins/Process/POSIX/CrashReason.cpp:62 +#ifndef SEGV_MTEAERR +#define SEGV_MTEAERR 8 +#endif emaste wrote: > emaste wrote: > > This should perhaps include an `#ifdef LINUX`(sp?) somehow, since 8 and 9 > > are

[Lldb-commits] [PATCH] D93495: CrashReason: Add MTE tag check faults to the list of crash reasons.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e5a187de313: CrashReason: Add MTE tag check faults to the list of crash reasons. (authored by pcc). Herald added a subscriber: krytarowski. Changed

[Lldb-commits] [PATCH] D93495: CrashReason: Add MTE tag check faults to the list of crash reasons.

pcc added a comment. In D93495#2462581 , @DavidSpickett wrote: > I assume that the signal displays without tag bits just like any other SEGV? > > I was thinking about testing but I don't see any tests for specific signals > so it would only be needed if

[Lldb-commits] [PATCH] D93495: CrashReason: Add MTE tag check faults to the list of crash reasons.

pcc updated this revision to Diff 313190. pcc added a comment. Show fault address for SEGV_MTESERR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93495/new/ https://reviews.llvm.org/D93495 Files: lldb/source/Plugins/Process/POSIX/CrashReason.cpp

[Lldb-commits] [PATCH] D93495: CrashReason: Add MTE tag check faults to the list of crash reasons.

pcc created this revision. pcc added a reviewer: labath. Herald added a subscriber: emaste. pcc requested review of this revision. Herald added a project: LLDB. As of Linux 5.10, the kernel may report either of the two following crash reasons: - SEGV_MTEAERR: async MTE tag check fault - SEGV_MTES

[Lldb-commits] [PATCH] D93438: ObjectFileELF: Test whether reloc_header is non-null instead of asserting.

pcc updated this revision to Diff 312608. pcc added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93438/new/ https://reviews.llvm.org/D93438 Files: lldb/source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp lldb/test/Shell/Object

[Lldb-commits] [PATCH] D93438: ObjectFileELF: Test whether reloc_header is non-null instead of asserting.

pcc created this revision. pcc added a reviewer: labath. Herald added a subscriber: emaste. Herald added a reviewer: espindola. pcc requested review of this revision. Herald added a subscriber: MaskRay. Herald added a project: LLDB. It is possible for the GetSectionHeaderByIndex lookup to fail bec