pcc added inline comments.
================
Comment at: llvm/utils/gn/secondary/BUILD.gn:15
"//lld/test",
+ "//lldb",
"//llvm/test",
----------------
thakis wrote:
> Does this build fine on windows?
>
> Generally this only depends on the test targets which in turn depend on the
> binaries, so probably should only have the old/test dep in this file anyways.
You're right, this needs to avoid the dependency on lldb on Windows targets.
The problem with only depending on `//lldb/test` is that nothing else refers to
`//lldb`, so `ninja lldb` wouldn't also build `lldb-server`. Maybe it would be
better to add `lldb-server` to the `data_deps` of `//lldb/tools/driver:lldb`
instead then.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109463/new/
https://reviews.llvm.org/D109463
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
