https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/78977
>From 4bcf2b50123b18752108aad163a059577e360aa6 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Mon, 22 Jan 2024 06:06:56 -0800
Subject: [PATCH 1/4] Add support for DW_OP_WASM_location to DWARFExpression
paolosevMSFT wrote:
> Apologies for the delay. LGTM!
Thanks! I have not merged any changes in several years and I am not very
familiar with the new process, now that llvm_project has moved to Github.
I have read
https://llvm.org/docs/MyFirstTypoFix.html#myfirsttypofix-issues-after-landing-your
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/77949
>From 30d932bb0988e1c78c3e023be2270259df5e6664 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Fri, 12 Jan 2024 09:10:59 -0800
Subject: [PATCH 1/7] Add support for source-level debugging of WebAssembly
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/77949
>From 30d932bb0988e1c78c3e023be2270259df5e6664 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Fri, 12 Jan 2024 09:10:59 -0800
Subject: [PATCH 1/6] Add support for source-level debugging of WebAssembly
@@ -2595,6 +2604,37 @@ bool DWARFExpression::Evaluate(
break;
}
+case DW_OP_WASM_location: {
+ uint8_t wasm_op = opcodes.GetU8(&offset);
+ uint32_t index;
+
+ /* LLDB doesn't have an address space to represents WebAssembly locals,
+ * globals
@@ -346,6 +346,15 @@ static offset_t GetOpcodeDataSize(const DataExtractor
&data,
return (offset - data_offset) + subexpr_len;
}
+ case DW_OP_WASM_location: {
+uint8_t wasm_op = data.GetU8(&offset);
+if (wasm_op == 3)
paolosevMSFT wrote:
I wil
@@ -1450,6 +1450,14 @@ class Process : public
std::enable_shared_from_this,
/// platforms where there is a difference (only Arm Thumb at this time).
lldb::addr_t FixAnyAddress(lldb::addr_t pc);
+ /// Some targets might use bits in a code address to represent additional
+
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/77949
>From 30d932bb0988e1c78c3e023be2270259df5e6664 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Fri, 12 Jan 2024 09:10:59 -0800
Subject: [PATCH 1/5] Add support for source-level debugging of WebAssembly
paolosevMSFT wrote:
Hi @JDevlieghere, could you take a look at the latest changes and unit tests?
https://github.com/llvm/llvm-project/pull/78977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
paolosevMSFT wrote:
Removed the 'wasm' command and addressed all the other review comments.
https://github.com/llvm/llvm-project/pull/77949
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
@@ -0,0 +1,293 @@
+//===-- ProcessWasm.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/77949
>From 30d932bb0988e1c78c3e023be2270259df5e6664 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Fri, 12 Jan 2024 09:10:59 -0800
Subject: [PATCH 1/4] Add support for source-level debugging of WebAssembly
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/78977
>From 4bcf2b50123b18752108aad163a059577e360aa6 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Mon, 22 Jan 2024 06:06:56 -0800
Subject: [PATCH 1/3] Add support for DW_OP_WASM_location to DWARFExpression
paolosevMSFT wrote:
The logic to manage `DW_OP_WASM_location` in `DWARFExpression` is moved to a
separate PR: https://github.com/llvm/llvm-project/pull/78977, which should be
reviewed (and hopefully approved :-)) before we can complete work on this PR>
https://github.com/llvm/llvm-project/pul
paolosevMSFT wrote:
> Seems like support for reading Wasm local and global variables is available
> in your code, but I don't understand how can one effectively read these
> variables from the lldb command line. Maybe adding commands to access these
> can be useful ?
The idea for this patch w
paolosevMSFT wrote:
> I see, thanks for the clarification. In the patch, the WasmLocal and
> WasmGlobal calls are done in ReadRegister, so it seems like those are being
> presented as register values? `register read` should show them. BTW, we
> shouldn't make a top level `wasm` command, we rea
paolosevMSFT wrote:
> > But currently a simple gdb-remote [:] does not enable the "wasm' plugin. Is
> > there a way to detect that we are debugging WebAssembly at connect time?
>
> Tracing down from `platform connect `, I get to
> `Process::FindPlugin`, which creates a process of all the regis
https://github.com/paolosevMSFT reopened
https://github.com/llvm/llvm-project/pull/77949
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/paolosevMSFT closed
https://github.com/llvm/llvm-project/pull/77949
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
paolosevMSFT wrote:
> might be a noobie question, but is compatible with split dwarf ?
Yes, it is :-).
For that to work, it expects that the Wasm module contains a custom section
named `.external_debug_info` that contains the path to another Wasm module that
contains the DWARF symbols section
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/78977
>From 4bcf2b50123b18752108aad163a059577e360aa6 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Mon, 22 Jan 2024 06:06:56 -0800
Subject: [PATCH 1/3] Add support for DW_OP_WASM_location to DWARFExpression
paolosevMSFT wrote:
Adding unit tests turned out to be a little complicated.
There were already a couple of unit tests in file
_lldb/unittests/Expression/DWARFExpressionTest.cpp_ that actually were failing
with these changes, so I replaced them.
>From the tests I learned that the vendor-specifi
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/78977
>From 4bcf2b50123b18752108aad163a059577e360aa6 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Mon, 22 Jan 2024 06:06:56 -0800
Subject: [PATCH 1/2] Add support for DW_OP_WASM_location to DWARFExpression
https://github.com/paolosevMSFT created
https://github.com/llvm/llvm-project/pull/78977
Add support for `DW_OP_WASM_location` in `DWARFExpression`.
>From 4bcf2b50123b18752108aad163a059577e360aa6 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Mon, 22 Jan 2024 06:06:56 -0800
Subject: [PATCH
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/77949
>From 30d932bb0988e1c78c3e023be2270259df5e6664 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Fri, 12 Jan 2024 09:10:59 -0800
Subject: [PATCH 1/3] Add support for source-level debugging of WebAssembly
paolosevMSFT wrote:
> > > A WebAssembly debugging session can be started using the new command:
> > > wasm [:]
> >
> >
> > What about wasm requires a new command, given that you are connecting to a
> > GDB server as existing targets do.
>
> +1! I don't think this needs a new command, it could
@@ -0,0 +1,291 @@
+//===-- ProcessWasm.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/77949
>From 30d932bb0988e1c78c3e023be2270259df5e6664 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Fri, 12 Jan 2024 09:10:59 -0800
Subject: [PATCH 1/2] Add support for source-level debugging of WebAssembly
paolosevMSFT wrote:
@JDevlieghere Thank you!
I will remove the code that handles DW_OP_WASM_location as you suggest.
For what concerns testing, I took a very quick look at `GdbRemoteTestCaseBase`
and if I am not wrong, it works by spawning an inferior processor attaching to
an inferior proces
paolosevMSFT wrote:
@JDevlieghere I created a new PR and closed
[https://github.com/llvm/llvm-project/pull/76683](https://github.com/llvm/llvm-project/pull/76683)
because I made a mess with a git rebase, and since the other PR had just
started I thought it made sense to start anew. I apologize
https://github.com/paolosevMSFT created
https://github.com/llvm/llvm-project/pull/77949
Add support for source-level debugging of WebAssembly code that runs in a
WebAssembly engine.
The idea is to use the GDB-remote protocol to connect to a Wasm engine that
implements a GDB-remote stub that o
https://github.com/paolosevMSFT ready_for_review
https://github.com/llvm/llvm-project/pull/76683
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/paolosevMSFT edited
https://github.com/llvm/llvm-project/pull/76683
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/76683
>From 739b26b03fd3661d1c22b975e241cbbe60ca6531 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Mon, 1 Jan 2024 06:55:40 -0800
Subject: [PATCH 1/4] [lldb] Implement WebAssembly debugging
Add support for
https://github.com/paolosevMSFT edited
https://github.com/llvm/llvm-project/pull/76683
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/76683
>From 739b26b03fd3661d1c22b975e241cbbe60ca6531 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Mon, 1 Jan 2024 06:55:40 -0800
Subject: [PATCH 1/3] [lldb] Implement WebAssembly debugging
Add support for
https://github.com/paolosevMSFT updated
https://github.com/llvm/llvm-project/pull/76683
>From 739b26b03fd3661d1c22b975e241cbbe60ca6531 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Mon, 1 Jan 2024 06:55:40 -0800
Subject: [PATCH 1/2] [lldb] Implement WebAssembly debugging
Add support for
https://github.com/paolosevMSFT created
https://github.com/llvm/llvm-project/pull/76683
Add support for source-level debugging of WebAssembly code.
>From 739b26b03fd3661d1c22b975e241cbbe60ca6531 Mon Sep 17 00:00:00 2001
From: Paolo Severini
Date: Mon, 1 Jan 2024 06:55:40 -0800
Subject: [PATCH]
Author: Paolo Severini
Date: 2020-02-27T11:17:10-08:00
New Revision: 256e61699b19c8e3545c948547c12872a8567250
URL:
https://github.com/llvm/llvm-project/commit/256e61699b19c8e3545c948547c12872a8567250
DIFF:
https://github.com/llvm/llvm-project/commit/256e61699b19c8e3545c948547c12872a8567250.diff
39 matches
Mail list logo
