paolosevMSFT wrote:

Adding unit tests turned out to be a little complicated.
There were already a couple of unit tests in file 
_lldb/unittests/Expression/DWARFExpressionTest.cpp_ that actually were failing 
with these changes, so I replaced them.
>From the tests I learned that the vendor-specific DWARF opcode 
>`DW_OP_WASM_location` should be handled in plugin code and not in 
>_DWARFExpression.cpp_.
Not sure what to do with the old tests, I don't think a `DW_OP_WASM_location` 
might ever be located in an ELF file, given that with "split symbols" Wasm uses 
the Wasm file format both for the file with the code and for the file with 
symbols. (Tested with emscripten).


https://github.com/llvm/llvm-project/pull/78977
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to