[Lldb-commits] [PATCH] D152176: [Demangle] convert microsoftDemangle to take a std::string_view

nickdesaulniers added a comment. This patch should have fixed the callsite in `llvm::demangle`...I will fix that up in D149104 which I am actively rebasing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152176/new

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers added a comment. > [Damangle] Damangle? dAmangle? *sigh* Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151003/new/ https://reviews.llvm.org/D151003 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D152176: [Demangle] convert microsoftDemangle to take a std::string_view

This revision was automatically updated to reflect the committed changes. Closed by commit rGdb98ac082744: [Demangle] convert microsoftDemangle to take a std::string_view (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/DLangDemangle.cpp:555 -Demangler D = Demangler(MangledName); -MangledName = D.parseMangle(&Demangled); +Demangler D(MangledName.data()); +const char *M = D.parseMangle(&Demangled);

[Lldb-commits] [PATCH] D152176: [Demangle] convert microsoftDemangle to take a std::string_view

nickdesaulniers created this revision. Herald added a subscriber: hiraditya. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commi

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/DLangDemangle.cpp:555 -Demangler D = Demangler(MangledName); -MangledName = D.parseMangle(&Demangled); +Demangler D(MangledName.data()); +const char *M = D.parseMangle(&Demangled);

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5371eb3d3ae: [Damangle] convert dlangDemangle to use std::string_view (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 528011. nickdesaulniers added a comment. This revision is now accepted and ready to land. - rebase on D149675 , remove nullptr check No, I don't want no nullptr-check A nullptr-check is a guard that can't get no love

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12d967c95f16: [Damangle] convert rustDemangle to use std::string_view (authored by nickdesaulniers). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 528006. nickdesaulniers added a comment. - rebase on top of D149675 (I wasn't sure which would land first) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149784/new/ h

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:49 bool llvm::nonMicrosoftDemangle(const char *MangledName, std::string &Result) { + if (!MangledName) +return false; MaskRay wrote: > nickdesaulniers wrote: > > nickdesaulnie

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 527900. nickdesaulniers added a comment. - rebase for presubmits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151003/new/ https://reviews.llvm.org/D151003 Files: lldb/source/Core/Mangled.cpp llvm/

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:49 bool llvm::nonMicrosoftDemangle(const char *MangledName, std::string &Result) { + if (!MangledName) +return false; nickdes

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers marked an inline comment as done. nickdesaulniers added inline comments. Comment at: llvm/lib/Demangle/Demangle.cpp:49 bool llvm::nonMicrosoftDemangle(const char *MangledName, std::string &Result) { + if (!MangledName) +return false; MaskRay

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 527895. nickdesaulniers added a comment. - rebase for presubmits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149784/new/ https://reviews.llvm.org/D149784 Files: lldb/include/lldb/Utility/ConstStrin

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 527514. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151003/new/ https://reviews.llvm.org/D151003 Files: lldb/source/Core/Mangled.cpp llvm/include/llvm/De

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 527507. nickdesaulniers marked an inline comment as done. nickdesaulniers added a comment. - update comments as per @Maskray Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149784/new/ https://reviews.llv

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 527502. nickdesaulniers added a comment. - rebase, reformat for presubmit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149784/new/ https://reviews.llvm.org/D149784 Files: lldb/include/lldb/Uti

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers planned changes to this revision. nickdesaulniers added a comment. needs rebasing for presubmit tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151003/new/ https://reviews.llvm.org/D151003 __

[Lldb-commits] [PATCH] D151003: [Damangle] convert dlangDemangle to use std::string_view

nickdesaulniers created this revision. Herald added a subscriber: hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. I was doing this API conversion to use std::string_v

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 519255. nickdesaulniers added a comment. - update llvm-rust-demangle-fuzzer.cpp call site Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149784/new/ https://reviews.llvm.org/D149784 Files: lldb/includ

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers updated this revision to Diff 519248. nickdesaulniers added a comment. - remove GetStringRef call Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149784/new/ https://reviews.llvm.org/D149784 Files: lldb/include/lldb/Utility/ConstSt

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers added inline comments. Comment at: lldb/source/Core/Mangled.cpp:263 case eManglingSchemeRustV0: -demangled_name = GetRustV0DemangledStr(mangled_name); +demangled_name = GetRustV0DemangledStr(m_mangled.GetStringRef()); break; ---

[Lldb-commits] [PATCH] D149784: [Damangle] convert rustDemangle to use std::string_view

nickdesaulniers created this revision. Herald added subscribers: JDevlieghere, hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits. I was doing this API conversion to use

[Lldb-commits] [PATCH] D148940: [Demangle] remove unused params of microsoftDemangle

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc2709fcb0a5b: [Demangle] remove unused params of microsoftDemangle (authored by nickdesaulniers). Herald added a subscriber: JDevlieghere. Repositor

[Lldb-commits] [PATCH] D148940: [Demangle] remove unused params of microsoftDemangle

nickdesaulniers updated this revision to Diff 515935. nickdesaulniers added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - fix lldb, test building lldb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148940/new/ h

[Lldb-commits] [PATCH] D148380: [lldb] Lock accesses to PathMappingLists's internals

nickdesaulniers added inline comments. Comment at: lldb/source/Target/PathMappingList.cpp:51 if (this != &rhs) { +std::scoped_lock locks(m_mutex, rhs.m_mutex); m_pairs = rhs.m_pairs; ``` [412/1011] Building CXX object tools/lldb/sourc...CMakeFiles/ll

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers added a comment. llvm/test/Demangle/ms-cxx14.test is now crashing on windows, working on a fix forward for llvm::microsoftDemangle which I think is missing a nullptr check. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148546/new/

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7c59e8001a3b: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view (authored by nickdesaulniers). Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers added a comment. Thanks for the help testing on Windows @ayzhao . Those warnings look potentially interesting to follow up; none appear to be introduced from this diff. Landing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148546/

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers updated this revision to Diff 515391. nickdesaulniers added a comment. - fix another conversion issue for msvc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148546/new/ https://reviews.llvm.org/D148546 Files: lldb/source/Plugins/

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers updated this revision to Diff 515387. nickdesaulniers marked 3 inline comments as done. nickdesaulniers added a comment. - git clang-format HEAD~, fix 2 more conversion issues Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148546/new/

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers marked 2 inline comments as done. nickdesaulniers added a comment. In D148546#4276926 , @DavidSpickett wrote: > I am confused why startswith is in the itanium demangle namespace but I could > be confusing a specialised function with the

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers closed this revision. nickdesaulniers added a comment. Let's use D148546 as the reland (sorry, couldn't get arcanist to work to reuse this instance of code review reopened). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148384/new/ htt

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers updated this revision to Diff 514386. nickdesaulniers added a comment. - rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148546/new/ https://reviews.llvm.org/D148546 Files: lldb/source/Plugins/SymbolFile/NativePDB/PdbAstBuil

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers planned changes to this revision. nickdesaulniers added inline comments. Herald added a subscriber: JDevlieghere. Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:19 +#include + I'll probably revert https://reviews.llvm.org/D148367 for

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers closed this revision. nickdesaulniers added a comment. Creating https://reviews.llvm.org/D148546 instead; `arcanist` really doesn't like how I've reopened this review. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148384/new/ https://reviews.llvm.org/D148384 __

[Lldb-commits] [PATCH] D148546: Reland: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers created this revision. nickdesaulniers added reviewers: MaskRay, erichkeane. Herald added a subscriber: hiraditya. Herald added a project: All. nickdesaulniers requested review of this revision. Herald added projects: LLDB, LLVM. Herald added subscribers: llvm-commits, lldb-commits.

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers updated this revision to Diff 514306. nickdesaulniers added a comment. This revision is now accepted and ready to land. - reopen with D148392 folded in, and 3 additional fixes for windows as reported by buildbots CHANGES SINCE LAST ACTION htt

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers added inline comments. Comment at: llvm/include/llvm/Demangle/ItaniumDemangle.h:19 +#include + MaskRay wrote: > chapuni wrote: > > Odd layering... > Good catch. LLVMDemangle cannot depend on other LLVM libraries. If these are inline function de

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers added a comment. In D148384#4270505 , @dhoekwater wrote: > It looks like this breaks the build: > https://lab.llvm.org/buildbot#builders/119/builds/12865 > https://lab.llvm.org/buildbot#builders/123/builds/18388 > https://lab.llvm.org/

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers added a comment. In D148384#4270106 , @nickdesaulniers wrote: > These windows buildbot failures are tough to make out: > https://lab.llvm.org/buildbot/#/builders/127/builds/46749/steps/4/logs/stdio > > [2/1778] Building CXX object > l

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers added a comment. These windows buildbot failures are tough to make out: https://lab.llvm.org/buildbot/#/builders/127/builds/46749/steps/4/logs/stdio [2/1778] Building CXX object lib\Demangle\CMakeFiles\LLVMDemangle.dir\DLangDemangle.cpp.obj FAILED: lib/Demangle/CMakeFiles/LL

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3e559509b426: [Demangle] replace use of llvm::StringView w/ std::string_view (authored by nickdesaulniers). Herald added a subscriber: JDevlieghere.

[Lldb-commits] [PATCH] D148384: [Demangle] replace use of llvm::StringView w/ std::string_view

nickdesaulniers updated this revision to Diff 513779. nickdesaulniers added a comment. This revision is now accepted and ready to land. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. - fix lldb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[Lldb-commits] [PATCH] D136572: Harmonize cmake_policy() across standalone builds of all projects

nickdesaulniers added inline comments. Comment at: clang/CMakeLists.txt:6 if(CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR) + # Please keep policies in sync with llvm/CMakeLists.txt. + if(POLICY CMP0114) Seems error prone. Does cmake have an include syste

[Lldb-commits] [PATCH] D117928: [lldb] Disable tests for x86 that uses write command on XMM registers

nickdesaulniers added a comment. In D117928#3264795 , @labath wrote: > If this is a problem with PTRACE_SETREGSET(NT_FPREGSET), then we might be > able to work around it by using PTRACE_POKEUSER instead. But it'd definitely > be good to confirm this, so

[Lldb-commits] [PATCH] D97449: [Diagnose] Unify MCContext and LLVMContext diagnosing

nickdesaulniers added a comment. I tested this on some wacko LTO kernel build failure (https://github.com/ClangBuiltLinux/linux/issues/1269). The error message went from: > :0: error: __ia32_compat_sys_sysctl changed binding to STB_GLOBAL To: unimplemented UNREACHABLE executed at ../incl

[Lldb-commits] [PATCH] D70277: [Signal] Allow llvm clients to opt into one-shot SIGPIPE handling

nickdesaulniers added a comment. This causes: $ clang -E -fno-integrated-cc1 x.c | tee foo.txt |head to crash. If I revert 9a3f892d018238dce5181e458905311db8e682f5 and 4624e83ce7b124545b55e45ba13f2d900ed65654

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

nickdesaulniers added a comment. Sounds like another approach was landed in https://reviews.llvm.org/D69403, and a follow up in https://reviews.llvm.org/D70277, and 9a3f892d018238dce5181e458905311db8e682f5 . Repository: rG

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

nickdesaulniers added a comment. In D73534#1883048 , @djtodoro wrote: > I’ve already pushed this. Please rebase on the latest commits. Ah faff707db82d7db12fcd9f7826b8741261230e63 . Coo

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

nickdesaulniers added a comment. In D73534#1882136 , @djtodoro wrote: > - Address the issue with ARM `describeLoadedValue()` (thanks to @vsk, I've > reduced the test > `llvm/test/DebugInfo/MIR/ARM/dbgcallsite-noreg-is-imm-check.mir`) I'd like to help t

[Lldb-commits] [PATCH] D73534: [DebugInfo] Enable the debug entry values feature by default

nickdesaulniers added a comment. As a heads up, Linaro's ToolChain Working Group's Linux kernel CI lit up on this change. I see it's been reverted (thank you). Please cc me on the updated patch and I can help test it against the Linux kernel. Edit: Link: https://ci.linaro.org/job/tcwg_kernel-b