@@ -744,6 +744,10 @@ let Command = "process continue" in {
Arg<"BreakpointIDRange">, Desc<"Specify a breakpoint to continue to,
temporarily "
"ignoring other breakpoints. Can be specified more than once. "
"The continue action will be done synchronously if this o
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/132846
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -38,23 +38,82 @@ class ThreadMemory : public lldb_private::Thread {
}
const char *GetName() override {
-if (!m_name.empty())
- return m_name.c_str();
if (m_backing_thread_sp)
return m_backing_thread_sp->GetName();
return nullptr;
}
cons
@@ -79,34 +136,124 @@ class ThreadMemory : public lldb_private::Thread {
}
bool SetBackingThread(const lldb::ThreadSP &thread_sp) override {
-// printf ("Thread 0x%llx is being backed by thread 0x%llx\n", GetID(),
-// thread_sp->GetID());
m_backing_thread_sp =
medismailben wrote:
Sorry for the delay, LGTM
https://github.com/llvm/llvm-project/pull/129301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/127153
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -453,22 +455,16 @@ ScriptedProcess::GetLoadedDynamicLibrariesInfos() {
if (!dict->HasKey("load_addr"))
return error_with_message("Dictionary is missing key 'load_addr'");
+llvm::StringRef path = "";
medismailben wrote:
If you're using a new `
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/128215
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -46,22 +46,82 @@ def __init__(self, exe_ctx: lldb.SBExecutionContext, args:
lldb.SBStructuredData
if len(self.threads) == 2:
self.threads[len(self.threads) - 1].is_stopped = True
-corefile_module = self.get_module_with_name(
-self.co
medismailben wrote:
> @jimingham @medismailben Can you please let me know if you have more
> questions regarding the problem and solution ? Right now, I have
> conditionally ignored the modules which are not created and only loaded the
> successful ones, if needed I can always load the success
medismailben wrote:
I'd like to get a better understanding of what you're trying to achieve:
Does the child elf-core process doesn't have any module loaded ? Are they only
described in the tombstone and require to be downloaded which could potentially
fail ?
https://github.com/llvm/llvm-proje
medismailben wrote:
I'm not convinced of that this change needs to be happen in ScriptedProcess ...
May be we could have a setting to not discard all modules loaded in case 1 of
them failed to load that would also work with other Process plugins. @jimingham
what do you think ?
https://github.
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
Nice! LGTM with comment.
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -76,6 +77,18 @@ bool ThreadPlanShouldStopHere::DefaultShouldStopHereCallback(
}
}
+ // Check whether the frame we are in is a language runtime thunk, only for
+ // step out:
+ if (operation == eFrameCompareOlder) {
+Symbol *symbol = frame->GetSymbolContext(eSym
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/126901
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/125302
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/123431
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/123225
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/122514
This fixes a typo when creating a target from the crashlog script and that we
were not able to find a valid architecture from the crash report.
rdar://137344016
>From 4b25769382f81fd03553703624e8b8e48d83a
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/120784
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
LGTM. nit: I'd have called the API `SBError::GetStructuredError`.
https://github.com/llvm/llvm-project/pull/120784
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
@@ -424,6 +425,14 @@ UserExpression::Execute(DiagnosticManager
&diagnostic_manager,
const EvaluateExpressionOptions &options,
lldb::UserExpressionSP &shared_ptr_to_me,
lldb::ExpressionVariableSP &result_va
@@ -1429,3 +1430,40 @@ PlatformDarwin::ResolveSDKPathFromDebugInfo(Module
&module) {
return path_or_err->str();
}
+
+llvm::Expected>
+PlatformDarwin::GetSDKPathFromDebugInfo(CompileUnit &unit) {
+ ModuleSP module_sp = unit.CalculateSymbolContextModule();
+ if (!module_sp)
@@ -473,6 +473,38 @@ class Platform : public PluginInterface {
LLVM_PRETTY_FUNCTION, GetName()));
}
+ /// Search CU for the SDK paths the CUs was compiled against. In the
+ /// presence of different SDKs, we try to pick the most appropriate
+ /// one
medismailben wrote:
> or, should we allow base classes to be looked up by name as well?
I'd prefer the latter so they can used interchangeably. I like the fact that
the subscript can be either an int or a string.
https://github.com/llvm/llvm-project/pull/118814
___
https://github.com/medismailben approved this pull request.
Nice! LGTM!
https://github.com/llvm/llvm-project/pull/118814
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
This doesn't seem to be used anywhere. LGTM!
https://github.com/llvm/llvm-project/pull/118411
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
medismailben wrote:
> > I'm only using it in an internal branch
>
>
>
> Not sure what the protocol is for this (CC @JDevlieghere @labath). At the
> very least we should have some coverage for it in the test-suite. There's
> precedent for this, e.g., APIs that only get exercised on the Swift
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/115963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben requested changes to this pull request.
@jasonmolenda I think there is a mistake in your range check.
https://github.com/llvm/llvm-project/pull/115963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lis
@@ -6184,7 +6184,14 @@ Status Process::GetMemoryRegionInfo(lldb::addr_t
load_addr,
MemoryRegionInfo &range_info) {
if (const lldb::ABISP &abi = GetABI())
load_addr = abi->FixAnyAddress(load_addr);
- return DoGetMemoryRegionInfo(load_a
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/111929
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/116300
This patch is a follow-up to 5b6b0c97ff09de2850577bbabe1f0c296d1c7af1 and adds
extra-null checks before dereferencing the inlined_info pointer.
>From cbd6cd71cdd99db615445d0c5591482a12b61df8 Mon Sep 17 00:
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/116300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/116300
>From fd5ba55ee1d1231fc0acf19ee124d811da795a41 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Thu, 14 Nov 2024 16:09:53 -0800
Subject: [PATCH] [lldb/Target] Add null-check before dereferencing
inl
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/116300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/116298
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/116298
This patch moves some of the logic implemented in the SBFrame APIs to the
lldb_private::StackFrame class so it can be re-used elsewhere.
>From c5bd8c739816988a6a3c710704fc83a298811bf6 Mon Sep 17 00:00:00 2
https://github.com/medismailben approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/115876
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,137 @@
+import os, struct, signal
+
+from typing import Any, Dict
+
+import lldb
+from lldb.plugins.scripted_process import ScriptedProcess
+from lldb.plugins.scripted_process import ScriptedThread
+
+
+class DummyStopHook:
+def __init__(self, target, args):
+
https://github.com/medismailben approved this pull request.
LGTM with comments.
https://github.com/llvm/llvm-project/pull/115963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,137 @@
+import os, struct, signal
+
+from typing import Any, Dict
+
+import lldb
+from lldb.plugins.scripted_process import ScriptedProcess
+from lldb.plugins.scripted_process import ScriptedThread
+
+
+class DummyStopHook:
+def __init__(self, target, args):
+
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/115963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/114469
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/114112
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/113166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> > @rocallahan does rr work on Mac?
>
> No, it doesn't. It does work on Linux AAarch64 though.
>
> > This didn't work because we also build lldb-server on macOS.
>
> Hmm, so lldb-server is built on macOS but we're not supposed to use it?
Yeah I was also surprised to see t
@@ -508,8 +508,20 @@ void BreakpointLocation::GetDescription(Stream *s,
s->PutCString("re-exported target = ");
else
s->PutCString("where = ");
+
+ // If there's a preferred line entry for printing, use that.
+ bool show_function_info = true;
+
@@ -537,7 +549,10 @@ void BreakpointLocation::GetDescription(Stream *s,
if (sc.line_entry.line > 0) {
s->EOL();
s->Indent("location = ");
- sc.line_entry.DumpStopContext(s, true);
+ if (GetPreferredLineEntry())
+GetPrefe
@@ -656,6 +671,49 @@ void
BreakpointLocation::SendBreakpointLocationChangedEvent(
}
}
+std::optional BreakpointLocation::GetSuggestedStackFrameIndex() {
+ if (!GetPreferredLineEntry())
+return {};
+ LineEntry preferred = *GetPreferredLineEntry();
medi
https://github.com/medismailben approved this pull request.
Also may be you can point to the crashlog script as an example where this is
already being used.
https://github.com/llvm/llvm-project/pull/112938
___
lldb-commits mailing list
lldb-commits@li
medismailben wrote:
LGTM but it would be nice if we made the `optional` fields stand out more by
either making it **bold** in the paragraph or add an `(optional)` on the
example lists.
https://github.com/llvm/llvm-project/pull/112938
___
lldb-commit
medismailben wrote:
> I adapted the code from here
>
> https://github.com/llvm/llvm-project/blob/a62768c427ec1f34d7c3823021a6c5a794709103/lldb/packages/Python/lldbsuite/test/tools/lldb-dap/lldbdap_testcase.py#L516
>
> into `lldbgdbproxy.py`:
> ```
> +lldb_server_exe = lldbgdbserverutils
medismailben wrote:
> > I suggest @medismailben (or an Apple colleague he nominates), runs this
> > test locally and does their best to narrow down the problem.
> > @rocallahan does `rr` work on Mac? Because one cross check here would be to
> > connect lldb to actual `rr` and see if that works.
medismailben wrote:
> I suggest @medismailben (or an Apple colleague he nominates), runs this test
> locally and does their best to narrow down the problem.
>
> @rocallahan does `rr` work on Mac? Because one cross check here would be to
> connect lldb to actual `rr` and see if that works. If i
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/111929
>From 5744d94fa7aaa8e8a800f929dfaf6baeb5670e03 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Mon, 14 Oct 2024 10:41:36 -0700
Subject: [PATCH] [lldb] Move SBLanguages.h out of API tree
This patch
https://github.com/medismailben approved this pull request.
LGTM with comments.
https://github.com/llvm/llvm-project/pull/112109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -45,13 +45,14 @@ class LLDB_API SBCommandReturnObject {
const char *GetOutput();
const char *GetError();
+ SBStructuredData GetErrorData();
#ifndef SWIG
LLDB_DEPRECATED_FIXME("Use PutOutput(SBFile) or PutOutput(FileSP)",
"PutOutput(SBFile
medismailben wrote:
ditto (line returns)
https://github.com/llvm/llvm-project/pull/112109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -184,53 +184,26 @@ def test_source_locations_from_objc_modules(self):
# the first argument are probably stable enough that this test can
check for them.
self.assertIn("void NSLog(NSString *format",
value.GetError().GetCString())
-def test_command_expr_
@@ -485,35 +485,8 @@ bool
CommandObjectExpression::EvaluateExpression(llvm::StringRef expr,
result.SetStatus(eReturnStatusSuccessFinishResult);
} else {
-// Retrieve the diagnostics.
-std::vector details;
-llvm::consumeError(llvm::handleE
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/112109
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
Answering
https://github.com/llvm/llvm-project/pull/99736#issuecomment-2408387985 and
https://github.com/llvm/llvm-project/pull/99736#issuecomment-2408398073here:
> Is there a way to run the full post-merge CI test suite against a Github PR?
Not that I'm aware of, unfortun
medismailben wrote:
Answered in your new PR.
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
Makes sense, LGTM!
https://github.com/llvm/llvm-project/pull/112062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/111929
>From 82b48c688943a3e2a61288a08955148a2d240952 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Fri, 11 Oct 2024 14:55:03 -0700
Subject: [PATCH] [lldb] Move SBLanguages.h out of API tree
This patch
@@ -71,7 +70,7 @@ class LLDB_API SBExpressionOptions {
/// Set the language using a pair of language code and version as
/// defined by the DWARF 6 specification.
/// WARNING: These codes may change until DWARF 6 is finalized.
- void SetLanguage(lldb::SBSourceLanguageNam
medismailben wrote:
> > I agree with that, but the argument here was going the other way.
> > lldb-enumerations.h are a base set of enumerations that anybody using LLDB,
> > either lldb_private or the SB API's are free to use. But the SB API's are
> > purely wrappers around lldb_private API's,
medismailben wrote:
> I'm just wondering, would this patch run into the same issue that I ran into
> on #111907 where this could cause a clean build to fail since the
> `SourceLangugageNames` file wouldn't be generated before it gets included in
> `lldb-enumerations.h`?
Possibly, we'll see wh
medismailben wrote:
> This looks better to me. I'm not sure why we were using defines from
> llvm::DWARF that seem to overlap the ones here, however. So I'll defer to
> Adrian or someone more knowledgeable about that side of things.
Yeah, that wasn't clear to me either, why didn't we just use
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/111929
This patch moves `SBLanguages.h` out of the API tree. This file gets generated
at build time using DWARF table-gen file and contains an enumeration of the
DWARF supported source language names and there re
https://github.com/medismailben approved this pull request.
LGTM with format fix
https://github.com/llvm/llvm-project/pull/111907
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/111763
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
Nice! LGTM!
https://github.com/llvm/llvm-project/pull/111747
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/111560
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
> I actually think it's fine to change this behavior, I don't think anyone
> would have expected SetError to AppendError...
If you feel strongly about this (I actually think you have a point), you could
make `SetError` as deprecated and have it call a newly added `AppendErr
https://github.com/medismailben commented:
LGTM!
https://github.com/llvm/llvm-project/pull/110707
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -486,19 +603,37 @@ bool
CommandObjectExpression::EvaluateExpression(llvm::StringRef expr,
result.SetStatus(eReturnStatusSuccessFinishResult);
} else {
-const char *error_cstr = result_valobj_sp->GetError().AsCString();
-if (error_cstr && error
@@ -8,6 +8,7 @@
#include "lldb/Utility/Status.h"
+#include "lldb/Expression/DiagnosticManager.h"
medismailben wrote:
Is this addition necessary ? It doesn't look like anything else has been added
to this file
https://github.com/llvm/llvm-project/pull/10647
https://github.com/medismailben approved this pull request.
This is pretty cool! LGTM with comment!
https://github.com/llvm/llvm-project/pull/106470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/106470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1887,7 +1887,8 @@ bool CommandInterpreter::HandleCommand(const char
*command_line,
CommandReturnObject &result,
bool force_repeat_command) {
std::string command_string(command_line);
- std::st
https://github.com/medismailben deleted
https://github.com/llvm/llvm-project/pull/106442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -61,8 +65,50 @@ std::string DiagnosticManager::GetString(char separator) {
stream << message.drop_front(severity_pos + severity.size());
stream << separator;
}
+ return str;
+}
- return ret;
+void DiagnosticManager::Dump(Log *log) {
+ if (!log)
+return;
https://github.com/medismailben deleted
https://github.com/llvm/llvm-project/pull/106442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
LGTM with comments!
https://github.com/llvm/llvm-project/pull/106442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -33,16 +33,16 @@ class RemoteAwarePlatformTester : public
RemoteAwarePlatform {
MOCK_METHOD0(CalculateTrapHandlerSymbolNames, void());
MOCK_METHOD2(ResolveExecutable,
- std::pair(const ModuleSpec &,
- const FileSp
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/106442
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -224,6 +224,14 @@ const char *Status::AsCString(const char
*default_error_str) const {
if (!m_string.empty() && m_string[m_string.size() - 1] == '\n')
m_string.pop_back();
+ // FIXME: Workaround for ErrorList[ExpressionError, ...].
+ if (m_error.isA()) {
+w
@@ -27,15 +27,15 @@ TEST(StatusTest, Formatv) {
}
TEST(StatusTest, ErrorConstructor) {
- EXPECT_TRUE(Status(llvm::Error::success()).Success());
+ EXPECT_TRUE(Status::FromError(llvm::Error::success()).Success());
- Status eagain(
+ Status eagain = Status::FromError(
@@ -254,14 +256,46 @@ class ClangDiagnosticManagerAdapter : public
clang::DiagnosticConsumer {
std::string stripped_output =
std::string(llvm::StringRef(m_output).trim());
- auto new_diagnostic = std::make_unique(
- stripped_output, severity, Inf
https://github.com/medismailben approved this pull request.
LGTM! Thanks for addressing my comments :)
https://github.com/llvm/llvm-project/pull/109062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/109498
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/109498
This patch re-lands #105449 and fixes the various test failures.
>From 6faa2d6ccad438818dd80c601a31a883fe29c882 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Fri, 20 Sep 2024 16:26:59 -0700
Subje
medismailben wrote:
@vogelsgesang Nice!
https://github.com/llvm/llvm-project/pull/109219
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben converted_to_draft
https://github.com/llvm/llvm-project/pull/109440
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben created
https://github.com/llvm/llvm-project/pull/109440
When running a oneliner script expression, if the script interpreter returned a
value, that value would be printed to the debugger standard output straight
from the interpreter instead of being propagated
https://github.com/medismailben closed
https://github.com/llvm/llvm-project/pull/105449
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 1127 matches
Mail list logo
