[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

2023-05-17 Thread Matt Arsenault via Phabricator via lldb-commits
arsenm closed this revision. arsenm added a comment. 44096e6904e10bb313fef2f6aaff25c25d1325f7 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150043/new/ https://reviews.llvm.org/D150043 __

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

2023-05-16 Thread Matt Arsenault via Phabricator via lldb-commits
arsenm added inline comments. Comment at: llvm/test/Transforms/InferAddressSpaces/masked-gather-scatter.ll:3 + +; CHECK-LABEL: @masked_gather_inferas( +; CHECK: tail call <4 x i32> @llvm.masked.gather.v4i32.v4p1 CaprYang wrote: > arsenm wrote: > > Generate full c

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

2023-05-16 Thread Matt Arsenault via Phabricator via lldb-commits
arsenm accepted this revision. arsenm added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150043/new/ https://reviews.llvm.org/D150043 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D150043: [InferAddressSpaces] Handle vector of pointers type & Support intrinsic masked gather/scatter

2023-05-09 Thread Matt Arsenault via Phabricator via lldb-commits
arsenm added inline comments. Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:289 + +static bool hasSameElementOfPtrOrVecPtrs(Type *Ty1, Type *Ty2) { + assert(isPtrOrVecOfPtrsType(Ty1) && isPtrOrVecOfPtrsType(Ty2)); arsenm wrote: > Ditto, only opaq

[Lldb-commits] [PATCH] D136959: clang: Improve errors for DiagnosticInfoResourceLimit

2022-10-28 Thread Matt Arsenault via Phabricator via lldb-commits
arsenm closed this revision. arsenm added a comment. 0ebd4638af1f71788ca55f521ed8e1ed8cab518d CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136959/new/ https://reviews.llvm.org/D136959 __

[Lldb-commits] [PATCH] D136959: clang: Improve errors for DiagnosticInfoResourceLimit

2022-10-28 Thread Matt Arsenault via Phabricator via lldb-commits
arsenm created this revision. arsenm added reviewers: nickdesaulniers, yaxunl, aaron.ballman, qcolombet, aeubanks, olista01, dnovillo, echristo, MaskRay. Herald added subscribers: kosarev, StephenFan, tpr. Herald added a project: All. arsenm requested review of this revision. Herald added a subscr

[Lldb-commits] [PATCH] D99812: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

2021-04-23 Thread Matt Arsenault via Phabricator via lldb-commits
arsenm added inline comments. Comment at: llvm/lib/Target/PowerPC/GISel/PPCCallLowering.cpp:46-58 +/** + * @brief Lower incoming arguments into generic MIR, this method is responsible + * for splitting aggregate arguments into multiple single value types as well + * as setting

[Lldb-commits] [PATCH] D99812: [PowerPC] [GlobalISel] Implementation of formal arguments lowering in the IRTranslator for the PPC backend

2021-04-08 Thread Matt Arsenault via Phabricator via lldb-commits
arsenm added a comment. Attached wrong diff? There are a lot of unrelated files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99812/new/ https://reviews.llvm.org/D99812 ___ lldb-commits mailing list lldb