arsenm added inline comments.
================ Comment at: llvm/lib/Transforms/Scalar/InferAddressSpaces.cpp:289 + +static bool hasSameElementOfPtrOrVecPtrs(Type *Ty1, Type *Ty2) { + assert(isPtrOrVecOfPtrsType(Ty1) && isPtrOrVecOfPtrsType(Ty2)); ---------------- arsenm wrote: > Ditto, only opaque pointers matter now You don't need to bother using getWithSamePointeeType. You can use Type::getWithNewType ================ Comment at: llvm/test/Transforms/InferAddressSpaces/masked-gather-scatter.ll:3 + +; CHECK-LABEL: @masked_gather_inferas( +; CHECK: tail call <4 x i32> @llvm.masked.gather.v4i32.v4p1 ---------------- Generate full checks ================ Comment at: llvm/test/Transforms/InferAddressSpaces/vector-of-pointers.ll:2 +; RUN: opt -S -passes=infer-address-spaces -assume-default-is-flat-addrspace %s | FileCheck %s + +; CHECK-LABEL: @double_ascast( ---------------- Generate full checks CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150043/new/ https://reviews.llvm.org/D150043 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits