[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. Refactored test according to recommendations given during review 1267bb2e416e Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum updated this revision to Diff 301796. fallkrum added a comment. make types extern. @jingham please commit this patch to check if it will fix DWO issue, the rest of your recommendations will add later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. In D88483#2363277 , @jingham wrote: > This test is still assuming (1) that main.c is CompUnit(0), etc. You don't > know that's true. And that there is only one type in each CU (and type 0 is > the one you want). Neither of th

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum updated this revision to Diff 301783. fallkrum added a comment. Api test fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 Files: lldb/test/API/functionalities/type_get_module/TestTypeGetModul

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. In D88483#2363075 , @fallkrum wrote: > @JDevlieghere @jingham api test failed after my commit: > http://lab.llvm.org:8011/#/builders/68/builds/1040 > Had no such an error on my computer, please help to figure out what went > wron

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum updated this revision to Diff 301768. fallkrum added a comment. Api test improvements. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 Files: lldb/test/API/functionalities/type_get_module/TestTyp

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. Could you explain how to commit that Differential revision is closed by commit? Commited like described in here https://llvm.org/docs/Phabricator.html#committing-someone-s-change-from-phabricator git pull --rebase https://github.com/llvm/llvm-project.git master git

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. @JDevlieghere @jingham api test failed after my commit: http://lab.llvm.org:8011/#/builders/68/builds/1040 Had no such an error on my computer, please help to figure out what went wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. Please commit it for me. Ilya Bukonkin fallk...@yahoo.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum updated this revision to Diff 301271. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 Files: lldb/bindings/interface/SBType.i lldb/include/lldb/API/SBModule.h lldb/include/lldb/API/SBType.h l

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. @JDevlieghere ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lis

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. In D88483#2343694 , @labath wrote: > > It sounds like that could be an artefact from how we parse function types > from dwarf. I haven't checked if that's what happens in this particular case, > but I know that we parse functio

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. In D88483#2342225 , @jingham wrote: > In D88483#2341538 , @fallkrum wrote: > >> Thanks a lot Jim for explanations, now it makes sense to me. >> Have one more question on class Type. Writing

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. Thanks a lot Jim for explanations, now it makes sense to me. Have one more question on class Type. Writing API test for the patch defined 2 functions like this: void *func1(int) { return NULL; } void *func2(int) { return NULL; } Tried to

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. In D88483#2339256 , @jingham wrote: > In D88483#2338408 , @fallkrum wrote: > >> Can you please give me a couple of words on what m_static_type and >> m_dynamic_type is in TypeImpl class, i

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. Can you please give me a couple of words on what m_static_type and m_dynamic_type is in TypeImpl class, in what cases can it be initialized with both of those types? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum marked 2 inline comments as done. fallkrum added a comment. Did not noticed it must be 3 slashes instead of 2 :) > Also, please make sure that your patch is well formatted (git clang-format > HEAD~) before submitting it. git-clang-format HEAD~ says the patch is well formatted. Reposi

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum updated this revision to Diff 299004. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 Files: lldb/bindings/interface/SBType.i lldb/include/lldb/API/SBModule.h lldb/include/lldb/API/SBType.h l

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum updated this revision to Diff 298596. fallkrum set the repository for this revision to rG LLVM Github Monorepo. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum updated this revision to Diff 298445. fallkrum added a comment. API test added. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 Files: lldb/bindings/interface/SBType.i lldb/include/lldb/API/SBModule.h lldb/include/lldb/API/SBType.

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum updated this revision to Diff 298184. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 Files: lldb/bindings/interface/SBType.i lldb/include/lldb/API/SBModule.h lldb/include/lldb/API/SBType.h l

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88483/new/ https://reviews.llvm.org/D88483 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cg

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum added a comment. In D88483#2300716 , @mib wrote: > Spotted some little things here and there ... This patch lacks a test and > would need some reformatting (`git clang-format HEAD~`) but other than that, > looks ok to me. Can I format and add t

[Lldb-commits] [PATCH] D88483: Add possibility to get module from SBType

fallkrum created this revision. fallkrum added reviewers: jingham, LLDB. fallkrum added a project: LLDB. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a reviewer: JDevlieghere. fallkrum requested review of this revision. Repository: rG LLVM Github Monorepo https://reviews.l

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. In D80112#2090767 , @JDevlieghere wrote: > In D80112#2090723 , @fallkrum wrote: > > > Guys help me figure out what may be wrong. Executed below listed command > > and can't find my newly

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. Guys help me figure out what may be wrong. Executed below listed command and can't find my newly added unit tests ThreadTest, ProcessEventDataTest. Ilyas-Mac-mini:Ninja ilya$ ./bin/llvm-lit --show-tests -sv ../../lldb/test/Unit -- Available Tests -- lldb-unit :

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. @JDevlieghere thanks for help. No, I have no commit access, please do it for me. Should I request the access now or you will grant it in the future? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://review

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. It says to provide the name and e-mail: Ilya Bukonkin fallk...@yahoo.com Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://reviews.llvm.org/D80112 ___ lldb-comm

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. It says "This revision is now accepted and ready to land." If I understand correctly I should be able to merge it somehow to the repository. Do not see how to do it though... Could you help to figure it out? Also very unclear why Harbormaster always fails with errors li

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum marked 9 inline comments as done. fallkrum added inline comments. Comment at: lldb/source/Target/Process.cpp:3977 +} else { + /* + For the sake of logical consistency. For example we have only jingham wrote: > I'm not entirely sure about t

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum updated this revision to Diff 270176. fallkrum added a comment. Removed _ptr from found_valid_stopinfo_ptr. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://reviews.llvm.org/D80112 Files: lldb/include/lldb/Target/Process

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum updated this revision to Diff 270148. fallkrum added a comment. Code review fixes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://reviews.llvm.org/D80112 Files: lldb/include/lldb/Target/Process.h lldb/source/Target/P

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum updated this revision to Diff 269963. fallkrum added a comment. Sorry for misunderstanding, you were right, it is possible to reproduce situation via SB API tests. Please check them out. In D80112#2080516 , @jingham wrote: > This patch has gotte

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. In D80112#2081008 , @jingham wrote: > Humm... So you'll have to test the continue behavior instead, which after > all was your original issue. That shouldn't be too hard, however. Just make > a breakpoint action that calls "t

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. In D80112#2080516 , @jingham wrote: > I was suggesting something like having a Python breakpoint action that > increments a Python variable. Hit the breakpoint first on thread A. That > should increment it by one. Then suspen

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum updated this revision to Diff 269067. fallkrum added a comment. In D80112#2075097 , @jingham wrote: > If I understand the problem you are describing, it is that you suspended a > thread as a user-level suspend, so it's stop reason got stuck. Tha

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. Didn't notice that we use in Process::ProcessEventData::DoOnRemoval: this_thread_wants_to_stop = stop_info_sp->ShouldStop(event_ptr); and yes it is probably correct to fix the issue by this: if (stop_info_sp && stop_info_sp->IsValid() && thread_sp->ShouldStop(even

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. As far as I see the problem lies in Process::ProcessEventData::DoOnRemoval: StopInfoSP stop_info_sp = thread_sp->GetStopInfo(); if (stop_info_sp && stop_info_sp->IsValid()) { does_anybody_have_an_opinion = true; bool this_thread_wants_to_sto

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum marked an inline comment as done. fallkrum added inline comments. Comment at: lldb/source/Target/Thread.cpp:382 +if (m_stop_info_sp->IsValid() || +(IsStillAtLastBreakpointHit() && + m_resume_state != eStateSuspended) || fa

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. @jingham tried test you added, got the following output: Ilyas-Mac-mini:Ninja ilya$ ./bin/lldb-dotest -p TestStateAfterExpression.py /Library/Frameworks/Python.framework/Versions/3.8/bin/python3.8 /Users/ilya/Documents/Projects/llvm-project/lldb/test/API/dotest.py --arc

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum updated this revision to Diff 267564. fallkrum added a comment. Added changes made to Thread.cpp itself to the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://reviews.llvm.org/D80112 Files: lldb/source/Target/Thr

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum updated this revision to Diff 267561. fallkrum added a comment. Herald added subscribers: dexonsmith, mgorny. Unit tests added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://reviews.llvm.org/D80112 Files: lldb/unittes

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum marked an inline comment as done. fallkrum added inline comments. Comment at: lldb/source/Target/Thread.cpp:382 +if (m_stop_info_sp->IsValid() || +(IsStillAtLastBreakpointHit() && + m_resume_state != eStateSuspended) || Wh

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. In D80112#2049657 , @JDevlieghere wrote: > In D80112#2048805 , @fallkrum wrote: > > > Anybody there? Do you see me? > > > Unless this change is somehow urgent, the common courtesy ‘ping’ r

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum added a comment. Anybody there? Do you see me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://reviews.llvm.org/D80112 ___ lldb-commits mailing list lldb-commits@lists.llvm.or

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum updated this revision to Diff 264576. fallkrum added a reviewer: LLDB. fallkrum removed a subscriber: lldb-commits. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80112/new/ https://reviews.llvm.org/D80112 Files: lldb/source/Target/Thread.cpp Index: lldb/source/Target/Thread.

[Lldb-commits] [PATCH] D80112: Check if thread was suspended during previous stop added.

fallkrum created this revision. fallkrum added reviewers: clayborg, jingham. fallkrum added a project: LLDB. Encountered the following situation: Let we started thread T1 and it hit breakpoint on B1 location. We suspended T1 and continued the process. Then we start