[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

kuilpd updated this revision to Diff 518801. kuilpd added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149262/new/ https://reviews.llvm.org/D149262 Files: lldb/include/lldb/Target/ABI.h lldb/include/lldb/Target/Target.h lldb/source/Expression/IRMemoryMap.cpp

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

kuilpd updated this revision to Diff 518520. kuilpd added a comment. Rebased and added a test. Instead of just getting a variable's address from allocated inside an expression, I decided to check for memory allocations inside logs. Exact variable address could change with the compilation change

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

kuilpd added a comment. In D149262#4306820 , @bulbazord wrote: > Sorry I should have brought this up earlier but I've noticed you don't have > any tests with this change. Is it possible you could add something there? > Something to make sure that these

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

kuilpd added inline comments. Comment at: lldb/source/Expression/LLVMUserExpression.cpp:340-348 +Process *process_sp; +ABISP abi_sp; +if ((process_sp = exe_ctx.GetProcessPtr()) && +(abi_sp = process_sp->GetABI())) { + stack_frame_size

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

kuilpd added inline comments. Comment at: lldb/source/Expression/LLVMUserExpression.cpp:38 +using namespace lldb; using namespace lldb_private; bulbazord wrote: > What in this file uses something from the lldb namespace now? ABI class Commen

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

kuilpd updated this revision to Diff 518010. kuilpd marked 4 inline comments as done. kuilpd added a comment. Removed unused variable arch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149262/new/ https://reviews.llvm.org/D149262 Files: lldb/include/lldb/Target/ABI.h lldb/include/

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

kuilpd updated this revision to Diff 518003. kuilpd added a comment. Made an ABI method that returns a stack frame size for the target. Removed the condition for alignment. The default value doesn't matter too much even for a 16-bit target, no need to add another ABI method just for this. The p

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

kuilpd added inline comments. Comment at: lldb/source/Expression/LLVMUserExpression.cpp:339 + if (stack_frame_size == 0) +stack_frame_size = arch == llvm::Triple::msp430 ? 512 : 512 * 1024; bulbazord wrote: > jingham wrote: > > This doesn't seem ap

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

kuilpd created this revision. kuilpd added reviewers: asl, bulbazord, DavidSpickett. kuilpd added projects: LLDB, All. Herald added subscribers: Michael137, JDevlieghere, arichardson. kuilpd requested review of this revision. Herald added a subscriber: lldb-commits. Expression evaluation allocates

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 514435. kuilpd added a comment. Fixed Triple.h include. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 Files: lldb/include/lldb/Utility/ArchSpec.h lldb/include/lldb/Utility/DataExtractor.h lldb/sourc

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 513245. kuilpd added a comment. Rebased and updated register info initialization. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 Files: lldb/include/lldb/Utility/ArchSpec.h lldb/include/lldb/Utility/Da

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 512891. kuilpd marked 6 inline comments as done. kuilpd added a comment. Added comments, changed memory strings formatting, added disassembler check. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 Files:

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd added a comment. In D146965#4240075 , @DavidSpickett wrote: > Two things come to mind: > > - Core files (though it is embedded so is that even a thing?) Looked into core dumping in LLDB a bit, I think it pretty much requires that there is an OS,

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 511497. kuilpd added a comment. Added a test for registers, breakpoints, stepping, backtracing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 Files: lldb/include/lldb/Utility/ArchSpec.h lldb/include/l

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd added a comment. In D146965#4240075 , @DavidSpickett wrote: > Two things come to mind: > > - Core files (though it is embedded so is that even a thing?) It is completely bare metal, but the address space is only 16-bit, so would the entire 64 KB

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 509089. kuilpd added a comment. Wrong previous diff. Added asserts in default cases, added checks for architecture instead of address size, added a unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D14696

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd updated this revision to Diff 509080. kuilpd added a comment. Added asserts in default cases, added checks for architecture instead of address size, added a unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 Files: lldb/inclu

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd marked 8 inline comments as done. kuilpd added inline comments. Comment at: lldb/source/Expression/IRMemoryMap.cpp:113-114 lldbassert(process_sp->GetAddressByteSize() == 4 || end_of_memory != 0xull); bulbazord wrote: > I th

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

kuilpd created this revision. kuilpd added a reviewer: asl. kuilpd added a project: LLDB. Herald added subscribers: Michael137, JDevlieghere. Herald added a project: All. kuilpd requested review of this revision. Herald added a subscriber: lldb-commits. Add MSP430 to the list of available targets,