kuilpd marked 8 inline comments as done.
kuilpd added inline comments.
================
Comment at: lldb/source/Expression/IRMemoryMap.cpp:113-114
lldbassert(process_sp->GetAddressByteSize() == 4 ||
end_of_memory != 0xffffffffull);
----------------
bulbazord wrote:
> I think with the change above we should probably make this assertion more
> useful.
Do we need this assert if I there is already one in the default case above?
```
default:
lldbassert(false && "Invalid address size.");
return LLDB_INVALID_ADDRESS;
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D146965/new/
https://reviews.llvm.org/D146965
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
