[Lldb-commits] [lldb] 066eea7 - Revert "Reland "clang][DebugInfo] Emit global variable definitions for static data members with constant initializers (#70639)""

Author: Hans Wennborg Date: 2023-11-07T15:52:19+01:00 New Revision: 066eea75d38957353824b46474413ef2632d01a7 URL: https://github.com/llvm/llvm-project/commit/066eea75d38957353824b46474413ef2632d01a7 DIFF: https://github.com/llvm/llvm-project/commit/066eea75d38957353824b46474413ef2632d01a7.diff

[Lldb-commits] [PATCH] D152712: [lldb][Android] Use a lambda for calls to ::open in RetryAfterSignal

hans edited reviewers, added: labath; removed: hans. hans added a comment. Herald added a subscriber: JDevlieghere. +labath Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152712/new/ https://reviews.llvm.org/D152712

[Lldb-commits] [PATCH] D151344: Reland "[CMake] Bumps minimum version to 3.20.0.

hans added a comment. This looks right to me. (I'm out of office at the moment, but this looks like what I tested in https://github.com/llvm/llvm-project/issues/62719 so it should work.) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151344/new/ h

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

hans added a comment. >>> Do you have a suggestion how we can move this patch forward? >> >> IIRC, D150688 + the diff in >> https://github.com/llvm/llvm-project/issues/62719#issuecomment-1552903385 + >> upgrading the pre-merge linux bot should take care of all

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

hans added a comment. In D144509#4350052 , @Mordante wrote: > In D144509#4349921 , @thakis wrote: > >> Reverted this and follow-ups in d763c6e5e2d0a6b34097aa7dabca31e9aff9b0b6 >>

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

hans added a comment. In D144509#4349399 , @mstorsjo wrote: > In D144509#4349051 , @hans wrote: > >> In D144509#4347562 , @glandium >> wrote: >> >>> FYI, 65429b9af6a2c99d

[Lldb-commits] [PATCH] D144509: [CMake] Bumps minimum version to 3.20.0.

hans added a comment. In D144509#4347562 , @glandium wrote: > FYI, 65429b9af6a2c99d340ab2dcddd41dab201f399c > is > causing problems on Windows compiler-rt for some reason I haven't id

[Lldb-commits] [PATCH] D112374: [clang] Implement ElaboratedType sugaring for types written bare

hans added a comment. Here's an example where I think this regressed a Clang diagnostic. Consider: template struct Template { Template(int x) {} }; struct S1 { struct Foo; typedef Template Typedef; }; struct S2 { struct Foo; typedef Template Typedef; }; typed

[Lldb-commits] [PATCH] D74727: Allow customized relative PYTHONHOME

hans added a comment. Herald added a project: All. In D74727#1887325 , @stella.stamenova wrote: > It looks like this broke the Windows LLDB Buildbot: > > http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/14048/steps/build/logs/stdio Seems i

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

hans added a comment. Looks great to me! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123957/new/ https://reviews.llvm.org/D123957 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb

[Lldb-commits] [PATCH] D123957: Update the developer policy to mention release notes

hans added a comment. If it's possible, maybe this could be worded in a way that strongly suggests the release notes should ideally be updated in the same patch as the code change? I think we're generally good at doing this for tests. It would be great if we could treat release notes the same.

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

hans added a comment. Sorry, the attached file is here: F20424768: a.ii Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110216/new/ https://reviews.llvm.org/D110216 __

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

hans added a comment. > I am not sure how to reproduce this. Attaching preprocessed source. With Clang built at 508aa4fe0c82b3b409e2e194d591ee6d665c8623 it reproduces for me like this: $ clang++ -c /tmp/a.ii ../../base/containers/span_unittest.cc:11:13: error: no viable conversion from 'sp

[Lldb-commits] [PATCH] D110216: [clang] retain type sugar in auto / template argument deduction

hans added a comment. We're seeing a diagnostic change in Chromium which looks funny. For the following code (span<> is our own class): int WontCompile() { const std::vector v; span s = make_span(v); } the diagnostic changes from: fatal error: no viable conversion from 'span' to

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

hans added inline comments. Comment at: llvm/cmake/config-ix.cmake:178 -if (LLVM_ENABLE_ZLIB STREQUAL "FORCE_ON" AND NOT HAVE_LIBZ) - message(FATAL_ERROR "Failed to configure zlib") Could this check be put back? E.g. for now it seems building with -DLLVM_USE_

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

hans added a comment. In D79219#2153585 , @phosek wrote: > In D79219#2152747 , @labath wrote: > >> I wouldn't mind separate (internal) cache variable, though I am somewhat >> surprised by this problem. A (non-cache

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

hans added a comment. Reverted in 3ab01550b632dad46f9595d74855749557ffd25c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews.llvm.org/D79219

[Lldb-commits] [lldb] 3ab0155 - Revert "[CMake] Simplify CMake handling for zlib"

Author: Hans Wennborg Date: 2020-08-05T12:31:44+02:00 New Revision: 3ab01550b632dad46f9595d74855749557ffd25c URL: https://github.com/llvm/llvm-project/commit/3ab01550b632dad46f9595d74855749557ffd25c DIFF: https://github.com/llvm/llvm-project/commit/3ab01550b632dad46f9595d74855749557ffd25c.diff

[Lldb-commits] [lldb] 3eec657 - Revert "Enable -Wsuggest-override in the LLVM build" and the follow-ups.

Author: Hans Wennborg Date: 2020-07-22T20:23:58+02:00 New Revision: 3eec65782575a1284391e447142fd004dd5de4a9 URL: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9 DIFF: https://github.com/llvm/llvm-project/commit/3eec65782575a1284391e447142fd004dd5de4a9.diff

[Lldb-commits] [PATCH] D84070: [LLDB] [COFF] Fix handling of symbols with more than one aux symbol

hans added a comment. In D84070#2162932 , @mstorsjo wrote: > @hans - I think this one could be a fairly safe backport to the release > branch. (Apparently phab lags behind regarding updating the reviews when they > are committed at the moment; this was c

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

hans added a comment. In D79447#2041250 , @hans wrote: > > - Added assert in `emitDebugInfoForUDTs` to ensure no lowering can occur > > during UDT emission, as suggested by @rnk > > It seems we hit the assert in Chromium. Here's a reproducer: > https://b

[Lldb-commits] [PATCH] D79447: [Debug][CodeView] Emit fully qualified names for globals

hans added a comment. > - Added assert in `emitDebugInfoForUDTs` to ensure no lowering can occur > during UDT emission, as suggested by @rnk It seems we hit the assert in Chromium. Here's a reproducer: https://bugs.chromium.org/p/chromium/issues/detail?id=1083877#c3 (I'll try to create a short

[Lldb-commits] [lldb] 525a591 - Revert 76c5f277f2 "Re-land [Debug][CodeView] Emit fully qualified names for globals"

Author: Hans Wennborg Date: 2020-05-18T11:26:30+02:00 New Revision: 525a591f0f48b9d54018bf5245f2abee09c9c1c8 URL: https://github.com/llvm/llvm-project/commit/525a591f0f48b9d54018bf5245f2abee09c9c1c8 DIFF: https://github.com/llvm/llvm-project/commit/525a591f0f48b9d54018bf5245f2abee09c9c1c8.diff

[Lldb-commits] [PATCH] D75406: Avoid including FileManager.h from SourceManager.h

hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75406/new/ https://reviews.llvm.org/D75406 ___ lld

[Lldb-commits] [PATCH] D70764: build: reduce CMake handling for zlib

hans added a comment. There were some concerns raised on this patch, and also in PR44780. I think at this point it's safer to revert these changes and start over. I've pushed the revert in 916be8fd6a0a0feea4cefcbeb0c22c65848d7a2e

[Lldb-commits] [lldb] 916be8f - Revert abb00753 "build: reduce CMake handling for zlib" (PR44780)

Author: Hans Wennborg Date: 2020-03-03T11:03:09+01:00 New Revision: 916be8fd6a0a0feea4cefcbeb0c22c65848d7a2e URL: https://github.com/llvm/llvm-project/commit/916be8fd6a0a0feea4cefcbeb0c22c65848d7a2e DIFF: https://github.com/llvm/llvm-project/commit/916be8fd6a0a0feea4cefcbeb0c22c65848d7a2e.diff

[Lldb-commits] [PATCH] D75279: Avoid SourceManager.h include in RawCommentList.h, add missing incs

hans accepted this revision. hans added a comment. Nice, lgtm! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75279/new/ https://reviews.llvm.org/D75279 ___ lldb-commits mailing list lldb-commits@lists.

[Lldb-commits] [PATCH] D74084: [LLDB] Fix compilation with GCC 5

hans added a comment. In D74084#1861269 , @mstorsjo wrote: > @hans - this could be applied on 10.x (it seems to apply cleanly), to fix > PR44791. Thanks! Cherry-picked as 22633f85bb7d317ff97c86b6ae7817b678777d93

Re: [Lldb-commits] [lldb] 2046d72 - build: improve python checks for Windows

Should https://llvm.org/docs/GettingStarted.html#requirements and https://llvm.org/docs/CMake.html#quick-start be updated to reflect the new requirement? And maybe a release note? On Sun, Dec 22, 2019 at 2:01 PM Saleem Abdulrasool via lldb-commits wrote: > > > Author: Saleem Abdulrasool > Date: 2

Re: [Lldb-commits] [lldb] fcaf5f6 - [LLDB] Fix the handling of unnamed bit-fields when parsing DWARF

erry-pick > 77cedb0cdb8623ff9eb22dbf3b9302ee4d9f8a20 ? > > Thanks again! > > > On 27. Jan 2020, at 15:10, Hans Wennborg wrote: > > > > Sure, b5cf892651812003e64c4a8f0dbf81f74a499016 > > > > On Mon, Jan 27, 2020 at 12:18 AM Raphael Isemann wrote: > >> &

Re: [Lldb-commits] [lldb] fcaf5f6 - [LLDB] Fix the handling of unnamed bit-fields when parsing DWARF

Sure, b5cf892651812003e64c4a8f0dbf81f74a499016 On Mon, Jan 27, 2020 at 12:18 AM Raphael Isemann wrote: > > This commit fixes a *very* frequent crash when debugging Clang with LLDB 10. > Could we get that cherry-picked into the 10.x branch? > > I’ve been running the patch since more than a week a

[Lldb-commits] [lldb] r374148 - Unify the two CRC implementations

Author: hans Date: Wed Oct 9 02:06:30 2019 New Revision: 374148 URL: http://llvm.org/viewvc/llvm-project?rev=374148&view=rev Log: Unify the two CRC implementations David added the JamCRC implementation in r246590. More recently, Eugene added a CRC-32 implementation in r357901, which falls back t

Re: [Lldb-commits] [lldb] r372788 - Host: use the platform identifiers from LLVM (NFC)

This seems to have broken the build: http://lab.llvm.org:8011/builders/lldb-x64-windows-ninja/builds/9182 I've reverted in r372847. On Wed, Sep 25, 2019 at 12:53 AM Saleem Abdulrasool via lldb-commits wrote: > > Author: compnerd > Date: Tue Sep 24 15:55:44 2019 > New Revision: 372788 > > URL: ht

[Lldb-commits] [lldb] r372847 - Revert r372788 "Host: use the platform identifiers from LLVM (NFC)"

Author: hans Date: Wed Sep 25 04:55:16 2019 New Revision: 372847 URL: http://llvm.org/viewvc/llvm-project?rev=372847&view=rev Log: Revert r372788 "Host: use the platform identifiers from LLVM (NFC)" > Use symbolic constants for the platform identifiers rather than replicating > them > locally.

Re: [Lldb-commits] [lldb] r367308 - [lldb] Fix crash when tab-completing in multi-line expr

Merged to release_90 in r367534. On Tue, Jul 30, 2019 at 2:53 PM Hans Wennborg wrote: > > Hi Raphael, > > Since this just landed, let's have it bake in trunk a little bit, and > then I'll merge it. > > Thanks, > Hans > > On Tue, Jul 30, 2019 at 2:36

Re: [Lldb-commits] [lldb] r367414 - [ProcessWindows] Choose a register context file by preprocessor

Merged to release_90 in r367523. On Wed, Jul 31, 2019 at 1:59 PM Tatyana Krasnukha via lldb-commits wrote: > > Author: tkrasnukha > Date: Wed Jul 31 05:00:30 2019 > New Revision: 367414 > > URL: http://llvm.org/viewvc/llvm-project?rev=367414&view=rev > Log: > [ProcessWindows] Choose a register co

Re: [Lldb-commits] [lldb] r367308 - [lldb] Fix crash when tab-completing in multi-line expr

Hi Raphael, Since this just landed, let's have it bake in trunk a little bit, and then I'll merge it. Thanks, Hans On Tue, Jul 30, 2019 at 2:36 PM Raphael “Teemperor” Isemann wrote: > > Hi Hans, > > Can you cherry-pick this to the 9.0 release? The issue is really easy to hit > when using LLDB

Re: [Lldb-commits] [lldb] r366985 - LLGS: fix tracking execve on linux

Merged to release_90 in r367128. On Wed, Jul 24, 2019 at 11:37 PM Pavel Labath via lldb-commits wrote: > > Author: labath > Date: Wed Jul 24 23:38:33 2019 > New Revision: 366985 > > URL: http://llvm.org/viewvc/llvm-project?rev=366985&view=rev > Log: > LLGS: fix tracking execve on linux > > Summar

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

hans added a comment. In D64881#1596920 , @labath wrote: > I think setting > -DPYTHON_EXECUTABLE=C:\Users\hwennborg\AppData\Local\Programs\Python\Python36-32\python.exe > (or something) should be enough to get cmake to select python3 for the > interpret

[Lldb-commits] [PATCH] D64881: [Cmake] Use the modern way to find Python when possible

hans added a comment. In D64881#1590204 , @amccarth wrote: > An aside ... > > I'm still trying to get back to a buildable state the earlier changes, like > the one that tries to enforce version consistency between the libs and the > interpreter. I'm cur

Re: [Lldb-commits] [lldb] r366433 - [CMake] Always build debugserver on Darwin and allow tests to use the system's one

Okay, merged in r366553. On Thu, Jul 18, 2019 at 3:38 PM Stefan Gränitz wrote: > > Hello Hans > > This commit would be very good to have on release/9.x. It simplifies a lot of > code in the code-sign and testing logic for LLDB on Darwin. This would be > useful for people who build their own LL

[Lldb-commits] [lldb] r360024 - Revert r359949 "[clang] adding explicit(bool) from c++2a"

Author: hans Date: Mon May 6 02:51:10 2019 New Revision: 360024 URL: http://llvm.org/viewvc/llvm-project?rev=360024&view=rev Log: Revert r359949 "[clang] adding explicit(bool) from c++2a" This caused Clang to start erroring on the following: struct S {   template explicit S(); }; stru

Re: [Lldb-commits] [lldb] r354122 - [lldb] [MainLoop] Add kevent() EINTR handling

Merged to release_80 in r354255. On Fri, Feb 15, 2019 at 1:12 PM Michal Gorny via lldb-commits wrote: > > Author: mgorny > Date: Fri Feb 15 04:13:02 2019 > New Revision: 354122 > > URL: http://llvm.org/viewvc/llvm-project?rev=354122&view=rev > Log: > [lldb] [MainLoop] Add kevent() EINTR handling

Re: [Lldb-commits] [lldb] r354029 - [lldb] [MainLoop] Report errno for failed kevent()

Merged to release_80 in r354254. On Thu, Feb 14, 2019 at 2:51 PM Michal Gorny via lldb-commits wrote: > > Author: mgorny > Date: Thu Feb 14 05:52:31 2019 > New Revision: 354029 > > URL: http://llvm.org/viewvc/llvm-project?rev=354029&view=rev > Log: > [lldb] [MainLoop] Report errno for failed keve

Re: [Lldb-commits] [lldb] r353642 - lldb: Fix compilation on OpenBSD

Merged to release_80 in r354253. On Sun, Feb 10, 2019 at 4:23 PM Raphael Isemann via lldb-commits wrote: > > Author: teemperor > Date: Sun Feb 10 07:23:58 2019 > New Revision: 353642 > > URL: http://llvm.org/viewvc/llvm-project?rev=353642&view=rev > Log: > lldb: Fix compilation on OpenBSD > > Sum

Re: [Lldb-commits] [lldb] r352116 - [Process/NetBSD] Add missing linkage to -lutil

Merged to 8.0 in r352134. Please let me know if there are any follow-ups. Thanks, Hans On Thu, Jan 24, 2019 at 2:20 PM Michal Gorny via lldb-commits wrote: > > Author: mgorny > Date: Thu Jan 24 14:20:47 2019 > New Revision: 352116 > > URL: http://llvm.org/viewvc/llvm-project?rev=352116&view=rev

Re: [Lldb-commits] [lldb] r351327 - Revert "Simplify Value::GetValueByteSize()"

Merged to the 8 branch in r351342. On Wed, Jan 16, 2019 at 1:23 PM Pavel Labath via lldb-commits wrote: > > Author: labath > Date: Wed Jan 16 04:19:22 2019 > New Revision: 351327 > > URL: http://llvm.org/viewvc/llvm-project?rev=351327&view=rev > Log: > Revert "Simplify Value::GetValueByteSize()"

[Lldb-commits] [lldb] r347758 - Revert r347673 "Catch up with EvaluateAsInt() clang API change."

Author: hans Date: Wed Nov 28 06:30:18 2018 New Revision: 347758 URL: http://llvm.org/viewvc/llvm-project?rev=347758&view=rev Log: Revert r347673 "Catch up with EvaluateAsInt() clang API change." r347417 was re-committed in Clang. Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modif

Re: [Lldb-commits] [lldb] r339076 - [lit, python] Always add quotes around the python path in lit

Merged to 7.0 in r339657. On Tue, Aug 7, 2018 at 12:37 AM, Stella Stamenova via lldb-commits wrote: > Author: stella.stamenova > Date: Mon Aug 6 15:37:53 2018 > New Revision: 339076 > > URL: http://llvm.org/viewvc/llvm-project?rev=339076&view=rev > Log: > [lit, python] Always add quotes around t

Re: [Lldb-commits] [lldb] r338949 - Fix a bug in VMRange

Merged to 7.0 in r339107. On Sat, Aug 4, 2018 at 4:15 AM, Leonard Mosescu via lldb-commits wrote: > Author: lemo > Date: Fri Aug 3 19:15:26 2018 > New Revision: 338949 > > URL: http://llvm.org/viewvc/llvm-project?rev=338949&view=rev > Log: > Fix a bug in VMRange > > I noticed a suspicious failur

Re: [Lldb-commits] [lldb] r324234 - Fix a crash in *NetBSD::Factory::Launch

Merged to 6.0 in r324327. On Mon, Feb 5, 2018 at 2:16 PM, Kamil Rytarowski via lldb-commits wrote: > Author: kamil > Date: Mon Feb 5 05:16:22 2018 > New Revision: 324234 > > URL: http://llvm.org/viewvc/llvm-project?rev=324234&view=rev > Log: > Fix a crash in *NetBSD::Factory::Launch > > Summary:

Re: [Lldb-commits] [lldb] r324251 - Sync PlatformNetBSD.cpp with Linux

Merged to 6.0 in r324326. On Mon, Feb 5, 2018 at 6:12 PM, Kamil Rytarowski via lldb-commits wrote: > Author: kamil > Date: Mon Feb 5 09:12:23 2018 > New Revision: 324251 > > URL: http://llvm.org/viewvc/llvm-project?rev=324251&view=rev > Log: > Sync PlatformNetBSD.cpp with Linux > > Summary: > Va

Re: [Lldb-commits] [lldb] r322081 - [test] Fix tests to use more portable LLVM_ENABLE_ZLIB

Merged to 6.0 in r322833. On Tue, Jan 9, 2018 at 3:44 PM, Michal Gorny via lldb-commits wrote: > Author: mgorny > Date: Tue Jan 9 06:44:04 2018 > New Revision: 322081 > > URL: http://llvm.org/viewvc/llvm-project?rev=322081&view=rev > Log: > [test] Fix tests to use more portable LLVM_ENABLE_ZLIB

Re: [Lldb-commits] [lldb] r321932 - [test] Use full PATH lookup for tools

Merged to 6.0 in r322832. On Sat, Jan 6, 2018 at 11:20 AM, Michal Gorny via lldb-commits wrote: > Author: mgorny > Date: Sat Jan 6 02:20:25 2018 > New Revision: 321932 > > URL: http://llvm.org/viewvc/llvm-project?rev=321932&view=rev > Log: > [test] Use full PATH lookup for tools > > Use full PAT

Re: [Lldb-commits] [lldb] r312008 - [IPv6] Fix a bug in the IPv6 listen behavior

Merged to 5.0 in r312016. On Tue, Aug 29, 2017 at 9:13 AM, Chris Bieneman via lldb-commits wrote: > Author: cbieneman > Date: Tue Aug 29 09:13:41 2017 > New Revision: 312008 > > URL: http://llvm.org/viewvc/llvm-project?rev=312008&view=rev > Log: > [IPv6] Fix a bug in the IPv6 listen behavior > >

Re: [Lldb-commits] [lldb] r311579 - Process: fix FXSAVE on x86

Merged in r311585. Thanks! On Wed, Aug 23, 2017 at 11:02 AM, Greg Clayton wrote: > Fine with me. > > On Aug 23, 2017, at 10:47 AM, Saleem Abdulrasool > wrote: > > This would be nice to merge to 5.0 IMO. It fixes reading the x87 FPU state. > What do you think Greg? > > On Wed, Aug 23, 2017 at 10

Re: [Lldb-commits] [lldb] r294019 - Push down more common code into PlatformPOSIX

> commit numbers. > > > > On 2/3/2017 4:54 PM, Hans Wennborg wrote: >> >> Geoff asked for this to be merged to 4.0. It looks like a nice change, >> but I'm a little hesitant since it doesn't look like it's fixing a >> regression. Pavel, what do

Re: [Lldb-commits] [lldb] r294019 - Push down more common code into PlatformPOSIX

Geoff asked for this to be merged to 4.0. It looks like a nice change, but I'm a little hesitant since it doesn't look like it's fixing a regression. Pavel, what do you think? On Fri, Feb 3, 2017 at 9:42 AM, Pavel Labath via lldb-commits wrote: > Author: labath > Date: Fri Feb 3 11:42:04 2017 >

Re: [Lldb-commits] [lldb] r277117 - Fix -break-insert not working when using absolute paths (MI)

Greg: ping? On Mon, Aug 8, 2016 at 1:38 PM, Hans Wennborg wrote: > Greg: ping? > > On Wed, Aug 3, 2016 at 9:06 AM, Hans Wennborg wrote: >> For LLDB, I think it's up to Greg to decide. >> >> On Tue, Aug 2, 2016 at 10:20 PM, Ilia K wrote: >>> Hi Hans! >

Re: [Lldb-commits] [lldb] r277117 - Fix -break-insert not working when using absolute paths (MI)

Greg: ping? On Wed, Aug 3, 2016 at 9:06 AM, Hans Wennborg wrote: > For LLDB, I think it's up to Greg to decide. > > On Tue, Aug 2, 2016 at 10:20 PM, Ilia K wrote: >> Hi Hans! >> >> The author of this commit asks me is there a chance to include this changes >&

Re: [Lldb-commits] [Diffusion] rL277426: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation…

Thanks! r278047. On Mon, Aug 8, 2016 at 10:26 AM, Greg Clayton wrote: > I am fine with this. It is in MIPS only code so it shouldn't affect anything > else. > >> On Aug 2, 2016, at 8:49 AM, Hans Wennborg wrote: >> >> While this all seems very MIPS-specific, so

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR (Merge Request)

Thanks! Merged in r278046. On Mon, Aug 8, 2016 at 10:25 AM, Greg Clayton wrote: > I am fine with this going in, but this fix is for MIPS only. > > >> On Aug 2, 2016, at 8:47 AM, Hans Wennborg wrote: >> >> Looks like a pretty big change to merge at this stage. &g

Re: [Lldb-commits] [lldb] r277117 - Fix -break-insert not working when using absolute paths (MI)

For LLDB, I think it's up to Greg to decide. On Tue, Aug 2, 2016 at 10:20 PM, Ilia K wrote: > Hi Hans! > > The author of this commit asks me is there a chance to include this changes > to 3.9 release? I'm not sure about our policy when RC has already been > tagged. > > On Fri, Jul 29, 2016 at 9:0

Re: [Lldb-commits] FW: [Diffusion] rL277426: [LLVM][MIPS] Add (D)SUBU, (D)ADDU, LUI instructions emulation . Fix emulation…

While this all seems very MIPS-specific, so probably fine to merge if you want to, it does look more like new development than just bug fixing. I'm OK with merging this if Clayton approves, though. Thanks, Hans On Tue, Aug 2, 2016 at 12:49 AM, Nitesh Jain wrote: > Hi Hans, > > Could you please

Re: [Lldb-commits] [PATCH] D20357: [LLDB][MIPS] Fix FPU Size Based on Dynamic FR (Merge Request)

Looks like a pretty big change to merge at this stage. I'll let Clayton decide. Thanks, Hans On Mon, Aug 1, 2016 at 11:25 PM, Nitesh Jain wrote: > Hi Hans, > > Could you please add this to the LLDB 3.9 release branch ? > > Thanks & regards, > Nitesh Jain > > > -Original Message- > From:

Re: [Lldb-commits] [lldb] r261206 - [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS

- > From: hwennb...@google.com [mailto:hwennb...@google.com] On Behalf Of Hans > Wennborg > Sent: 23 February 2016 00:25 > To: Bhushan Attarde > Cc: lldb-commits@lists.llvm.org; Greg Clayton (gclay...@apple.com); > ztur...@google.com > Subject: Re: [Lldb-commits] [lldb] r261206 -

Re: [Lldb-commits] [lldb] r261206 - [LLDB][MIPS] Provide CPU string to compiler for appropriate code generation for MIPS

Hi Bhushan, This looks more like new functionality than a regression fix from 3.7. As such, I'd rather not merge it to 3.8 this late in the process. Thanks, Hans On Sun, Feb 21, 2016 at 9:08 PM, Bhushan Attarde wrote: > Hi Hans, > > Could you please add this (r261206) to the release branch? > >

Re: [Lldb-commits] [lldb] r260072 - [LLDB][MIPS] Fix TestExpressionInSyscall.py for MIPS

Merged in r260236. Thanks, Hans On Tue, Feb 9, 2016 at 1:40 AM, Bhushan Attarde wrote: > Hi Hans, > > Could you please add this (r260072) to the release branch? > > Thanks, > Bhushan > > > -Original Message- > From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf Of

Re: [Lldb-commits] [lldb] r258485 - Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation

r259525. On Mon, Feb 1, 2016 at 1:51 PM, Hans Wennborg wrote: > Greg: ping? > > On Mon, Jan 25, 2016 at 11:40 AM, Hans Wennborg wrote: >> SGTM if Greg approves. >> >> On Mon, Jan 25, 2016 at 2:03 AM, Bhushan Attarde >> wrote: >>> Could you please add

Re: [Lldb-commits] [lldb] r258919 - [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

On Tue, Feb 2, 2016 at 8:52 AM, Hans Wennborg wrote: > On Mon, Feb 1, 2016 at 9:34 AM, Hans Wennborg wrote: >> On Mon, Feb 1, 2016 at 2:37 AM, Bhushan Attarde >> wrote: >>> Hi Hans, >>> >>> Could you please add this (r258919) to the release branch? &

Re: [Lldb-commits] [lldb] r258919 - [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

On Mon, Feb 1, 2016 at 9:34 AM, Hans Wennborg wrote: > On Mon, Feb 1, 2016 at 2:37 AM, Bhushan Attarde > wrote: >> Hi Hans, >> >> Could you please add this (r258919) to the release branch? >> Also commit r258967 (on top of this) by Zachary which fixes some

Re: [Lldb-commits] [lldb] r257926 - Implement missing GoASTContext methods

guages that aren't C/C++/ObjC or Swift (renderscript, go). > > >> On Feb 1, 2016, at 1:49 PM, Hans Wennborg wrote: >> >> Greg: ping? >> >> On Tue, Jan 26, 2016 at 11:10 AM, Hans Wennborg wrote: >>> Greg: Ping? >>> >>> On Tue, Ja

Re: [Lldb-commits] [lldb] r258485 - Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation

Greg: ping? On Mon, Jan 25, 2016 at 11:40 AM, Hans Wennborg wrote: > SGTM if Greg approves. > > On Mon, Jan 25, 2016 at 2:03 AM, Bhushan Attarde > wrote: >> Could you please add this to the release branch? >> >> Thanks, >> Bhushan >> >> >

Re: [Lldb-commits] [lldb] r257926 - Implement missing GoASTContext methods

Greg: ping? On Tue, Jan 26, 2016 at 11:10 AM, Hans Wennborg wrote: > Greg: Ping? > > On Tue, Jan 19, 2016 at 1:12 PM, Hans Wennborg wrote: >> Sure. Greg, are you the code owner for this, or is there a specific >> owner for Go? >> >> Thanks, >> Hans >&

Re: [Lldb-commits] [lldb] r258919 - [LLDB][MIPS] A small fix in GetBreakableLoadAddress() for MIPS

On Mon, Feb 1, 2016 at 2:37 AM, Bhushan Attarde wrote: > Hi Hans, > > Could you please add this (r258919) to the release branch? > Also commit r258967 (on top of this) by Zachary which fixes some python 3 > incompatibilities. Since this touched more than just MIPS-specific files, I'd like Greg t

Re: [Lldb-commits] [lldb] r259188 - Fix linking of lldb-server with BUILD_SHARED_LIBS

r259241. Thanks. On Fri, Jan 29, 2016 at 10:21 AM, Zachary Turner wrote: > lgtm, as Pavel points out build_shared_libs is already broken anyway and > this doesn't make it worse, while also not touching the non > build_shared_libs path. > > On Fri, Jan 29, 2016 at 10:15 AM

Re: [Lldb-commits] [lldb] r259188 - Fix linking of lldb-server with BUILD_SHARED_LIBS

Sgtm. Zach's the owner here. On Fri, Jan 29, 2016 at 6:47 AM, Pavel Labath wrote: > Zachary, Hans, > > this is not super-important, as a BUILD_SHARED_LIBS build of lldb will > still remain broken due to other issues, but I'd still like to get > this into 3.8, as it will reduce the pain for anyone

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

hans added a comment. I've committed the patch to 3.8 in r259081. Please confirm if this fixes the issue there. http://reviews.llvm.org/D16284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

hans added a comment. loladiro: Ping? http://reviews.llvm.org/D16284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r258921 - Fix linking with LLVM_LINK_LLVM_DYLIB=ON

Merged in r258964, thanks. (I accidentally committed some local changes too; reverted those in r258968.) On Wed, Jan 27, 2016 at 10:06 AM, Zachary Turner wrote: > Yea I think this is fine. > > On Wed, Jan 27, 2016 at 9:29 AM Hans Wennborg wrote: >> >> Zach is the lldb cm

Re: [Lldb-commits] [lldb] r258921 - Fix linking with LLVM_LINK_LLVM_DYLIB=ON

Zach is the lldb cmake owner. Zach, does this seem OK for 3.8? On Wed, Jan 27, 2016 at 7:13 AM, Pavel Labath wrote: > Hi, > > could we get this patch applied to the 3.8 branch? > > thanks, > pl > > > On 27 January 2016 at 11:02, Pavel Labath via lldb-commits > wrote: >> Author: labath >> Date: W

Re: [Lldb-commits] [lldb] r257926 - Implement missing GoASTContext methods

Greg: Ping? On Tue, Jan 19, 2016 at 1:12 PM, Hans Wennborg wrote: > Sure. Greg, are you the code owner for this, or is there a specific > owner for Go? > > Thanks, > Hans > > On Fri, Jan 15, 2016 at 11:43 AM, Ryan Brown via lldb-commits > wrote: >> It would be nice

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

hans added a comment. Did this ever get committed? http://reviews.llvm.org/D16284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [lldb] r258485 - Use "_$" prefix instead of "$" for dynamic checker function inserted by LLDB during expression evaluation

SGTM if Greg approves. On Mon, Jan 25, 2016 at 2:03 AM, Bhushan Attarde wrote: > Could you please add this to the release branch? > > Thanks, > Bhushan > > > -Original Message- > From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf Of > Bhushan D. Attarde via lldb-co

Re: [Lldb-commits] [lldb] r257926 - Implement missing GoASTContext methods

Sure. Greg, are you the code owner for this, or is there a specific owner for Go? Thanks, Hans On Fri, Jan 15, 2016 at 11:43 AM, Ryan Brown via lldb-commits wrote: > It would be nice if we could get this into 3.8 to get rid of these asserts. > > -- Ryan Brown > > On Fri, Jan 15, 2016 at 11:35 AM

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

hans added a comment. In http://reviews.llvm.org/D16284#329161, @loladiro wrote: > The Makefile system will be removed from trunk very soon, so it might not > necessarily make sense there, but I think it would be good to get this > applied to release-38. @clayborg @hans how would you like to ha

Re: [Lldb-commits] [lldb] r257691 - Include IR/DerivedTypes.h instead of IR/Type.h to match LLVM change r256406.

On Wed, Jan 13, 2016 at 2:40 PM, Hans Wennborg via lldb-commits wrote: > Author: hans > Date: Wed Jan 13 16:40:24 2016 > New Revision: 257691 > > URL: http://llvm.org/viewvc/llvm-project?rev=257691&view=rev > Log: > Include IR/DerivedTypes.h instead of IR/Type.h to

Re: [Lldb-commits] [lldb] r257692 - Fix -Wformat-pedantic warning

On Wed, Jan 13, 2016 at 2:40 PM, Hans Wennborg via lldb-commits wrote: > Author: hans > Date: Wed Jan 13 16:40:26 2016 > New Revision: 257692 > > URL: http://llvm.org/viewvc/llvm-project?rev=257692&view=rev > Log: > Fix -Wformat-pedantic warning

[Lldb-commits] [lldb] r257692 - Fix -Wformat-pedantic warning

Author: hans Date: Wed Jan 13 16:40:26 2016 New Revision: 257692 URL: http://llvm.org/viewvc/llvm-project?rev=257692&view=rev Log: Fix -Wformat-pedantic warning /work/llvm-3.8/llvm.src/tools/lldb/source/API/SBProcess.cpp:1003:73: error: format specifies type 'void *' but the argument has type 'l

[Lldb-commits] [lldb] r257691 - Include IR/DerivedTypes.h instead of IR/Type.h to match LLVM change r256406.

Author: hans Date: Wed Jan 13 16:40:24 2016 New Revision: 257691 URL: http://llvm.org/viewvc/llvm-project?rev=257691&view=rev Log: Include IR/DerivedTypes.h instead of IR/Type.h to match LLVM change r256406. This is similar to r256407 and fixes the following warning: In file included from /work

Re: [Lldb-commits] [PATCH] D12275: Fix build on mips

hans added a comment. In http://reviews.llvm.org/D12275#231979, @sagar wrote: > I have committed it to the trunk in revision 245927. You can now merge it to > the release branch. Thanks! Merged in r245947. Repository: rL LLVM http://reviews.llvm.org/D12275

Re: [Lldb-commits] [lldb] r245547 - [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

I'm not happy about this. lldb builds fine on Linux for me. What's the build problem on mips? I also don't see the relation between r245240 (which was also a large patch) and this, but I haven't looked closely and am not familiar with the code. In general it would be nice if merge requests don't

Re: [Lldb-commits] [lldb] r245020 - [MIPS]Handle floating point and aggregate return types in SysV-mips [32 bit] ABI

Greg: ping? On Fri, Aug 14, 2015 at 11:06 AM, Hans Wennborg wrote: > Sure, if Greg approves. > > Thanks, > Hans > > On Thu, Aug 13, 2015 at 11:25 PM, Bhushan Attarde > wrote: >> Hi Hans, >> >> Could you please merge this to the release branch? >>

Re: [Lldb-commits] [lldb] r245217 - [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 mode support

ts. > Could you please delete RegisterContext_mips64.h from the release branch ? > > Regards, > Sagar > > > On Tuesday 18 August 2015 02:47 AM, Hans Wennborg wrote: >> >> Merged to 3.7 in r245240. There was a conflicts because r245141 isn't >> on the branch.

Re: [Lldb-commits] [lldb] r245217 - [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 mode support

Merged to 3.7 in r245240. There was a conflicts because r245141 isn't on the branch. Please check that I got it right: http://llvm.org/viewvc/llvm-project?rev=245240&view=rev Thanks, Hans On Mon, Aug 17, 2015 at 1:28 PM, Greg Clayton wrote: > Ok to merge. >> On Aug 17, 2015

Re: [Lldb-commits] [lldb] r245216 - [LLDB] Use llvm::APInt and llvm::APFloat in Scalar and RegisterValue

+lldb-commits On Mon, Aug 17, 2015 at 1:25 PM, Hans Wennborg wrote: > I'm OK with it if Greg approves. > > - Hans > > On Mon, Aug 17, 2015 at 7:06 AM, wrote: >> Hi Hans, >> >> Could you please merge r245216 in the release branch? >> >> Thanks,

Re: [Lldb-commits] [lldb] r245217 - [LLDB][MIPS] Fix offsets of all register sets and add MSA regset and FRE=1 mode support

I'm OK with it if Greg approves. - Hans On Mon, Aug 17, 2015 at 7:07 AM, wrote: > Hi Hans, > > Could you please also merge r245217 in the release branch. > > Thanks, > Sagar > > -Original Message- > From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf Of > Sagar T

Re: [Lldb-commits] [lldb] r245020 - [MIPS]Handle floating point and aggregate return types in SysV-mips [32 bit] ABI

Sure, if Greg approves. Thanks, Hans On Thu, Aug 13, 2015 at 11:25 PM, Bhushan Attarde wrote: > Hi Hans, > > Could you please merge this to the release branch? > > Thanks > Bhushan > > > -Original Message- > From: lldb-commits [mailto:lldb-commits-boun...@lists.llvm.org] On Behalf Of >

Re: [Lldb-commits] [Diffusion] rL244866: [LLDB][MIPS] Use qfThreadID if qC packet is not supported by target

Merged in r244967. Thanks, Hans On Thu, Aug 13, 2015 at 9:54 AM, Greg Clayton wrote: > Fine to merge. > >> On Aug 13, 2015, at 9:33 AM, Hans Wennborg wrote: >> >> Greg: you're the owner here. OK for merging to 3.7? >> >> On Wed, Aug 12, 2015 at 10:22

Re: [Lldb-commits] [Diffusion] rL244865: [LLDB][MIPS] Support standard GDB remote stop reply packet for watchpoint

Merged in r244965. Thanks, Hans On Thu, Aug 13, 2015 at 10:48 AM, Greg Clayton wrote: > Yes, merging this is fine. > >> On Aug 13, 2015, at 9:33 AM, Hans Wennborg wrote: >> >> >> Greg: you're the owner here. Approved for 3.7? >> >> On Wed, Au

  1   2   >