[Lldb-commits] [PATCH] D138176: [dsymutil] Fix assertion: (Ref > InputDIE.getOffset()), function cloneDieReferenceAttribute

friss added inline comments. Comment at: llvm/include/llvm/DWARFLinker/DWARFLinkerCompileUnit.h:81-82 + +/// Is DIE a forward or backward reference? +bool Reference : 1; }; When I read the comment, I was confused as I thought the flag was used to diff

[Lldb-commits] [PATCH] D101094: lldb/Instrumentation: NFC-ish use GetFrameCodeAddressForSymbolication()

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. friss marked an inline comment as done. Closed by commit rG91e90cf62207: lldb/Instrumentation: NFC-ish use GetFrameCodeAddressForSymbolication() (authored by friss). R

[Lldb-commits] [PATCH] D101094: lldb/Instrumentation: NFC-ish use GetFrameCodeAddressForSymbolication()

friss updated this revision to Diff 339746. friss added a comment. Use make_shared Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101094/new/ https://reviews.llvm.org/D101094 Files: lldb/source/Plugins/InstrumentationRuntime/MainThreadChecker/In

[Lldb-commits] [PATCH] D101094: lldb/Instrumentation: NFC-ish use GetFrameCodeAddressForSymbolication()

friss created this revision. friss added reviewers: jasonmolenda, JDevlieghere. friss requested review of this revision. Herald added a project: LLDB. A couple of our Instrumentation runtimes were gathering backtraces, storing it in a StructuredData array and later creating a HistoryThread using t

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

friss added a comment. In D97739#2607961 , @clayborg wrote: > In D97739#2607869 , @jingham wrote: > >> This way of doing progress is going to look odd in anything that uses >> multiple debuggers. If I'm reading th

[Lldb-commits] [PATCH] D92820: [lldb] Deal gracefully with concurrency in the API instrumentation.

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. This LGTM. There is one thing that you might want to address, but I'll leave it up to you (and even if you do it can be a different commit): with the introduction of `idx` variables, it becomes

[Lldb-commits] [PATCH] D92820: [lldb] Deal gracefully with concurrency in the API instrumentation.

friss added a comment. The change itself looks fine, but I'm wondering about the test. There is nothing that really guarantees that the SB calls and return values are going to be intertwined, is there? Does it rely solely on the fact that it's very very unlikely to succeed? CHANGES SINCE LAST

[Lldb-commits] [PATCH] D92811: [lldb] Track the API boundary using a thread_local variable.

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. This LGTM. I like that it's way easier than what we have discussed offline. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92811/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

friss added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/valueobject-pass-by-reg.s:14-40 +# typedef union +# { +# unsigned raw; +# struct +# { +# unsigned a : 8; +# unsigned b : 8; This gives a much more compact debug info section:

[Lldb-commits] [PATCH] D85265: Add a setting to always run all threads when stepping

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. Sure. As I said I know this is unrelated to the path. this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85265/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D85265: Add a setting to always run all threads when stepping

friss added inline comments. Comment at: lldb/source/Commands/CommandObjectThread.cpp:486-490 + // NonStopMode runs all threads down in the ProcessPlugin layer, but + // at this level we need to pretend we are actually only running this + // thread. So functionall

[Lldb-commits] [PATCH] D85537: [lldb] Store the Apple SDK in the configuration and use it to determine the platform.

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85537/new/ https://reviews.llvm.org/D85537 ___ lldb-commits mai

[Lldb-commits] [PATCH] D85539: [lldb] Extend builder to pass the TRIPLE spec to Make

friss added a comment. `lldbremote.py` looks awfully Apple-specific, yet it is going to be called from the generic code. Is that not an issue? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85539/new/ https://reviews.llvm.org/D85539 ___

[Lldb-commits] [PATCH] D85265: Add a setting to always run all threads when stepping

friss added a comment. This LGTM. The only comment I had is about a comment you added on preexisting code: Comment at: lldb/source/Commands/CommandObjectThread.cpp:486-490 + // NonStopMode runs all threads down in the ProcessPlugin layer, but + // at this level we ne

[Lldb-commits] [PATCH] D85358: Correctly detect legacy iOS simulator Mach-O objectfiles

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85358/new/ https://reviews.llvm.org/D85358 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

friss added inline comments. Comment at: lldb/source/Core/ValueObjectChild.cpp:202-205 -if (m_bitfield_bit_size) - scalar.ExtractBitfield(m_bitfield_bit_size, - m_bitfield_bit_offset); -else

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

friss added inline comments. Comment at: lldb/source/Core/ValueObjectChild.cpp:202-205 -if (m_bitfield_bit_size) - scalar.ExtractBitfield(m_bitfield_bit_size, - m_bitfield_bit_offset); -else

[Lldb-commits] [PATCH] D85358: Correctly detect legacy iOS simulator Mach-O objectfiles

friss added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:5029-5030 + // Disambiguate legacy simulator platforms. + if (base_triple.getArch() == llvm::Triple::x86_64 || + base_triple.getArch() == llvm::Triple::x86) { +

[Lldb-commits] [PATCH] D85237: [lldb] Add an option to inherit TCC permissions from parent.

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85237/new/ https://reviews.llvm.org/D85237 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D85237: [lldb] Add an option to disable TCC

friss added a comment. The logic of the patch itself looks fine, but the names, description and commit message are off. A process cannot disable TCC, it's always active. What your patch decides is whether the inferior is responsible for its own TCC permissions. If you don't make the inferior re

[Lldb-commits] [PATCH] D84576: Fix debugserver's qProcessInfo reporting of maccatalyst binaries

friss added a comment. This looks good outside of 2 cross-platform issues in the tests themselves. Comment at: lldb/test/API/macosx/macCatalyst/TestMacCatalyst.py:27 +self.expect("image list -t -b", +patterns=["x86_64.*-apple-ios.*-macabi a\.out"]) +

[Lldb-commits] [PATCH] D84716: [lldb/ArchSpec] Always match simulator environment in IsEqualTo

This revision was automatically updated to reflect the committed changes. Closed by commit rG8120eba5fce3: [lldb/ArchSpec] Always match simulator environment in IsEqualTo (authored by friss). Changed prior to commit: https://reviews.llvm.org/D84716?vs=281084&id=281088#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D84716: [lldb/ArchSpec] Always match simulator environment in IsEqualTo

friss marked an inline comment as done. friss added inline comments. Comment at: lldb/unittests/Utility/ArchSpecTest.cpp:329 ASSERT_FALSE(A.IsExactMatch(B)); // FIXME: See above, though the extra environment complicates things. ASSERT_FALSE(A.IsCompatibleMatch(B));

[Lldb-commits] [PATCH] D84716: [lldb/ArchSpec] Always match simulator environment in IsEqualTo

friss created this revision. friss added a reviewer: aprantl. Herald added subscribers: dexonsmith, inglorion. Herald added a project: LLDB. Initially, Apple simulator binarie triples didn't use a `-simulator` environment and were just differentiated based on the architecture. For example, `x86_64

[Lldb-commits] [PATCH] D84537: [lldb/AppleSimulator] Always provide a -simulator environment

friss updated this revision to Diff 280604. friss added a comment. Simplify the logic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84537/new/ https://reviews.llvm.org/D84537 Files: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp

[Lldb-commits] [PATCH] D84537: [lldb/AppleSimulator] Always provide a -simulator environment

friss marked 4 inline comments as done. friss added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:270 +static const ArchSpec platform_arch( +HostInfo::GetArchitecture(HostInfo::eArchKind64)); +arch = platform_arch; ---

[Lldb-commits] [PATCH] D84537: [lldb/AppleSimulator] Always provide a -simulator environment

friss created this revision. friss added a reviewer: aprantl. Herald added a subscriber: mgorny. Herald added a project: LLDB. This commit is somewhat NFC-ish today as the environment of triples is not considered when comparing s if one of them is not set (I plan to change that). We have made sim

[Lldb-commits] [PATCH] D84083: [lldb/ObjectFileMachO] Correctly account for resolver symbols

This revision was automatically updated to reflect the committed changes. Closed by commit rG22c16360dd00: [lldb/ObjectFileMachO] Correctly account for resolver symbols (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84083/new/ ht

[Lldb-commits] [PATCH] D84480: debugserver: Support ios simulator load command disambiguation in qProcessInfo

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. LGTM! Comment at: lldb/tools/debugserver/source/DNB.cpp:1396 if (GetProcessSP(pid, procSP)) { -// FIXME: This doesn't correct for older ios simulator and macCatalyst. +

[Lldb-commits] [PATCH] D83552: [lldb/test] Do a better job at setting (DY)LD_LIBRARY_PATH

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. In D83552#2162782 , @labath wrote: > In D83552#2162555 , @friss wrote: > > > The `lldbtest.py` part LGTM, but I'm

[Lldb-commits] [PATCH] D83552: [lldb/test] Do a better job at setting (DY)LD_LIBRARY_PATH

friss added a comment. The `lldbtest.py` part LGTM, but I'm failing to see how this interacts with `TestWeakSymbols.py`? IIRC, `registerSharedLibraryWithTarget` is an API we call explicitly in the tests, but I don't see it called here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D84083: [lldb/ObjectFileMachO] Correctly account for resolver symbols

friss created this revision. friss added reviewers: jasonmolenda, jingham. Herald added a project: LLDB. The resolver addresses stored in the dyld trie are relative to the base of the __TEXT segment. This is usually 0 in a dylib, so this was never noticed, but it is not 0 for most dylibs integrate

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

This revision was automatically updated to reflect the committed changes. Closed by commit rG8113a8bb7934: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache (authored by friss). Changed prior to commit: https://reviews.llvm.org/D83023?vs=278495&id=278537#toc Repository

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

friss added a comment. I'll commit after I've re-built top of tree and fully retested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83023/new/ https://reviews.llvm.org/D83023 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

friss updated this revision to Diff 278495. friss marked an inline comment as done. friss added a comment. Address review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83023/new/ https://reviews.llvm.org/D83023 Files: lldb/include/lldb/

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

friss updated this revision to Diff 278331. friss added a comment. Herald added a subscriber: mgorny. - Rebase on top of D83512 - Change the ObjectFileMachO pieces to rewrite offsets to look like a standard Mach-o image instead of adding a bunch of conditionals t

[Lldb-commits] [PATCH] D83512: [lldb/Module] Allow for the creation of memory-only modules

friss marked an inline comment as done. friss added inline comments. Comment at: lldb/unittests/TestingSupport/TestUtilities.h:39-41 + TestFile(TestFile &&RHS) : Buffer(std::move(RHS.Buffer)) { +RHS.Buffer = llvm::None; } labath wrote: > Since we don't ne

[Lldb-commits] [PATCH] D83512: [lldb/Module] Allow for the creation of memory-only modules

This revision was automatically updated to reflect the committed changes. Closed by commit rGa4a00ced0cf8: [lldb/Module] Allow for the creation of memory-only modules (authored by friss). Changed prior to commit: https://reviews.llvm.org/D83512?vs=277657&id=277850#toc Repository: rG LLVM Git

[Lldb-commits] [PATCH] D83512: [lldb/Module] Allow for the creation of memory-only modules

friss marked 2 inline comments as done. friss added inline comments. Comment at: lldb/source/Plugins/ObjectFile/PECOFF/ObjectFilePECOFF.cpp:543-544 + if (m_data.ValidOffsetForDataOfSize(offset, size)) +return DataExtractor(m_data, offset, size); + This see

[Lldb-commits] [PATCH] D83512: [lldb/Module] Allow for the creation of memory-only modules

friss updated this revision to Diff 277657. friss added a comment. Herald added a subscriber: mgorny. I went ahead and updated all unittests to use only in-memory modules. This required tweaking both ObjectFileELF and ObjectFilePECOFF a little. Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

friss added a comment. In D83023#2129985 , @labath wrote: > In D83023#2128475 , @friss wrote: > > > In D83023#2128298 , @labath wrote: > > > > > I think this is a very intere

[Lldb-commits] [PATCH] D83512: [lldb/Module] Allow for the creation of memory-only modules

friss added a comment. This is the generic part of https://reviews.llvm.org/D83023 I modified to existing unittests to load their binary directly from memory, one ELF, one Mach-O. I tried to modify a PECOFF test to, but ObjectFilePECoff requires the file to be on the filesystem as it reopens it

[Lldb-commits] [PATCH] D83512: [lldb/Module] Allow for the creation of memory-only modules

friss created this revision. friss added a reviewer: labath. Herald added subscribers: MaskRay, emaste. Herald added a reviewer: espindola. Herald added a project: LLDB. This patch extends the ModuleSpec class to include a DataBufferSP which contains the module data. If this data is provided, LLDB

[Lldb-commits] [PATCH] D83443: Fix debugserver reporting of deployment target

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/test/API/macosx/simulator/TestSimulatorPlatform.py:30 +dylib_info = None +reponse = False +response = False typo?

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

friss marked 4 inline comments as done. friss added a comment. In D83023#2128298 , @labath wrote: > I think this is a very interesting feature (lldb being able to load modules > from memory; the mac shared cache thingy is interesting too, but in a > diff

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

friss added a comment. @labath I tagged you mostly for the generic parts of the patch. I don't suppose you care a lot about `ObjectFileMachO.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83023/new/ https://reviews.llvm.org/D83023 _

[Lldb-commits] [PATCH] D83023: [lldb/ObjectFileMachO] Fetch shared cache images from our own shared cache

friss created this revision. friss added reviewers: jasonmolenda, labath. Herald added projects: LLDB, LLVM. Herald added a subscriber: llvm-commits. On macOS 11, the libraries that have been integrated in the system shared cache are not present on the filesystem anymore. LLDB was using those file

[Lldb-commits] [PATCH] D82507: [lldb/Docs] Add more details to the issues with custom Python installs on macOS

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. LGTM Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82507/new/ https://reviews.llvm.org/D82507 ___ lldb-commits m

[Lldb-commits] [PATCH] D81210: Teach GetXcodeSDK to look in the Xcode that contains LLDB

friss added a comment. This LGTM, with the caveat that it doesn't handle command line tools. But we didn't handle it correctly before, so not something we need to fix here. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81210/new/ https://reviews.llvm.org/D81210 _

[Lldb-commits] [PATCH] D80807: [lldb/Utility] Fix DecodeUUIDBytesFromString not to access past the input buffer

friss abandoned this revision. friss added a comment. Abandon in favor of D80755 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80807/new/ https://reviews.llvm.org/D80807 _

[Lldb-commits] [PATCH] D80755: Support build-ids of other sizes than 16 in UUID::SetFromStringRef

friss added inline comments. Comment at: lldb/source/Utility/UUID.cpp:66-67 uuid_bytes.clear(); while (!p.empty()) { -if (isxdigit(p[0]) && isxdigit(p[1])) { +if (p.size() >= 2 && isxdigit(p[0]) && isxdigit(p[1])) { int hi_nibble = xdigit_to_int(p[0]); --

[Lldb-commits] [PATCH] D80807: [lldb/Utility] Fix DecodeUUIDBytesFromString not to access past the input buffer

friss created this revision. friss added a reviewer: labath. Herald added a project: LLDB. friss added a comment. I would have committed this right away if it weren't for the slight change in behavior I wanted to point out. With this patch, if an input string ends with a `-`, it won't be consume

[Lldb-commits] [PATCH] D80807: [lldb/Utility] Fix DecodeUUIDBytesFromString not to access past the input buffer

friss added a comment. I would have committed this right away if it weren't for the slight change in behavior I wanted to point out. With this patch, if an input string ends with a `-`, it won't be consumed anymore. I suppose it doesn't matter. Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D80680: save_crashlog should not be using the load_addr property of an SBAddress

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. Thanks for adding a test! this LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80680/new/ https://reviews.llvm.org/D80680 __

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

This revision was automatically updated to reflect the committed changes. Closed by commit rGd9166ad27284: [lldb/Driver] Support terminal resizing (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79654/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

friss added a comment. In D79654#2030635 , @friss wrote: > > If we wanted to avoid delaying the change to the next keystroke, we could > > reuse the same mechanism that ^C/SIGINT uses > > (`m_input_connection.InterruptRead()`). That would probably requir

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

friss added a comment. In D79654#2029131 , @labath wrote: > Yes, resizing the window (or doing any other nontrivial task) from within a > signal handler is a bad idea. Making a note of the signal and then bailing > out is the right approach. Though, to b

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

friss updated this revision to Diff 263331. friss added a comment. Herald added a subscriber: jfb. Use sig_atomic_t as Pavel suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79654/new/ https://reviews.llvm.org/D79654 Files: lldb/include/l

[Lldb-commits] [PATCH] D79654: [lldb/Driver] Support terminal resizing

friss created this revision. friss added reviewers: labath, teemperor. Herald added a project: LLDB. The comment in the Editine.h header made it sound like editline was just unable to handle terminal resizing. We were not ever telling editline that the terminal had changed size, which might explai

[Lldb-commits] [PATCH] D79554: [lldb/Dataformatter] Add support to CF{Dictionary, Set}Ref types

friss added inline comments. Comment at: lldb/source/Core/ValueObject.cpp:52 +#include "Plugins/TypeSystem/Clang/TypeSystemClang.h" + You don't want to introduce a dependency between Core and a plugin. What you need here might need to be introduced as a new ab

[Lldb-commits] [PATCH] D79273: Add an explicit API to read the Xcode SDK DWARF attribute from compile units

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. This looks good to me. If a similar API made sense on Module, I guess it can live on SymboleFile. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79273/new/ https://reviews.llvm.org/D792

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

friss added a comment. This looks like what I'd like to implement, but unfortunately it breaks other tests. Some C tests start printing null pointers as `nullptr` too. I suppose this is because the expression evaluator is always in C++ mode. Is there a way to get the origin type/language of a v

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

friss updated this revision to Diff 255579. friss added a comment. Remove the now useless code in TypeSummary.cpp, and change the C++ implementation of IsNilReference() to return true soemtimes. This breaks other tests though... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

friss updated this revision to Diff 255571. friss added a comment. Implement null C++ printing at the ValueObjectPrinter level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77153/new/ https://reviews.llvm.org/D77153 Files: lldb/include/lldb/Targ

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

friss added a comment. I was checking whether there is a way to catch null pointer before a type summary is even chosen. And found out that such logic exists, but only for Objective-C. Languages have a `IsNilReference()` virtual method that can tell whether a `ValueObject` is a nil reference. I

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

friss added a comment. In D77153#1954154 , @labath wrote: > It might be worth mentioning though that the title of the patch is somewhat > misleading -- I believe the `CXX` in `CXXFunctionSummaryFormat` refers to the > language the formatter is implemente

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

friss added a comment. I haven't tested the libstdc++ part, would be great if someone could confirm this works. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77153/new/ https://reviews.llvm.org/D77153 ___

[Lldb-commits] [PATCH] D77153: [lldb/DataFormatters] Display null C++ pointers as nullptr

friss created this revision. friss added reviewers: jingham, labath. Herald added a project: LLDB. friss added a comment. I haven't tested the libstdc++ part, would be great if someone could confirm this works. The original motivation for this patch was to display a null std::string pointer as

[Lldb-commits] [PATCH] D77123: [lldb] Inherit host environment when running shell commands

friss accepted this revision. friss added a comment. This revision is now accepted and ready to land. I agree host shell command should run with the host environment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77123/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D76955: [lldb/Test] Decode stdout and stderr in case it contains UTF-8

friss added a comment. I think this won't work with Python3, were `out` and `err` will be already "decoded" str objects CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76955/new/ https://reviews.llvm.org/D76955 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D76835: [lldb] Fix TestSettings.test_pass_host_env_vars on windows

friss added a comment. Thanks for fixing this Pavel! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76835/new/ https://reviews.llvm.org/D76835 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [PATCH] D76450: [lldb/PlatformDarwin] Always delete destination file first in PutFile

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6ae8937e031: [lldb/PlatformDarwin] Always delete destination file first in PutFile (authored by friss). Changed prior to commit: https://reviews.llvm.org/D76450?vs=251461&id=252146#toc Repository: r

[Lldb-commits] [PATCH] D76009: [lldb/Target] Initialize new targets environment variables from target.env-vars

This revision was automatically updated to reflect the committed changes. Closed by commit rG9228a9efc6c5: [lldb/Target] Initialize new targets environment variables from target.env-vars (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D76045: [lldb/API] Make Launch(Simple) use args and env from target properties

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd7b45057ca9: [lldb/API] Make Launch(Simple) use args and env from target properties (authored by friss). Changed prior to commit: https://reviews.llvm.org/D76045?vs=249834&id=252051#toc Repository:

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4a6e63ea123: [lldb/Target] Rework the way the inferior environment is created (authored by friss). Changed prior to commit: https://reviews.llvm.org/D76470?vs=251813&id=252052#toc Repository: rG LLV

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

friss updated this revision to Diff 251813. friss added a comment. Simplify command definition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76470/new/ https://reviews.llvm.org/D76470 Files: lldb/include/lldb/Target/Target.h lldb/source/Comman

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

friss added a comment. In D76470#1934201 , @jingham wrote: > In D76470#1934146 , @friss wrote: > > > In D76470#1933910 , @jingham wrote: > > > > > Is there any command-based

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

friss updated this revision to Diff 251794. friss added a comment. Herald added a subscriber: mgrang. Add a new target command to dump the launch environment Make env-vars override unset-env-vars Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76470/n

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

friss added a comment. In D76470#1933910 , @jingham wrote: > Is there any command-based way to see the entire environment that a process > will get when it launches? By populating target.env-vars with the inherited > environment there was a way to mostl

[Lldb-commits] [PATCH] D76009: [lldb/Target] Initialize new targets environment variables from target.env-vars

friss updated this revision to Diff 251675. friss added a comment. Make helper function name more descriptive. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76009/new/ https://reviews.llvm.org/D76009 Files: lldb/include/lldb/Target/Target.h ll

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

friss added a comment. In D76470#1933062 , @labath wrote: > I think this is a good change, and is in line with what we have discussed > previously. I have just one question about the exact variable interactions > here. > > Since the raison d'être of the

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

friss updated this revision to Diff 251670. friss added a comment. Add tests and update m_launch_info when undet-vars change. Improve docs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76470/new/ https://reviews.llvm.org/D76470 Files: lldb/incl

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

friss created this revision. friss added reviewers: labath, jingham. Herald added a project: LLDB. friss added a comment. This needs some tests, but I wanted to put it out there for comments. The interactions between the environment settings (`target.env-vars`, `target.inherit-env`) and the infe

[Lldb-commits] [PATCH] D76470: [lldb/Target] Rework the way the inferior environment is created

friss added a comment. This needs some tests, but I wanted to put it out there for comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76470/new/ https://reviews.llvm.org/D76470 ___ lldb-commits ma

[Lldb-commits] [PATCH] D76450: [lldb/PlatformDarwin] Always delete destination file first in PutFile

friss created this revision. friss added a reviewer: jasonmolenda. Herald added a project: LLDB. The default behavior of Platform::PutFile is to open the file and truncate it if it already exists. This works fine and is a sensible default, but it interacts badly with code-signing on iOS, as doing

[Lldb-commits] [PATCH] D76408: [lldb/testsuite] XFail TestBuiltinTrap.py not only on linux

This revision was automatically updated to reflect the committed changes. Closed by commit rGe154cbb124a6: [lldb/testsuite] XFail TestBuiltinTrap.py not only on linux (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76408/new/ http

[Lldb-commits] [PATCH] D76406: [lldb/testsuite] Fix TestInlineStepping on arm64 with newer compilers

This revision was automatically updated to reflect the committed changes. Closed by commit rGecc6c426977f: [lldb/testsuite] Fix TestInlineStepping on arm64 with newer compilers (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76406/

[Lldb-commits] [PATCH] D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py

friss abandoned this revision. friss added a comment. I skipped the test for embedded in 8758d02074be7b80b804fad19e8b7de6ebd43c31 . I'll abandon this for now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py

friss marked an inline comment as done. friss added a comment. In D76407#1930693 , @labath wrote: > Could the inferior manually wipe the crash annotation? This is not something you're supposed to wipe. It's additional information that is going to b dump

[Lldb-commits] [PATCH] D76407: [lldb/testsuite] Remove "healthy process" test from TestProcessCrashInfo.py

friss created this revision. friss added reviewers: mib, jingham. Herald added a project: LLDB. The crash info annotations are not necessarily indicative of a crash. Some APIs will set them before doing something risk and clean them up after, while some others might just leave a breadcrumb there f

[Lldb-commits] [PATCH] D76408: [lldb/testsuite] XFail TestBuiltinTrap.py not only on linux

friss created this revision. friss added a reviewer: labath. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: LLDB. TestBuiltinTrap fail on darwin embedded because the `__builin_trap` builtin doesn't get any line info attached to it by clang when building for arm64. Th

[Lldb-commits] [PATCH] D76406: [lldb/testsuite] Fix TestInlineStepping on arm64 with newer compilers

friss created this revision. friss added reviewers: labath, jingham. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: LLDB. TestInlineStepping tests LLDB's ability to step in the presence of inline frames. The testcase source has a number of functions and some of them a

[Lldb-commits] [PATCH] D76341: [lldb/MemoryHistoryAsan] Fix address resolution for recorded backtraces

This revision was automatically updated to reflect the committed changes. Closed by commit rGb40ee7ff1b16: [lldb/MemoryHistoryAsan] Fix address resolution for recorded backtraces (authored by friss). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7634

[Lldb-commits] [PATCH] D76341: [lldb/MemoryHistoryAsan] Fix address resolution for recorded backtraces

friss created this revision. friss added reviewers: jasonmolenda, kubamracek. Herald added subscribers: danielkiss, kristof.beyls. Herald added a project: LLDB. The memory history plugin for Asan creates a HistoryThread with the recorded PC values provided by the Asan runtime. In other cases, thos

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

friss added inline comments. Comment at: lldb/test/API/commands/frame/recognizer/TestFrameRecognizer.py:162-167 +lldbutil.run_break_set_by_symbol(self, "bar") +self.runCmd("c") + +process = target.GetProcess() +thread = process.GetSelectedThread()

[Lldb-commits] [PATCH] D76188: [lldb/Target] Support more than 2 symbols in StackFrameRecognizer

friss added inline comments. Comment at: lldb/include/lldb/Target/StackFrameRecognizer.h:115 std::function const - &callback); + std::string module, std::vector &symbols, + bool regexp)> const &callback); ---

[Lldb-commits] [PATCH] D76105: [lldb/settings] Reset the inferior environment when target.inherit-env is toggled

friss added a comment. In D76105#1920633 , @jingham wrote: > If I'm following the logic correctly, if you run a target with inherit-env > off, and then do: > > env VAR_IN_ENVIRONMENT=NOT_THE_ENVIRONMENTS_VALUE > > > > then turn inherit-env on, we will

[Lldb-commits] [PATCH] D76045: [lldb/API] Make Launch(Simple) use args and env from target properties

friss added a comment. This is somewhat useless without D76009 because the default LaunchInfo doesn't get populated with the environment without it. I'll wait for a resolution there before landing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D76105: [lldb/settings] Reset the inferior environment when target.inherit-env is toggled

friss created this revision. friss added reviewers: labath, jingham. Herald added a project: LLDB. Allow the target.env-vars property to be recomputed when the target.inherit-env property changes. This allows to change the value of the property between runs and get a meaningful behavior. Reposit

[Lldb-commits] [PATCH] D76009: [lldb/Target] Initialize new targets environment variables from target.env-vars

friss added a comment. I put up a "fix" for the inherit-env issue mentioned here: https://reviews.llvm.org/D76105 It is mostly orthogonal to this patch as Jim showed the behavior today is already broken. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

  1   2   3   >