[Lldb-commits] [lldb] r287397 - Removing myself from CODE_OWNERS, and distributing those duties among other members of the community

2016-11-18 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Nov 18 17:18:11 2016 New Revision: 287397 URL: http://llvm.org/viewvc/llvm-project?rev=287397&view=rev Log: Removing myself from CODE_OWNERS, and distributing those duties among other members of the community That's All, Folks Modified: lldb/trunk/CODE_OWNERS.txt

Re: [Lldb-commits] [lldb] r287354 - Resubmit "Remove an output-parameter from Variable function".

2016-11-18 Thread Enrico Granata via lldb-commits
I tend to agree with Jim's point. I have sometimes put in things that look like "dead/vestigial code", which I am actually either planning to use later on, or actively using somewhere else. This is a quite realistic scenario due to Swift support for LLDB existing in an entirely separate univers

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

2016-11-16 Thread Enrico Granata via lldb-commits
granata.enrico added inline comments. Comment at: scripts/Python/prepare_binding_Python.py:229 stderr=subprocess.PIPE, -shell=True) +) # Wait for SWIG process to terminate This worries me a little bit.. Are we sure we are not in any way

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

2016-11-16 Thread Enrico Granata via lldb-commits
granata.enrico added a reviewer: beanz. granata.enrico added a comment. Chris, can you take a look at this? I am far from a CMake expert https://reviews.llvm.org/D26757 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/

Re: [Lldb-commits] [PATCH] D26618: Make some code not manipulate the underlying buffer of a StreamString

2016-11-14 Thread Enrico Granata via lldb-commits
I will gladly let Todd run tests on your diff, but I just thought I'd explain what is going on there In Cocoa, some NSURL objects are represented as "sub-URLs", e.g. you can start from www.apple.com and represent www.apple.com/macos as NSURL(base="www.apple.com", next="/macos") This can be r

[Lldb-commits] [lldb] r286782 - I am leaving Apple in a few weeks; switch over to my personal email address

2016-11-13 Thread Enrico Granata via lldb-commits
Author: enrico Date: Sun Nov 13 15:30:54 2016 New Revision: 286782 URL: http://llvm.org/viewvc/llvm-project?rev=286782&view=rev Log: I am leaving Apple in a few weeks; switch over to my personal email address Modified: lldb/trunk/CODE_OWNERS.txt Modified: lldb/trunk/CODE_OWNERS.txt URL: ht

[Lldb-commits] [PATCH] D26403: Display the pointer value in the libstdc++ unique_ptr summary

2016-11-09 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. Makes sense. Feel free to commit. Repository: rL LLVM https://reviews.llvm.org/D26403 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D26403: Display the pointer value in the libstdc++ unique_ptr summary

2016-11-08 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. Make what you will of my suggestion above, but in general the reasoning looks good Comment at: source/Plugins/Language/CPlusPlus/LibStdcppUniquePointer.cpp:1

[Lldb-commits] [lldb] r286176 - Simplify the PrintableRepresentationSpecialCases code; we never used the ePrintableRepresentationSpecialCasesOnly value and with enum classes the names doesn't need to

2016-11-07 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Nov 7 17:32:20 2016 New Revision: 286176 URL: http://llvm.org/viewvc/llvm-project?rev=286176&view=rev Log: Simplify the PrintableRepresentationSpecialCases code; we never used the ePrintableRepresentationSpecialCasesOnly value and with enum classes the names doesn't nee

[Lldb-commits] [lldb] r286116 - Fix an issue where LLDB would hang trying to launch tvOS simulator binaries

2016-11-07 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Nov 7 10:25:01 2016 New Revision: 286116 URL: http://llvm.org/viewvc/llvm-project?rev=286116&view=rev Log: Fix an issue where LLDB would hang trying to launch tvOS simulator binaries Modified: lldb/trunk/source/Plugins/Platform/MacOSX/PlatformAppleTVSimulator.cpp

[Lldb-commits] [lldb] r286003 - Preliminary plumbing work to make 'parray' able to take offset and stride options

2016-11-04 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Nov 4 13:15:39 2016 New Revision: 286003 URL: http://llvm.org/viewvc/llvm-project?rev=286003&view=rev Log: Preliminary plumbing work to make 'parray' able to take offset and stride options Modified: lldb/trunk/include/lldb/DataFormatters/DumpValueObjectOptions.h

[Lldb-commits] [lldb] r285943 - Add RenderScriptScriptGroup to the Xcode project

2016-11-03 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Nov 3 12:33:11 2016 New Revision: 285943 URL: http://llvm.org/viewvc/llvm-project?rev=285943&view=rev Log: Add RenderScriptScriptGroup to the Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj URL:

[Lldb-commits] [lldb] r285941 - Add support to the ObjC type scavenger for finding types via debug info

2016-11-03 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Nov 3 12:25:27 2016 New Revision: 285941 URL: http://llvm.org/viewvc/llvm-project?rev=285941&view=rev Log: Add support to the ObjC type scavenger for finding types via debug info Modified: lldb/trunk/include/lldb/Target/Language.h lldb/trunk/packages/Python/lld

[Lldb-commits] [lldb] r285736 - Add helpers for the notion of a type scavenger that is "either this or that" source, and one that is "both this and that" source

2016-11-01 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Nov 1 15:17:14 2016 New Revision: 285736 URL: http://llvm.org/viewvc/llvm-project?rev=285736&view=rev Log: Add helpers for the notion of a type scavenger that is "either this or that" source, and one that is "both this and that" source Use the helper to rewrite the ObjC

[Lldb-commits] [lldb] r285727 - Implement a general type scavenger that can dig types from debug info + a filtering mechanism to accept/reject results thusly obtained

2016-11-01 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Nov 1 13:50:49 2016 New Revision: 285727 URL: http://llvm.org/viewvc/llvm-project?rev=285727&view=rev Log: Implement a general type scavenger that can dig types from debug info + a filtering mechanism to accept/reject results thusly obtained Implement the C++ type looku

[Lldb-commits] [lldb] r285599 - Remove a couple of old TODOs and don't make a new ConstString each time; none of this is super-critical since it applies to older versions of macOS (or OSX, I guess?) b

2016-10-31 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Oct 31 12:12:16 2016 New Revision: 285599 URL: http://llvm.org/viewvc/llvm-project?rev=285599&view=rev Log: Remove a couple of old TODOs and don't make a new ConstString each time; none of this is super-critical since it applies to older versions of macOS (or OSX, I gues

[Lldb-commits] [lldb] r285596 - Add the new minidump plugin files to the Xcode project

2016-10-31 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Oct 31 12:00:54 2016 New Revision: 285596 URL: http://llvm.org/viewvc/llvm-project?rev=285596&view=rev Log: Add the new minidump plugin files to the Xcode project Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj

[Lldb-commits] [lldb] r285332 - Add support for "type lookup" to find C and C++ types

2016-10-27 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Oct 27 13:44:45 2016 New Revision: 285332 URL: http://llvm.org/viewvc/llvm-project?rev=285332&view=rev Log: Add support for "type lookup" to find C and C++ types This is an important first step in closing the functionality gap between "type lookup" and "images lookup -t"

[Lldb-commits] [lldb] r285226 - Fix an issue where frame variable -s would not show the scope even though the user asked for it

2016-10-26 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Oct 26 14:17:49 2016 New Revision: 285226 URL: http://llvm.org/viewvc/llvm-project?rev=285226&view=rev Log: Fix an issue where frame variable -s would not show the scope even though the user asked for it Part of rdar://28434047 Added: lldb/trunk/packages/Python/ll

[Lldb-commits] [lldb] r285216 - Actually use = delete to mark constructors and operators we want to not exist. Just declaring them as private works, but it can confuse certain tools as it doesn't actu

2016-10-26 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Oct 26 13:12:52 2016 New Revision: 285216 URL: http://llvm.org/viewvc/llvm-project?rev=285216&view=rev Log: Actually use = delete to mark constructors and operators we want to not exist. Just declaring them as private works, but it can confuse certain tools as it doesn't

[Lldb-commits] [lldb] r284847 - I hadn't fixed all the instances of the old marker for scripted format strings; do so now

2016-10-21 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Oct 21 13:03:55 2016 New Revision: 284847 URL: http://llvm.org/viewvc/llvm-project?rev=284847&view=rev Log: I hadn't fixed all the instances of the old marker for scripted format strings; do so now Modified: lldb/trunk/www/formats.html Modified: lldb/trunk/www/form

[Lldb-commits] [lldb] r284788 - frame.script became script.frame a while ago; fix up the docs

2016-10-20 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Oct 20 17:10:07 2016 New Revision: 284788 URL: http://llvm.org/viewvc/llvm-project?rev=284788&view=rev Log: frame.script became script.frame a while ago; fix up the docs Modified: lldb/trunk/www/formats.html Modified: lldb/trunk/www/formats.html URL: http://llvm.org

[Lldb-commits] [lldb] r284787 - This debugging message has been left in the code for years, until one day it randomly hit on some corrupted memory

2016-10-20 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Oct 20 17:05:21 2016 New Revision: 284787 URL: http://llvm.org/viewvc/llvm-project?rev=284787&view=rev Log: This debugging message has been left in the code for years, until one day it randomly hit on some corrupted memory It is misleading to users in its current form, a

[Lldb-commits] [PATCH] D25726: Improve the libstdc++ smart pointer formatters

2016-10-19 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. I see you already got a bunch of feedback on specific items. The overall idea looks good to me. I'll try to delve a little deeper in the code ASAP (I was out for a couple days and have some backlog...), but should be good to go assuming you address the feedback y

[Lldb-commits] [PATCH] D25734: Add data formatter for libstdc++ unique_ptr

2016-10-19 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. I see you already got a bunch of feedback on specific items. The overall idea looks good to me. I'll try to delve a little deeper in the code ASAP (I was out for a couple days and have some backlog...), but should be good to go assuming you address the feedback y

[Lldb-commits] [lldb] r283396 - Fixes for libc++ std::unordered_map data formatter against trunk

2016-10-05 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Oct 5 17:04:43 2016 New Revision: 283396 URL: http://llvm.org/viewvc/llvm-project?rev=283396&view=rev Log: Fixes for libc++ std::unordered_map data formatter against trunk Fixes rdar://28237467 Modified: lldb/trunk/source/Plugins/Language/CPlusPlus/LibCxxUnorderedM

Re: [Lldb-commits] [lldb] r283351 - Try to fix Android build.

2016-10-05 Thread Enrico Granata via lldb-commits
Alright, I'll bite and ask... What is so special about the Android bot? Every so often, I'll see it reject a piece of syntax that other compilers gleefully handle > On Oct 5, 2016, at 10:58 AM, Zachary Turner via lldb-commits > wrote: > > Author: zturner > Date: Wed Oct 5 12:58:46 2016 > New

[Lldb-commits] [lldb] r283167 - Fix the data formatter for std::multiset in libc++ - this is a trivial amount of extra change on top of multimap

2016-10-03 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Oct 3 19:07:42 2016 New Revision: 283167 URL: http://llvm.org/viewvc/llvm-project?rev=283167&view=rev Log: Fix the data formatter for std::multiset in libc++ - this is a trivial amount of extra change on top of multimap Also, proper formatting.. Modified: lldb/tru

Re: [Lldb-commits] [lldb] r283160 - Changes to the std::multimap formatter to make it work against trunk libc++

2016-10-03 Thread Enrico Granata via lldb-commits
Woops... Guess I am just gonna reformat the entire file... Sorry about that! On 10/03/16 04:43 PM, Zachary Turner wrote: > > > Was this clang-formatted? some of these lines look way longer than 80 columns. > > > > On Mon, Oct 3, 2016 at 4:41 PM Enrico Granata via l

[Lldb-commits] [lldb] r283160 - Changes to the std::multimap formatter to make it work against trunk libc++

2016-10-03 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Oct 3 18:33:00 2016 New Revision: 283160 URL: http://llvm.org/viewvc/llvm-project?rev=283160&view=rev Log: Changes to the std::multimap formatter to make it work against trunk libc++ Fixes rdar://28237486 Modified: lldb/trunk/source/Plugins/Language/CPlusPlus/LibC

[Lldb-commits] [lldb] r282824 - Prefer skipping over x-failing

2016-09-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 29 19:41:07 2016 New Revision: 282824 URL: http://llvm.org/viewvc/llvm-project?rev=282824&view=rev Log: Prefer skipping over x-failing Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/type_lookup/TestTypeLookup.py Modified: lldb/trunk/packag

[Lldb-commits] [lldb] r282823 - Do not assume we will be able to discover the return type of this selector call, for that is not true in i386 mode

2016-09-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 29 19:40:04 2016 New Revision: 282823 URL: http://llvm.org/viewvc/llvm-project?rev=282823&view=rev Log: Do not assume we will be able to discover the return type of this selector call, for that is not true in i386 mode Modified: lldb/trunk/packages/Python/lldbs

[Lldb-commits] [lldb] r282774 - This test will not work in i386 mode because we don't create interesting types from the ObjC runtime

2016-09-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 29 16:20:56 2016 New Revision: 282774 URL: http://llvm.org/viewvc/llvm-project?rev=282774&view=rev Log: This test will not work in i386 mode because we don't create interesting types from the ObjC runtime "Fixes" rdar://28501616 Modified: lldb/trunk/packages/P

[Lldb-commits] [lldb] r282754 - Fix an issue where, in i386 mode, the wrong values were being copied into the pair object for a single-entry NSDictionary

2016-09-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 29 14:46:48 2016 New Revision: 282754 URL: http://llvm.org/viewvc/llvm-project?rev=282754&view=rev Log: Fix an issue where, in i386 mode, the wrong values were being copied into the pair object for a single-entry NSDictionary Fixes rdar://28502335 Modified: lld

Re: [Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

2016-09-29 Thread Enrico Granata via lldb-commits
> On Sep 29, 2016, at 10:58 AM, Enrico Granata via lldb-commits > wrote: > > >> On Sep 29, 2016, at 10:50 AM, Zachary Turner > <mailto:ztur...@google.com>> wrote: >> >> >> >> On Thu, Sep 29, 2016 at 10:43 AM Enrico Granata > <mai

Re: [Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

2016-09-29 Thread Enrico Granata via lldb-commits
>> >> On Wed, Sep 28, 2016 at 4:02 PM Enrico Granata via lldb-commits >> mailto:lldb-commits@lists.llvm.org>> wrote: >> >> - >> + >> + static ConstString g___i_("__i_"); >> + >>// this must be a ValueObject* because it i

Re: [Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

2016-09-29 Thread Enrico Granata via lldb-commits
> On Sep 28, 2016, at 5:58 PM, Zachary Turner wrote: > > > > On Wed, Sep 28, 2016 at 4:02 PM Enrico Granata via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > > - > + > + static ConstString g___i_("__i_"); > + >// this

[Lldb-commits] [lldb] r282648 - Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator

2016-09-28 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Sep 28 17:53:16 2016 New Revision: 282648 URL: http://llvm.org/viewvc/llvm-project?rev=282648&view=rev Log: Fix an issue where libc++ changed the type information we get for std::map::iterator, rendering LLDB unable to display elements vended by an iterator Fixes Mod

Re: [Lldb-commits] [lldb] r282445 - Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring

2016-09-26 Thread Enrico Granata via lldb-commits
;> testing command line options similar to what I proposed with unwinding etc. >> oh well > > There already is a test for this - that's how the breakage was caught to > begin with :-) > >> On Mon, Sep 26, 2016 at 2:45 PM Enrico Granata via lldb-commits >&

Re: [Lldb-commits] [lldb] r282445 - Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring

2016-09-26 Thread Enrico Granata via lldb-commits
ding etc. > oh well There already is a test for this - that's how the breakage was caught to begin with :-) > On Mon, Sep 26, 2016 at 2:45 PM Enrico Granata via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > Author: enrico > Date: Mon Sep 26 16:36:17 2

[Lldb-commits] [lldb] r282445 - Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring

2016-09-26 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Sep 26 16:36:17 2016 New Revision: 282445 URL: http://llvm.org/viewvc/llvm-project?rev=282445&view=rev Log: Fix an issue where LLDB would not accept the --description-verbosity option to 'po' without an argument after the StringRef refactoring Fixes rdar://28480275 Mod

[Lldb-commits] [lldb] r282310 - Add an accessor to get the value of RC_PLATFORM_NAME at build time

2016-09-23 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Sep 23 17:30:08 2016 New Revision: 282310 URL: http://llvm.org/viewvc/llvm-project?rev=282310&view=rev Log: Add an accessor to get the value of RC_PLATFORM_NAME at build time Modified: lldb/trunk/scripts/Xcode/lldbbuild.py Modified: lldb/trunk/scripts/Xcode/lldbbuild

[Lldb-commits] [lldb] r282297 - Install only the manpage and only in the proper location

2016-09-23 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Sep 23 16:24:08 2016 New Revision: 282297 URL: http://llvm.org/viewvc/llvm-project?rev=282297&view=rev Log: Install only the manpage and only in the proper location Modified: lldb/trunk/lldb.xcodeproj/project.pbxproj Modified: lldb/trunk/lldb.xcodeproj/project.pbxpr

[Lldb-commits] [lldb] r282179 - Actually, do it this way because I will want to know if I am in a host build elsewhere too

2016-09-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 22 12:59:58 2016 New Revision: 282179 URL: http://llvm.org/viewvc/llvm-project?rev=282179&view=rev Log: Actually, do it this way because I will want to know if I am in a host build elsewhere too Modified: lldb/trunk/scripts/Xcode/lldbbuild.py Modified: lldb/tru

[Lldb-commits] [lldb] r282178 - The host version of lldb always builds for macosx

2016-09-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 22 12:47:33 2016 New Revision: 282178 URL: http://llvm.org/viewvc/llvm-project?rev=282178&view=rev Log: The host version of lldb always builds for macosx Modified: lldb/trunk/scripts/Xcode/lldbbuild.py Modified: lldb/trunk/scripts/Xcode/lldbbuild.py URL: http:/

[Lldb-commits] [lldb] r281993 - Make it so that one can register prefix matches as well as identical matches as extra cases for NSDictionary data formatting

2016-09-20 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Sep 20 13:26:30 2016 New Revision: 281993 URL: http://llvm.org/viewvc/llvm-project?rev=281993&view=rev Log: Make it so that one can register prefix matches as well as identical matches as extra cases for NSDictionary data formatting Modified: lldb/trunk/source/Plugi

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

2016-09-14 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. In https://reviews.llvm.org/D24591#543277, @beanz wrote: > @granata.enrico, we could migrate the existing tests into being executed by > lit even if they aren't using lit's features, so if that direction is desired > we could get everything in lit. That said, you

Re: [Lldb-commits] [PATCH] D24591: [LIT] First pass of LLDB LIT support

2016-09-14 Thread Enrico Granata via lldb-commits
granata.enrico added a subscriber: granata.enrico. granata.enrico added a comment. One piece of concern that I have is the multiplication of things that "testing LLDB" means. We have unit tests, Python tests, and now LIT tests. That means, for each change I want to commit, if I want confidence

[Lldb-commits] [lldb] r281282 - Fix an issue where LLDB was not masking enough bits off of objc classes data() pointers, effectively rendering us unable to generate descriptors for some classes

2016-09-12 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Sep 12 19:22:49 2016 New Revision: 281282 URL: http://llvm.org/viewvc/llvm-project?rev=281282&view=rev Log: Fix an issue where LLDB was not masking enough bits off of objc classes data() pointers, effectively rendering us unable to generate descriptors for some classes

[Lldb-commits] [lldb] r280513 - Check for null

2016-09-02 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Sep 2 13:15:48 2016 New Revision: 280513 URL: http://llvm.org/viewvc/llvm-project?rev=280513&view=rev Log: Check for null Modified: lldb/trunk/source/Core/ValueObject.cpp Modified: lldb/trunk/source/Core/ValueObject.cpp URL: http://llvm.org/viewvc/llvm-project/lld

[Lldb-commits] [lldb] r280395 - When updating a ValueObjectRegister, set the flag to remind yourself of whether it changed

2016-09-01 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 1 13:31:40 2016 New Revision: 280395 URL: http://llvm.org/viewvc/llvm-project?rev=280395&view=rev Log: When updating a ValueObjectRegister, set the flag to remind yourself of whether it changed Modified: lldb/trunk/source/Core/ValueObjectRegister.cpp Modified:

Re: [Lldb-commits] [lldb] r280344 - XFail TestMemoryFind on 32-bit architectures

2016-09-01 Thread Enrico Granata via lldb-commits
I am probably being a little dense right now, but I can't seem to find (const char*)0x1000 anywhere in the test case code... > On Sep 1, 2016, at 2:17 AM, Pavel Labath via lldb-commits > wrote: > > Author: labath > Date: Thu Sep 1 04:17:37 2016 > New Revision: 280344 > > URL: http://llvm.org

[Lldb-commits] [lldb] r280389 - Change the formula for tagged NSIndexPath data formatting

2016-09-01 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Sep 1 13:09:01 2016 New Revision: 280389 URL: http://llvm.org/viewvc/llvm-project?rev=280389&view=rev Log: Change the formula for tagged NSIndexPath data formatting Fixes rdar://25192935 Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatt

[Lldb-commits] [lldb] r280328 - There exists at least one compiler on one platform that doesn't know how to assert on a std::shared_ptr<>

2016-08-31 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Aug 31 19:32:53 2016 New Revision: 280328 URL: http://llvm.org/viewvc/llvm-project?rev=280328&view=rev Log: There exists at least one compiler on one platform that doesn't know how to assert on a std::shared_ptr<> Appease it by being very very very explicit about what I

[Lldb-commits] [lldb] r280295 - Add a data formatter for std::function in libcxx

2016-08-31 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Aug 31 16:46:37 2016 New Revision: 280295 URL: http://llvm.org/viewvc/llvm-project?rev=280295&view=rev Log: Add a data formatter for std::function in libcxx Added: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-stl/libcxx/fun

[Lldb-commits] [lldb] r280294 - Fix an issue where a synthetic child provider could only provide a value of the same size as the containing type

2016-08-31 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Aug 31 16:46:21 2016 New Revision: 280294 URL: http://llvm.org/viewvc/llvm-project?rev=280294&view=rev Log: Fix an issue where a synthetic child provider could only provide a value of the same size as the containing type Modified: lldb/trunk/packages/Python/lldbsui

Re: [Lldb-commits] [PATCH] D24074: Fixup TestPyObjSynthProvider.py and enable it again

2016-08-31 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. This revision is now accepted and ready to land. Comment at: packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py:19 @@ -18,2 +18,3 @@ mydir = TestBase.compute_mydir(__file__) +N

Re: [Lldb-commits] [lldb] r280151 - Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type

2016-08-30 Thread Enrico Granata via lldb-commits
;> Is there going to be a test for this? >> >> On Tue, Aug 30, 2016 at 1:48 PM Enrico Granata via lldb-commits >> mailto:lldb-commits@lists.llvm.org>> wrote: >> Author: enrico >> Date: Tue Aug 30 15:39:58 2016 >> New Revision: 280151 >> >&

[Lldb-commits] [lldb] r280173 - Rename the test class

2016-08-30 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Aug 30 18:00:52 2016 New Revision: 280173 URL: http://llvm.org/viewvc/llvm-project?rev=280173&view=rev Log: Rename the test class Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/pyobjsynthprovider/TestPyObjSynthProvider.py Modified

[Lldb-commits] [lldb] r280172 - Add an helper class lldb.formatters.synth.PythonObjectSyntheticChildProvider

2016-08-30 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Aug 30 18:00:02 2016 New Revision: 280172 URL: http://llvm.org/viewvc/llvm-project?rev=280172&view=rev Log: Add an helper class lldb.formatters.synth.PythonObjectSyntheticChildProvider This class enables one to easily write a synthetic child provider by writing a class t

[Lldb-commits] [lldb] r280166 - Teach ValueObject::ReadPointedString how to read char[] in host memory

2016-08-30 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Aug 30 16:33:47 2016 New Revision: 280166 URL: http://llvm.org/viewvc/llvm-project?rev=280166&view=rev Log: Teach ValueObject::ReadPointedString how to read char[] in host memory Modified: lldb/trunk/source/Core/ValueObject.cpp Modified: lldb/trunk/source/Core/Value

[Lldb-commits] [lldb] r280164 - Fix a typo/thinko - this was generating the wrong kind of array

2016-08-30 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Aug 30 16:33:29 2016 New Revision: 280164 URL: http://llvm.org/viewvc/llvm-project?rev=280164&view=rev Log: Fix a typo/thinko - this was generating the wrong kind of array Modified: lldb/trunk/source/Symbol/ClangASTContext.cpp Modified: lldb/trunk/source/Symbol/Clan

Re: [Lldb-commits] [lldb] r280151 - Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type

2016-08-30 Thread Enrico Granata via lldb-commits
g 30, 2016 at 1:48 PM Enrico Granata via lldb-commits > mailto:lldb-commits@lists.llvm.org>> wrote: > Author: enrico > Date: Tue Aug 30 15:39:58 2016 > New Revision: 280151 > > URL: http://llvm.org/viewvc/llvm-project?rev=280151&view=rev > <http://llvm.org/view

[Lldb-commits] [lldb] r280151 - Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type

2016-08-30 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Aug 30 15:39:58 2016 New Revision: 280151 URL: http://llvm.org/viewvc/llvm-project?rev=280151&view=rev Log: Add SBType::GetArrayType() such that - given a type - one can make an array (of a given size) of that type This is currently only implemented for the clang-based T

Re: [Lldb-commits] [PATCH] D23951: Remove unused any_found local variable

2016-08-29 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D23951 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mail

Re: [Lldb-commits] [PATCH] D23950: Remove unused local variable

2016-08-29 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. Looks good to me https://reviews.llvm.org/D23950 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/

[Lldb-commits] [lldb] r279784 - Add a notification message in 'type lookup' when the current language doesn't yield results and one has to go across multiple languages to scan for types

2016-08-25 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Aug 25 17:11:01 2016 New Revision: 279784 URL: http://llvm.org/viewvc/llvm-project?rev=279784&view=rev Log: Add a notification message in 'type lookup' when the current language doesn't yield results and one has to go across multiple languages to scan for types Fixes rda

[Lldb-commits] [lldb] r279446 - Add a non-code-running data formatter for __NSCFBoolean

2016-08-22 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Aug 22 13:07:52 2016 New Revision: 279446 URL: http://llvm.org/viewvc/llvm-project?rev=279446&view=rev Log: Add a non-code-running data formatter for __NSCFBoolean Modified: lldb/trunk/source/Plugins/Language/ObjC/Cocoa.cpp lldb/trunk/source/Plugins/Language/ObjC

[Lldb-commits] [lldb] r279353 - Add logic to the ObjC runtime in LLDB to extract the pointer values of the two singleton (pairtons?) instances of __NSCFBoolean that represent true and false

2016-08-19 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Aug 19 19:48:11 2016 New Revision: 279353 URL: http://llvm.org/viewvc/llvm-project?rev=279353&view=rev Log: Add logic to the ObjC runtime in LLDB to extract the pointer values of the two singleton (pairtons?) instances of __NSCFBoolean that represent true and false This

Re: [Lldb-commits] [PATCH] D23406: Fix a race in Broadcaster/Listener interaction

2016-08-11 Thread Enrico Granata via lldb-commits
> On Aug 11, 2016, at 3:55 PM, Jim Ingham via lldb-commits > wrote: > > jingham added a comment. > > The patch seems correct to me. > > I don't have a strong opinion about std::vector vrs. SmallVector. These are > temporary objects, so the size of the container doesn't matter, and I doubt

[Lldb-commits] [lldb] r278166 - Adjust LLDB's iOS simulator interface for changes in CoreSimulator

2016-08-09 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Aug 9 16:16:58 2016 New Revision: 278166 URL: http://llvm.org/viewvc/llvm-project?rev=278166&view=rev Log: Adjust LLDB's iOS simulator interface for changes in CoreSimulator rdar://27732333 and rdar://27732377 Modified: lldb/trunk/source/Plugins/Platform/MacOSX/Pla

[Lldb-commits] [lldb] r278158 - Remove CFData from the xcodeproj as well

2016-08-09 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Aug 9 15:32:42 2016 New Revision: 278158 URL: http://llvm.org/viewvc/llvm-project?rev=278158&view=rev Log: Remove CFData from the xcodeproj as well Modified: lldb/trunk/tools/debugserver/debugserver.xcodeproj/project.pbxproj Modified: lldb/trunk/tools/debugserver/de

[Lldb-commits] [lldb] r277897 - The lack of classes in the hash table is not an error - it's very legitimately possible for a process to define no ObjC classes of its own. Discovered by debugging /bin

2016-08-05 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Aug 5 19:57:07 2016 New Revision: 277897 URL: http://llvm.org/viewvc/llvm-project?rev=277897&view=rev Log: The lack of classes in the hash table is not an error - it's very legitimately possible for a process to define no ObjC classes of its own. Discovered by debugging

[Lldb-commits] [lldb] r277844 - Tweaks to the reporting of "missing dyld shared cached" that make it easier to grab logs when such issues occur, make the logs more helpful, and also tweaks to the user

2016-08-05 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Aug 5 13:09:50 2016 New Revision: 277844 URL: http://llvm.org/viewvc/llvm-project?rev=277844&view=rev Log: Tweaks to the reporting of "missing dyld shared cached" that make it easier to grab logs when such issues occur, make the logs more helpful, and also tweaks to the

Re: [Lldb-commits] [PATCH] D22863: Improve code of loading plugins that provide cmnds

2016-07-27 Thread Enrico Granata via lldb-commits
granata.enrico added a comment. Everything Greg said makes total sense In general dynamically loadable C++ plugins as a feature is a little rough around the edges. I am glad to see interest in improving it! https://reviews.llvm.org/D22863 ___ lldb

[Lldb-commits] [lldb] r276709 - Print a warning if the directory passed to --test-subdir doesn't end up existing

2016-07-25 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Jul 25 18:26:24 2016 New Revision: 276709 URL: http://llvm.org/viewvc/llvm-project?rev=276709&view=rev Log: Print a warning if the directory passed to --test-subdir doesn't end up existing Modified: lldb/trunk/packages/Python/lldbsuite/test/dosep.py Modified: lldb/t

[Lldb-commits] [lldb] r276220 - Fix an issue where LLDB would detect an empty shared cache - which is legitimate albeit suboptimal - and warn about being unable to fetch ObjC class information, even t

2016-07-20 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Jul 20 19:13:40 2016 New Revision: 276220 URL: http://llvm.org/viewvc/llvm-project?rev=276220&view=rev Log: Fix an issue where LLDB would detect an empty shared cache - which is legitimate albeit suboptimal - and warn about being unable to fetch ObjC class information, e

[Lldb-commits] [lldb] r276065 - s/Cocoa/Foundation/

2016-07-19 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Jul 19 18:58:23 2016 New Revision: 276065 URL: http://llvm.org/viewvc/llvm-project?rev=276065&view=rev Log: s/Cocoa/Foundation/ Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/data-formatter-objc/TestDataFormatterObjC.py lldb/t

[Lldb-commits] [lldb] r276061 - Fix an issue where the libc++ std::list formatter wasn't recognizing the new memory layout correctly

2016-07-19 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Jul 19 18:50:31 2016 New Revision: 276061 URL: http://llvm.org/viewvc/llvm-project?rev=276061&view=rev Log: Fix an issue where the libc++ std::list formatter wasn't recognizing the new memory layout correctly rdar://problem/26999542 Modified: lldb/trunk/source/Plug

[Lldb-commits] [lldb] r276033 - Don't check the value of the unset variables on iOS

2016-07-19 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Jul 19 16:50:39 2016 New Revision: 276033 URL: http://llvm.org/viewvc/llvm-project?rev=276033&view=rev Log: Don't check the value of the unset variables on iOS Modified: lldb/trunk/packages/Python/lldbsuite/test/functionalities/data-formatter/boolreference/TestForma

Re: [Lldb-commits] [PATCH] D22286: [LLDB] Help text overhaul

2016-07-13 Thread Enrico Granata via lldb-commits
granata.enrico added inline comments. Comment at: source/Commands/CommandObjectCommands.cpp:2272 @@ -2271,3 +2271,3 @@ "command script", -"A set of commands for managing or customizing script commands.", +

[Lldb-commits] [lldb] r275199 - Tweaks to the NSIndexPath formatter to enhance stability

2016-07-12 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue Jul 12 13:33:52 2016 New Revision: 275199 URL: http://llvm.org/viewvc/llvm-project?rev=275199&view=rev Log: Tweaks to the NSIndexPath formatter to enhance stability rdar://problem/25767901 Modified: lldb/trunk/source/Plugins/Language/ObjC/NSIndexPath.cpp Modified:

[Lldb-commits] [lldb] r275080 - Fix an issue where one could not define a Python command with the same name as an existing alias (or rather, one could but the results of invoking the command were far

2016-07-11 Thread Enrico Granata via lldb-commits
Author: enrico Date: Mon Jul 11 12:36:55 2016 New Revision: 275080 URL: http://llvm.org/viewvc/llvm-project?rev=275080&view=rev Log: Fix an issue where one could not define a Python command with the same name as an existing alias (or rather, one could but the results of invoking the command were

[Lldb-commits] [lldb] r274901 - Make IsSyntheticChildrenGenerated() virtual so that dynamic and synthetic values can refer back to their parents

2016-07-08 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Jul 8 13:39:36 2016 New Revision: 274901 URL: http://llvm.org/viewvc/llvm-project?rev=274901&view=rev Log: Make IsSyntheticChildrenGenerated() virtual so that dynamic and synthetic values can refer back to their parents Modified: lldb/trunk/include/lldb/Core/ValueO

[Lldb-commits] [lldb] r274697 - Fix the installation of the vector data formatters in order to restore functionality

2016-07-06 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Jul 6 17:35:34 2016 New Revision: 274697 URL: http://llvm.org/viewvc/llvm-project?rev=274697&view=rev Log: Fix the installation of the vector data formatters in order to restore functionality Modified: lldb/trunk/source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.

[Lldb-commits] [lldb] r274683 - Because of our lifetime rules w.r.t. ValueObjects and ClusterManagers, synthetic children caching is a tricky area:

2016-07-06 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Jul 6 16:24:28 2016 New Revision: 274683 URL: http://llvm.org/viewvc/llvm-project?rev=274683&view=rev Log: Because of our lifetime rules w.r.t. ValueObjects and ClusterManagers, synthetic children caching is a tricky area: - if a synthetic child comes from the same hiera

Re: [Lldb-commits] [PATCH] D21984: Add data formatter for libstdc++ shared_ptr and weak_ptr

2016-07-05 Thread Enrico Granata via lldb-commits
granata.enrico added inline comments. Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:665 @@ +664,3 @@ + +stl_summary_flags.SetDontShowChildren(true); +AddCXXSummary(cpp_category_sp, lldb_private::formatters::LibStdcppSmartPointerSummaryProvider, -

Re: [Lldb-commits] [PATCH] D21984: Add data formatter for libstdc++ shared_ptr and weak_ptr

2016-07-05 Thread Enrico Granata via lldb-commits
granata.enrico added inline comments. Comment at: source/Plugins/Language/CPlusPlus/CPlusPlusLanguage.cpp:665 @@ +664,3 @@ + +stl_summary_flags.SetDontShowChildren(true); +AddCXXSummary(cpp_category_sp, lldb_private::formatters::LibStdcppSmartPointerSummaryProvider, -

[Lldb-commits] [lldb] r274164 - Add NSTaggedPointerString to the table of data formatters

2016-06-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Jun 29 16:00:18 2016 New Revision: 274164 URL: http://llvm.org/viewvc/llvm-project?rev=274164&view=rev Log: Add NSTaggedPointerString to the table of data formatters Fixes rdar://27002512 Modified: lldb/trunk/source/Plugins/Language/ObjC/ObjCLanguage.cpp Modified:

[Lldb-commits] [lldb] r274159 - Validate the option index before trying to access an array element using it - OptionArgElement can potentially use negative indices to mean interesting, but non option,

2016-06-29 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed Jun 29 15:23:03 2016 New Revision: 274159 URL: http://llvm.org/viewvc/llvm-project?rev=274159&view=rev Log: Validate the option index before trying to access an array element using it - OptionArgElement can potentially use negative indices to mean interesting, but non op

[Lldb-commits] [lldb] r273721 - The Objective-C Class type should not be treated as a potential dynamic type, since it actually doesn't resolve to the type of the class it points to

2016-06-24 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Jun 24 15:45:08 2016 New Revision: 273721 URL: http://llvm.org/viewvc/llvm-project?rev=273721&view=rev Log: The Objective-C Class type should not be treated as a potential dynamic type, since it actually doesn't resolve to the type of the class it points to Fixes rdar://

[Lldb-commits] [lldb] r273695 - Fix an issue where LLDB would show the key and value of a single entry NSDictionary in the wrong order

2016-06-24 Thread Enrico Granata via lldb-commits
Author: enrico Date: Fri Jun 24 12:48:01 2016 New Revision: 273695 URL: http://llvm.org/viewvc/llvm-project?rev=273695&view=rev Log: Fix an issue where LLDB would show the key and value of a single entry NSDictionary in the wrong order Fixes rdar://26478641 Added: lldb/trunk/packages/Pytho

Re: [Lldb-commits] [PATCH] D21680: Fix the libc++ pretty printers for the android NDK

2016-06-24 Thread Enrico Granata via lldb-commits
granata.enrico accepted this revision. granata.enrico added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D21680 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

[Lldb-commits] [lldb] r273640 - Fix an issue where the @lldb.command marker would not work with the new 5-argument version of the Python command function

2016-06-23 Thread Enrico Granata via lldb-commits
Author: enrico Date: Thu Jun 23 21:07:15 2016 New Revision: 273640 URL: http://llvm.org/viewvc/llvm-project?rev=273640&view=rev Log: Fix an issue where the @lldb.command marker would not work with the new 5-argument version of the Python command function This: a) teaches PythonCallable to look i

[Lldb-commits] [lldb] r270793 - It has been brought to my attention that, given two variables

2016-05-25 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed May 25 18:19:01 2016 New Revision: 270793 URL: http://llvm.org/viewvc/llvm-project?rev=270793&view=rev Log: It has been brought to my attention that, given two variables T x; U y; doing x = *((T*)y) is undefined behavior, even if sizeof(T) == sizeof(U), due to pointer

[Lldb-commits] [lldb] r270770 - Add logging to ValueObjectSyntheticFilter such that one can trace through the creation of synthetic children

2016-05-25 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed May 25 16:38:32 2016 New Revision: 270770 URL: http://llvm.org/viewvc/llvm-project?rev=270770&view=rev Log: Add logging to ValueObjectSyntheticFilter such that one can trace through the creation of synthetic children Modified: lldb/trunk/source/Core/ValueObjectSynthe

[Lldb-commits] [lldb] r270752 - Fix an issue where LLDB would crash if one tried to 'frame variable' an unordered_map more than once in a stop due to the synthetic provider not properly caching the Va

2016-05-25 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed May 25 15:38:33 2016 New Revision: 270752 URL: http://llvm.org/viewvc/llvm-project?rev=270752&view=rev Log: Fix an issue where LLDB would crash if one tried to 'frame variable' an unordered_map more than once in a stop due to the synthetic provider not properly caching t

[Lldb-commits] [lldb] r270621 - Fix an issue where the NSDate data formatter was not using the proper alignment on watchOS targets

2016-05-24 Thread Enrico Granata via lldb-commits
Author: enrico Date: Tue May 24 17:11:57 2016 New Revision: 270621 URL: http://llvm.org/viewvc/llvm-project?rev=270621&view=rev Log: Fix an issue where the NSDate data formatter was not using the proper alignment on watchOS targets Fixes rdar://problem/23298264 Modified: lldb/trunk/source/

Re: [Lldb-commits] Patch: Add additional nullptr check to SBValue::CreateValueFromData

2016-05-20 Thread Enrico Granata via lldb-commits
> On May 20, 2016, at 2:35 AM, Sebastian Theophil via lldb-commits > wrote: > > SBValue::CreateValueFromData didn’t check if the SBType argument was in fact > a nullptr. This leads to a crash when dereferencing it of course. I followed > the naming used in SBValue CreateValueFromAddress above

[Lldb-commits] [lldb] r270004 - Fix an issue where debugserver would not properly vend OS version information on iOS devices

2016-05-18 Thread Enrico Granata via lldb-commits
Author: enrico Date: Wed May 18 18:59:24 2016 New Revision: 270004 URL: http://llvm.org/viewvc/llvm-project?rev=270004&view=rev Log: Fix an issue where debugserver would not properly vend OS version information on iOS devices The __ENVIRONMENT_MAC_OS_X_VERSION_MIN_REQUIRED macro is only defined

  1   2   3   4   5   >