slydiman wrote:
lldb-remote-linux-win uses Windows host to build and run tests on AArch64 Linux.
Use @skipIf(hostoslist=["windows"]) instead of @skipIfWindows.
https://github.com/llvm/llvm-project/pull/153911
___
lldb-commits mailing list
lldb-commits@
slydiman wrote:
@JDevlieghere, @omjavaid,
Is there any reason why GetDemangledName returns empty on Windows?
The problem is hidden now. Could you create an issue and add the link to
@expectedFailureAll(bugnumber="...") at least, please.
https://github.com/llvm/llvm-project/pull/155939
_
slydiman wrote:
@JDevlieghere
```
TEST 'lldb-api :: python_api/basename/TestGetBaseName.py'
FAILED
Script:
--
C:/Python312/python.exe
C:/buildbot/as-builder-10/lldb-x86-64/llvm-project/lldb\test\API\dotest.py -u
CXXFLAGS -u CFLAGS --env
LLVM_LIBS_DIR
slydiman wrote:
The test `lldb-api::TestGetBaseName.py` is broken on
[lldb-x86_64-win](https://lab.llvm.org/buildbot/#/builders/211/builds/1715)
after this patch. Please take a look.
https://github.com/llvm/llvm-project/pull/155939
___
lldb-commits m
slydiman wrote:
This patch fixed
[lldb-remote-linux-ubuntu](https://lab.llvm.org/buildbot/#/builders/195/builds/13924)
and
[lldb-remote-linux-win](https://lab.llvm.org/buildbot/#/builders/197/builds/8541)
But the test `lldb-api::TestVariableAnnotationsDisassembler.py` is still broken
on [lldb-x
slydiman wrote:
The following buildbots are broken after this patch
[lldb-x86_64-win](https://lab.llvm.org/buildbot/#/builders/211/builds/1510)
[lldb-remote-linux-win](https://lab.llvm.org/buildbot/#/builders/197/builds/8267)
Please fix ASAP or revert to make them green.
https://github.com/llv
slydiman wrote:
Please fix the issue or revert ASAP to make buildbots green.
https://github.com/llvm/llvm-project/pull/149493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
The following buildbots are broken after this patch
[lldb-x86_64-win](https://lab.llvm.org/buildbot/#/builders/211/builds/1439)
[lldb-remote-linux-win](https://lab.llvm.org/buildbot/#/builders/197/builds/8177)
Please take a look and fix.
https://github.com/llvm/llvm-project/pull
slydiman wrote:
@cs01
> LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-win`
```
C:\buildbot\as-builder-10\lldb-x-aarch64\llvm-project\lldb\unittests\Platform\Android\AdbClientTest.cpp(116):
error C3861: 'setenv': identifier not found
```
Please take a look and fix it AS
slydiman wrote:
@chelcassanova
> Relands the commit to upstream the lldb-rpc-gen tool in order to fix a build
> failure on the linux remote bots.
What `linux remote bots` are you talking about? Everything worked. Looks like
we need to revert this PR ASAP because it broke too much.
https://g
slydiman wrote:
The buildbot lldb-remote-linux-ubuntu is broken
https://lab.llvm.org/buildbot/#/builders/195/builds/11604
```
/home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/llvm-project/lldb/include/lldb/lldb-enumerations.h:12:10:
fatal error: 'cstdint' file not found
```
https://g
slydiman wrote:
The buildbot lldb-x86_64-win is broken after this patch
https://lab.llvm.org/buildbot/#/builders/211/builds/361
```
FAIL: lldb-api::TestDataFormatterStdU8String.py
FAIL: lldb-api::TestDataFormatterStdString.py
```
https://github.com/llvm/llvm-project/pull/147525
_
slydiman wrote:
So far everything looks good. Thanks.
https://github.com/llvm/llvm-project/pull/147438
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman approved this pull request.
LGTM.
But I agree that
> it is hard to ensure a race condition is fixed without running the CI on
> multiple machines/configurations.
https://github.com/llvm/llvm-project/pull/147438
___
lldb-co
https://github.com/slydiman deleted
https://github.com/llvm/llvm-project/pull/145621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/145621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -44,26 +163,20 @@ MainLoopWindows::~MainLoopWindows() {
}
llvm::Expected MainLoopWindows::Poll() {
- std::vector events;
+ std::vector events;
events.reserve(m_read_fds.size() + 1);
- for (auto &[fd, info] : m_read_fds) {
-int result = WSAEventSelect(fd, info.even
@@ -31,6 +34,122 @@ static DWORD
ToTimeout(std::optional point) {
return ceil(dur).count();
}
+namespace {
+
+class PipeEvent : public MainLoopWindows::IOEvent {
+public:
+ explicit PipeEvent(HANDLE handle)
+ : IOEvent((IOObject::WaitableHandle)CreateEventW(
+
slydiman wrote:
The test lldb-unit::HostTests.exe/MainLoopTest/NoSpuriousPipeReads is flaky on
Windows.
Please fix it.
https://lab.llvm.org/buildbot/#/builders/211/builds/231
https://lab.llvm.org/buildbot/#/builders/197/builds/6659
https://github.com/llvm/llvm-project/pull/145621
slydiman wrote:
> I think you're looking for `@skipIf(hostoslist=["windows"])`
Yes, it looks more correct. But can a Unix socket be used for a remote
connection?
https://github.com/llvm/llvm-project/pull/146807
___
lldb-commits mailing list
lldb-comm
slydiman wrote:
Please look at
[lldb-remote-linux-win](https://lab.llvm.org/buildbot/#/builders/197/builds/6610)
Probably this test is flaky now.
```
FAIL: lldb-unit::HostTests.exe/MainLoopTest/NoSpuriousPipeReads
[view all 27
lines](https://lab.llvm.org/buildbot/#/builders/197/builds/6610/step
slydiman wrote:
Please look at https://lab.llvm.org/buildbot/#/builders/211/builds/181
This buildbot was red last 2 days. But probably this patch fixed `XPASS:
lldb-api::TestCallStdStringFunction.py` and `@expectedFailureAll` can be
removed.
https://github.com/llvm/llvm-project/pull/146562
__
https://github.com/slydiman approved this pull request.
Please land it ASAP.
https://github.com/llvm/llvm-project/pull/146807
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
Please look at the following problem
https://lab.llvm.org/buildbot/#/builders/211/builds/181
XPASS: lldb-api::TestCallStdStringFunction.py
It is hard to determine the source of problem because this buildbot is red
already last 2 days.
Probably lldb-api::TestCallStdStringFuncti
slydiman wrote:
The buildbot
[lldb-x86_64-win](https://lab.llvm.org/staging/#/builders/211/builds/700) is
broken after this patch.
Please fix it ASAP. We are planning to switch this buildbot to the production
mode soon.
https://github.com/llvm/llvm-project/pull/145994
https://github.com/slydiman approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/145706
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
[lldb-remote-linux-ubuntu](https://lab.llvm.org/buildbot/#/builders/195/builds/10876)
is broken after this patch.
Please update the test conditions to skip riscv tests on non-riscv platforms.
https://github.com/llvm/llvm-project/pull/127505
__
slydiman wrote:
> Looks like it got resolved?
Yes, sorry for the inconvenience.
https://github.com/llvm/llvm-project/pull/144998
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
It seems the buildbot
[lldb-remote-linux-ubuntu](https://lab.llvm.org/buildbot/#/builders/195/builds/10819)
is broken after this patch.
```
Unresolved Tests (3):
lldb-api :: commands/expression/import-std-module/basic/TestImportStdModule.py
lldb-api ::
commands/expression/i
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/145301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/145301
See #144891 for details.
>From 7d1bbcc0f16a67612439dc3133c361f2582ac25b Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Mon, 23 Jun 2025 13:58:08 +0400
Subject: [PATCH] [lldb] Disable flaky TestDetachResu
slydiman wrote:
The buildbot lldb-remote-linux-ubuntu is still broken.
Please fix it ASAP or revert the patch.
https://github.com/llvm/llvm-project/pull/145072
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
@@ -1084,55 +1052,30 @@ Status GDBRemoteCommunication::StartDebugserverProcess(
if (socket_pipe.CanWrite())
socket_pipe.CloseWriteFileDescriptor();
- if (socket_pipe.CanRead()) {
-// Read port from pipe with 10 second timeout.
-std::string port_str;
-while (
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/145021
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman approved this pull request.
LGTM
Note the comment above.
https://github.com/llvm/llvm-project/pull/145021
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
https://github.com/slydiman approved this pull request.
LGTM
I think we must mention in the description the main functional change that now
we are always using --fd for gdbserver on Windows instead of the back
connection.
https://github.com/llvm/llvm-project/pull/145017
__
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/144779
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/144779
See #144777 for details.
>From 5bdc9d7ae0ff06e29d9ac25f1c0b459edc87719e Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 18 Jun 2025 22:46:09 +0400
Subject: [PATCH] [lldb] Disable TestTargetWatchAddre
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/142573
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/142573
See #142196 and https://github.com/llvm/llvm-zorg/pull/452 for details.
>From 7f770486b80d0f927f5e4ad16f5e31a771b2ad0a Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Tue, 3 Jun 2025 14:28:58 +0400
Subjec
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/142192
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/142193
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/142193
See #138084 for details.
>From 72e166aa5f1d851cfd0cc972e761536eed14679a Mon Sep 17 00:00:00 2001
From: Dmitry Vassiliev
Date: Fri, 30 May 2025 22:19:28 +0400
Subject: [PATCH] [lldb] Disable TestReverseContinue
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/142192
See #138083 for details.
>From 99e4418063a869e0d9bdec784e62c5ebcb569510 Mon Sep 17 00:00:00 2001
From: Dmitry Vassiliev
Date: Fri, 30 May 2025 20:33:49 +0400
Subject: [PATCH] [lldb] Disable TestConsecutiveBrea
slydiman wrote:
The following buildbots are broken
https://lab.llvm.org/buildbot/#/builders/197/builds/5950
```
ld.lld: error: unable to find library -lobjc
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make: *** [Makefile.rules:530: a.out] Error 1
```
https://l
slydiman wrote:
https://lab.llvm.org/buildbot/#/builders/197/builds/5542 is broken.
Probably you must use `XFAIL: target-windows` instead of `XFAIL:
system-windows`.
https://github.com/llvm/llvm-project/pull/140588
___
lldb-commits mailing list
lldb-
slydiman wrote:
The following buildbots are broken by this patch too
https://lab.llvm.org/buildbot/#/builders/195/builds/8715
https://lab.llvm.org/buildbot/#/builders/197/builds/5054
Please fix ASAP.
https://github.com/llvm/llvm-project/pull/137904
___
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/138940
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/138940
See #138085 for details.
https://lab.llvm.org/buildbot/#/builders/59/builds/16937
https://lab.llvm.org/buildbot/#/builders/59/builds/17224
Rate limit ยท GitHub
body {
https://github.com/slydiman approved this pull request.
I have tested the failed Host.LaunchProcessDuplicatesHandle test on the setup
similar to
[lldb-remote-linux-win](https://lab.llvm.org/buildbot/#/builders/197). It is
fixed now.
https://github.com/llvm/llvm-project/pull/138896
___
https://github.com/slydiman approved this pull request.
Ok, let's see how it flies in the real world.
https://github.com/llvm/llvm-project/pull/137978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/137978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -122,8 +123,14 @@ struct ForkLaunchInfo {
ExitWithError(error_fd, "close");
break;
case FileAction::eFileActionDuplicate:
- if (dup2(action.fd, action.arg) == -1)
-ExitWithError(error_fd, "dup2");
+ if (action.fd != action.arg) {
-
@@ -274,10 +274,8 @@ static Status spawn_process(const char *progname, const
FileSpec &prog,
self_args.AppendArgument(llvm::StringRef("platform"));
self_args.AppendArgument(llvm::StringRef("--child-platform-fd"));
self_args.AppendArgument(llvm::to_string(shared_socket.Ge
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/138263
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/138263
See #138085 for details.
>From b35ad88aa12a000c13a4cc854fd55ba59c2e8535 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 2 May 2025 16:48:21 +0400
Subject: [PATCH] [lldb][test] Disable flaky TestLldbG
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/137978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/137978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -274,10 +274,8 @@ static Status spawn_process(const char *progname, const
FileSpec &prog,
self_args.AppendArgument(llvm::StringRef("platform"));
self_args.AppendArgument(llvm::StringRef("--child-platform-fd"));
self_args.AppendArgument(llvm::to_string(shared_socket.Ge
@@ -274,10 +274,8 @@ static Status spawn_process(const char *progname, const
FileSpec &prog,
self_args.AppendArgument(llvm::StringRef("platform"));
self_args.AppendArgument(llvm::StringRef("--child-platform-fd"));
self_args.AppendArgument(llvm::to_string(shared_socket.Ge
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/137978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -274,10 +274,8 @@ static Status spawn_process(const char *progname, const
FileSpec &prog,
self_args.AppendArgument(llvm::StringRef("platform"));
self_args.AppendArgument(llvm::StringRef("--child-platform-fd"));
self_args.AppendArgument(llvm::to_string(shared_socket.Ge
slydiman wrote:
https://github.com/llvm/llvm-project/commit/e6f7e3418eb8519d6cf12da8576ad75aac6b307b
broke
[lldb-remote-linux-win](https://lab.llvm.org/buildbot/#/builders/197/builds/4542)
again.
Note the special case Windows host and non-Windows target.
Note the buildbot cannot report the pro
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/137415
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
Duplicate of #137414.
https://github.com/llvm/llvm-project/pull/137415
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/137415
The buildbot lldb-remote-linux-win is broken after #136466. This patch should
make it green.
>From 53d84b5113c4d7398694a0e0ff7e07f2cc77451b Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Sat, 26 Apr 202
slydiman wrote:
Note DomainSocket is not supported on Windows, so removing the following code
broke the Windows build!
```
#if LLDB_ENABLE_POSIX
socket = new DomainSocket(sockfd, /*should_close=*/true);
#else
WithColor::error() << "lldb-platform child: Unix domain sockets are not "
slydiman wrote:
https://lab.llvm.org/buildbot/#/builders/141 is also broken.
https://github.com/llvm/llvm-project/pull/131836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
https://lab.llvm.org/buildbot/#/builders/197/builds/4470 is still broken
```
FAILED:
tools/lldb/source/Plugins/ExpressionParser/Clang/CMakeFiles/lldbPluginExpressionParserClang.dir/ClangModulesDeclVendor.cpp.obj
ccache
C:\PROGRA~1\MICROS~1\2022\COMMUN~1\VC\Tools\MSVC\1441~1.34
slydiman wrote:
The buildbot
[lldb-remote-linux-ubuntu](https://lab.llvm.org/buildbot/#/builders/195/builds/8132)
is broken too
```
FAILED: tools/lldb/source/Target/CMakeFiles/lldbTarget.dir/Statistics.cpp.o
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG
-D_GLIBCXX_ASSERTIONS -D
https://github.com/slydiman approved this pull request.
Thanks
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
Still failed
https://lab.llvm.org/buildbot/#/builders/195/builds/8109
https://lab.llvm.org/buildbot/#/builders/197/builds/4470
https://github.com/llvm/llvm-project/pull/131836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
slydiman wrote:
> Feel free to ping on this PR if any issues pop up
https://lab.llvm.org/buildbot/#/builders/195/builds/8106
```
14.009 [1092/66/4173] Building CXX object
tools/lldb/source/Core/CMakeFiles/lldbCore.dir/DemangledNameInfo.cpp.o
FAILED: tools/lldb/source/Core/CMakeFiles/lldbCore.di
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/137267
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
Ok, thanks.
Then I will close this PR.
https://github.com/llvm/llvm-project/pull/137267
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/137267
None
>From e14614a7ded95fbe9988739ed9d35260f0541e86 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Fri, 25 Apr 2025 02:30:03 +0400
Subject: [PATCH] [lldb] Add InstructionARM64 to lldb-server
---
lldb/t
@@ -455,35 +455,29 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
- Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
-
+ Log *log = GetLog(LLDBLog::Platform);
@@ -182,3 +191,22 @@ std::vector
DomainSocket::GetListeningConnectionURI() const {
return {llvm::formatv("unix-connect://{0}", addr.sun_path)};
}
+
+Socket *DomainSocket::Create(NativeSocket sockfd, bool should_close,
+ Status &error) {
+#ifdef _
@@ -455,35 +455,29 @@ int main_platform(int argc, char *argv[]) {
lldb_private::Args inferior_arguments;
inferior_arguments.SetArguments(argc, const_cast(argv));
- Socket::SocketProtocol protocol = Socket::ProtocolUnixDomain;
slydiman wrote:
There is a p
slydiman wrote:
Don't forget to update the protocol passed to the
GDBRemoteCommunicationServerPlatform constructor.
https://github.com/llvm/llvm-project/pull/136466
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
slydiman wrote:
I like it.
I would suggest to move domain/abstract socket checking to a static helper,
something like
```
Socket* DomainSocket::Create(NativeSocket sockfd, bool should_close) {
#ifdef __linux__
// Check if fd represents domain socket or abstract socket.
if (/*abstract*/)
slydiman wrote:
@ashgti Did you test #130169 on Windows?
This patch will fix the building, but I'm not sure that it will work on Windows
considering this:
```
// TODO: On Windows this should be a HANDLE, and wait should use
// WaitForMultipleObjects
typedef int WaitableHandle;
IOObject::Waitab
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/135033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
Ping
https://github.com/llvm/llvm-project/pull/135033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman approved this pull request.
LGTM, thanks.
Currently `GDBRemoteCommunication::ListenThread()` to get the bound port is
weird.
https://github.com/llvm/llvm-project/pull/135342
___
lldb-commits mailing list
lldb-commits@lists.
slydiman wrote:
Maybe rename `CPlusPlusLanguage::CPPMethodName` to
`CPlusPlusLanguage::CxxMethodName`?
Any preferences?
https://github.com/llvm/llvm-project/pull/132274
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/132274
>From 40d69ed7386c3f8169b324bd3b7591a46e34ff4d Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu, 20 Mar 2025 21:50:51 +0400
Subject: [PATCH 1/3] [LLDB] Refactored CPlusPlusLanguage::MethodName to break
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/132274
>From 40d69ed7386c3f8169b324bd3b7591a46e34ff4d Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Thu, 20 Mar 2025 21:50:51 +0400
Subject: [PATCH 1/3] [LLDB] Refactored CPlusPlusLanguage::MethodName to break
slydiman wrote:
I'm looking on it.
https://github.com/llvm/llvm-project/pull/132274
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/135033
>From 5e365a86734b33f4ce31eb9199b88a4a772b5342 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 9 Apr 2025 17:06:49 +0400
Subject: [PATCH] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to
br
slydiman wrote:
Note `Language::ForEach()` gives the following list:
```
cplusplus(eLanguageTypeC_plus_plus)
objc(eLanguageTypeObjC)
objcplusplus(eLanguageTypeObjC_plus_plus)
cplusplus(eLanguageTypeC_plus_plus_03)
cplusplus(eLanguageTypeC_plus_plus_11)
cplusplus(eLanguageTypeC_plus_plus_14)
cplus
https://github.com/slydiman ready_for_review
https://github.com/llvm/llvm-project/pull/135033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
slydiman wrote:
It seems the sorting of language plug-ins in CMakeLists.txt is not enough. I
tested #132274 locally and it passed, but failed on the buildbot
[lldb-aarch64-windows](https://lab.llvm.org/buildbot/#/builders/141).
I have updated LookupInfo::LookupInfo() close to the current code
https://github.com/slydiman edited
https://github.com/llvm/llvm-project/pull/135033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman converted_to_draft
https://github.com/llvm/llvm-project/pull/135033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/135033
>From d89b0242152002161b90d29e275a68e0e3f51dfe Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 9 Apr 2025 17:06:49 +0400
Subject: [PATCH] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to
br
https://github.com/slydiman updated
https://github.com/llvm/llvm-project/pull/135033
>From 75c47b9b6ff38150ee7ddd47c9b0be05681bc499 Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 9 Apr 2025 17:06:49 +0400
Subject: [PATCH] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to
br
https://github.com/slydiman created
https://github.com/llvm/llvm-project/pull/135033
The original PR is #132274.
>From 08b6d2b832d3f40ed56f05e7e7da26d6f3f0a8cc Mon Sep 17 00:00:00 2001
From: Dmitry Vasilyev
Date: Wed, 9 Apr 2025 17:06:49 +0400
Subject: [PATCH] [LLDB] Reapply refactored CPlusPl
https://github.com/slydiman closed
https://github.com/llvm/llvm-project/pull/132274
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -222,6 +222,21 @@ ObjCLanguage::GetMethodNameVariants(ConstString
method_name) const {
return variant_names;
}
+std::pair
+ObjCLanguage::GetFunctionNameInfo(ConstString name) const {
+ FunctionNameType func_name_type = eFunctionNameTypeNone;
+
+ if (ObjCLanguage::IsPos
1 - 100 of 651 matches
Mail list logo
