[Lldb-commits] [lldb] Fix connecting via abstract socket (PR #136466)

[Dmitry Vasilyev via lldb-commits]

slydiman wrote:

I like it. 
I would suggest to move domain/abstract socket checking to a static helper, 
something like
```
Socket* DomainSocket::Create(NativeSocket sockfd, bool should_close) {
#ifdef __linux__
  // Check if fd represents domain socket or abstract socket.
  if (/*abstract*/) 
    return new AbstractSocket(sockfd, should_close);
#endif
  return new DomainSocket(sockfd, should_close);
}
```
But please wait for @labath comments first.

https://github.com/llvm/llvm-project/pull/136466
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits