DavidSpickett wrote:
How does this relate to / overlap with existing PRs
https://github.com/llvm/llvm-project/pull/77949 and
https://github.com/llvm/llvm-project/pull/78977? They are unlikely to get
merged by the authors, so I assume you'll make your own equivalent.
> qWasmCallStack
This is
DavidSpickett wrote:
First commit is https://github.com/llvm/llvm-project/pull/148836, please review
the second onward.
https://github.com/llvm/llvm-project/pull/150011
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/150011
Fixes https://github.com/llvm/llvm-project/issues/135707
Follow up to https://github.com/llvm/llvm-project/pull/148836
which fixed some of this issue but not all of it.
Our Value/ValueObject system does
@@ -69,6 +69,7 @@ class LLDB_API SBData {
const char *GetString(lldb::SBError &error, lldb::offset_t offset);
+ [[clang::annotate("lldb-rpc-gen pointer plus len")]]
DavidSpickett wrote:
> This commit changes this by using the Clang annotation attribute to
DavidSpickett wrote:
ping!
https://github.com/llvm/llvm-project/pull/145033
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
ping!
https://github.com/llvm/llvm-project/pull/145029
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,23 @@
+#include "Plugins/Process/Linux/NativeProcessLinux.h"
+#include "Plugins/Process/Utility/NativeRegisterContextDBReg.h"
+#include "lldb/Utility/Status.h"
+#include
+#include
+#include
+#include
+#include
+
+namespace lldb_private {
+namespace process_linux {
@@ -102,18 +105,8 @@ class NativeRegisterContextLinux_arm : public
NativeRegisterContextLinux {
uint32_t m_gpr_arm[k_num_gpr_registers_arm];
RegisterInfoPOSIX_arm::FPU m_fpr;
- // Debug register info for hardware breakpoints and watchpoints management.
- struct DREG {
-
@@ -0,0 +1,63 @@
+#include "NativeRegisterContextLinuxArm64Shared.h"
+
+using namespace lldb_private::process_linux::arm64;
+
+namespace lldb_private {
+namespace process_linux {
+namespace arm64 {
DavidSpickett wrote:
You don't need `using namespace` if you're t
@@ -74,8 +75,10 @@ class NativeRegisterContextLinux_arm : public
NativeRegisterContextLinux {
bool WatchpointIsEnabled(uint32_t wp_index);
- // Debug register type select
- enum DREGType { eDREGTypeWATCH = 0, eDREGTypeBREAK };
+ using DREGType = NativeRegisterContextDBR
@@ -0,0 +1,63 @@
+#include "NativeRegisterContextLinuxArm64Shared.h"
DavidSpickett wrote:
All new .cpp and .h files need the license header, you can copy one from an
existing file and modify it.
https://github.com/llvm/llvm-project/pull/147198
_
@@ -0,0 +1,63 @@
+#include "NativeRegisterContextLinuxArm64Shared.h"
+
+using namespace lldb_private::process_linux::arm64;
+
+namespace lldb_private {
+namespace process_linux {
+namespace arm64 {
+
+namespace {
+Status ReadHardwareDebugInfoHelper(int regset, ::pid_t tid,
---
@@ -8,6 +8,7 @@ add_lldb_library(lldbPluginProcessLinux
NativeRegisterContextLinux.cpp
NativeRegisterContextLinux_arm.cpp
NativeRegisterContextLinux_arm64.cpp
+ NativeRegisterContextLinuxArm64Shared.cpp
DavidSpickett wrote:
We have the term "dbreg" in u
@@ -0,0 +1,63 @@
+#include "NativeRegisterContextLinuxArm64Shared.h"
DavidSpickett wrote:
Also the top of this file needs a comment explaining why it needed to be split
out.
https://github.com/llvm/llvm-project/pull/147198
__
https://github.com/DavidSpickett approved this pull request.
With the lack of apostrophes fixed, this LGTM.
https://github.com/llvm/llvm-project/pull/149768
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
@@ -203,7 +203,7 @@ Scoping
Many times the information that you might have in your prompt might not be
available and you won``t want it to print out if it isn``t valid. To take care
DavidSpickett wrote:
You can fix the uses double back tick instead of apostro
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/149480
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
https://github.com/llvm/llvm-project/issues/114906 as well.
https://github.com/llvm/llvm-project/pull/149305
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Opened https://github.com/llvm/llvm-project/issues/149498 so you can refer to
it.
I think it's a reasonable pitch to say:
* Formatters that work with PDB are a good idea.
* If we opt-in those formatters for testing using PDB, they will be run on at
least Linaro's Windows o
DavidSpickett wrote:
I ran this on Linaro's bot machine and got these results:
```
Unresolved Tests (5):
lldb-api ::
functionalities/data-formatter/data-formatter-stl/generic/string/TestDataFormatterStdString.py
lldb-api :: lang/c/vla/TestVLA.py
lldb-api :: python_api/
DavidSpickett wrote:
Windows Terminal is the default on Windows 10 at least. I think buildbot
launches things in conhost, but if utf-8 there was a problem for tests, we
would have seen it before now.
https://github.com/llvm/llvm-project/pull/149493
_
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/149493
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
I opened an issue for this https://github.com/llvm/llvm-project/issues/142568.
Where @Nerixyz mentions that SetConsoleOutputCP might have problems in cmd.exe
(which probably means conhost, the original windows terminal host, as opposed
to "windows terminal", the new one).
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/149490
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/149480
In some places it was printing "= {...}" and some "={...}" with no space. I
think the space looks nicer so do that in both cases.
>From 3c6241d1ed5e5b8d8c86447a98bed2f407f50ffb Mon Sep 17 00:00:00 2001
Fr
Author: David Spickett
Date: 2025-07-18T08:26:00Z
New Revision: 88721d63d482cf8f95deb66e74462b2cf583be8f
URL:
https://github.com/llvm/llvm-project/commit/88721d63d482cf8f95deb66e74462b2cf583be8f
DIFF:
https://github.com/llvm/llvm-project/commit/88721d63d482cf8f95deb66e74462b2cf583be8f.diff
LOG
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/149322
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
@Michael137 Does this actually need DWARF, or will any debug info format do?
https://github.com/llvm/llvm-project/pull/149322
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/149322
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/149322
By not forcing the DWARF debug info format. When left as the default, the tests
pass.
>From 092168660b280c0e1a1f6956bddd11899d5bafcc Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 17 Jul 2025 1
Author: David Spickett
Date: 2025-07-17T14:30:50Z
New Revision: ba5f31cfaa2452a4a94a482b53d899d6f2ee0e66
URL:
https://github.com/llvm/llvm-project/commit/ba5f31cfaa2452a4a94a482b53d899d6f2ee0e66
DIFF:
https://github.com/llvm/llvm-project/commit/ba5f31cfaa2452a4a94a482b53d899d6f2ee0e66.diff
LOG
Author: David Spickett
Date: 2025-07-17T14:24:05Z
New Revision: 756e07734b4f2aa64bd1bd5b6a29389c4c642323
URL:
https://github.com/llvm/llvm-project/commit/756e07734b4f2aa64bd1bd5b6a29389c4c642323
DIFF:
https://github.com/llvm/llvm-project/commit/756e07734b4f2aa64bd1bd5b6a29389c4c642323.diff
LOG
DavidSpickett wrote:
Yes this is what I was thinking of. Don't go diving into the failures yet, I'll
try this on the bot machine first and see if we need other adjustments.
https://github.com/llvm/llvm-project/pull/149305
___
lldb-commits mailing list
DavidSpickett wrote:
You should email the worker admin and see if they can help. "Worker:" tab then
"admin".
It is doing remote testing but the failure seems to be before that step so I
think it's something to do with the host.
https://github.com/llvm/llvm-project/pull/148996
@@ -0,0 +1,469 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,469 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/DavidSpickett commented:
What happens when you don't put this annotation on one of these? It generates
something I suppose, but it fails when you use lldb-rpc?
https://github.com/llvm/llvm-project/pull/148981
___
lldb-commits mailin
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/148981
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,124 @@
+#include "RPCLibraryHeaderEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/AST/Mangle.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Support/ToolOutputFile.h"
+#include "llvm/S
@@ -0,0 +1,542 @@
+#include "RPCLibrarySourceEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Suppor
@@ -0,0 +1,20 @@
+#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H
+#define LLDB_API_SBRPC_CHECKARRAYPTR_H
+
+#include
+#include
+
+#include "lldb/API/SBDefines.h"
+
+namespace lldb {
+class LLDB_API SBRPC_CHECKARRAYPTR {
DavidSpickett wrote:
Not sure about the ALLCAPS n
@@ -0,0 +1,542 @@
+#include "RPCLibrarySourceEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Suppor
@@ -0,0 +1,542 @@
+#include "RPCLibrarySourceEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Suppor
@@ -0,0 +1,20 @@
+#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H
+#define LLDB_API_SBRPC_CHECKARRAYPTR_H
+
+#include
+#include
+
+#include "lldb/API/SBDefines.h"
+
+namespace lldb {
+class LLDB_API SBRPC_CHECKARRAYPTR {
DavidSpickett wrote:
So these are just test input
@@ -0,0 +1,124 @@
+#include "RPCLibraryHeaderEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/AST/Mangle.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Support/ToolOutputFile.h"
+#include "llvm/S
@@ -0,0 +1,542 @@
+#include "RPCLibrarySourceEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Suppor
@@ -0,0 +1,542 @@
+#include "RPCLibrarySourceEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Suppor
@@ -0,0 +1,124 @@
+#include "RPCLibraryHeaderEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/AST/Mangle.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Support/ToolOutputFile.h"
+#include "llvm/S
@@ -0,0 +1,542 @@
+#include "RPCLibrarySourceEmitter.h"
+#include "RPCCommon.h"
+
+#include "clang/AST/AST.h"
+#include "clang/Frontend/CompilerInstance.h"
+
+#include "llvm/ADT/STLExtras.h"
+#include "llvm/ADT/SmallString.h"
+#include "llvm/ADT/StringRef.h"
+#include "llvm/Suppor
@@ -0,0 +1,20 @@
+#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H
+#define LLDB_API_SBRPC_CHECKARRAYPTR_H
+
+#include
+#include
DavidSpickett wrote:
Oh these are just test inputs. So the include can be removed entirely?
https://github.com/llvm/llvm-project/pull/147655
@@ -0,0 +1,15 @@
+RUN: mkdir -p %t/server
+RUN: mkdir -p %t/lib
+RUN: %lldb-rpc-gen --output-dir=%t %S/../../Inputs/CheckSBPointer.h
+
+RUN: cat %t/lib/CheckSBPointer.cpp | FileCheck %s
+
+# Pointers to SB objects must be checked to
+# see if they're null. If so, then a new object
@@ -0,0 +1,20 @@
+#ifndef LLDB_API_SBRPC_CHECKARRAYPTR_H
+#define LLDB_API_SBRPC_CHECKARRAYPTR_H
+
+#include
+#include
DavidSpickett wrote:
I think all the cstdio includes can move into the cpp files.
https://github.com/llvm/llvm-project/pull/147655
__
Author: David Spickett
Date: 2025-07-17T09:17:25Z
New Revision: d87170211dc780341e42f7719c7332416f9cc290
URL:
https://github.com/llvm/llvm-project/commit/d87170211dc780341e42f7719c7332416f9cc290
DIFF:
https://github.com/llvm/llvm-project/commit/d87170211dc780341e42f7719c7332416f9cc290.diff
LOG
DavidSpickett wrote:
We had a discussion about preferring one or the other PDB implementation but I
don't recall the conclusion. I think this is just for reading PDB, right? Clang
is going to use llvm's libraries to *write* PDB and of course MSVC is using
Microsoft's implementation.
I think a
DavidSpickett wrote:
What does running API tests with PDB look like? I assume Linaro is not doing
that because we don't pass any extra flags, and often have to disable tests
because link.exe is mangling the DWARF sections.
Or put another way, @Nerixyz how do you make sure PDB is being used whe
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/149057
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Also, the server made it into 21.x but the docs obviously didn't and there's no
release note for it. Is it complete "enough" to cherry-pick this and add a
release note?
https://github.com/llvm/llvm-project/pull/148708
___
lldb-co
https://github.com/DavidSpickett approved this pull request.
LGTM with whatever is the correct thing to document for debugger IDs.
https://github.com/llvm/llvm-project/pull/148708
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/149057
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -167,3 +167,49 @@ The result of this is that:
Your VM configuration should have ports ``54321`` and ``49140`` forwarded for
this to work.
+
+QEMU user mode emulation
+
+
+Serious testing of LLDB should be done using system mode emulation. The
follow
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/149057
>From eab94453a4275cdbc5fe60607fb18a7869a2d3a8 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 16 Jul 2025 10:20:59 +
Subject: [PATCH 1/2] [lldb][docs] Add section on testing with QEMU user
T
DavidSpickett wrote:
Perhaps with a release note saying this happened and how to switch back to the
non-default way?
https://github.com/llvm/llvm-project/pull/147887
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/149057
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Hopefully there are enough "here be dragons, fighting them is your problem" in
the text.
WASM runtimes is another class of simulator I was thinking of in future. I know
we don't have support for that yet but if that one PR ever gets revived, it
might be a thing. So I'm le
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/149057
This is not recommended to basically anyone but on occasion it's useful and
could be used for testing with other simulator programs for example bare metal
simulators.
Adding this is also an excuse to doc
@@ -1376,29 +1376,26 @@ class EntityRegister : public Materializer::Entity {
return;
}
-DataExtractor register_data;
-
-if (!reg_value.GetData(register_data)) {
- err = Status::FromErrorStringWithFormat(
- "couldn't get the data for register %s"
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/148836
Relates to https://github.com/llvm/llvm-project/issues/135707
Where it was reported that reading the PC using "register read" had different
results to an expression "$pc".
This was happening because regi
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/148823
>From ba64d72e000bd14125b202a70bd7d34831e12cc0 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Tue, 15 Jul 2025 10:30:21 +
Subject: [PATCH] [lldb] Improve setting of program for filtering disassemb
Author: David Spickett
Date: 2025-07-15T09:54:58Z
New Revision: a64bfd8a5186bc5b967878689509db81b9d1922c
URL:
https://github.com/llvm/llvm-project/commit/a64bfd8a5186bc5b967878689509db81b9d1922c
DIFF:
https://github.com/llvm/llvm-project/commit/a64bfd8a5186bc5b967878689509db81b9d1922c.diff
LOG
@@ -75,7 +75,69 @@ Configuration example for [Visual Studio
Code](https://code.visualstudio.com/doc
}
```
-### Troubleshooting
+## Tools
+
+Tools are a primitive in the Model Context Protocol that enable servers to
+expose functionality to clients.
+
+LLDB's MCP integration e
@@ -75,7 +75,69 @@ Configuration example for [Visual Studio
Code](https://code.visualstudio.com/doc
}
```
-### Troubleshooting
+## Tools
+
+Tools are a primitive in the Model Context Protocol that enable servers to
+expose functionality to clients.
+
+LLDB's MCP integration e
@@ -75,7 +75,69 @@ Configuration example for [Visual Studio
Code](https://code.visualstudio.com/doc
}
```
-### Troubleshooting
+## Tools
+
+Tools are a primitive in the Model Context Protocol that enable servers to
+expose functionality to clients.
+
+LLDB's MCP integration e
https://github.com/DavidSpickett approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/147054
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DavidSpickett wrote:
Please fix the formatting before landing -
https://github.com/llvm/llvm-project/actions/runs/16232166455/job/45836933279?pr=145793.
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -90,3 +91,64 @@ TEST_F(TestMCDisasmInstanceRISCV, TestRISCV32Instruction) {
EXPECT_FALSE(inst_sp->IsCall());
EXPECT_TRUE(inst_sp->DoesBranch());
}
+
+TEST_F(TestMCDisasmInstanceRISCV, TestOpcodeBytePrinter) {
+ ArchSpec arch("riscv32-*-linux");
+
+ const unsigned num_o
@@ -304,6 +304,10 @@ Changes to LLDB
stop reason = SIGSEGV: sent by tkill system call (sender pid=649752,
uid=2667987)
```
* ELF Cores can now have their siginfo structures inspected using `thread
siginfo`.
+* Disassembly of unknown instructions now produces "" instead
DavidSpickett wrote:
> So the solution is copying the implementation in
> NativeRegisterContextLinux_arm64.cpp.
Yes, try putting the 64-bit code in a separate file in Process/Linux then using
it in both places.
Currently arm64 includes the arm header, for reasons I am not sure, so if there
i
DavidSpickett wrote:
> the test
By this you mean it skips any test that requires hardware breakpoints? Or you
mean that in the general course of using lldb it doesn't use hardware
breakpoints because of this?
(I assume you could make the test suite launch all debugees as AArch32 but
seems un
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/145793
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,28 @@
+# REQUIRES: x86
+
+# This test verifies that disassemble -b prints out the correct bytes and
+# format for x86_64 instructions of various sizes, and that an unknown
+# instruction shows the opcode and disassembles as ""
+
+# RUN: llvm-mc -filetype=obj --triple=x8
@@ -0,0 +1,30 @@
+# REQUIRES: riscv
+
+# This test verifies that disassemble -b prints out the correct bytes and
+# format for standard and unknown riscv instructions of various sizes,
+# and that unknown instructions show opcodes and disassemble as "".
+# It also tests that the f
@@ -0,0 +1,30 @@
+# REQUIRES: riscv
+
+# This test verifies that disassemble -b prints out the correct bytes and
+# format for standard and unknown riscv instructions of various sizes,
+# and that unknown instructions show opcodes and disassemble as "".
+# It also tests that the f
@@ -304,6 +304,9 @@ Changes to LLDB
stop reason = SIGSEGV: sent by tkill system call (sender pid=649752,
uid=2667987)
```
* ELF Cores can now have their siginfo structures inspected using `thread
siginfo`.
+* Changed invalid disassembly to say instead of being blank.
-
@@ -304,6 +304,9 @@ Changes to LLDB
stop reason = SIGSEGV: sent by tkill system call (sender pid=649752,
uid=2667987)
```
* ELF Cores can now have their siginfo structures inspected using `thread
siginfo`.
+* Changed invalid disassembly to say instead of being blank.
+
@@ -0,0 +1,30 @@
+# REQUIRES: riscv
+
+# This test verifies that disassemble -b prints out the correct bytes and
+# format for standard and unknown riscv instructions of various sizes,
+# and that unknown instructions show opcodes and disassemble as "".
+# It also tests that the f
DavidSpickett wrote:
> Unfortunately there is no easy way to add testing for this. No RISCV hardware
> at the disposal. I welcome the suggestions.
Make a core file that does not include any internal data and then it can be
tested on any system. If you have to satisfy internal policies around t
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/147434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
I guess you're emulating what the tool gets during the normal build so if it
works it works. Let's find out what the bot thinks.
https://github.com/llvm/llvm-project/pull/147417
___
lldb-com
DavidSpickett wrote:
For relands, please describe the difference between the reland and the original
patch in the PR description. This helps us later when it turns out that either
it did not fix the problem you thought it did, or it did, but now there is
another problem.
https://github.com/ll
DavidSpickett wrote:
> Relands the commit to upstream the lldb-rpc-gen tool in order to fix a build
> failure on the linux remote bots.
And changes what when compared to the original PR?
https://github.com/llvm/llvm-project/pull/147417
___
lldb-commi
DavidSpickett wrote:
> Yes I already found it and its in my list to fix, there are few places where
> DWARF32 parsing but I was planing to do in separate PR. or you want me to do
> it here only ?
Separate PR please.
https://github.com/llvm/llvm-project/pull/147054
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/145033
>From ba8fcf4ef14e25b8a628b994988d6a67bdbea7df Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 19 Jun 2025 10:43:48 +
Subject: [PATCH 1/3] [lldb][AArch64] Add HWCAP3 to register field detectio
DavidSpickett wrote:
> And by searching that error message I found:
Hacking that to be DWARF64 gets more tests passing:
```
Total Discovered Tests: 33363
Skipped : 1 (0.00%)
Unsupported : 518 (1.55%)
Passed : 32696 (98.00%)
Expectedly Failed:31 (0.09%)
DavidSpickett wrote:
> Could use a test case.
But I too still want a targeted test case for this. Especially given that no
one is going to be running a DWARF64 buildbot any time soon.
https://github.com/llvm/llvm-project/pull/147054
___
lldb-commits
DavidSpickett wrote:
DWARF64, with this PR branch:
```
Total Discovered Tests: 33363
Skipped : 1 (0.00%)
Unsupported : 518 (1.55%)
Passed : 32716 (98.06%)
Expectedly Failed:31 (0.09%)
Unresolved : 3 (0.01%)
Failed :94 (0.28%)
`
DavidSpickett wrote:
This is the relevant part of the standard, correct?
```
7.5.5 Classes and Forms
18 • stroffsetsptr
19 This is an offset into the .debug_str_offsets section
20 (DW_FORM_sec_offset). It consists of an offset from the beginning of the
21 .debug_str_offsets section to the begin
https://github.com/DavidSpickett commented:
I agree with the change, FixAnyAddress uses whatever is the least destructive
fix.
Jonas should look over the core file bit, I don't know much about MachO.
https://github.com/llvm/llvm-project/pull/147011
_
@@ -44,6 +43,8 @@ def test_armv7_corefile(self):
self.assertTrue(exception.IsValid())
self.assertEqual(exception.GetValueAsUnsigned(), 0x3F5C)
+self.expect("x/4bx $sp-1", substrs=["0x000d", "0xff 0x00 0x01
0x02"])
DavidSpickett
@@ -0,0 +1,15 @@
+# Disabling until the lldb-rpc-gen tool lands.
+UNSUPPORTED: system-windows, system-linux, system-darwin
DavidSpickett wrote:
That's fine with me.
https://github.com/llvm/llvm-project/pull/138032
___
1 - 100 of 2069 matches
Mail list logo
