[Lldb-commits] [lldb] [lldb] Reimplement __str__ in SBStructuredDataExtensions.i (PR #156725)

2025-09-03 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/156725 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Reimplement __str__ in SBStructuredDataExtensions.i (PR #156725)

2025-09-03 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/156725 Follow up to #155061 and #156721. After discussing with @medismailben, the ideal course of to have a `__str__`, however, instead of throwing an exception, the fallback behavior calls `__repr__` (`GetDescrip

[Lldb-commits] [lldb] [lldb] Revert custom __str__ in SBStructuredDataExtensions.i (PR #156721)

2025-09-03 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/156721 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Revert custom __str__ in SBStructuredDataExtensions.i (PR #156721)

2025-09-03 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/156721 None >From 3aa17b0109bf625bc73d7b4713b526f95f5f0d9c Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 3 Sep 2025 10:28:58 -0700 Subject: [PATCH] [lldb] Revert custom __str__ in SBStructuredDataExtensions.i

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-09-03 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/155061 >From eff269a2c869b3a3c73ed0198f3b749fd914b2aa Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 22 Aug 2025 19:34:57 -0700 Subject: [PATCH 1/5] [lldb] Add Pythonic API to SBStructuredData extension * Impl

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-09-02 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/155061 >From eff269a2c869b3a3c73ed0198f3b749fd914b2aa Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 22 Aug 2025 19:34:57 -0700 Subject: [PATCH 1/4] [lldb] Add Pythonic API to SBStructuredData extension * Impl

[Lldb-commits] [lldb] [lldb] Fix a typo in --one-shot description (NFC) (PR #155637)

2025-08-27 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/155637 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix a typo in --one-shot description (NFC) (PR #155637)

2025-08-27 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/155637 None >From 6e8a5f3e782e30a18b6910489c1ecfce7b38d977 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 27 Aug 2025 08:24:02 -0700 Subject: [PATCH] [lldb] Fix a typo in --one-shot description (NFC) --- lld

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-08-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/155061 >From 8c8a17a0ac56d31ec9cf8319a5aa33060852ef27 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 22 Aug 2025 19:34:57 -0700 Subject: [PATCH 1/4] [lldb] Add Pythonic API to SBStructuredData extension * Impl

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-08-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/155061 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-08-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/155061 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-08-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/155061 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-08-23 Thread Dave Lee via lldb-commits
kastiglione wrote: thanks @medismailben, I did another update to add a `dynamic` property, which is effectively an unwrapping operation. These two expressions have the same result: ```py data["id"] == data.GetValueForKey("id").GetUnsignedInteger() ``` https://github.com/llvm/llvm-project/pull

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-08-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/155061 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-08-23 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/155061 >From 8c8a17a0ac56d31ec9cf8319a5aa33060852ef27 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 22 Aug 2025 19:34:57 -0700 Subject: [PATCH 1/3] [lldb] Add Pythonic API to SBStructuredData extension * Impl

[Lldb-commits] [lldb] [lldb] Add Pythonic API to SBStructuredData extension (PR #155061)

2025-08-22 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/155061 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] More windows fixes TestSettings.py (PR #154983)

2025-08-22 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/154983 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add flag to "settings show" to include default values (PR #153233)

2025-08-22 Thread Dave Lee via lldb-commits
kastiglione wrote: @slydiman https://github.com/llvm/llvm-project/pull/154983 https://github.com/llvm/llvm-project/pull/153233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] More windows fixes TestSettings.py (PR #154983)

2025-08-22 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/154983 None >From 06b3b8336271662500a9997b082f2201eb0715da Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 22 Aug 2025 09:50:46 -0700 Subject: [PATCH] [lldb] More windows fixes TestSettings.py --- lldb/test/A

[Lldb-commits] [lldb] [lldb] Add flag to "settings show" to include default values (PR #153233)

2025-08-22 Thread Dave Lee via lldb-commits
kastiglione wrote: @slydiman I received emails yesterday and fixed the failures, but there's another failure that wasn't initially reported. I'll fix that now. https://github.com/llvm/llvm-project/pull/153233 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [lldb] [lldb] Improve error message in ResolveSDKPathFromDebugInfo (NFC) (PR #154607)

2025-08-21 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/154607 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve error message in ResolveSDKPathFromDebugInfo (NFC) (PR #154607)

2025-08-21 Thread Dave Lee via lldb-commits
@@ -1039,7 +1039,12 @@ ResolveSDKPathFromDebugInfo(lldb_private::Target *target) { SymbolFile *sym_file = exe_module_sp->GetSymbolFile(); if (!sym_file) -return llvm::createStringError("Failed to get symbol file from module"); +return llvm::createStringError("Fail

[Lldb-commits] [lldb] [lldb] Improve error message in ResolveSDKPathFromDebugInfo (NFC) (PR #154607)

2025-08-21 Thread Dave Lee via lldb-commits
@@ -1039,7 +1039,12 @@ ResolveSDKPathFromDebugInfo(lldb_private::Target *target) { SymbolFile *sym_file = exe_module_sp->GetSymbolFile(); if (!sym_file) -return llvm::createStringError("Failed to get symbol file from module"); +return llvm::createStringError("Fail

[Lldb-commits] [lldb] [lldb] Improve error message in ResolveSDKPathFromDebugInfo (NFC) (PR #154607)

2025-08-21 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/154607 >From 1e70adad6b2d62bcb568ad603298a1a91121a87b Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 20 Aug 2025 13:27:51 -0700 Subject: [PATCH 1/2] [lldb] Improve error message in ResolveSDKPathFromDebugInfo

[Lldb-commits] [lldb] [lldb] Remove unused XcodeSDK::SupportsSwift (NFC) (PR #154572)

2025-08-21 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/154572 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve error message in ResolveSDKPathFromDebugInfo (NFC) (PR #154607)

2025-08-21 Thread Dave Lee via lldb-commits
@@ -1039,7 +1039,12 @@ ResolveSDKPathFromDebugInfo(lldb_private::Target *target) { SymbolFile *sym_file = exe_module_sp->GetSymbolFile(); if (!sym_file) -return llvm::createStringError("Failed to get symbol file from module"); +return llvm::createStringError("Fail

[Lldb-commits] [lldb] [lldb] Tweak check for CommandLineTools in ParseXcodeSDK (PR #154574)

2025-08-21 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/154574 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Tweak check for CommandLineTools in ParseXcodeSDK (PR #154574)

2025-08-20 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/154574 >From 13264919452f446dd13f5f8a3e3ed207e84bf96b Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 20 Aug 2025 09:41:26 -0700 Subject: [PATCH 1/2] [lldb] Tweak check for CommandLineTools in ParseXcodeSDK ---

[Lldb-commits] [lldb] [lldb] Improve error message in ResolveSDKPathFromDebugInfo (NFC) (PR #154607)

2025-08-20 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/154607 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Improve error message in ResolveSDKPathFromDebugInfo (NFC) (PR #154607)

2025-08-20 Thread Dave Lee via lldb-commits
@@ -1039,7 +1039,12 @@ ResolveSDKPathFromDebugInfo(lldb_private::Target *target) { SymbolFile *sym_file = exe_module_sp->GetSymbolFile(); if (!sym_file) -return llvm::createStringError("Failed to get symbol file from module"); +return llvm::createStringError("Fail

[Lldb-commits] [lldb] [lldb] Improve error message in ResolveSDKPathFromDebugInfo (NFC) (PR #154607)

2025-08-20 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/154607 While debugging, I saw a log line of: > Failed to resolve SDK path: Error while searching for SDK (XcodeSDK ''): > Unrecognized SDK type: Looking into how this might happen, it seems `ResolveSDKPathFromDe

[Lldb-commits] [lldb] [lldb] Tweak check for CommandLineTools in ParseXcodeSDK (PR #154574)

2025-08-20 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/154574 None >From 13264919452f446dd13f5f8a3e3ed207e84bf96b Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 20 Aug 2025 09:41:26 -0700 Subject: [PATCH] [lldb] Tweak check for CommandLineTools in ParseXcodeSDK -

[Lldb-commits] [lldb] [lldb] Tweak check for CommandLineTools in ParseXcodeSDK (PR #154574)

2025-08-20 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/154574 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove unused XcodeSDK::SupportsSwift (NFC) (PR #154572)

2025-08-20 Thread Dave Lee via lldb-commits
kastiglione wrote: this function is also not used downstream in the swift repo. https://github.com/llvm/llvm-project/pull/154572 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove unused XcodeSDK::SupportsSwift (NFC) (PR #154572)

2025-08-20 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/154572 None >From 9e56a63771919e53ed7228adab394f61b1d1a5ba Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 19 Aug 2025 21:59:05 -0700 Subject: [PATCH] [lldb] Remove unused XcodeSDK::SupportsSwift (NFC) --- ll

[Lldb-commits] [lldb] [lldb] Add flag to "settings show" to include default values (PR #153233)

2025-08-20 Thread Dave Lee via lldb-commits
kastiglione wrote: If there's no more feedback, I'll merge this soon. https://github.com/llvm/llvm-project/pull/153233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make step/s alias for new _regexp-step (PR #153984)

2025-08-19 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/153984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make step/s alias for new _regexp-step (PR #153984)

2025-08-17 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/153984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make step/s alias for new _regexp-step (PR #153984)

2025-08-16 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/153984 >From 07a8f9b07c67b6a84a922180aaeb5808c84c7fdc Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Sat, 16 Aug 2025 15:37:35 -0700 Subject: [PATCH 1/3] [lldb] Make step/s alias for new _regexp-step Introduces `_r

[Lldb-commits] [lldb] [lldb] Make step/s alias for new _regexp-step (PR #153984)

2025-08-16 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/153984 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make step/s alias for new _regexp-step (PR #153984)

2025-08-16 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/153984 >From 07a8f9b07c67b6a84a922180aaeb5808c84c7fdc Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Sat, 16 Aug 2025 15:37:35 -0700 Subject: [PATCH 1/2] [lldb] Make step/s alias for new _regexp-step Introduces `_r

[Lldb-commits] [lldb] [lldb] Make step/s alias for new _regexp-step (PR #153984)

2025-08-16 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/153984 Introduces `_regexp-step`, a regex command which allows for stepping into a target function. This change updates `step` and `s` to be aliases for `_regexp-step`. The existing `sif` command ("Step Into Funct

[Lldb-commits] [lldb] [lldb] Add flag to "settings show" to include default values (PR #153233)

2025-08-16 Thread Dave Lee via lldb-commits
kastiglione wrote: Updated. Of note: * collection types now show `(default: empty)` * the flag is named `--defaults`, in part because `settings show --show-defaults` seemed redundant * added tests https://github.com/llvm/llvm-project/pull/153233 ___

[Lldb-commits] [lldb] [lldb] Add flag to "settings show" to include default values (PR #153233)

2025-08-16 Thread Dave Lee via lldb-commits
@@ -56,6 +56,11 @@ let Command = "settings clear" in { Desc<"Clear all settings.">; } +let Command = "settings show" in { + def setshow_include_defaults : Option<"include-defaults", "d">, kastiglione wrote: changed to `settings show --defaults`. https:/

[Lldb-commits] [lldb] [lldb] Add flag to "settings show" to include default values (PR #153233)

2025-08-16 Thread Dave Lee via lldb-commits
@@ -54,17 +55,18 @@ void OptionValueFormatEntity::DumpValue(const ExecutionContext *exe_ctx, if (dump_mask & eDumpOptionValue) { if (dump_mask & eDumpOptionType) strm.PutCString(" = "); -std::string escaped; -EscapeBackticks(m_current_format, escaped); -

[Lldb-commits] [lldb] [lldb] Add flag to "settings show" to include default values (PR #153233)

2025-08-16 Thread Dave Lee via lldb-commits
@@ -338,6 +340,14 @@ class OptionValue { // DeepCopy to it. Inherit from Cloneable to avoid doing this manually. virtual lldb::OptionValueSP Clone() const = 0; + struct DefaultValueFormat { +DefaultValueFormat(Stream &stream) : stream(stream) { + stream.PutCStrin

[Lldb-commits] [lldb] [lldb] Add flag to "settings show" to include default values (PR #153233)

2025-08-16 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/153233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add flag to "settings show" to include default values (PR #153233)

2025-08-16 Thread Dave Lee via lldb-commits
https://github.com/kastiglione ready_for_review https://github.com/llvm/llvm-project/pull/153233 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add flag to "settings show" to include default values (PR #153233)

2025-08-16 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/153233 >From 88b491d4a1a13e1f64efdf8e1bb71c3b58c4b0b5 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 12 Aug 2025 10:45:04 -0700 Subject: [PATCH 01/10] [lldb] Show setting default in new verbose mode --- lldb/

[Lldb-commits] [lldb] Revert "[lldb] Fallback to expression eval when Dump of variable fails in dwim-print" (PR #153824)

2025-08-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/153824 Reverts llvm/llvm-project#151374 Superseded by https://github.com/llvm/llvm-project/pull/152417 >From 82f23539351c8365281f6b68a42564c4ec25548e Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Fri, 15 Aug 2025

[Lldb-commits] [lldb] [lldb] Print ValueObject when GetObjectDescription fails (PR #152417)

2025-08-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/152417 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print ValueObject when GetObjectDescription fails (PR #152417)

2025-08-15 Thread Dave Lee via lldb-commits
@@ -150,6 +151,11 @@ llvm::Expected ValueObjectPrinter::GetDescriptionForDisplay() { if (maybe_str) return maybe_str; + if (maybe_str.errorIsA()) +// Propagate expression errors to expose diagnostics to the user. +// Without this early exit, the summary/value m

[Lldb-commits] [lldb] [lldb] Underline short option letters as mnemonics (PR #153695)

2025-08-15 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/153695 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Underline short option letters as mnemonics (PR #153695)

2025-08-15 Thread Dave Lee via lldb-commits
@@ -736,18 +736,35 @@ let Command = "process launch" in { } let Command = "process attach" in { - def process_attach_continue : Option<"continue", "c">, -Desc<"Immediately continue the process once attached.">; - def process_attach_plugin : Option<"plugin", "P">, Arg<"Pl

[Lldb-commits] [lldb] [lldb] Underline short option letters as mnemonics (PR #153695)

2025-08-15 Thread Dave Lee via lldb-commits
@@ -736,18 +736,35 @@ let Command = "process launch" in { } let Command = "process attach" in { - def process_attach_continue : Option<"continue", "c">, -Desc<"Immediately continue the process once attached.">; - def process_attach_plugin : Option<"plugin", "P">, Arg<"Pl

[Lldb-commits] [lldb] [lldb] Print ValueObject when GetObjectDescription fails (PR #152417)

2025-08-14 Thread Dave Lee via lldb-commits
kastiglione wrote: >``` > (lldb) po bogus_description > Warning: po description expression crashed, printing value > (BogusDescription *) 0x12345 >``` This case looks like: ``` (lldb) po bogus_description error: could not evaluate print object function: expression interrupted (BogusDescription

[Lldb-commits] [lldb] [lldb] Print ValueObject when GetObjectDescription fails (PR #152417)

2025-08-14 Thread Dave Lee via lldb-commits
kastiglione wrote: I've renamed the various use_objc names to use_object_desc. https://github.com/llvm/llvm-project/pull/152417 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print ValueObject when GetObjectDescription fails (PR #152417)

2025-08-14 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/152417 >From 93c8135a07e21ef0f5764735cd6ddc97c9b48a32 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 6 Aug 2025 17:13:02 -0700 Subject: [PATCH 1/7] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::Ge

[Lldb-commits] [lldb] [lldb] Print ValueObject when GetObjectDescription fails (PR #152417)

2025-08-14 Thread Dave Lee via lldb-commits
kastiglione wrote: > You said above that this code wouldn't get used if the description expression > crashed. Originally, that was the case. > it would be nice to use this same codepath to do: agree, and it does so. I was in the process of writing tests, which I've now added. https://github

[Lldb-commits] [lldb] [lldb] Print ValueObject when GetObjectDescription fails (PR #152417)

2025-08-14 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/152417 >From 93c8135a07e21ef0f5764735cd6ddc97c9b48a32 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 6 Aug 2025 17:13:02 -0700 Subject: [PATCH 1/6] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::Ge

[Lldb-commits] [lldb] [lldb] Print ValueObject when GetObjectDescription fails (PR #152417)

2025-08-14 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/152417 >From 93c8135a07e21ef0f5764735cd6ddc97c9b48a32 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 6 Aug 2025 17:13:02 -0700 Subject: [PATCH 1/5] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::Ge

[Lldb-commits] [lldb] [lldb] Print ValueObject when GetObjectDescription fails (PR #152417)

2025-08-14 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152417 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print ValueObject when GetObjectDescription fails (PR #152417)

2025-08-14 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152417 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print ValueObject when GetObjectDescription fails (PR #152417)

2025-08-14 Thread Dave Lee via lldb-commits
kastiglione wrote: Following a offline conversation with Jim, I've updated this PR. See the description for details on the changes. https://github.com/llvm/llvm-project/pull/152417 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [lldb] [lldb] Print ValueObject when GetObjectDescription fails (PR #152417)

2025-08-14 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/152417 >From 93c8135a07e21ef0f5764735cd6ddc97c9b48a32 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 6 Aug 2025 17:13:02 -0700 Subject: [PATCH 1/3] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::Ge

[Lldb-commits] [lldb] [lldb] Print ValueObject when GetObjectDescription fails (PR #152417)

2025-08-14 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152417 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Print ValueObject when GetObjectDescription fails (PR #152417)

2025-08-14 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152417 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::GetDescriptionForDisplay (PR #152417)

2025-08-14 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/152417 >From 93c8135a07e21ef0f5764735cd6ddc97c9b48a32 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 6 Aug 2025 17:13:02 -0700 Subject: [PATCH 1/2] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::Ge

[Lldb-commits] [lldb] [lldb] Add "settings modified" command (PR #152338)

2025-08-08 Thread Dave Lee via lldb-commits
kastiglione wrote: @labath do you think it will be more discoverable that way, or more memorable? https://github.com/llvm/llvm-project/pull/152338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [lldb] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::GetDescriptionForDisplay (PR #152417)

2025-08-07 Thread Dave Lee via lldb-commits
@@ -150,6 +151,11 @@ llvm::Expected ValueObjectPrinter::GetDescriptionForDisplay() { if (maybe_str) return maybe_str; + if (maybe_str.errorIsA()) +// Propagate expression errors to expose diagnostics to the user. +// Without this early exit, the summary/value m

[Lldb-commits] [lldb] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::GetDescriptionForDisplay (PR #152417)

2025-08-07 Thread Dave Lee via lldb-commits
kastiglione wrote: > That's changing this UI to NOT print the value if the `po` expression fails > for some reason. > > Is that your intent? it's my intent when the failure is a _compiler reason_ – which is to make a distinction that this is a more narrow change than "some reason". https://gi

[Lldb-commits] [lldb] [lldb] Propagate ExpressionErrors from ValueObjectPrinter::GetDescriptionForDisplay (PR #152417)

2025-08-07 Thread Dave Lee via lldb-commits
kastiglione wrote: The ultimate intent is to show errors preventing an expected successful object description. If producing an object description fails, printing an object's address (value) is not what users expect. We can change this to print the error and the value, but I don't expect any us

[Lldb-commits] [lldb] [lldb] Add "settings modified" command (PR #152338)

2025-08-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add "settings modified" command (PR #152338)

2025-08-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152338 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] wip: add "settings modified" command (PR #152338)

2025-08-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/152338 >From a298abcf82d56a1ccc10b6bc4ac0fd11765ba1a6 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 15:37:30 -0700 Subject: [PATCH] [lldb] Add "settings modified" command --- .../lldb/Interpreter/

[Lldb-commits] [lldb] wip: add "settings modified" command (PR #152338)

2025-08-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/152338 None >From aa9613b6e7a328af6764184e5bbd4a0f33a6d16f Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 15:37:30 -0700 Subject: [PATCH] wip: add "settings modified" command --- .../lldb/Interpre

[Lldb-commits] [lldb] [lldb] Use const ref for looping over frame recognizers (NFC) (PR #152334)

2025-08-06 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/152334 None >From e7ea7c066193c52700035a87a4ee08950c21da99 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 15:39:17 -0700 Subject: [PATCH] [lldb] Use const ref for looping over frame recognizers (NFC

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/152201 >From 90eaf547090690c6250fa36937c0f07b170eb8bb Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 13:34:50 -0700 Subject: [PATCH 1/4] [lldb] Preserve original symbol of Mangled function names ---

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152201 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/152201 >From 90eaf547090690c6250fa36937c0f07b170eb8bb Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 13:34:50 -0700 Subject: [PATCH 1/3] [lldb] Preserve original symbol of Mangled function names ---

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152201 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/152201 >From 90eaf547090690c6250fa36937c0f07b170eb8bb Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 13:34:50 -0700 Subject: [PATCH 1/2] [lldb] Preserve original symbol of Mangled function names ---

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/152201 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Preserve original symbol of Mangled function names (PR #152201)

2025-08-05 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/152201 None >From 90eaf547090690c6250fa36937c0f07b170eb8bb Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Tue, 5 Aug 2025 13:34:50 -0700 Subject: [PATCH] [lldb] Preserve original symbol of Mangled function names -

[Lldb-commits] [lldb] [lldb] Add stop_reason Python property to SBThread (PR #151568)

2025-07-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/151568 >From e6016cf51e315fd894382c0c76ffbd5e3fc3ac04 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 31 Jul 2025 10:53:48 -0700 Subject: [PATCH 1/2] [lldb] Add stop_reason Python property to SBThread --- lldb

[Lldb-commits] [lldb] [lldb] Add stop_reason Python property to SBThread (PR #151568)

2025-07-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/151568 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add stop_reason Python property to SBThread (PR #151568)

2025-07-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/151568 None >From e6016cf51e315fd894382c0c76ffbd5e3fc3ac04 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Thu, 31 Jul 2025 10:53:48 -0700 Subject: [PATCH] [lldb] Add stop_reason Python property to SBThread --- ll

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-31 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/151374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/151374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/151374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione edited https://github.com/llvm/llvm-project/pull/151374 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-30 Thread Dave Lee via lldb-commits
@@ -186,8 +182,11 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, expr); } - dump_val_object(*valobj_sp); - return; + bool failed = errorToBool(dump_val_object(*valobj_sp)); kastiglione wro

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-30 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/151374 >From d4b65cbf4f45fd92950e1660087b72ca39369b44 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Wed, 30 Jul 2025 11:33:28 -0700 Subject: [PATCH 1/2] [lldb] Fallback to expression eval when Dump of variable fai

[Lldb-commits] [lldb] [lldb] Fallback to expression eval when Dump of variable fails in dwim-print (PR #151374)

2025-07-30 Thread Dave Lee via lldb-commits
@@ -186,8 +182,11 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command, expr); } - dump_val_object(*valobj_sp); - return; + bool failed = errorToBool(dump_val_object(*valobj_sp)); kastiglione wro

[Lldb-commits] [lldb] [lldb][NFC] Small fixes identified by the clang static analyzer (PR #148773)

2025-07-15 Thread Dave Lee via lldb-commits
@@ -539,6 +540,8 @@ static Status HandleFileAction(ProcessLaunchInfo &launch_info, : "unable to launch"); } + [env_dict release]; + [options release]; kastiglione wrote: I wonder if these objc++ files ca

[Lldb-commits] [lldb] [lldb][NFC] Small fixes identified by the clang static analyzer (PR #148773)

2025-07-15 Thread Dave Lee via lldb-commits
@@ -289,12 +286,8 @@ void LanguageRuntime::InitializeCommands(CommandObject *parent) { if (!parent->IsMultiwordObject()) return; - LanguageRuntimeCreateInstance create_callback; - for (uint32_t idx = 0; - (create_callback = -PluginManager::GetLangu

[Lldb-commits] [lldb] [lldb] Fix AppleObjCDeclVendor for classes which have no methods (PR #145452)

2025-06-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione closed https://github.com/llvm/llvm-project/pull/145452 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix AppleObjCDeclVendor for classes which have no methods (PR #145452)

2025-06-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/145452 >From 57857bf2749a2801e9c4fb840a984a483ced6a44 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 23 Jun 2025 20:36:38 -0700 Subject: [PATCH 1/3] [lldb] Fix AppleObjCDeclVendor for classes which have no met

[Lldb-commits] [lldb] [lldb] Fix AppleObjCDeclVendor for classes which have no methods (PR #145452)

2025-06-24 Thread Dave Lee via lldb-commits
https://github.com/kastiglione updated https://github.com/llvm/llvm-project/pull/145452 >From 57857bf2749a2801e9c4fb840a984a483ced6a44 Mon Sep 17 00:00:00 2001 From: Dave Lee Date: Mon, 23 Jun 2025 20:36:38 -0700 Subject: [PATCH 1/2] [lldb] Fix AppleObjCDeclVendor for classes which have no met

[Lldb-commits] [lldb] [lldb] Show more children of top level values (PR #140938)

2025-06-05 Thread Dave Lee via lldb-commits
kastiglione wrote: @jimingham is the updated description for `max-children-count` sufficient? https://github.com/llvm/llvm-project/pull/140938 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lld

  1   2   3   4   5   6   7   8   >