https://github.com/kastiglione created https://github.com/llvm/llvm-project/pull/154572
None >From 9e56a63771919e53ed7228adab394f61b1d1a5ba Mon Sep 17 00:00:00 2001 From: Dave Lee <davelee....@gmail.com> Date: Tue, 19 Aug 2025 21:59:05 -0700 Subject: [PATCH] [lldb] Remove unused XcodeSDK::SupportsSwift (NFC) --- lldb/include/lldb/Utility/XcodeSDK.h | 2 -- lldb/source/Utility/XcodeSDK.cpp | 23 ----------------------- lldb/unittests/Utility/XcodeSDKTest.cpp | 11 ----------- 3 files changed, 36 deletions(-) diff --git a/lldb/include/lldb/Utility/XcodeSDK.h b/lldb/include/lldb/Utility/XcodeSDK.h index a1a0ec415b90e..5b345a4965cf9 100644 --- a/lldb/include/lldb/Utility/XcodeSDK.h +++ b/lldb/include/lldb/Utility/XcodeSDK.h @@ -86,8 +86,6 @@ class XcodeSDK { Type GetType() const; llvm::StringRef GetString() const; const FileSpec &GetSysroot() const; - /// Whether this Xcode SDK supports Swift. - bool SupportsSwift() const; /// Whether LLDB feels confident importing Clang modules from this SDK. static bool SDKSupportsModules(Type type, llvm::VersionTuple version); diff --git a/lldb/source/Utility/XcodeSDK.cpp b/lldb/source/Utility/XcodeSDK.cpp index eb2047e67c326..2040791882fd0 100644 --- a/lldb/source/Utility/XcodeSDK.cpp +++ b/lldb/source/Utility/XcodeSDK.cpp @@ -243,29 +243,6 @@ bool XcodeSDK::SDKSupportsModules(XcodeSDK::Type sdk_type, return false; } -bool XcodeSDK::SupportsSwift() const { - XcodeSDK::Info info = Parse(); - switch (info.type) { - case Type::MacOSX: - return info.version.empty() || info.version >= llvm::VersionTuple(10, 10); - case Type::iPhoneOS: - case Type::iPhoneSimulator: - return info.version.empty() || info.version >= llvm::VersionTuple(8); - case Type::AppleTVSimulator: - case Type::AppleTVOS: - return info.version.empty() || info.version >= llvm::VersionTuple(9); - case Type::WatchSimulator: - case Type::watchOS: - return info.version.empty() || info.version >= llvm::VersionTuple(2); - case Type::XROS: - case Type::XRSimulator: - case Type::Linux: - return true; - default: - return false; - } -} - bool XcodeSDK::SDKSupportsModules(XcodeSDK::Type desired_type, const FileSpec &sdk_path) { ConstString last_path_component = sdk_path.GetFilename(); diff --git a/lldb/unittests/Utility/XcodeSDKTest.cpp b/lldb/unittests/Utility/XcodeSDKTest.cpp index 4db6a50fcf860..de9f91a04d53e 100644 --- a/lldb/unittests/Utility/XcodeSDKTest.cpp +++ b/lldb/unittests/Utility/XcodeSDKTest.cpp @@ -102,17 +102,6 @@ TEST(XcodeSDKTest, SDKSupportsModules) { } #endif -TEST(XcodeSDKTest, SDKSupportsSwift) { - EXPECT_TRUE(XcodeSDK("iPhoneSimulator12.0.sdk").SupportsSwift()); - EXPECT_TRUE(XcodeSDK("iPhoneSimulator12.0.Internal.sdk").SupportsSwift()); - EXPECT_FALSE(XcodeSDK("iPhoneSimulator7.2.sdk").SupportsSwift()); - EXPECT_TRUE(XcodeSDK("MacOSX10.10.sdk").SupportsSwift()); - EXPECT_FALSE(XcodeSDK("MacOSX10.9.sdk").SupportsSwift()); - EXPECT_TRUE(XcodeSDK("Linux.sdk").SupportsSwift()); - EXPECT_TRUE(XcodeSDK("MacOSX.sdk").SupportsSwift()); - EXPECT_FALSE(XcodeSDK("EverythingElse.sdk").SupportsSwift()); -} - TEST(XcodeSDKTest, GetCanonicalNameAndConstruct) { XcodeSDK::Info info; info.type = XcodeSDK::Type::MacOSX; _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits