[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr added a comment. In https://reviews.llvm.org/D35065#803602, @brunoalr wrote: > @labath @joerg @krytarowski thanks for the review. Can anyone commit this, > please? I still don't have commit privileges. thanks, @labath Repository: rL LLVM https://reviews.llvm.org/D35065 __

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr added a comment. @labath @joerg thanks for the review. Can anyone commit this, please? I still don't have commit privileges. https://reviews.llvm.org/D35065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cg

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr updated this revision to Diff 105640. brunoalr added a comment. Small fix https://reviews.llvm.org/D35065 Files: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYL

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr updated this revision to Diff 105639. brunoalr added a comment. Use string+5 instead of concatenation https://reviews.llvm.org/D35065 Files: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h source/Plugins/DynamicLoader/POSI

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr updated this revision to Diff 105638. brunoalr added a comment. Applying suggestions from review https://reviews.llvm.org/D35065 Files: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h source/Plugins/DynamicLoader/POSIX-DYL

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:115 _type: \ name = #_type switch (type) { joerg wrote: > labath wrote: > > If we go

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h:46 + /// Added AUXV prefix because some targets already define names such as + /// AT_DCACHEBSIZE in system headers enum EntryType { joerg wrote: > I think most t

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr updated this revision to Diff 105517. brunoalr added a comment. Add comments https://reviews.llvm.org/D35065 Files: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIX

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr updated this revision to Diff 105515. brunoalr added a comment. Fixing replace mistake. https://reviews.llvm.org/D35065 Files: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h source/Plugins/DynamicLoader/POSIX-DYLD/Dynamic

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr updated this revision to Diff 105514. brunoalr added a comment. Renaming enum consistently and updating name ENTRY_NAME macro to correctly assign the standard names of aux vector entries. https://reviews.llvm.org/D35065 Files: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp s

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr marked 2 inline comments as done. brunoalr added a comment. In https://reviews.llvm.org/D35065#800906, @joerg wrote: > If you want to go this way, rename them consistently and use a different > prefix (e.g. AUXV_*) please. Wiil do. https://reviews.llvm.org/D35065

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr marked an inline comment as done. brunoalr added inline comments. Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp:11 // C Includes #include #include labath wrote: > Do you still get the error if you remove these includes? > > As f

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr added a comment. In https://reviews.llvm.org/D35065#800877, @krytarowski wrote: > What are the build failures? [2397/3183] Building CXX object tools/lldb/source/Plugins/DynamicLoader/POSIX-DYLD/CMakeFiles/lldbPluginDynamicLoaderPosixDYLD.dir/AuxVector.cpp.o FAILED: tools/lldb/s

[Lldb-commits] [PATCH] D35065: [LLDB][ppc64le] Rename enums in AuxVector

brunoalr added a comment. In https://reviews.llvm.org/D35065#800852, @krytarowski wrote: > Values like AT_NULL are macros on NetBSD and there are no problems? I haven't tested in ppc64le on NetBSD, but I'm afraid the same problems would occur. https://reviews.llvm.org/D35065 _

[Lldb-commits] [PATCH] D35065: Rename enums in AuxVector

brunoalr added reviewers: mikesart, labath. brunoalr added a comment. Adding Code Owner (Pavel Labeth) and responsible for the relevant changes (Michael Sartain). https://reviews.llvm.org/D35065 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D35065: Rename enums in AuxVector

brunoalr created this revision. On linux on ppc64le some of the enums in AuxVector have the same name as macros defined in the system. https://reviews.llvm.org/D35065 Files: source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.cpp source/Plugins/DynamicLoader/POSIX-DYLD/AuxVector.h source/Pl