[Lldb-commits] [PATCH] D60968: WIP, RFC: Add an example of how LLDB python plug-in could look like

apolyakov abandoned this revision. apolyakov added a comment. Abandoned since for now, it will require a lot of changes to the codebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60968/new/ https://reviews.llvm.org/D60968 ___

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

apolyakov abandoned this revision. apolyakov added a comment. Herald added a subscriber: JDevlieghere. Abandoned since the patch is outdated too much. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D50525/new/ https://reviews.llvm.org/D50525 __

[Lldb-commits] [PATCH] D60968: WIP, RFC: Add an example of how LLDB python plug-in could look like

apolyakov added a comment. Gentle ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60968/new/ https://reviews.llvm.org/D60968 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D60968: WIP, RFC: Add an example of how LLDB python plug-in could look like

apolyakov marked an inline comment as done. apolyakov added a comment. In D60968#1474470 , @clayborg wrote: > Not sure what functionality this really adds? It seems to just wrap the OS > plug-in python class in a different way? You are right, for now th

[Lldb-commits] [PATCH] D60968: WIP, RFC: Add an example of how LLDB python plug-in could look like

apolyakov created this revision. apolyakov added reviewers: jingham, aprantl, labath. Herald added a project: LLDB. This commit shows how LLDB python plug-in could look like. Such an approach allows users to use LLDB for OS kernel debugging, for doing that they only need to implement two interfa

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

apolyakov accepted this revision. apolyakov added a comment. This revision is now accepted and ready to land. LGTM. https://reviews.llvm.org/D52953 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

apolyakov added a comment. Here it is: build/bin/llvm-lit -avv llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test -- Testing: 1 tests, 1 threads -- FAIL: lldb :: tools/lldb-mi/breakpoint/break-insert-enable-pending.test (1 of 1) TEST 'lldb

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

apolyakov added a comment. I only have these options: build/bin/llvm-lit -avv --dump-input-on-failure llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test usage: llvm-lit [-h] [--version] [-j N] [--config-prefix NAME] [-D NAME=VAL] [-q] [-s] [-v] [

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

apolyakov added a comment. I ran the test and got a fail: build/bin/llvm-lit -avv llvm/tools/lldb/lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test -- Testing: 1 tests, 1 threads -- FAIL: lldb :: tools/lldb-mi/breakpoint/break-insert-enable-pending.test (1 of 1) ***

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

apolyakov added inline comments. Comment at: lit/tools/lldb-mi/breakpoint/break-insert-enable-pending.test:4 +# +# RUN: %cc -o b.exe %p/inputs/break-insert-pending.c -g +# RUN: %lldbmi < %s | FileCheck %s As far as your first command is `file-exec-and-symbols`, t

[Lldb-commits] [PATCH] D52953: [lldb-mi] Implement -gdb-set breakpoint pending on/off

apolyakov added a comment. I think that it's worth it to rewrite the test with LIT and FileCheck because the python approach has some limitations, e.g. timeouts. You can find examples in `lldb/lit/tools/lldb-mi/`. Comment at: tools/lldb-mi/MICmdCmdGdbShow.cpp:369 +const C

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

This revision was automatically updated to reflect the committed changes. Closed by commit rLLDB343033: [lldb-mi] Fix bugs in target-select-so-path.test (authored by apolyakov, committed by ). Repository: rLLDB LLDB https://reviews.llvm.org/D52498 Files: lit/tools/lldb-mi/target/inputs/targ

[Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

apolyakov marked an inline comment as done. apolyakov added inline comments. Comment at: lit/tools/lldb-mi/target/target-select-so-path.test:4 +# RUN: %cc -o %t %p/inputs/main.c -g +# RUN: python %p/inputs/target-select-so-path.py "%debugserver" "%lldbmi %t" %s +

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

apolyakov updated this revision to Diff 166953. apolyakov edited the summary of this revision. apolyakov added a comment. Changed the test to use `%python` variable instead of `python` https://reviews.llvm.org/D52498 Files: lit/tools/lldb-mi/target/inputs/target-select-so-path.py lit/tools/

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

apolyakov updated this revision to Diff 166936. apolyakov added a comment. Changed python version required to use 'pass_fds' argument to 3.2. I tested this patch with python 2.7 and 3.5. https://reviews.llvm.org/D52498 Files: lit/tools/lldb-mi/target/inputs/target-select-so-path.py Index: l

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

apolyakov updated this revision to Diff 166919. apolyakov added a comment. Removed the shebang line since we call the script via `python ...` so that line doesn't matter. https://reviews.llvm.org/D52498 Files: lit/tools/lldb-mi/target/inputs/target-select-so-path.py Index: lit/tools/lldb-m

[Lldb-commits] [PATCH] D52498: [lldb-mi] Fix bugs in target-select-so-path.test

apolyakov created this revision. apolyakov added reviewers: teemperor, labath, tatyana-krasnukha, aprantl. Herald added a subscriber: ki.stfu. This patch fixes hanging of the test in case of using python3, changes callback function that will be called if the timer ends; Also, the test didn't work

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov added a comment. Thanks Pavel, I fixed it here https://reviews.llvm.org/D52498. Repository: rL LLVM https://reviews.llvm.org/D52139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

This revision was automatically updated to reflect the committed changes. Closed by commit rL342915: [lldb-mi] Fix hanging of target-select-so-path.test (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52139?vs=1

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov updated this revision to Diff 166714. apolyakov added a comment. Reduced timer from 120 to 30 seconds. https://reviews.llvm.org/D52139 Files: lit/tools/lldb-mi/target/inputs/target-select-so-path.py Index: lit/tools/lldb-mi/target/inputs/target-select-so-path.py ==

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov added a comment. If so, we can try to run the script with python2.x. @teemperor can you try to modify `target-select-so-path.test` this way: change `# RUN: python %p/inputs/target-select-so-path.py "%debugserver" "%lldbmi %t" %s` to `# RUN: python2 %p/inputs/target-select-so-path.py "

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov added a comment. AFAIR, adding an `exit(...)` to `ConnectToRemote` won't solve this problem. The test will still be failing on Arch. https://reviews.llvm.org/D52139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.ll

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov added a comment. Do you mean `ConnectToRemote` method from `lldb/tools/lldb-server/lldb-gdbserver.cpp`? https://reviews.llvm.org/D52139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov added a comment. In https://reviews.llvm.org/D52139#1240835, @apolyakov wrote: > Can you provide some logs? For example, you might be able to run this test > (llvm-lit -a -vv .../target-select-so-path.test) and kill lldb-mi and > filecheck processes if they hang. Also, information abo

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov updated this revision to Diff 166337. apolyakov edited the summary of this revision. apolyakov added a comment. Thanks to @tatyana-krasnukha for the idea about a timer. Added a timer to target-select-so-path test. https://reviews.llvm.org/D52139 Files: lit/tools/lldb-mi/target/inpu

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov added a comment. Can you provide some logs? For example, you might be able to run this test (llvm-lit -a -vv .../target-select-so-path.test) and kill lldb-mi and filecheck processes if they hang. Also, information about which processes hang would be useful too (lldb-mi or filecheck or

[Lldb-commits] [PATCH] D52139: [lldb-mi] Fix hanging of target-select-so-path.test

apolyakov updated this revision to Diff 166290. apolyakov retitled this revision from "[lldb-mi] Improve lldb-mi LIT tests" to "[lldb-mi] Fix hanging of target-select-so-path.test". apolyakov edited the summary of this revision. apolyakov added a comment. I found out that the reason of hanging of

[Lldb-commits] [PATCH] D52139: [lldb-mi] Improve lldb-mi LIT tests

apolyakov added a comment. It seems reasonable, I'll look at this. Repository: rLLDB LLDB https://reviews.llvm.org/D52139 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D52139: [lldb-mi] Improve lldb-mi LIT tests

apolyakov created this revision. apolyakov added reviewers: tatyana-krasnukha, aprantl. Herald added subscribers: abidh, ki.stfu. The test suite might hang on some platforms if an lldb-mi test fails. Adding of -gdb-exit command to a test prevents it from hanging and hence increase test suite relia

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

apolyakov added a comment. In https://reviews.llvm.org/D48802#1234892, @tatyana-krasnukha wrote: > symbol-list-lines.test fails on Linux too, input is compiled with gcc. Thanks for noting this. Fixed in r342329 (https://reviews.llvm.org/D52101). Repository: rL LLVM https://reviews.llvm.org

[Lldb-commits] [PATCH] D52101: [lldb-mi] Correct regex in the symbol-list-lines test

This revision was automatically updated to reflect the committed changes. Closed by commit rL342329: [lldb-mi] Correct regex in the symbol-list-lines test (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52101?vs

[Lldb-commits] [PATCH] D52101: [lldb-mi] Correct regex in the symbol-list-lines test

apolyakov added a comment. I've created this revision to be sure that you don't think that this approach is some kind of hack. Repository: rLLDB LLDB https://reviews.llvm.org/D52101 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

[Lldb-commits] [PATCH] D52101: [lldb-mi] Correct regex in the symbol-list-lines test

apolyakov created this revision. apolyakov added reviewers: tatyana-krasnukha, aprantl, clayborg. Herald added a subscriber: ki.stfu. The test failed in case of compiling a test suite with gcc (checked versions are 5.2.0 and 7.3.0) because it adds one more line entry comparing to clang. It doesn't

[Lldb-commits] [PATCH] D51594: [ARC] Make char unsigned by default

This revision was automatically updated to reflect the committed changes. Closed by commit rL341667: [ARC] Make char unsigned by default (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D51594?vs=163710&id=164419#

[Lldb-commits] [PATCH] D51594: [ARC] Make char unsigned by default

apolyakov created this revision. apolyakov added a reviewer: tatyana-krasnukha. This patch specifies 'char' default sign on ARC. Repository: rLLDB LLDB https://reviews.llvm.org/D51594 Files: source/Utility/ArchSpec.cpp Index: source/Utility/ArchSpec.cpp ==

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

apolyakov added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/target-list.test:18 +target list +# CHECK: ~"Current targets:\n* target #0: {{.*}}a.exe{{.*}}\n" + aprantl wrote: > Does lldb-mi echo the comment lines? If yes, you need to be

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

apolyakov added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s stella.stamenova wrote: > apolyakov wrote: > > stella.stamenova wrote:

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

apolyakov added inline comments. Comment at: lit/tools/lldb-mi/interpreter/cli-support/breakpoint-set.test:4 +# +# RUN: %cxx -o %t %p/inputs/main.cpp -g +# RUN: %lldbmi %t < %s | FileCheck %s stella.stamenova wrote: > One thing to consider here is that any extra

[Lldb-commits] [PATCH] D50525: [WIP] Move lldb-mi interpreter tests to LIT

apolyakov created this revision. apolyakov added reviewers: aprantl, clayborg, jingham, labath. Herald added a subscriber: ki.stfu. In this patch I move some of interpreter tests from python to LIT(I will move all interpreter test if these are OK). It's a WIP since I want to get your opinion abo

[Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

apolyakov added a comment. I think those options don't fit. I'm looking for behavior like this: ~/workspace/gsoc/build/bin/lldb-server gdbserver --pipe 1 localhost:0 36251 Here lldb-server prints out the port number he is listening on and continues running. If debugserver can choose a tcp

[Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

apolyakov added a subscriber: t.p.northover. apolyakov added a comment. It seems that `target-select-so-path.test` hangs on macOS. Thanks to @t.p.northover for noting this. The debugserver doesn't have `--pipe` option, so on macOS it fails to start and the test hangs waiting for output from de

[Lldb-commits] [PATCH] D47302: [WIP] New class SBTargetSettings to store and manipulate all target's properties.

polyakov.alex abandoned this revision. polyakov.alex added a comment. Abandoned since suggested functionality is already done in https://reviews.llvm.org/D49739. https://reviews.llvm.org/D47302 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

apolyakov added a comment. Sure, will do it. Repository: rL LLVM https://reviews.llvm.org/D49739 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

This revision was automatically updated to reflect the committed changes. Closed by commit rL339175: Add new API to SBTarget class (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49739?vs=159582&id=159587#toc R

[Lldb-commits] [PATCH] D49739: Add new API to SBTarget class

apolyakov updated this revision to Diff 159582. apolyakov retitled this revision from "[WIP] Re-implement MI target-select command." to "Add new API to SBTarget class". apolyakov edited the summary of this revision. apolyakov added a comment. Splitted the patch into two parts: this part with the

[Lldb-commits] [PATCH] D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended.

This revision was automatically updated to reflect the committed changes. Closed by commit rL339160: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended. (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49

[Lldb-commits] [PATCH] D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended.

apolyakov added a comment. @clayborg can you explain what are you worry about because I don't completely understand you? As I said, all lldb-mi commands print their result to STDOUT, AFAIK, an IDE should parse it and then show in a GUI. https://reviews.llvm.org/D49632 __

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov updated this revision to Diff 158377. apolyakov added a comment. Changed the order of `if` statements to follow llvm coding standards. https://reviews.llvm.org/D49739 Files: include/lldb/API/SBTarget.h lit/lit.cfg lit/tools/lldb-mi/target/inputs/main.c lit/tools/lldb-mi/target

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov added inline comments. Comment at: source/API/SBTarget.cpp:1467 + } + const ConstString csFrom(from), csTo(to); + if (csFrom && csTo) { aprantl wrote: > apolyakov wrote: > > aprantl wrote: > > > personally I would write this as: > > > ``` > > > if (!

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov added inline comments. Comment at: source/API/SBTarget.cpp:1467 + } + const ConstString csFrom(from), csTo(to); + if (csFrom && csTo) { aprantl wrote: > personally I would write this as: > ``` > if (!csFrom) > return error.SetErrorString(" path is

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov updated this revision to Diff 158330. apolyakov added a comment. Made error handling more meaningful: added different error messages for cases - empty path and empty path. https://reviews.llvm.org/D49739 Files: include/lldb/API/SBTarget.h lit/lit.cfg lit/tools/lldb-mi/target/

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov updated this revision to Diff 158319. apolyakov added a comment. Added converting from `const char *` to `ConstString`, documented new API. https://reviews.llvm.org/D49739 Files: include/lldb/API/SBTarget.h lit/lit.cfg lit/tools/lldb-mi/target/inputs/main.c lit/tools/lldb-mi/t

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov added inline comments. Comment at: source/API/SBTarget.cpp:1468 + } + if (from[0] && to[0]) { +Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_API)); aprantl wrote: > apolyakov wrote: > > I didn't find nullptr check in other API functi

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov added a comment. OK, thank you for respond. Then, I think, we should wait for review from @clayborg or @aprantl, and if they accept the patch I'll divide it into two parts: SB API part and target-select one. https://reviews.llvm.org/D49739 _

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov added a comment. So, do you have any thoughts about this approach letting the debugserver choose a tcp port and patch overall? https://reviews.llvm.org/D49739 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org

[Lldb-commits] [PATCH] D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended.

apolyakov added a comment. In https://reviews.llvm.org/D49632#1180465, @clayborg wrote: > I still don't get why we are printing process stopped information to STDOUT. > MI is a machine interface for a IDE. The IDE should be showing the process > state in the GUI. AFAIK, all lldb-mi commands p

[Lldb-commits] [PATCH] D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended.

apolyakov updated this revision to Diff 157533. apolyakov retitled this revision from "[WIP] Re-implement MI HandleProcessEventStateSuspended." to "[lldb-mi] Re-implement MI HandleProcessEventStateSuspended.". apolyakov added a comment. It seems that it's impossible to get `HandleProcessEventSta

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov updated this revision to Diff 157512. apolyakov added a comment. Now tcp port is choosing by debugserver. https://reviews.llvm.org/D49739 Files: include/lldb/API/SBTarget.h lit/lit.cfg lit/tools/lldb-mi/target/inputs/main.c lit/tools/lldb-mi/target/inputs/target-select-so-path

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov added inline comments. Comment at: lit/tools/lldb-mi/target/inputs/target-select-so-path.py:8-11 +def get_free_port(): +s = socket.socket() +s.bind(('', 0)) +return s.getsockname()[1] labath wrote: > apolyakov wrote: > > labath wrote: > > >

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov added inline comments. Comment at: lit/tools/lldb-mi/target/inputs/target-select-so-path.py:8-11 +def get_free_port(): +s = socket.socket() +s.bind(('', 0)) +return s.getsockname()[1] labath wrote: > apolyakov wrote: > > labath wrote: > > >

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov added inline comments. Comment at: lit/tools/lldb-mi/target/inputs/target-select-so-path.py:8-11 +def get_free_port(): +s = socket.socket() +s.bind(('', 0)) +return s.getsockname()[1] labath wrote: > This is still racy, because the port can

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov added inline comments. Comment at: lit/lit.cfg:59 -debugserver = lit.util.which('debugserver', lldb_tools_dir) +if platform.system() in ['Darwin']: +debugserver = lit.util.which('debugserver', lldb_tools_dir) Do we have `debugserver` only on macOS

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov updated this revision to Diff 157310. apolyakov added a comment. Moved test from bash to python, removed unnecessary `Target::AppendImageSearchPath`. https://reviews.llvm.org/D49739 Files: include/lldb/API/SBTarget.h lit/lit.cfg lit/tools/lldb-mi/target/inputs/main.c lit/tool

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov added a comment. Thanks, I used this `lldb-server gdbserver --pipe 0 localhost:0` and got a port chosen by debugserver. But to let lldb-mi know about this port we need an additional script, is python a good choice for that? https://reviews.llvm.org/D49739 _

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov added a comment. `packages/Python/lldbsuite/test/tools/lldb-mi/signal/TestMiSignal.py` test contains `port = 12000 + random.randint(0, 3999)`. https://reviews.llvm.org/D49739 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov added a comment. What do you think about running tests with a hardcoded port number(as it's done in a web-services). Doing this, we get rid of additional scripts and os-specific things. AFAIK, debugserver even has its own default port. P.S. As I saw in the lldb-mi python tests, port n

[Lldb-commits] [PATCH] D49739: [WIP] Re-implement MI target-select command.

apolyakov created this revision. apolyakov added reviewers: aprantl, clayborg, labath. Herald added a subscriber: ki.stfu. In this patch I suggest a way to deal with the problem started in https://reviews.llvm.org/D47302 and use it to re-implement MI target-select command. You are welcome to com

[Lldb-commits] [PATCH] D47302: [WIP] New class SBTargetSettings to store and manipulate all target's properties.

apolyakov added a comment. In https://reviews.llvm.org/D47302#1171639, @clayborg wrote: > We could end up moving anything that is set by a target property into the > lldb_private target property class if it isn't already there and then that > would fix things. If you remember, we started this

[Lldb-commits] [PATCH] D49632: [WIP] Re-implement MI HandleProcessEventStateSuspended.

apolyakov added a comment. You mean that it's unreasonable to provide such an output to stdout since MI clients are text redactors, IDE and not people? https://reviews.llvm.org/D49632 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:/

[Lldb-commits] [PATCH] D47302: [WIP] New class SBTargetSettings to store and manipulate all target's properties.

apolyakov added a comment. Another approach is to implement SBTargetSettings' functionality such as serialization inside lldb_private TargetProperties class and then just add an API to the SBTarget. For example: `void SBTarget::SerializeProperties(...)` What do you think about this way? https

[Lldb-commits] [PATCH] D49062: [lldb-mi] Re-implement data-info-line command.

This revision was automatically updated to reflect the committed changes. Closed by commit rL337689: [lldb-mi] Re-implement data-info-line command. (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49062?vs=156299

[Lldb-commits] [PATCH] D49632: [WIP] Re-implement MI HandleProcessEventStateSuspended.

apolyakov added a comment. In https://reviews.llvm.org/D49632#1171024, @clayborg wrote: > So with CMICmnLLDBDebuggerHandleEvents::HandleProcessEventStateSuspended() it > will report a bunch of text back through the MI interface with this each > time? Why would it do that? I would assume that th

[Lldb-commits] [PATCH] D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended.

apolyakov added inline comments. Comment at: tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.cpp:963 +sbProcess.GetDescription(streamOut); +for (uint32_t i = 0, e = sbProcess.GetNumThreads(); i < e; ++i) { + const lldb::SBThread thread = sbProcess.GetThreadAtIndex(i); --

[Lldb-commits] [PATCH] D49632: [lldb-mi] Re-implement MI HandleProcessEventStateSuspended.

apolyakov created this revision. apolyakov added reviewers: aprantl, clayborg, labath. Herald added a subscriber: ki.stfu. Now this function uses SB API instead of HandleCommand. https://reviews.llvm.org/D49632 Files: tools/lldb-mi/MICmnLLDBDebuggerHandleEvents.cpp Index: tools/lldb-mi/MICm

[Lldb-commits] [PATCH] D49062: [lldb-mi] Re-implement data-info-line command.

apolyakov updated this revision to Diff 156299. apolyakov added a comment. Converted data-info-line python test to a lit one. https://reviews.llvm.org/D49062 Files: lit/tools/lldb-mi/data/data-info-line.test lit/tools/lldb-mi/data/inputs/data-info-line.c lit/tools/lldb-mi/data/lit.local.c

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

apolyakov added a comment. @stella.stamenova Done in r337064. Repository: rL LLVM https://reviews.llvm.org/D48802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49062: [lldb-mi] Re-implement data-info-line command.

apolyakov added a comment. It would be good to convert to LIT as more tests as we can. I'll do this in one of a next patches. Let's continue with this one? https://reviews.llvm.org/D49062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

apolyakov added a comment. In https://reviews.llvm.org/D48802#1161904, @stella.stamenova wrote: > @apolyakov Perhaps we can mark the test as XFAIL on Windows while you > investigate. Any objections? Sure, I'll do it. Repository: rL LLVM https://reviews.llvm.org/D48802 _

[Lldb-commits] [PATCH] D49062: [lldb-mi] Re-implement data-info-line command.

apolyakov added inline comments. Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/data/TestMiData.py:22 @skipIfDarwin # pexpect is known to be unreliable on Darwin @skipIfFreeBSD # llvm.org/pr22411: Failure presumably due to known thread races def test_

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

apolyakov added a comment. Could you please provide an output of this command on Windows: `E:\_work\4\b\LLVMBuild\Release\bin\lldb-mi.EXE --synchronous E:\_work\4\b\LLVMBuild\tools\lldb\lit\tools\lldb-mi\symbol\Output\symbol-list-lines.test.tmp < E:\_work\4\s\llvm\tools\lldb\lit\tools\lldb-mi\

[Lldb-commits] [PATCH] D49062: [lldb-mi] Re-implement data-info-line command.

apolyakov added inline comments. Comment at: tools/lldb-mi/MICmdCmdData.cpp:1691 +break; + for (uint32_t j = 0, e = cu.GetNumLineEntries(); j < e; ++j) { +const lldb::SBLineEntry &curLine = cu.GetLineEntryAtIndex(j); aprantl wrote: > @claybor

[Lldb-commits] [PATCH] D49062: [lldb-mi] Re-implement data-info-line command.

apolyakov updated this revision to Diff 154623. apolyakov added a comment. Returned accidentally removed backslashes in `self.expect` pattern, removed comment from: `#include // For std::to_string.` https://reviews.llvm.org/D49062 Files: packages/Python/lldbsuite/test/tools/lldb-mi/data/Tes

[Lldb-commits] [PATCH] D49062: [lldb-mi] Re-implement data-info-line command.

apolyakov created this revision. apolyakov added reviewers: aprantl, clayborg. Herald added a subscriber: ki.stfu. Now data-info-line command uses SB API instead of HandleCommand. https://reviews.llvm.org/D49062 Files: packages/Python/lldbsuite/test/tools/lldb-mi/data/TestMiData.py tools/ll

[Lldb-commits] [PATCH] D49006: Add LLDB_API to SBAddress's operator==

This revision was automatically updated to reflect the committed changes. Closed by commit rL336494: Add LLDB_API to SBAddress's operator==. (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D49006?vs=154360&id=154

[Lldb-commits] [PATCH] D49006: Add LLDB_API to SBAddress's operator==

apolyakov added a comment. Unfortunately, I don't have an opportunity to check this out on windows, but if this works, I'll be glad that someone found out how to fix compilation failure on windows. https://reviews.llvm.org/D49006 ___ lldb-commits

[Lldb-commits] [PATCH] D49006: Add LLDB_API to SBAddress's operator==

apolyakov accepted this revision. apolyakov added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D49006 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

This revision was automatically updated to reflect the committed changes. Closed by commit rL336206: [lldb-mi] Re-implement symbol-list-lines command. (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48802?vs=153

[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

This revision was automatically updated to reflect the committed changes. Closed by commit rL336200: Add new API to SBTarget and SBModule classes. (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48801?vs=153846&

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

apolyakov updated this revision to Diff 153847. apolyakov added a comment. Removed `sb_target.IsDummy()` since `IsDummy` won't be a member of SBTarget class. Now `sb_target == rSessionInfo.GetDebugger().GetDummyTarget()` is used for this goal. https://reviews.llvm.org/D48802 Files: lit/tool

[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

apolyakov updated this revision to Diff 153846. apolyakov added a comment. Updated passing an argument to `find_compile_units` function. https://reviews.llvm.org/D48801 Files: include/lldb/API/SBModule.h include/lldb/API/SBTarget.h packages/Python/lldbsuite/test/python_api/module_section

[Lldb-commits] [PATCH] D48775: Add new SBTarget::IsDummy method.

apolyakov abandoned this revision. apolyakov added a comment. Abandoned since suggested functionality is optional. https://reviews.llvm.org/D48775 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[Lldb-commits] [PATCH] D48775: Add new SBTarget::IsDummy method.

apolyakov added a comment. It's hard to choose something, both variants are good enough. But, if there is no necessity in such a method, we can drop it. https://reviews.llvm.org/D48775 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http:

[Lldb-commits] [PATCH] D48775: Add new SBTarget::IsDummy method.

apolyakov added a comment. I think we can remove comments added by me and commit patch as it is. Any thoughts about it? https://reviews.llvm.org/D48775 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

This revision was automatically updated to reflect the committed changes. Closed by commit rL336155: [lldb-mi] Re-implement a few MI commands. (authored by apolyakov, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D48520?vs=152715&id=1

[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

apolyakov added inline comments. Comment at: include/lldb/API/SBModule.h:136 + /// + /// @param[in] sb_file_spec + /// A lldb::SBFileSpec object that contains source file aprantl wrote: > We typically use `\param` instead of `@param` in LLVM. I did it like

[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

apolyakov added inline comments. Comment at: packages/Python/lldbsuite/test/python_api/target/TestTargetAPI.py:54 +self.setTearDownCleanup(dictionary=d) +self.find_compile_units('b.out') + aprantl wrote: > shouldn't this be `self.getBuildArtifact(

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

apolyakov updated this revision to Diff 153818. apolyakov added a comment. Removed `inline` keyword. https://reviews.llvm.org/D48802 Files: lit/tools/lldb-mi/symbol/inputs/list-lines-helper.c lit/tools/lldb-mi/symbol/inputs/list-lines-helper.h lit/tools/lldb-mi/symbol/inputs/main.c lit/

[Lldb-commits] [PATCH] D48801: Add new API to SBTarget and SBModule classes.

apolyakov updated this revision to Diff 153817. apolyakov added a comment. Added documentation and tests. https://reviews.llvm.org/D48801 Files: include/lldb/API/SBModule.h include/lldb/API/SBTarget.h packages/Python/lldbsuite/test/python_api/module_section/TestModuleAndSection.py pack

[Lldb-commits] [PATCH] D48520: [lldb-mi] Re-implement a few MI commands.

apolyakov added a comment. Update comment. It still needs a review, thanks for your time. https://reviews.llvm.org/D48520 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D48802: [lldb-mi] Re-implement symbol-list-lines command.

apolyakov added inline comments. Comment at: tools/lldb-mi/MICmdCmdSymbol.cpp:24 +namespace { +inline const CMICmnMIValueTuple +CreateMITuplePCLine(const uint32_t addr, const uint32_t line_number) { aprantl wrote: > Please remove the `inline` keyword. LLVM will i

  1   2   3   >