apolyakov added inline comments.
================
Comment at: source/API/SBTarget.cpp:1468
+ }
+ if (from[0] && to[0]) {
+ Log *log(lldb_private::GetLogIfAllCategoriesSet(LIBLLDB_LOG_API));
----------------
aprantl wrote:
> apolyakov wrote:
> > I didn't find nullptr check in other API functions, is it OK or it's better
> > to add it?
> I would convert it to a ConstString up front and then check whether the
> ConstString is empty. This way you don't have to worry about nullptr vs empty
> string.
Maybe then change method's signature from `const char *` to `ConstString`? I
haven't done this since in other methods strings are represented as pointers to
char, is it some rule for SB API or not?
https://reviews.llvm.org/D49739
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
