@@ -426,9 +426,12 @@ void RegisterContextUnwind::InitializeNonZerothFrame() {
}
}
-if (abi_sp) {
- m_fast_unwind_plan_sp.reset();
+m_fast_unwind_plan_sp.reset();
+m_full_unwind_plan_sp.reset();
bulbazord wrote:
Is it necessary to cl
bulbazord wrote:
> This change looks good to me. I might not have read it sufficiently closely,
> but the duplicate symbols we're looking at here are only when there are debug
> map entries for .o file debugging, maybe?
Possibly? I'm definitely doing .o debugging, didn't try with dSYMs at all.
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/155931
This change is motivated by performance. Creating ConstStrings can be expensive
and is a non-trivial amount of ObjectFileMachO::ParseSymtab. This patch reduces
the number of ConstStrings created.
LLDB relies
@@ -244,6 +266,7 @@ kern_return_t DNBArchMachARM64::GetGPRState(bool force) {
uint64_t log_sp = m_state.context.gpr.__sp;
uint64_t log_pc = m_state.context.gpr.__pc;
#endif
+uint64_t *x = &m_state.context.gpr.__x[0];
bulbazord wrote:
This line was
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/155282
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/155282
>From d4dc7c8612c0a939e86842270fdaf4a4573e8b8e Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Fri, 13 Sep 2024 10:33:43 -0700
Subject: [PATCH] [lldb] Do not use LC_FUNCTION_STARTS data to determine symbol
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/155282
Note: This is a resubmission of #106791. I had to revert this a year ago for a
failing test that I could not understand. I have time now to try and get this
in again.
Summary:
This improves the performance o
https://github.com/bulbazord approved this pull request.
I wouldn't say I'm an expert but I don't see any glaring issues here. LGTM
https://github.com/llvm/llvm-project/pull/154975
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists
@@ -340,11 +341,101 @@ def find_matching_slice(self):
print(
(
"error\nerror: unable to locate '%s' with UUID
%s"
-% (self.path, self.get_normalized_uuid_string())
+
@@ -340,11 +341,101 @@ def find_matching_slice(self):
print(
(
"error\nerror: unable to locate '%s' with UUID
%s"
-% (self.path, self.get_normalized_uuid_string())
+
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/154445
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -130,6 +130,38 @@ class MyRandomClass:
self.assertSuccess(example.SetFromJSON("null"))
self.assertEqual(example.GetType(), lldb.eStructuredDataTypeNull)
+example = lldb.SBStructuredData()
+example.SetUnsignedIntegerValue(1)
+self.asse
@@ -81,6 +81,40 @@ class StructuredDataImpl {
void SetObjectSP(const StructuredData::ObjectSP &obj) { m_data_sp = obj; }
+ void SetValueForKey(llvm::StringRef key,
+ const StructuredData::ObjectSP &value) {
+if (m_data_sp) {
+ if (StructuredDa
@@ -81,6 +81,40 @@ class StructuredDataImpl {
void SetObjectSP(const StructuredData::ObjectSP &obj) { m_data_sp = obj; }
+ void SetValueForKey(llvm::StringRef key,
+ const StructuredData::ObjectSP &value) {
+if (m_data_sp) {
+ if (StructuredDa
https://github.com/bulbazord requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/154445
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -81,6 +81,39 @@ class StructuredDataImpl {
void SetObjectSP(const StructuredData::ObjectSP &obj) { m_data_sp = obj; }
+ void SetValueForKey(const char *key,
+ const StructuredData::ObjectSP &value) const {
+if (m_data_sp) {
+ auto dict = m_
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/154572
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
Nice :)
https://github.com/llvm/llvm-project/pull/154574
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/153052
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
I think this makes sense.
Out of curiosity, what does clang-format do to the formatting?
https://github.com/llvm/llvm-project/pull/152618
___
lldb-commits mailing list
lldb-commits@lists.llvm.or
https://github.com/bulbazord approved this pull request.
ConstString? ugh.
https://github.com/llvm/llvm-project/pull/152599
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/152560
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module
*module) const {
}
namespace {
+/// A wrapper around ModuleList for shared modules. Provides fast lookups for
+/// file-based ModuleSpec queries.
+class SharedModuleList {
+public:
+ /// Finds all the m
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/152031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/152031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1212,12 +1178,12 @@ class BinaryPythonFile : public PythonIOFile {
num_bytes = 0;
return Status();
}
-auto pybuffer = PythonBuffer::Create(pybuffer_obj.get());
-if (!pybuffer)
- // Cloning since the wrapped exception may still reference the PyTh
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/152034
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/151601
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord updated
https://github.com/llvm/llvm-project/pull/151601
>From 28e3ee59aca4c4c8ce6a5d9e67be48cf692d7d86 Mon Sep 17 00:00:00 2001
From: Alex Langford
Date: Thu, 31 Jul 2025 14:48:55 -0700
Subject: [PATCH 1/2] [lldb] Fix TLS support on Darwin platforms
When I wrote t
bulbazord wrote:
> This does mean we won't handle the old TLS format correctly though right?
My understanding is that this should handle the "old" TLS format correctly.
When I updated this code 2 years ago, I think I misunderstood the dyld
implementation and this worked because of a coincidenc
https://github.com/bulbazord approved this pull request.
Makes sense to me. Thanks!
https://github.com/llvm/llvm-project/pull/151586
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord commented:
I think I'm missing something. Instead of removing it at the end of
`ResolveTypeUID`, you remove it right _after_ the call to `ResolveTypeUID`.
What's the difference?
https://github.com/llvm/llvm-project/pull/151586
_
https://github.com/bulbazord approved this pull request.
Wunderbar
https://github.com/llvm/llvm-project/pull/151489
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,26 @@
+"""
+Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+See https://llvm.org/LICENSE.txt for license information.
+SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+
+Prepares language bindings for LLDB build process. Run with
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/150300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
Makes sense to me. Generally in CMake, if you have a file generated by a
command and multiple independent targets depend on said file, you should "wrap"
the file into a custom target and have everything depend on the custom target
instead. Only one target should depend on thes
@@ -105,18 +78,32 @@ set_target_properties(liblldb-resource-headers PROPERTIES
FOLDER "LLDB/Resources
add_dependencies(liblldb-resource-headers liblldb-header-staging)
add_dependencies(liblldb liblldb-resource-headers)
-# Take the headers from the staging directory and fix up
bulbazord wrote:
> > The new code duplicates a lot of the existing logic in API/CMakeLists.txt.
> > Wouldn't it be simpler to add the framework code to the existing loop
> > behind if(LLDB_BUILD_FRAMEWORK)?
>
> That can be done, I think we'd also have to move the top-level targets for
> fixin
@@ -105,18 +78,30 @@ set_target_properties(liblldb-resource-headers PROPERTIES
FOLDER "LLDB/Resources
add_dependencies(liblldb-resource-headers liblldb-header-staging)
add_dependencies(liblldb liblldb-resource-headers)
+# Glob all necessary header files from source and place
@@ -2473,3 +2474,35 @@ bool
PluginManager::SetUnwindAssemblyPluginEnabled(llvm::StringRef name,
bool enable) {
return GetUnwindAssemblyInstances().SetInstanceEnabled(name, enable);
}
+
+void PluginManager::AutoCompletePlugin
@@ -292,200 +594,367 @@ class LLDB_API SBDebugger {
/// "platform list" command.
uint32_t GetNumAvailablePlatforms();
- /// Get the name and description of one of the available platforms.
+ /// Get information about one of the available platforms.
///
/// \param[in
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/147621
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -61,8 +61,10 @@ class PathMappingList {
return m_pairs.size();
}
- bool GetPathsAtIndex(uint32_t idx, ConstString &path,
- ConstString &new_path) const;
+ /// Invokes callback for each pair of paths in the list. The callback can
+ /// return f
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/147396
Iteration by index is not thread-safe with PathMapingList's design. Instead, we
can expose a `ForEach` method that grabs the PathMappingList's lock before the
callback.
There is a potential pitfall here wher
https://github.com/bulbazord approved this pull request.
Ok, this makes sense to me now. LGTM.
https://github.com/llvm/llvm-project/pull/146425
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
bulbazord wrote:
> > If framework-header-fix.py already puts the header in the framework, why
> > might we want to wholesale copy it into the framework beforehand?
>
> I don't think the script and build infrastructure was actually putting
> everything in the framework itself, just the staging
@@ -148,23 +161,12 @@ void TelemetryManager::DispatchClientTelemetry(
LLDB_LOG(GetLog(LLDBLog::Object),
"Cannot determine client_data from client-telemetry entry");
- int64_t start_time;
- if (dict->GetValueForKeyAsInteger("start_time", start_time)) {
-c
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/145954
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/146356
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
Let's get this patch in and iterate on the tool. Please watch the bots after
landing.
https://github.com/llvm/llvm-project/pull/138031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
h
@@ -148,23 +161,14 @@ void TelemetryManager::DispatchClientTelemetry(
LLDB_LOG(GetLog(LLDBLog::Object),
"Cannot determine client_data from client-telemetry entry");
- int64_t start_time;
- if (dict->GetValueForKeyAsInteger("start_time", start_time)) {
-c
@@ -148,23 +161,14 @@ void TelemetryManager::DispatchClientTelemetry(
LLDB_LOG(GetLog(LLDBLog::Object),
"Cannot determine client_data from client-telemetry entry");
- int64_t start_time;
- if (dict->GetValueForKeyAsInteger("start_time", start_time)) {
-c
@@ -20,7 +20,7 @@
# Main header regexes
INCLUDE_FILENAME_REGEX = re.compile(
-r'#include "lldb/API/(?P.*){0,1}"'
+r'#include "lldb/(API/){0,1}(?P.*){0,1}"'
bulbazord wrote:
I'm not an expert on regex but would it make sense to use `?` here instead of
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/145961
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1998,6 +1998,23 @@ threads (live system debug) / cores (JTAG) in your
program have
stopped and allows LLDB to display and control your program
correctly.
+## qWatchpointSupportInfo
+
+Get the number of hardware watchpoints available on the remote target.
+
+```
+send pack
@@ -552,10 +552,9 @@ bool ClassDescriptorV2::Describe(
} else {
std::optional base_method_list =
GetMethodList(process, class_ro->m_baseMethods_ptr);
- if (!base_method_list)
-return false;
- if (!ProcessMethodList(instance_method_func, *ba
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/145606
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,22 @@
+include(CheckCXXCompilerFlag)
bulbazord wrote:
If you remove it, does it add new compiler warnings? If not, let's take it out.
https://github.com/llvm/llvm-project/pull/138031
___
lldb-commits mailing
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/145452
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/145245
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -16,6 +17,37 @@ def setUp(self):
self.broadcaster, lldb.SBDebugger.eBroadcastBitProgress
)
+def test_wait_attach_progress_reporting(self):
+"""Test that progress reports for wait attaching work as intended."""
+self.build()
+t
https://github.com/bulbazord commented:
LGTM as well. In terms of "Tolerated" vs "Acceptable", I would argue every
dependency should be "tolerated" by default and "acceptable" should be the one
that requires justification.
https://github.com/llvm/llvm-project/pull/144543
__
@@ -0,0 +1,22 @@
+include(CheckCXXCompilerFlag)
bulbazord wrote:
What is this for?
https://github.com/llvm/llvm-project/pull/138031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
@@ -0,0 +1,535 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,535 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,535 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/bulbazord commented:
Some comments. Overall looks ok to me, but I'm already familiar with most of it.
https://github.com/llvm/llvm-project/pull/138031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/c
https://github.com/bulbazord edited
https://github.com/llvm/llvm-project/pull/138031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/144217
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
> @bulbazord I have a auggestion for this patch. I want to have the minimum
> CMake necessary to let the tool build. To accomplish this, I want to take out
> all code in this tool that relates to the server/client code, leaving the
> code that generates the byproducts. I'd the
@@ -0,0 +1,535 @@
+//===-- RPCCommon.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/142689
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/142689
This is always on, and has been since at least 2011 from what I can tell. The
code in the `#else` clauses are effectively dead code.
>From 5b0c4e004c980d37c3ec461b486256027afc3a38 Mon Sep 17 00:00:00 2001
Fro
bulbazord wrote:
> This seems like a generic module loading observer. I don't see anything JIT
> specific about it. Not saying a generic module loading observer is not a good
> idea. But calling it a JITLoader seems pretty confusing to me.
+1 on the name. The design seems very general, so mayb
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/141116
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/142620
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/142587
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/142583
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord closed
https://github.com/llvm/llvm-project/pull/142231
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord created
https://github.com/llvm/llvm-project/pull/142231
This macro does not do what is described. The only thing it actually does
control is whether or not the process's memory cache gets flushed when writing
to an address. It does not override the setting
`targe
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/142183
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/142051
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -51,13 +51,18 @@ macro(add_optional_dependency variable description package
found)
message(STATUS "${description}: ${${variable}}")
endmacro()
+set(LLDB_LIBXML2_VERSION "2.8" CACHE STRING
+ "Sepcify the version of libxml 2 to use with LLDB. This is only meant to be
ove
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/142056
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -290,6 +290,45 @@ else()
endif()
endif()
+# Stage all headers in the include directory in the build dir.
bulbazord wrote:
This looks very similar to some logic in `LLDBFramework.cmake`. Do we need this
logic in both places or could it only live here?
h
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/142052
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1219,45 +1191,42 @@ lldb::SBError
SBTarget::BreakpointsCreateFromFile(SBFileSpec &source_file,
LLDB_INSTRUMENT_VA(this, source_file, matching_names, new_bps);
SBError sberr;
- TargetSP target_sp(GetSP());
- if (!target_sp) {
-sberr.SetErrorString(
-"Brea
@@ -1266,25 +1235,22 @@ lldb::SBError
SBTarget::BreakpointsWriteToFile(SBFileSpec &dest_file,
LLDB_INSTRUMENT_VA(this, dest_file, bkpt_list, append);
SBError sberr;
- TargetSP target_sp(GetSP());
- if (!target_sp) {
-sberr.SetErrorString("BreakpointWriteToFile calle
@@ -208,41 +204,37 @@ SBStructuredData
SBTarget::GetStatistics(SBStatisticsOptions options) {
LLDB_INSTRUMENT_VA(this);
SBStructuredData data;
- TargetSP target_sp(GetSP());
- if (!target_sp)
+ if (TargetSP target_sp = GetSP()) {
+std::string json_str =
+ll
@@ -2393,62 +2329,54 @@ lldb::addr_t SBTarget::GetStackRedZoneSize() {
bool SBTarget::IsLoaded(const SBModule &module) const {
LLDB_INSTRUMENT_VA(this, module);
- TargetSP target_sp(GetSP());
- if (!target_sp)
-return false;
-
- ModuleSP module_sp(module.GetSP());
-
@@ -208,41 +204,37 @@ SBStructuredData
SBTarget::GetStatistics(SBStatisticsOptions options) {
LLDB_INSTRUMENT_VA(this);
SBStructuredData data;
- TargetSP target_sp(GetSP());
- if (!target_sp)
+ if (TargetSP target_sp = GetSP()) {
+std::string json_str =
+ll
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/141217
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord commented:
There is functionality in `lldb/scripts/framework-header-fix.sh` that does the
same thing. Can you remove this functionality from that script too?
https://github.com/llvm/llvm-project/pull/141116
___
lldb-commit
https://github.com/bulbazord approved this pull request.
Beautiful
https://github.com/llvm/llvm-project/pull/141066
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,592 @@
+//===-- RPCServerSourceEmitter.cpp
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/bulbazord approved this pull request.
Makes sense. `std::unique` doesn't invalidate the end iterator, so I believe
this should be ok.
https://github.com/llvm/llvm-project/pull/139910
___
lldb-commits mailing list
lldb-commits@lists.
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/140011
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
bulbazord wrote:
> Pushed again to address David's comments and remove most of the FIXMEs.
> There's one FIXME I've kept in for now:
>
> ```
> // FIXME: SB class server references are stored as non-const references so
> // that we can actually change them as needed. If a parameter is marked
> /
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/138020
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/139932
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 1268 matches
Mail list logo
