bulbazord wrote:

> > If framework-header-fix.py already puts the header in the framework, why 
> > might we want to wholesale copy it into the framework beforehand?
> 
> I don't think the script and build infrastructure was actually putting 
> everything in the framework itself, just the staging area in the build dir. 
> Copying the files into the framework was a step in the original config for 
> this CMake module before I modified it to use the Python script so I think it 
> might have to be added back in here.

My understanding was the `-o ${output_header}` here should place it in the 
framework when `${output_header}` is the right directory.
```
 add_custom_command(TARGET liblldb POST_BUILD
     COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.py -f lldb_main -i 
${input_header} -o ${output_header} -p ${unifdef_EXECUTABLE} USWIG
    COMMENT "LLDB.framework: Fix up and copy framework headers"
  )
```

https://github.com/llvm/llvm-project/pull/146425
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to