The reason for the define is it’s not possible currently to include winnt.h
without build errors. Definitely something to cleanup.
> On Aug 22, 2019, at 9:47 AM, Gwen Mittertreiner via Phabricator
> wrote:
>
> jmittert added a comment.
>
> I believe it's using the one in ntstatus.h
>
> 10.0
Author: asmith
Date: Thu Aug 15 20:49:41 2019
New Revision: 369083
URL: http://llvm.org/viewvc/llvm-project?rev=369083&view=rev
Log:
[lldb-server] Disable a test on Windows until it can be fixed
Modified:
lldb/trunk/unittests/tools/lldb-server/tests/LLGSTest.cpp
Modified: lldb/trunk/unittest
Author: asmith
Date: Wed Aug 14 09:39:41 2019
New Revision: 368872
URL: http://llvm.org/viewvc/llvm-project?rev=368872&view=rev
Log:
Add missing NativeProcessFactory for lldb-server on Windows
Modified:
lldb/trunk/tools/lldb-server/lldb-gdbserver.cpp
Modified: lldb/trunk/tools/lldb-server/ll
Author: asmith
Date: Wed Aug 14 06:49:52 2019
New Revision: 368852
URL: http://llvm.org/viewvc/llvm-project?rev=368852&view=rev
Log:
Add missing SetID method to fix Windows build
Modified:
lldb/trunk/include/lldb/Host/common/NativeProcessProtocol.h
Modified: lldb/trunk/include/lldb/Host/comm
Author: asmith
Date: Tue Aug 13 17:14:15 2019
New Revision: 368776
URL: http://llvm.org/viewvc/llvm-project?rev=368776&view=rev
Log:
Update Python tests for lldb-server on Windows
Summary: Thanks to Hui Huang and reviewers for all the help with this patch!
Reviewers: labath, jfb, clayborg
Revie
Author: asmith
Date: Tue Aug 13 16:50:54 2019
New Revision: 368774
URL: http://llvm.org/viewvc/llvm-project?rev=368774&view=rev
Log:
Enable lldb-server on Windows
Summary:
This commit contains three small changes to enable lldb-server on Windows.
- Add lldb-server for Windows to the build
- Disa
Author: asmith
Date: Tue Jul 9 20:41:34 2019
New Revision: 365593
URL: http://llvm.org/viewvc/llvm-project?rev=365593&view=rev
Log:
Revert accidental change to file
Modified:
lldb/trunk/source/Plugins/ObjectFile/ELF/ELFHeader.cpp
Modified: lldb/trunk/source/Plugins/ObjectFile/ELF/ELFHeader.
Author: asmith
Date: Tue Jul 9 20:34:57 2019
New Revision: 365592
URL: http://llvm.org/viewvc/llvm-project?rev=365592&view=rev
Log:
Try again to move common functionality from ProcessWindows into ProcessDebugger
This reverts commit ed499a36b67cf46cbf66052cfe374c80a595f1c1 and addresses
a problem
Author: asmith
Date: Mon Jun 24 10:43:47 2019
New Revision: 364210
URL: http://llvm.org/viewvc/llvm-project?rev=364210&view=rev
Log:
Move common functionality from processwindows into processdebugger
Summary:
This change extracts functionalities from processwindows into a
introduced processdebugg
Author: asmith
Date: Mon Apr 29 18:41:33 2019
New Revision: 359528
URL: http://llvm.org/viewvc/llvm-project?rev=359528&view=rev
Log:
[PECOFF] Implementation of ObjectFilePECOFF:: GetUUID()
Summary:
Provide an implementation of GetUUID() for remote debugging scenarios.
Return a PDB's GUID (or PDB
Author: asmith
Date: Tue Apr 16 20:13:06 2019
New Revision: 358550
URL: http://llvm.org/viewvc/llvm-project?rev=358550&view=rev
Log:
Clear the output string passed to GetHostName()
LLVM's wchar to UTF8 conversion routine expects an empty string to store the
output.
GetHostName() on Windows is so
Author: asmith
Date: Fri Apr 12 00:48:49 2019
New Revision: 358265
URL: http://llvm.org/viewvc/llvm-project?rev=358265&view=rev
Log:
[lldb-server] Update tests to use std::thread/mutex for all platforms
Summary:
Some cleanup suggested when bringing up lldb-server on Windows.
Thanks to Hui Huang
Author: asmith
Date: Tue Apr 9 21:57:18 2019
New Revision: 358044
URL: http://llvm.org/viewvc/llvm-project?rev=358044&view=rev
Log:
[lldb-server] Introduce Socket::Initialize and Terminate to simply WSASocket
setup
Reviewers: zturner, labath
Reviewed By: labath
Subscribers: lldb-commits
Tags
Author: asmith
Date: Tue Apr 2 10:10:12 2019
New Revision: 357496
URL: http://llvm.org/viewvc/llvm-project?rev=357496&view=rev
Log:
[lldb-server] Use llgs namespace to avoid conflicts with Win32 API
Modified:
lldb/trunk/tools/lldb-server/lldb-server.cpp
Modified: lldb/trunk/tools/lldb-serve
Author: asmith
Date: Tue Apr 2 10:02:21 2019
New Revision: 357495
URL: http://llvm.org/viewvc/llvm-project?rev=357495&view=rev
Log:
Fix typo; NFC
Modified:
lldb/trunk/include/lldb/Target/Platform.h
Modified: lldb/trunk/include/lldb/Target/Platform.h
URL:
http://llvm.org/viewvc/llvm-project
Author: asmith
Date: Thu Feb 14 22:13:59 2019
New Revision: 354100
URL: http://llvm.org/viewvc/llvm-project?rev=354100&view=rev
Log:
Fix for build bot problem from last change
Modified:
lldb/trunk/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
Modified: lldb/trunk/source/Plugins/Pr
Author: asmith
Date: Thu Feb 14 20:32:50 2019
New Revision: 354099
URL: http://llvm.org/viewvc/llvm-project?rev=354099&view=rev
Log:
Implement GetLoadAddress for the Windows process plugin
Summary:
When a process is loaded, update its sections with the load address to resolve
any created breakpo
Author: asmith
Date: Thu Feb 14 00:59:04 2019
New Revision: 354012
URL: http://llvm.org/viewvc/llvm-project?rev=354012&view=rev
Log:
[gdb-remote] Sanity check platform pointer
Modified:
lldb/trunk/source/Plugins/Process/gdb-remote/GDBRemoteCommunication.cpp
Modified:
lldb/trunk/source/Plugi
Author: asmith
Date: Wed Feb 13 21:34:46 2019
New Revision: 354010
URL: http://llvm.org/viewvc/llvm-project?rev=354010&view=rev
Log:
[lldb-server] Add remote platform capabilities for Windows
Summary:
Implement a few routines for Windows to support some basic process interaction
and file system
Author: asmith
Date: Thu Feb 7 10:52:22 2019
New Revision: 353447
URL: http://llvm.org/viewvc/llvm-project?rev=353447&view=rev
Log:
Add missing overrides
Modified:
lldb/trunk/include/lldb/Host/windows/PipeWindows.h
Modified: lldb/trunk/include/lldb/Host/windows/PipeWindows.h
URL:
http://ll
Author: asmith
Date: Thu Feb 7 10:46:25 2019
New Revision: 353446
URL: http://llvm.org/viewvc/llvm-project?rev=353446&view=rev
Log:
[lldb-server] Improve support on Windows
Summary:
This commit contains the following changes:
- Rewrite vfile close/read/write packet handlers with portable rout
Author: asmith
Date: Thu Feb 7 10:22:00 2019
New Revision: 353440
URL: http://llvm.org/viewvc/llvm-project?rev=353440&view=rev
Log:
[gdb-remote] Use lldb's portable Host::GetEnvironment() instead of getenv
Reviewers: zturner, llvm-commits, labath, serge-sans-paille
Reviewed By: labath
Subscrib
Author: asmith
Date: Wed Jan 9 16:46:09 2019
New Revision: 350784
URL: http://llvm.org/viewvc/llvm-project?rev=350784&view=rev
Log:
[lldb-server] Add unnamed pipe support to PipeWindows
Summary:
This adds unnamed pipe support in PipeWindows to support communication between
a debug server and ch
Author: asmith
Date: Wed Jan 2 16:54:08 2019
New Revision: 350281
URL: http://llvm.org/viewvc/llvm-project?rev=350281&view=rev
Log:
Check that a pointer is valid and fix a log message on Windows
Modified:
lldb/trunk/source/Plugins/Process/Windows/Common/ProcessWindows.cpp
Modified: lldb/tru
Author: asmith
Date: Thu Dec 6 13:36:39 2018
New Revision: 348527
URL: http://llvm.org/viewvc/llvm-project?rev=348527&view=rev
Log:
[pecoff] Implement ObjectFilePECOFF::GetDependedModules()
Summary:
This parses entries in pecoff import tables for imported DLLs and
is intended as the first step t
Author: asmith
Date: Fri Oct 19 12:30:59 2018
New Revision: 344809
URL: http://llvm.org/viewvc/llvm-project?rev=344809&view=rev
Log:
[PDB] Test variadic function type in PDB
This adds back the test case reverted in commit:
d260a269200824c5c1c8c6de531fd5aa63db9c35
Modified:
lldb/trunk/unitte
Author: asmith
Date: Fri Oct 19 11:58:24 2018
New Revision: 344798
URL: http://llvm.org/viewvc/llvm-project?rev=344798&view=rev
Log:
[lldb] Add support in Status::AsCString to retrieve win32 system error strings
Reviewers: rnk, zturner, aleksandr.urakov
Subscribers: lldb-commits
Differential Re
Author: asmith
Date: Wed Oct 10 11:30:32 2018
New Revision: 344168
URL: http://llvm.org/viewvc/llvm-project?rev=344168&view=rev
Log:
[Windows] Fix a bug that causes lldb to freeze
Summary:
If the process exits before any initial stop then notify the debugger
of the error otherwise WaitForDebugge
Author: asmith
Date: Mon Oct 1 10:08:51 2018
New Revision: 343497
URL: http://llvm.org/viewvc/llvm-project?rev=343497&view=rev
Log:
[lldb] Start a new line for the next output if there are no symbols in the
current symtab
Summary:
If there is no newline the "lldb" prompt could be on the wrong l
Author: asmith
Date: Thu Sep 27 19:33:51 2018
New Revision: 343292
URL: http://llvm.org/viewvc/llvm-project?rev=343292&view=rev
Log:
[lldb] Remove an assertion in RichManglingContext::GetBufferRef() hit when
debugging a native x86 Windows process
Summary: A RichManglingContext constructed with a
Not at all.
> On Jul 18, 2018, at 8:27 AM, Aleksandr Urakov via Phabricator
> wrote:
>
> aleksandr.urakov added a comment.
>
> Don't you mind if I try to combine this with https://reviews.llvm.org/D49368?
> To avoid doing the work twice.
>
>
> https://reviews.llvm.org/D49410
>
>
>
_
Sure, I will do it Monday if someone hasn’t done it already.
> On Jul 12, 2018, at 9:22 PM, Aleksandr Urakov via Phabricator
> wrote:
>
> aleksandr.urakov updated this revision to Diff 155154.
> aleksandr.urakov added a comment.
>
> Thanks a lot, I have updated the patch!
>
> I also have add
Author: asmith
Date: Tue May 22 18:58:23 2018
New Revision: 333051
URL: http://llvm.org/viewvc/llvm-project?rev=333051&view=rev
Log:
[SymbolFilePDB] Add a test for wchar_t type in PDB.
The wchar_t is unsigned.
https://msdn.microsoft.com/en-us/library/s3f49ktz.aspx
Modified:
lldb/trunk/lit
Author: asmith
Date: Thu Mar 22 12:21:34 2018
New Revision: 328230
URL: http://llvm.org/viewvc/llvm-project?rev=328230&view=rev
Log:
[SymbolFilePDB] Ignore compiler generated functions when creating the LLDB type
from a PDB
Modified:
lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
Author: asmith
Date: Thu Mar 22 12:26:33 2018
New Revision: 328232
URL: http://llvm.org/viewvc/llvm-project?rev=328232&view=rev
Log:
[SymbolFilePDB] Use section contributions as another way to determine the
compiland
Some PDB Symbols don't have line information. Use the section contributions to
Author: asmith
Date: Tue May 22 19:48:25 2018
New Revision: 333055
URL: http://llvm.org/viewvc/llvm-project?rev=333055&view=rev
Log:
[SymbolFilePDB] PDB_BuiltinType::Char16 and Char32 are unsigned in MSVC.
Modified:
lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
Modified: lldb/tru
Author: asmith
Date: Tue Apr 24 10:08:05 2018
New Revision: 330740
URL: http://llvm.org/viewvc/llvm-project?rev=330740&view=rev
Log:
[lit, lldbsuite] Update the lldbsuite to correctly run tests on windows and
windows server
Summary:
The new script to run the lldbtests as part of lit invokes each
Author: asmith
Date: Tue Jun 5 10:19:21 2018
New Revision: 334030
URL: http://llvm.org/viewvc/llvm-project?rev=334030&view=rev
Log:
PDB support of function-level linking and splitted functions
Summary:
The patch adds support of splitted functions (when MSVC is used with PGO) and
function-level
Author: asmith
Date: Thu Apr 12 16:29:49 2018
New Revision: 329971
URL: http://llvm.org/viewvc/llvm-project?rev=329971&view=rev
Log:
[docs] Add LLDB_TEST_USE_CUSTOM_C_COMPILER and
LLDB_TEST_USE_CUSTOM_CXX_COMPILER to the build and test hmtl pages
Modified:
lldb/trunk/www/build.html
lldb/
Author: asmith
Date: Wed Mar 21 20:44:51 2018
New Revision: 328176
URL: http://llvm.org/viewvc/llvm-project?rev=328176&view=rev
Log:
[SymbolFilePDB] Run clang-format; NFC
Modified:
lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTPar
Author: asmith
Date: Thu Jun 7 19:45:25 2018
New Revision: 334260
URL: http://llvm.org/viewvc/llvm-project?rev=334260&view=rev
Log:
PDB support of function-level linking and splitted functions
Summary:
The patch adds support of splitted functions (when MSVC is used with PGO) and
function-level
Author: asmith
Date: Tue May 22 18:52:42 2018
New Revision: 333049
URL: http://llvm.org/viewvc/llvm-project?rev=333049&view=rev
Log:
[SymbolFilePDB] Add support for resolving variable symbols
Summary:
Implement FindGlobalVariables and ParseVariableContext methods.
Compile unit information is nec
Author: asmith
Date: Tue Mar 13 21:05:27 2018
New Revision: 327473
URL: http://llvm.org/viewvc/llvm-project?rev=327473&view=rev
Log:
[SymbolFilePDB] Rewrite ParseTypes method
Summary:
The types for the compiland's children are parsed when parsing types for a PDB
compiland. Global types also need
Author: asmith
Date: Mon Mar 19 17:18:22 2018
New Revision: 327925
URL: http://llvm.org/viewvc/llvm-project?rev=327925&view=rev
Log:
[SymbolFilePDB] Simplify getting the source file path
Summary: Replace SymbolFilePDB::GetSourceFileNameForPDBCompiland() with
PDBSymbolCompiland::getSourceFileFull
Author: asmith
Date: Mon Mar 19 17:34:18 2018
New Revision: 327927
URL: http://llvm.org/viewvc/llvm-project?rev=327927&view=rev
Log:
[SymbolFilePDB] Simplify code with newer methods
Modified:
lldb/trunk/source/Plugins/SymbolFile/PDB/PDBASTParser.cpp
lldb/trunk/source/Plugins/SymbolFile/PD
Author: asmith
Date: Mon Mar 19 14:14:19 2018
New Revision: 327908
URL: http://llvm.org/viewvc/llvm-project?rev=327908&view=rev
Log:
[SymbolFilePDB] Remove a few null pointer checks by passing ref
Reviewers: zturner, rnk, lldb-commits
Reviewed By: zturner
Subscribers: llvm-commits
Differential
Author: asmith
Date: Tue Feb 20 16:05:51 2018
New Revision: 325652
URL: http://llvm.org/viewvc/llvm-project?rev=325652&view=rev
Log:
[lit] Update how clang and other binaries are found in per-configuration
directories
Summary:
This is modeled after the clang and llvm lit tests.
Several properti
Author: asmith
Date: Tue Mar 6 16:35:27 2018
New Revision: 326858
URL: http://llvm.org/viewvc/llvm-project?rev=326858&view=rev
Log:
[SymbolFilePDB] Get line number for PDBSymbolTypeEnum
Reviewers: zturner, lldb-commits, rnk
Reviewed By: zturner
Subscribers: llvm-commits
Differential Revision:
Author: asmith
Date: Fri Mar 9 10:50:19 2018
New Revision: 327162
URL: http://llvm.org/viewvc/llvm-project?rev=327162&view=rev
Log:
[SymbolFilePDB] Keep searching until the file name is found for the pdb
compiland
Reviewers: zturner, rnk, lldb-commits
Reviewed By: zturner
Subscribers: llvm-co
Author: asmith
Date: Tue Mar 6 19:16:50 2018
New Revision: 326870
URL: http://llvm.org/viewvc/llvm-project?rev=326870&view=rev
Log:
[SymbolFilePDB] Minor cleanup
Summary:
- Remove unused code
- Adding `break` statement conditionally
- Ignore empty strings in FindTypeByName
Reviewers: zturner
Author: asmith
Date: Wed Feb 7 21:11:17 2018
New Revision: 324564
URL: http://llvm.org/viewvc/llvm-project?rev=324564&view=rev
Log:
[docs] Update docs for cmake options LLDB_TEST_C_COMPILER and
LLDB_TEST_CXX_COMPILER
Summary:
LLDB_TEST_COMPILER is not a valid option for CMake for LLDB. There ar
Author: asmith
Date: Tue Mar 6 21:43:05 2018
New Revision: 326875
URL: http://llvm.org/viewvc/llvm-project?rev=326875&view=rev
Log:
[SymbolFilePDB] Add missing Char16 and Char32 types in a few places
Reviewers: zturner, rnk, lldb-commits
Subscribers: clayborg, llvm-commits
Differential Revisio
Author: asmith
Date: Thu Feb 8 21:31:28 2018
New Revision: 324707
URL: http://llvm.org/viewvc/llvm-project?rev=324707&view=rev
Log:
[SymbolFilePDB] Add support for function symbols
Summary:
This is combination of following changes,
- Resolve function symbols in PDB symbol file. `lldb-test symbo
Author: asmith
Date: Tue Mar 6 16:39:25 2018
New Revision: 326859
URL: http://llvm.org/viewvc/llvm-project?rev=326859&view=rev
Log:
[SymbolFilePDB] Add support for CVR pointer type qualifier
Summary:
- Complete element type of PDBSymbolTypeArray.
- Add a test to check types of multi-dimensional
Author: asmith
Date: Thu Feb 8 15:10:29 2018
New Revision: 324671
URL: http://llvm.org/viewvc/llvm-project?rev=324671&view=rev
Log:
Only throw -fPIC when building a shared library
Summary:
Update makefiles to specify -fPIC in Makefile.rules and only throw -fPIC when
building a shared library. T
Author: asmith
Date: Thu Feb 8 15:11:56 2018
New Revision: 324672
URL: http://llvm.org/viewvc/llvm-project?rev=324672&view=rev
Log:
Recognize MSVC style mangling in CPlusPlusLanguage::IsCPPMangledName
Reviewers: zturner, lldb-commits, labath
Reviewed By: zturner
Subscribers: jingham, labath, d
Author: asmith
Date: Thu Dec 21 16:04:36 2017
New Revision: 321327
URL: http://llvm.org/viewvc/llvm-project?rev=321327&view=rev
Log:
Enable more abilities in SymbolFilePDB
Summary:
1) Finding symbols through --symfile
2) More abilities: Functions, Blocks, GlobalVariables, LocalVariables,
Variabl
Author: asmith
Date: Wed Dec 27 23:48:10 2017
New Revision: 321514
URL: http://llvm.org/viewvc/llvm-project?rev=321514&view=rev
Log:
Remove duplicate declaration from D41550; NFC
Modified:
lldb/trunk/source/Plugins/SymbolFile/PDB/SymbolFilePDB.h
Modified: lldb/trunk/source/Plugins/SymbolFil
Author: asmith
Date: Tue Jan 23 12:35:19 2018
New Revision: 323255
URL: http://llvm.org/viewvc/llvm-project?rev=323255&view=rev
Log:
[SymbolFilePDB] Fix null array access when parsing the type of a function
without any arguments, i.e. 'int main()' and add support to test it
Summary:
- Fix a null
Author: asmith
Date: Fri Jan 12 22:58:18 2018
New Revision: 322433
URL: http://llvm.org/viewvc/llvm-project?rev=322433&view=rev
Log:
[lldb] Add support to cache a PDB's global scope and fix a bug in getting the
source file name for a compiland
Summary:
This commit is a combination of the followi
Author: asmith
Date: Wed Feb 7 18:13:48 2018
New Revision: 324555
URL: http://llvm.org/viewvc/llvm-project?rev=324555&view=rev
Log:
Add CMAKE_CFG_INTDIR as part of the include path for the default test compiler.
Summary:
This is a small change towards running the LLDB unit tests on Windows (sti
Author: asmith
Date: Thu Dec 21 21:26:50 2017
New Revision: 321344
URL: http://llvm.org/viewvc/llvm-project?rev=321344&view=rev
Log:
[lldb] Stop searching for a symbol in a pdb by regex
Summary:
It was possible when searching for a symbol by regex in a pdb that an invalid
regex would cause an ex
Author: asmith
Date: Wed Dec 27 22:29:59 2017
New Revision: 321511
URL: http://llvm.org/viewvc/llvm-project?rev=321511&view=rev
Log:
Update failing PDB unit tests that are searching for symbols by regex
Summary: D41086 fixed an exception in FindTypes()/FindTypesByRegex() and caused
two lldb unit
Author: asmith
Date: Fri Jan 19 13:55:44 2018
New Revision: 322995
URL: http://llvm.org/viewvc/llvm-project?rev=322995&view=rev
Log:
[SymbolFilePDB] Fix null array access when parsing the type of a function
without any arguments, i.e. 'int main()' and add support to test it
Summary:
- Fix a null
The url provided times out but my guess is these two unit tests are
what are failing.
lldb/unittests/SymbolFile/PDB/SymbolFilePDBTests.cpp
- TEST_F(SymbolFilePDBTests, TestRegexNameMatch)
- TEST_F(SymbolFilePDBTests, TestMaxMatches)
The first one is testing regex name matching which was decided i
65 matches
Mail list logo
