https://github.com/piyushjaiswal98 updated
https://github.com/llvm/llvm-project/pull/154632
>From c40952ce7096505455ade9ad8b1598928b40118f Mon Sep 17 00:00:00 2001
From: Piyush Jaiswal
Date: Wed, 20 Aug 2025 14:41:29 -0700
Subject: [PATCH 1/2] Fix non-deterministic failure in
---
.../test/too
https://github.com/Sirraide commented:
Reusing the existing diagnostics machinery for this sgtm.
https://github.com/llvm/llvm-project/pull/154618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
@@ -1813,6 +1813,7 @@ void ScalarExprEmitter::EmitBinOpCheck(
SanitizerHandler Check;
SmallVector StaticData;
SmallVector DynamicData;
+ std::unique_ptr RTDB = nullptr;
Sirraide wrote:
Actually, this is in a function—I thought it was at class scope for
@@ -33,6 +33,7 @@
#include "clang/AST/StmtVisitor.h"
#include "clang/Basic/Builtins.h"
#include "clang/Basic/CodeGenOptions.h"
+#include "clang/Basic/DiagnosticParse.h"
Sirraide wrote:
I don’t think we should be including `DiagnosticParse.h` in codegen.
https
@@ -1824,6 +1825,12 @@ class CodeGenModule : public CodeGenTypeCache {
return PAlign;
}
+ /// Helper function to construct a RuntimeTrapDiagnosticBuilder
+ [[nodiscard]] std::unique_ptr
+ RuntimeDiag(unsigned DiagID) {
+return std::make_unique(&getDiags(), DiagID)
@@ -1813,6 +1813,7 @@ void ScalarExprEmitter::EmitBinOpCheck(
SanitizerHandler Check;
SmallVector StaticData;
SmallVector DynamicData;
+ std::unique_ptr RTDB = nullptr;
Sirraide wrote:
I don’t think this is the right place to cache and reuse these. If w
@@ -0,0 +1,26 @@
+//==--- DiagnosticCodeGenKinds.td - CodeGen Diagnostics
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -30,6 +30,7 @@ def CLASS_REMARK: DiagClass;
def CLASS_WARNING : DiagClass;
def CLASS_EXTENSION : DiagClass;
def CLASS_ERROR : DiagClass;
+def CLASS_TRAP : DiagClass;
Sirraide wrote:
Hmm, I wonder if we really need a new diagnostic class for t
@@ -1534,6 +1535,72 @@ inline DiagnosticBuilder
DiagnosticsEngine::Report(unsigned DiagID) {
return Report(SourceLocation(), DiagID);
}
+//===--===//
+// RuntimeTrapDiagnosticBuilder
+//===-
@@ -30,4 +30,5 @@
#include "clang/Basic/DiagnosticAnalysisKinds.inc"
#include "clang/Basic/DiagnosticRefactoringKinds.inc"
#include "clang/Basic/DiagnosticInstallAPIKinds.inc"
+#include "clang/Basic/DiagnosticCodeGenKinds.inc"
Sirraide wrote:
I don’t really li
@@ -47,6 +47,7 @@ namespace clang {
DIAG_SIZE_ANALYSIS = 100,
DIAG_SIZE_REFACTORING = 1000,
DIAG_SIZE_INSTALLAPI= 100,
+ DIAG_SIZE_CODEGEN = 10,
Sirraide wrote:
Maybe preallocate more than 10 so we don’t have to bump t
@@ -3721,7 +3722,8 @@ static void emitCheckHandlerCall(CodeGenFunction &CGF,
void CodeGenFunction::EmitCheck(
ArrayRef>
Checked,
SanitizerHandler CheckHandler, ArrayRef StaticArgs,
-ArrayRef DynamicArgs) {
+ArrayRef DynamicArgs,
+std::unique_ptr RTDB) {
---
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/154618
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-s390x-linux` running
on `systemz-1` while building
`clang-tools-extra,clang,compiler-rt,libcxx,libcxxabi,libunwind,lldb,llvm,mlir,offload,openmp,third-party`
at step 5 "ninja check 1".
Full details are available at:
ht
https://github.com/medismailben updated
https://github.com/llvm/llvm-project/pull/154445
>From 65b7e3a056f7b3c76217364d700e577f029e4190 Mon Sep 17 00:00:00 2001
From: Med Ismail Bennani
Date: Wed, 20 Aug 2025 16:59:25 -0700
Subject: [PATCH] [lldb/API] Add setters to SBStructuredData
This patch
https://github.com/kastiglione updated
https://github.com/llvm/llvm-project/pull/154574
>From 13264919452f446dd13f5f8a3e3ed207e84bf96b Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Wed, 20 Aug 2025 09:41:26 -0700
Subject: [PATCH 1/2] [lldb] Tweak check for CommandLineTools in ParseXcodeSDK
---
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/154606
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Kazu Hirata
Date: 2025-08-20T14:53:28-07:00
New Revision: 1da200bec5b92653245d742032bf934b1926
URL:
https://github.com/llvm/llvm-project/commit/1da200bec5b92653245d742032bf934b1926
DIFF:
https://github.com/llvm/llvm-project/commit/1da200bec5b92653245d742032bf934b1926.diff
L
eronnen wrote:
@JDevlieghere Added public functions to `SBSymbol` to convert from and to
lldb::SymbolType
https://github.com/llvm/llvm-project/pull/153836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
@@ -1,9 +1,110 @@
#include "Protocol/DAPTypes.h"
+#include "lldb/lldb-enumerations.h"
using namespace llvm;
namespace lldb_dap::protocol {
+static std::string SymbolTypeToString(lldb::SymbolType symbol_type) {
eronnen wrote:
:100:
https://github.com/ll
@@ -1,9 +1,110 @@
#include "Protocol/DAPTypes.h"
+#include "lldb/lldb-enumerations.h"
using namespace llvm;
namespace lldb_dap::protocol {
+static std::string SymbolTypeToString(lldb::SymbolType symbol_type) {
+ switch (symbol_type) {
+ case lldb::eSymbolTypeInvalid:
+
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/154574
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/154574
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -998,12 +999,12 @@ XcodeSDK SymbolFileDWARF::ParseXcodeSDK(CompileUnit
&comp_unit) {
const char *sdk = cu_die.GetAttributeValueAsString(DW_AT_APPLE_sdk, nullptr);
if (!sdk)
return {};
- std::string sysroot =
+ llvm::StringRef sysroot =
Michael137
@@ -81,6 +81,39 @@ class StructuredDataImpl {
void SetObjectSP(const StructuredData::ObjectSP &obj) { m_data_sp = obj; }
+ void SetValueForKey(const char *key,
+ const StructuredData::ObjectSP &value) const {
+if (m_data_sp) {
+ auto dict = m_
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
While debugging, I saw a log line of:
> Failed to resolve SDK path: Error while searching for SDK (XcodeSDK ''):
Unrecognized SDK type:
Looking into how this might happen, it seems `ResolveSDKPathFromDebugI
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/154607
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1039,7 +1039,12 @@ ResolveSDKPathFromDebugInfo(lldb_private::Target
*target) {
SymbolFile *sym_file = exe_module_sp->GetSymbolFile();
if (!sym_file)
-return llvm::createStringError("Failed to get symbol file from module");
+return llvm::createStringError("Fail
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/154607
While debugging, I saw a log line of:
> Failed to resolve SDK path: Error while searching for SDK (XcodeSDK ''):
> Unrecognized SDK type:
Looking into how this might happen, it seems `ResolveSDKPathFromDe
https://github.com/JDevlieghere approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/154247
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows`
running on `linaro-armv8-windows-msvc-05` while building
`clang-tools-extra,clang,compiler-rt,libcxx,libcxxabi,libunwind,lldb,llvm,mlir,offload,openmp,third-party`
at step 6 "test".
Full details are avai
@@ -109,6 +109,22 @@ class SBStructuredData {
/// Return the generic pointer if this data structure is a generic type.
lldb::SBScriptObject GetGenericValue() const;
+ void SetValueForKey(const char *key, SBStructuredData &value) const;
jimingham wrote:
I
@@ -109,6 +109,22 @@ class SBStructuredData {
/// Return the generic pointer if this data structure is a generic type.
lldb::SBScriptObject GetGenericValue() const;
+ void SetValueForKey(const char *key, SBStructuredData &value) const;
medismailben wrote:
https://github.com/yln updated https://github.com/llvm/llvm-project/pull/154247
>From 51480efc86e24eb79a4d95fc79da282828aa1a5f Mon Sep 17 00:00:00 2001
From: Julian Lettner
Date: Mon, 18 Aug 2025 12:37:24 -0700
Subject: [PATCH 1/3] [lldb] Introduce HistoryPCType enum
Introduce and adopt `Histor
https://github.com/cjdb edited https://github.com/llvm/llvm-project/pull/139632
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/cjdb edited https://github.com/llvm/llvm-project/pull/139632
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/147787
>From e692c5f9bda1c37e486dfbbd4a57fe573c83045e Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 9 Jul 2025 10:25:08 -0700
Subject: [PATCH 1/3] [lldb-dap] Reland refactor of DebugCommunication.
Originally
@@ -176,10 +170,24 @@ HistoryThreads
MemoryHistoryASan::GetHistoryThreads(lldb::addr_t address) {
options.SetAutoApplyFixIts(false);
options.SetLanguage(eLanguageTypeObjC_plus_plus);
+ // The ASan compiler-rt runtime already massages the return addresses into
+ // call
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/154445
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -248,6 +248,22 @@ enum class IterationAction {
Stop,
};
+/// Specifies the type of PCs when creating a `HistoryThread`.
+/// - Usually, when LLDB unwinds the stack or we retrieve a stack trace via
+/// `backtrace()` we are collecting return addresses (except for the top
@@ -109,6 +109,22 @@ class SBStructuredData {
/// Return the generic pointer if this data structure is a generic type.
lldb::SBScriptObject GetGenericValue() const;
+ void SetValueForKey(const char *key, SBStructuredData &value) const;
jimingham wrote:
A
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `clang-armv8-quick` running
on `linaro-clang-armv8-quick` while building
`clang-tools-extra,clang,compiler-rt,libcxx,libcxxabi,libunwind,lldb,llvm,mlir,offload,openmp,third-party`
at step 5 "ninja check 1".
Full details are av
https://github.com/bulbazord approved this pull request.
https://github.com/llvm/llvm-project/pull/154572
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/yln updated https://github.com/llvm/llvm-project/pull/154247
>From b92dee9ba04d1baabab08ab96fcef7d860d3b47e Mon Sep 17 00:00:00 2001
From: Julian Lettner
Date: Mon, 18 Aug 2025 12:37:24 -0700
Subject: [PATCH 1/2] [lldb] Introduce TracePCType enum
Introduce and adopt `TracePCT
https://github.com/bulbazord approved this pull request.
Nice :)
https://github.com/llvm/llvm-project/pull/154574
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1141,15 +1253,22 @@ def request_completions(self, text, frameId=None):
"type": "request",
"arguments": args_dict,
}
-return self.send_recv(command_dict)
-
-def request_modules(self, startModule: int, moduleCount: int):
-re
@@ -188,267 +241,326 @@ def validate_response(cls, command, response):
)
def _read_packet_thread(self):
-done = False
try:
-while not done:
+while True:
packet = read_packet(self.recv, trace_file=self.tr
@@ -1141,15 +1253,22 @@ def request_completions(self, text, frameId=None):
"type": "request",
"arguments": args_dict,
}
-return self.send_recv(command_dict)
-
-def request_modules(self, startModule: int, moduleCount: int):
-re
@@ -188,267 +241,326 @@ def validate_response(cls, command, response):
)
def _read_packet_thread(self):
-done = False
try:
-while not done:
+while True:
packet = read_packet(self.recv, trace_file=self.tr
@@ -152,25 +189,41 @@ def __init__(
self.log_file = log_file
self.send = send
self.recv = recv
-self.recv_packets: list[Optional[ProtocolMessage]] = []
-self.recv_condition = threading.Condition()
-self.recv_thread = threading.Thr
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/147787
>From e692c5f9bda1c37e486dfbbd4a57fe573c83045e Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Wed, 9 Jul 2025 10:25:08 -0700
Subject: [PATCH 1/2] [lldb-dap] Reland refactor of DebugCommunication.
Originally
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/154574
None
>From 13264919452f446dd13f5f8a3e3ed207e84bf96b Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Wed, 20 Aug 2025 09:41:26 -0700
Subject: [PATCH] [lldb] Tweak check for CommandLineTools in ParseXcodeSDK
-
https://github.com/kastiglione edited
https://github.com/llvm/llvm-project/pull/154574
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
Follow up to https://github.com/llvm/llvm-project/pull/128712
---
Full diff: https://github.com/llvm/llvm-project/pull/154574.diff
1 Files Affected:
- (modified) lldb/source/Plugins/SymbolFile/DWARF/SymbolF
https://github.com/daltenty closed
https://github.com/llvm/llvm-project/pull/154537
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Dave Lee (kastiglione)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/154572.diff
3 Files Affected:
- (modified) lldb/include/lldb/Utility/XcodeSDK.h (-2)
- (modified) lldb/source/Utility/XcodeSDK.cpp (-23)
- (modifi
kastiglione wrote:
this function is also not used downstream in the swift repo.
https://github.com/llvm/llvm-project/pull/154572
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/154472
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/kastiglione created
https://github.com/llvm/llvm-project/pull/154572
None
>From 9e56a63771919e53ed7228adab394f61b1d1a5ba Mon Sep 17 00:00:00 2001
From: Dave Lee
Date: Tue, 19 Aug 2025 21:59:05 -0700
Subject: [PATCH] [lldb] Remove unused XcodeSDK::SupportsSwift (NFC)
---
ll
https://github.com/daltenty updated
https://github.com/llvm/llvm-project/pull/154537
>From d642441854a74abcf5d3aa651abdec3465e78188 Mon Sep 17 00:00:00 2001
From: David Tenty
Date: Wed, 20 Aug 2025 00:08:58 -0400
Subject: [PATCH 1/4] [NFC][CMake] quote ${CMAKE_SYSTEM_NAME} consistently
---
ll
cmtice wrote:
> > Even a 3-4% increase in binary size is going to cause serious problems for
> > us at Google. Is there any way that this work could be guarded by a flag,
> > so that we can turn it off until we find a way to work around the problems
> > it will cause for us?
>
> Yup I put thi
https://github.com/daltenty updated
https://github.com/llvm/llvm-project/pull/154537
>From d642441854a74abcf5d3aa651abdec3465e78188 Mon Sep 17 00:00:00 2001
From: David Tenty
Date: Wed, 20 Aug 2025 00:08:58 -0400
Subject: [PATCH 1/3] [NFC][CMake] quote ${CMAKE_SYSTEM_NAME} consistently
---
ll
Michael137 wrote:
> Even a 3-4% increase in binary size is going to cause serious problems for us
> at Google. Is there any way that this work could be guarded by a flag, so
> that we can turn it off until we find a way to work around the problems it
> will cause for us?
Yup I put this behind
cmtice wrote:
Even a 3-4% increase in binary size is going to cause serious problems for us
at Google. Is there any way that this work could be guarded by a flag, so that
we can turn it off until we find a way to work around the problems it will
cause for us?
https://github.com/llvm/llvm-proj
kastiglione wrote:
If there's no more feedback, I'll merge this soon.
https://github.com/llvm/llvm-project/pull/153233
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/154396
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Charles Zablit
Date: 2025-08-20T14:10:50+01:00
New Revision: c56bb124e31da76d09cf6419a4a6ca3bd38474c4
URL:
https://github.com/llvm/llvm-project/commit/c56bb124e31da76d09cf6419a4a6ca3bd38474c4
DIFF:
https://github.com/llvm/llvm-project/commit/c56bb124e31da76d09cf6419a4a6ca3bd38474c4.diff
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/154424
>From 5c7c53e53d179e7e002cbe958c12aef453afa6da Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 19 Aug 2025 22:22:38 +0100
Subject: [PATCH 1/3] [lldb][windows] remove duplicate implementation of
https://github.com/charles-zablit updated
https://github.com/llvm/llvm-project/pull/154424
>From 5c7c53e53d179e7e002cbe958c12aef453afa6da Mon Sep 17 00:00:00 2001
From: Charles Zablit
Date: Tue, 19 Aug 2025 22:22:38 +0100
Subject: [PATCH 1/2] [lldb][windows] remove duplicate implementation of
@@ -248,6 +248,22 @@ enum class IterationAction {
Stop,
};
+/// Specifies the type of PCs when creating a `HistoryThread`.
+/// - Usually, when LLDB unwinds the stack or we retrieve a stack trace via
+/// `backtrace()` we are collecting return addresses (except for the top
https://github.com/Michael137 approved this pull request.
LGTM!
I'd wait a day or so before merging so @JDevlieghere or @jasonmolenda can chime
in.
https://github.com/llvm/llvm-project/pull/154247
___
lldb-commits mailing list
lldb-commits@lists.llvm
@@ -248,6 +248,22 @@ enum class IterationAction {
Stop,
};
+/// Specifies the type of PCs when creating a `HistoryThread`.
+/// - Usually, when LLDB unwinds the stack or we retrieve a stack trace via
+/// `backtrace()` we are collecting return addresses (except for the top
72 matches
Mail list logo
