llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
This commit upstreams the client side emitters for the lldb-rpc-gen tool
alongside tests for its functionality and heuristics.
https://discourse.llvm.org/t/rfc-upstreaming-lldb-rpc/85804
---
Patc
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/147655
This commit upstreams the client side emitters for the lldb-rpc-gen tool
alongside tests for its functionality and heuristics.
https://discourse.llvm.org/t/rfc-upstreaming-lldb-rpc/85804
>From cbcab9124c
@@ -235,7 +235,8 @@ contain the following key/value pairs:
| **cwd** | string | | The program working
directory.
| **env** | dictionary | | Environment
variables to set when launching the program. The format of
vogelsgesang wrote:
Semi-related: I wonder if we should have a way to set the language from within
the condition expression itself. E.g. a `\language{C} a + b` prefix. That would
allow us to also use those conditions from, e.g., lldb-dap where the UI only
provides a way to enter a single expre
asavonic wrote:
Updated the patch to [use
RemoveOrphanSharedModules](https://github.com/llvm/llvm-project/pull/147289/commits/7a27fe962726c3190ce6ad7d635e3ae30a0f52f7)
instead of force-clearing the cache.
Changed the description as well.
> No one SBDebugger should force-clear the Shared Module
https://github.com/asavonic updated
https://github.com/llvm/llvm-project/pull/147289
>From a01eb1943afb03d1dc9439e9ae8f3a01b8c15398 Mon Sep 17 00:00:00 2001
From: Andrew Savonichev
Date: Mon, 7 Jul 2025 17:33:50 +0900
Subject: [PATCH 1/3] [lldb] Clear ModuleList shared modules in
SBDebugger::C
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/146972
>From b593c9b4f8791f2b5562ca301f77af72619b9c30 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 8 Jul 2025 15:32:13 -0700
Subject: [PATCH 1/2] [lldb] Change breakpoint interfaces for error handli
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
Enable SWIG support for translating Doxygen comments found in interface and
header files into a target language's normal documentation language. This
feature was introduced in SWIG 4.0 and currently
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/147617
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/147617
Enable SWIG support for translating Doxygen comments found in interface and
header files into a target language's normal documentation language. This
feature was introduced in SWIG 4.0 and currently only s
https://github.com/ashgti created
https://github.com/llvm/llvm-project/pull/147611
This adds new protocol types for the 'variables' request.
While implementing this, I removed the '$__lldb_extension' field we returned on
the 'variables' request, since I think all the data can be retrieved from
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/test/API/functionalities/breakpoint/breakpoint_conditions/TestBreakpoin
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/147603
>From 67ce4cd81355863ec2b3af43eb5a0e47f420acd2 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 8 Jul 2025 14:55:59 -0700
Subject: [PATCH] [lldb] Support specifying a language for breakpoint
con
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
LLDB breakpoint conditions take an expression that's evaluated using the
language of the code where the breakpoint is located. Users have asked to have
an option to tell it to evaluate the expressio
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/147603
LLDB breakpoint conditions take an expression that's evaluated using the
language of the code where the breakpoint is located. Users have asked to have
an option to tell it to evaluate the expression in a
Author: Kazu Hirata
Date: 2025-07-08T15:00:08-07:00
New Revision: 4647398d6a44d4596c6716875d8d92750f731f90
URL:
https://github.com/llvm/llvm-project/commit/4647398d6a44d4596c6716875d8d92750f731f90
DIFF:
https://github.com/llvm/llvm-project/commit/4647398d6a44d4596c6716875d8d92750f731f90.diff
L
augusto2112 wrote:
> Here is the problem with types: initial scalar literal type, all the type
> promotions and conversions are done using `lldb::BasicType` enumeration
> types, and later converted to `CompilerType` using the `TypeSystem`. In C++,
> this works perfectly well, because in
> [`T
https://github.com/slydiman approved this pull request.
LGTM.
But I agree that
> it is hard to ensure a race condition is fixed without running the CI on
> multiple machines/configurations.
https://github.com/llvm/llvm-project/pull/147438
___
lldb-co
@@ -61,8 +61,10 @@ class PathMappingList {
return m_pairs.size();
}
- bool GetPathsAtIndex(uint32_t idx, ConstString &path,
- ConstString &new_path) const;
+ /// Invokes callback for each pair of paths in the list. The callback can
+ /// return f
https://github.com/YexuanXiao edited
https://github.com/llvm/llvm-project/pull/143653
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
YexuanXiao wrote:
The failed tests in CI are allowed to fail. See the
[comment](https://github.com/llvm/llvm-project/pull/135386#issuecomment-3049426611)
in another PR #135386.
https://github.com/llvm/llvm-project/pull/143653
___
lldb-commits mailing
cjdb wrote:
@vogelsgesang, this patch is only changing `__split_buffer`. The intention was
for this patch to be quickly merged, and for the feedback from this patch to
influence the changes to `vector` (thereby minimising churn and repeated
comments). Changes
https://github.com/satyajanga edited
https://github.com/llvm/llvm-project/pull/147434
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/147438
>From 8a60d1cbd3d75e640d5efddf23c717278e7d6b80 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Mon, 7 Jul 2025 17:31:25 -0700
Subject: [PATCH 1/3] [lldb] Improving synchronization of MainLoopWindows.
This sho
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/146966
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/147438
>From 8a60d1cbd3d75e640d5efddf23c717278e7d6b80 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Mon, 7 Jul 2025 17:31:25 -0700
Subject: [PATCH 1/4] [lldb] Improving synchronization of MainLoopWindows.
This sho
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp --
lldb/source/Host/windows/MainLoopWindows.cpp
lldb/un
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/147438
>From 8a60d1cbd3d75e640d5efddf23c717278e7d6b80 Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Mon, 7 Jul 2025 17:31:25 -0700
Subject: [PATCH 1/2] [lldb] Improving synchronization of MainLoopWindows.
This sho
https://github.com/ashgti approved this pull request.
https://github.com/llvm/llvm-project/pull/146966
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/147529
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/147525
>From ce9eaf42172580aac1d97e109d8713ba59c3c91a Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Tue, 8 Jul 2025 15:21:28 +0100
Subject: [PATCH 1/2] [lldb][test] Merge MSVC STL std::(u8)string tests into
gen
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: nerix (Nerixyz)
Changes
This adds synthetic child providers for `std::vector` and
`std::vector` for MSVC's STL.
The structure of a `std::vector` is relatively similar to libc++'s
implementation that uses `__begin` and `__end`.
https://github.com/Nerixyz created
https://github.com/llvm/llvm-project/pull/147538
This adds synthetic child providers for `std::vector` and
`std::vector` for MSVC's STL.
The structure of a `std::vector` is relatively similar to libc++'s
implementation that uses `__begin` and `__end`.
`std::
Author: Michael Buch
Date: 2025-07-08T15:22:38+01:00
New Revision: d338d197e7ee6e6f8986e14b2aec9d4c368d8a9e
URL:
https://github.com/llvm/llvm-project/commit/d338d197e7ee6e6f8986e14b2aec9d4c368d8a9e
DIFF:
https://github.com/llvm/llvm-project/commit/d338d197e7ee6e6f8986e14b2aec9d4c368d8a9e.diff
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/147529
This just moves the test from `libcxx` to `generic`. There are currently no
`std::queue` formatters for libstdc++ so I didn't add a test-case for it.
Split out from https://github.com/llvm/llvm-project/pull/
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/147529
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Nerixyz wrote:
> prints as `"abc"`. But libc++ and libstdc++ print it as `"abcd"` (which seems
> like the more correct thing to do?)
This is too MSVC STL/libc++ specific, I think. `std::string` on MSVC's STL
always has a valid size (regardless of SSO or not) and the test tests that this
is re
labath wrote:
> But libc++ and libstdc++ print it as "abcd" (which seems like the more
> correct thing to do?)
I'm not so sure about that. std::string has a separate length field and it can
contain embedded nul characters, so I can at least understand the idea of
trusting the length field mo
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This just moves the test from `libcxx` to `generic`. There are currently no
`std::queue` formatters for libstdc++ so I didn't add a test-case for it.
Split out from https://github.com/llvm/llvm-project/pul
Michael137 wrote:
FYI @Nerixyz
https://github.com/llvm/llvm-project/pull/147525
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
Now that most STL formatter tests have been moved to `generic`. Do the same for
the MSVC tests (which are currently just for `std::string`). The `std::string`
test was mostly the same (MSVC just had 1 addi
https://github.com/Michael137 created
https://github.com/llvm/llvm-project/pull/147525
Now that most STL formatter tests have been moved to `generic`. Do the same for
the MSVC tests (which are currently just for `std::string`). The `std::string`
test was mostly the same (MSVC just had 1 additi
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/147340
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-07-08T14:45:15+01:00
New Revision: f184ddde1bc5de1bba0e25780cb25f435909
URL:
https://github.com/llvm/llvm-project/commit/f184ddde1bc5de1bba0e25780cb25f435909
DIFF:
https://github.com/llvm/llvm-project/commit/f184ddde1bc5de1bba0e25780cb25f435909.diff
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/147175
>From 24240c7efa951340d7f19e0f74d1075ab100598e Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Sun, 6 Jul 2025 07:49:57 +0100
Subject: [PATCH 1/3] [lldb][test] Combine libstdc++ and libc++ iterator tests
i
hokein wrote:
> Ah, not a problem, the new one is fine. I was just very thrown/wondering why
> I was reviewing something so similar again.
Sorry for not being clearer about that. I’ll go ahead and close the previous
review. The new one should already incorporate your review comments from the
labath wrote:
> > Sorry for going off-topic, but what does this say about the support for
> > `i386-apple-*` as a whole? I find the prospect of dropping that exciting,
> > as I believe that is the only target where eh_ and debug_frame register
> > numbers are different.
>
> I think we can rem
https://github.com/labath commented:
I'm not very fond of the amount of validity checks this PR is adding. What's up
with that? Is it somehow related to you passing a non-nullptr-but-uninitialized
Connection object (`std::make_unique()`) into the
AdbClient? Any chance to get rid of that? Maybe
@@ -665,3 +655,40 @@ Status
AdbClient::SyncService::PullFileChunk(std::vector &buffer,
Status AdbClient::SyncService::ReadAllBytes(void *buffer, size_t size) {
return ::ReadAllBytes(*m_conn, buffer, size);
}
+
+Status AdbClient::SyncService::SetupSyncConnection(const std::st
@@ -241,6 +234,10 @@ Status AdbClient::SendDeviceMessage(const std::string
&packet) {
Status AdbClient::ReadMessage(std::vector &message) {
message.clear();
+ if (!m_conn) {
labath wrote:
https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simp
@@ -580,17 +564,23 @@ bool AdbClient::SyncService::IsConnected() const {
return m_conn && m_conn->IsConnected();
}
-AdbClient::SyncService::SyncService(std::unique_ptr &&conn)
-: m_conn(std::move(conn)) {}
+AdbClient::SyncService::SyncService(std::unique_ptr conn, const
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/147340
>From dba291d4b0b5ac6e62cfc084340cc0524d15d51c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 7 Jul 2025 14:45:59 +0100
Subject: [PATCH 1/3] [lldb][Formatters] Consistently unwrap pointer
element_typ
athierry-oct wrote:
@JDevlieghere done!
https://github.com/llvm/llvm-project/pull/144919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/athierry-oct updated
https://github.com/llvm/llvm-project/pull/144919
>From 28e1078877df5466dec8791a7b2c8a2da1633bed Mon Sep 17 00:00:00 2001
From: Adrien Thierry
Date: Thu, 3 Jul 2025 10:13:28 -0400
Subject: [PATCH] [lldb] Transfer events from previous listener when hijackin
erichkeane wrote:
> > Why is this a new review? What changed from the last one I looked at?
>
> Ah, right -- this patch is actually derived from the previous one, and it is
> simpler. That older patch became a bit outdated since some of its changes
> were split out and already landed in main.
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/147340
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -19,6 +19,11 @@ namespace formatters {
bool GenericOptionalSummaryProvider(ValueObject &valobj, Stream &stream,
const TypeSummaryOptions &options);
+/// Return the ValueObjectSP of the underlying pointer member whose type
+/// is a desuga
https://github.com/labath approved this pull request.
I find `Generic.h` a bit... generic, but it's there, so ship it.
https://github.com/llvm/llvm-project/pull/147340
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
Author: Michael Buch
Date: 2025-07-08T14:09:48+01:00
New Revision: 1f28da60d5dfa51b1e623fdd168fbb3ea85f6ac9
URL:
https://github.com/llvm/llvm-project/commit/1f28da60d5dfa51b1e623fdd168fbb3ea85f6ac9
DIFF:
https://github.com/llvm/llvm-project/commit/1f28da60d5dfa51b1e623fdd168fbb3ea85f6ac9.diff
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/147355
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/147253
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-07-08T14:09:32+01:00
New Revision: d9b208b4d31d863c86e27e8889a521a82385f1a7
URL:
https://github.com/llvm/llvm-project/commit/d9b208b4d31d863c86e27e8889a521a82385f1a7
DIFF:
https://github.com/llvm/llvm-project/commit/d9b208b4d31d863c86e27e8889a521a82385f1a7.diff
Michael137 wrote:
> This looks good. The problem with caching is not related to this patch.
>
> > For now i think I'll probably i'll reset the formatters in the teardown
> > hook, but @jimingham comment on #110767 might be a good follow-up:
> > > Since this is just an optimization, we should fi
https://github.com/labath approved this pull request.
FWIW, I don't find `(null)` nor `Summary Unavailable` particularly good
summaries for `(std::string*)NULL`. At least in Python, I believe that
returning an empty string from the summary provider causes lldb to treat it as
not present and sh
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/146966
>From cc0846ca1aa8e302806154b3576698aa1c97dd0d Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Tue, 8 Jul 2025 13:57:57 +0100
Subject: [PATCH] [lldb-dap] Use protocol-types for modules request
---
.../test/t
https://github.com/labath approved this pull request.
This looks good. The problem with caching is not related to this patch.
> For now i think I'll probably i'll reset the formatters in the teardown hook,
> but @jimingham comment on #110767 might be a good follow-up:
>
> > Since this is just
Michael137 wrote:
For std::vector this patch didn't actually change anything about the vector
layout. It just changed some accesses in
__swap_out_circular_buffer/insert/emplace. LLDB formatters don't rely on those
functions. They most rely on the data members
vogelsgesang wrote:
But at least `std::vector` (i.e. what this commit here is targetting) is
already ported over to C++. Instead of / In addition to modifying the example
code, shouldn't this PR also update `LibCxxVector.cpp`?
https://github.com/llvm/llvm-pro
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/147253
>From e592d39c751480838ed90fcaa2b247e96b5bab59 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Sun, 6 Jul 2025 09:58:02 +0100
Subject: [PATCH 1/7] [lldb][test] Combine libstdc++ and libc++ std::variant
tes
Michael137 wrote:
For now i think I'll probably i'll reset the formatters in the teardown hook,
but Jim's comment on https://github.com/llvm/llvm-project/pull/110767 might be
a good follow-up;
> The narrowest solution is that when you go to cache a type name -> formatter
> pair, you should f
Michael137 wrote:
Yea I can repro this if I use the same debugger instance to debug a target
compiled against libc++, then print the typedef, and then debug a libstdc++
target.
I think the issue is that the formatter infra caches `typedef name ->
formatter`. So we would try using the libc++ f
Michael137 wrote:
Hah i can repro it when i run both libcxx and libstdcxx tests together
(previously i just ran with `--category libstdcxx`).
Could this be another instance of https://reviews.llvm.org/D66398? Though i
thought that's fixed now though...
https://github.com/llvm/llvm-project/pull
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-x86_64-win` running
on `as-builder-10` while building `lldb` at step 8 "test-check-lldb-unit".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/211/builds/321
Here is the relevant piece of the bui
Michael137 wrote:
Confused why the variant tests fail for libstdc++ (they don't locally)
https://github.com/llvm/llvm-project/pull/147253
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
Michael137 wrote:
Bit unfortunate because I personally zoom (i.e., resize) in and out of tmux
panes a lot to see more of the LLDB output. Now it would clear the screen. But
I understand why the trade-off was made
https://github.com/llvm/llvm-project/pull/146578
Author: nerix
Date: 2025-07-08T09:55:18+01:00
New Revision: 45689b26eb4bfa619127013dccea8efd8de4d21a
URL:
https://github.com/llvm/llvm-project/commit/45689b26eb4bfa619127013dccea8efd8de4d21a
DIFF:
https://github.com/llvm/llvm-project/commit/45689b26eb4bfa619127013dccea8efd8de4d21a.diff
LOG: [L
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/143177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
lbfalvy wrote:
Until this is fixed, how would I determine the specific Python build I need to
install for LLDB to work? A related issue mentioned 3.10.11 but that no longer
seems correct so a way to find this info for ourself would be useful.
https://github.com/llvm/llvm-project/pull/137467
__
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/147355
>From 78533da4cfb0c5d5f9f142cce19609810e630dd7 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 7 Jul 2025 18:36:57 +0100
Subject: [PATCH 1/4] [lldb][test] Combine libstdc++ and libc++ std::string
test
Michael137 wrote:
> I'm not entirely comfortable with putting the (obviously c++ specific) helper
> function into the DataFormatters) library. There's no reason to call this
> from outside the c++ language plugin, right? What would you say to putting
> this into some header inside the plugin (
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/147340
>From dba291d4b0b5ac6e62cfc084340cc0524d15d51c Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 7 Jul 2025 14:45:59 +0100
Subject: [PATCH 1/2] [lldb][Formatters] Consistently unwrap pointer
element_typ
DavidSpickett wrote:
> Relands the commit to upstream the lldb-rpc-gen tool in order to fix a build
> failure on the linux remote bots.
And changes what when compared to the original PR?
https://github.com/llvm/llvm-project/pull/147417
___
lldb-commi
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/147139
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Michael Buch
Date: 2025-07-08T09:01:10+01:00
New Revision: fd997d86f060c8110a6b5151e8f21c4e4e17ba4a
URL:
https://github.com/llvm/llvm-project/commit/fd997d86f060c8110a6b5151e8f21c4e4e17ba4a
DIFF:
https://github.com/llvm/llvm-project/commit/fd997d86f060c8110a6b5151e8f21c4e4e17ba4a.diff
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Michael Buch (Michael137)
Changes
This combines the libc++ and libstdc++ test cases. The main difference was that
the libstdcpp tests had additional tests for references/pointers to
std::string. I moved those over.
The libstdc++ formatter
https://github.com/Michael137 ready_for_review
https://github.com/llvm/llvm-project/pull/147355
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/147355
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/147355
>From 78533da4cfb0c5d5f9f142cce19609810e630dd7 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Mon, 7 Jul 2025 18:36:57 +0100
Subject: [PATCH 1/3] [lldb][test] Combine libstdc++ and libc++ std::string
test
@@ -65,15 +66,21 @@ class PipeEvent : public MainLoopWindows::IOEvent {
}
void WillPoll() override {
-if (!m_monitor_thread.joinable())
- m_monitor_thread = std::thread(&PipeEvent::Monitor, this);
+// If the m_event is signaled, wait until it is consumed befor
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/147438
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
Thanks. I like how this means we no longer create the thread lazily.
I think I see one more race, see inline comment. LGTM assuming you agree with
my analysis.
https://github.com/llvm/llvm-project/pull/147438
___
@@ -110,6 +117,7 @@ class PipeEvent : public MainLoopWindows::IOEvent {
continue;
}
+ ResetEvent(m_ready);
SetEvent(m_event);
labath wrote:
I think there's still a race here where if `WillPoll` runs between these two
calls, it will
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/147253
>From e592d39c751480838ed90fcaa2b247e96b5bab59 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Sun, 6 Jul 2025 09:58:02 +0100
Subject: [PATCH 1/6] [lldb][test] Combine libstdc++ and libc++ std::variant
tes
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/147139
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
> I'm not entirely comfortable with putting the (obviously c++ specific) helper
> function into the DataFormatters) library. There's no reason to call this
> from outside the c++ language plugin, right? What would you say to putting
> this into some header inside the plugin (
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/147139
>From 2fcd6b1084a6cf91c82aef0ebf78208eda868335 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Sat, 5 Jul 2025 11:15:23 +0100
Subject: [PATCH 1/6] [lldb][test] Combine libstdc++ and libc++ tuple tests
into
97 matches
Mail list logo
