Michael137 wrote:
@labath @jimingham any final comments? Otherwise happy to merge
https://github.com/llvm/llvm-project/pull/143177
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Michael137 wrote:
Hmm weirdly doesn't repro on my machine. Also only happens on the AArch64 bot
(but not x86_64). Bit confused.
https://github.com/llvm/llvm-project/pull/146094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
Author: Michael Buch
Date: 2025-07-04T07:39:13+01:00
New Revision: 59e812f2eed8be9674efa42cdbfe4a9d1fb57052
URL:
https://github.com/llvm/llvm-project/commit/59e812f2eed8be9674efa42cdbfe4a9d1fb57052
DIFF:
https://github.com/llvm/llvm-project/commit/59e812f2eed8be9674efa42cdbfe4a9d1fb57052.diff
Michael137 wrote:
I think if you used the address of the static maybe it would force dsymutil to
keep it? Let me check
https://github.com/llvm/llvm-project/pull/146094
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/jimingham edited
https://github.com/llvm/llvm-project/pull/146773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -181,7 +181,17 @@ void EvaluateRequestHandler::operator()(
expression = dap.last_nonempty_var_expression;
else
dap.last_nonempty_var_expression = expression;
+} else {
+ // If this isn't a REPL context, trim leading pointer/reference
character
https://github.com/jasonmolenda approved this pull request.
Seems like a reasonable RP to me.
https://github.com/llvm/llvm-project/pull/146972
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lld
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/146166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp --
lldb/include/lldb/Utility/GPUGDBRemotePackets.h
ll
clayborg wrote:
This didn't come out right... This should be for my GPU branch only.
https://github.com/llvm/llvm-project/pull/146978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/146978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -181,7 +181,17 @@ void EvaluateRequestHandler::operator()(
expression = dap.last_nonempty_var_expression;
else
dap.last_nonempty_var_expression = expression;
+} else {
+ // If this isn't a REPL context, trim leading pointer/reference
character
@@ -46,6 +48,107 @@ static bool ShouldDisplayAssemblySource(
return false;
}
+static uint64_t GetDebugInfoSizeInSection(lldb::SBSection section) {
+ uint64_t debug_info_size = 0;
+ const llvm::StringRef section_name(section.GetName());
+ if (section_name.starts_with(".deb
@@ -7,64 +7,43 @@
//===--===//
#include "DAP.h"
-#include "EventHelper.h"
-#include "JSONUtils.h"
+#include "ProtocolUtils.h"
#include "RequestHandler.h"
+using namespace lldb_dap::protocol;
namespace lld
https://github.com/JDevlieghere commented:
Can you separate out the functional changes and the protocol-type-related
non-functional changes?
https://github.com/llvm/llvm-project/pull/146966
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
ht
@@ -1347,45 +1347,7 @@ void DAP::EventThread() {
SendStdOutStdErr(*this, process);
}
} else if (lldb::SBTarget::EventIsTargetEvent(event)) {
-if (event_mask & lldb::SBTarget::eBroadcastBitModulesLoaded ||
-event_mask & lldb::SBTarget:
@@ -46,6 +48,107 @@ static bool ShouldDisplayAssemblySource(
return false;
}
+static uint64_t GetDebugInfoSizeInSection(lldb::SBSection section) {
+ uint64_t debug_info_size = 0;
+ const llvm::StringRef section_name(section.GetName());
+ if (section_name.starts_with(".deb
@@ -743,6 +743,48 @@ bool fromJSON(const llvm::json::Value &,
DisassembledInstruction &,
llvm::json::Path);
llvm::json::Value toJSON(const DisassembledInstruction &);
+struct Module {
+ /// Unique identifier for the module.
+ std::string id;
+
+ /// A name of
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/146966
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
This RP changes some Breakpoint-related interfaces to return errors. On its own
these improvements are small, but they encourage better error handling going
forward. There are a bunch of other candi
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/146972
This RP changes some Breakpoint-related interfaces to return errors. On its own
these improvements are small, but they encourage better error handling going
forward. There are a bunch of other candidates,
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Chelsea Cassanova (chelcassanova)
Changes
Reverts llvm/llvm-project#138031. This is failing during the build
phase on the Ubuntu buildbot:
```
Error while processing
/home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/llvm-project/
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/146969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2025-07-03T15:53:40-07:00
New Revision: 7e04bfbf18c9c65866d5f18e902b24604ea7da5f
URL:
https://github.com/llvm/llvm-project/commit/7e04bfbf18c9c65866d5f18e902b24604ea7da5f
DIFF:
https://github.com/llvm/llvm-project/commit/7e04bfbf18c9c65866d5f18e902b24604ea7da5f.d
https://github.com/chelcassanova created
https://github.com/llvm/llvm-project/pull/146969
Reverts llvm/llvm-project#138031. This is failing during the build phase on the
Ubuntu buildbot:
```
Error while processing
/home/buildbot/worker/as-builder-9/lldb-remote-linux-ubuntu/llvm-project/lldb/in
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-remote-linux-ubuntu`
running on `as-builder-9` while building `lldb` at step 7 "build-default".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/195/builds/11340
Here is the relevant piece of the
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/138031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2025-07-03T15:31:17-07:00
New Revision: 9bfb347ea0a0a260eb505921dfc0cb824a6ced5d
URL:
https://github.com/llvm/llvm-project/commit/9bfb347ea0a0a260eb505921dfc0cb824a6ced5d
DIFF:
https://github.com/llvm/llvm-project/commit/9bfb347ea0a0a260eb505921dfc0cb824a6ced5d.d
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/146966
>From 8ece8558ed3caebf6a58772d9aa81d7f82a5b564 Mon Sep 17 00:00:00 2001
From: Ebuka Ezike
Date: Sun, 22 Jun 2025 08:28:54 +0100
Subject: [PATCH 1/5] [lldb-dap] Use protocol-types for modules request
---
.../H
https://github.com/chelcassanova closed
https://github.com/llvm/llvm-project/pull/146425
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Chelsea Cassanova
Date: 2025-07-03T15:09:15-07:00
New Revision: 45083dc4d2248b2e3f331af745459f2011db4b7f
URL:
https://github.com/llvm/llvm-project/commit/45083dc4d2248b2e3f331af745459f2011db4b7f
DIFF:
https://github.com/llvm/llvm-project/commit/45083dc4d2248b2e3f331af745459f2011db4b7f.d
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/146425
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/146425
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/bulbazord approved this pull request.
Ok, this makes sense to me now. LGTM.
https://github.com/llvm/llvm-project/pull/146425
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
da-viper wrote:
Not to sure if I should split it into different PR since they are all module
related.
https://github.com/llvm/llvm-project/pull/146966
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Ebuka Ezike (da-viper)
Changes
Can now limit the number of modules fetched.
Show the non-standard `debugInfoSize` field in the vs-code extension.
Update tests to fix silently failing test and handle when a module is removed.
---
Patch
https://github.com/da-viper created
https://github.com/llvm/llvm-project/pull/146966
Can now limit the number of modules fetched.
Show the non-standard `debugInfoSize` field in the vs-code extension.
Update tests to fix silently failing test and handle when a module is removed.
>From c98a51
Author: Jonas Devlieghere
Date: 2025-07-03T14:37:05-07:00
New Revision: 1725cc025e8faa8dc0fd8799bc277e2c0f0f8c1c
URL:
https://github.com/llvm/llvm-project/commit/1725cc025e8faa8dc0fd8799bc277e2c0f0f8c1c
DIFF:
https://github.com/llvm/llvm-project/commit/1725cc025e8faa8dc0fd8799bc277e2c0f0f8c1c.d
https://github.com/adrian-prantl closed
https://github.com/llvm/llvm-project/pull/146963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
adrian-prantl wrote:
I pushed this manually as 0b98b27930da.
https://github.com/llvm/llvm-project/pull/146963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: CodingCarpincho
Date: 2025-07-03T14:20:31-07:00
New Revision: 0b98b27930dad5ff59de050605c3f101330a2b5c
URL:
https://github.com/llvm/llvm-project/commit/0b98b27930dad5ff59de050605c3f101330a2b5c
DIFF:
https://github.com/llvm/llvm-project/commit/0b98b27930dad5ff59de050605c3f101330a2b5c.dif
https://github.com/adrian-prantl updated
https://github.com/llvm/llvm-project/pull/146963
>From 16b7748cf38aaade5185a1073d2755abb2c40d12 Mon Sep 17 00:00:00 2001
From: CodingCarpincho
Date: Thu, 3 Jul 2025 13:54:46 -0700
Subject: [PATCH] Use the root directory as the SDK root on POSIX platforms
@@ -39,6 +39,7 @@ class HostInfoPosix : public HostInfoBase {
static llvm::VersionTuple GetOSVersion();
static std::optional GetOSBuildString();
+ static llvm::Expected GetSDKRoot(SDKOptions options);
CodingCarpincho wrote:
To put it simply, because the
Author: Jonas Devlieghere
Date: 2025-07-03T14:19:09-07:00
New Revision: 17cb0a73a0542da3477ac94c3fddfa05c20888f8
URL:
https://github.com/llvm/llvm-project/commit/17cb0a73a0542da3477ac94c3fddfa05c20888f8
DIFF:
https://github.com/llvm/llvm-project/commit/17cb0a73a0542da3477ac94c3fddfa05c20888f8.d
CodingCarpincho wrote:
👍🏼
https://github.com/llvm/llvm-project/pull/146963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -39,6 +39,7 @@ class HostInfoPosix : public HostInfoBase {
static llvm::VersionTuple GetOSVersion();
static std::optional GetOSBuildString();
+ static llvm::Expected GetSDKRoot(SDKOptions options);
adrian-prantl wrote:
That's existing API.
https://gi
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp --
lldb/include/lldb/Host/posix/HostInfoPosix.h
lldb/
https://github.com/JDevlieghere approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/146963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -39,6 +39,7 @@ class HostInfoPosix : public HostInfoBase {
static llvm::VersionTuple GetOSVersion();
static std::optional GetOSBuildString();
+ static llvm::Expected GetSDKRoot(SDKOptions options);
JDevlieghere wrote:
Why not a `FileSpec`?
https://gi
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/146963
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Adrian Prantl (adrian-prantl)
Changes
LLDB has the concept of an "SDK root", which expresses where the system
libraries and so which are necessary for debugging can be found. On POSIX
platforms, the SDK root is just the root of the file sy
https://github.com/adrian-prantl created
https://github.com/llvm/llvm-project/pull/146963
LLDB has the concept of an "SDK root", which expresses where the system
libraries and so which are necessary for debugging can be found. On POSIX
platforms, the SDK root is just the root of the file syste
chelcassanova wrote:
Ok I was being way overkill with this patch, I updated it so that the script
creates the output directories if it doesn't exist.
https://github.com/llvm/llvm-project/pull/146425
___
lldb-commits mailing list
lldb-commits@lists.llv
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/146425
>From 7b11f001e18d0f8d641448cac63181c9ed3c33e8 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Mon, 30 Jun 2025 14:51:43 -0700
Subject: [PATCH] [lldb][framework] Copy framework files correctly
A bu
slydiman wrote:
> I think you're looking for `@skipIf(hostoslist=["windows"])`
Yes, it looks more correct. But can a Unix socket be used for a remote
connection?
https://github.com/llvm/llvm-project/pull/146807
___
lldb-commits mailing list
lldb-comm
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/146801
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-07-03T13:46:47-07:00
New Revision: 1995fd9ac6be4ff0822589f00d5fcaa12688eb87
URL:
https://github.com/llvm/llvm-project/commit/1995fd9ac6be4ff0822589f00d5fcaa12688eb87
DIFF:
https://github.com/llvm/llvm-project/commit/1995fd9ac6be4ff0822589f00d5fcaa12688eb87.d
https://github.com/adrian-prantl approved this pull request.
https://github.com/llvm/llvm-project/pull/146801
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/tedwoodward updated
https://github.com/llvm/llvm-project/pull/145793
>From 1a7ee4297bb8e6b3fa08818e05cf245a2c768c2b Mon Sep 17 00:00:00 2001
From: Ted Woodward
Date: Wed, 25 Jun 2025 14:22:28 -0700
Subject: [PATCH 1/3] Support disassembling RISC-V proprietary insns
RISC-V su
https://github.com/medismailben approved this pull request.
https://github.com/llvm/llvm-project/pull/138031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
tedwoodward wrote:
@DavidSpickett @jasonmolenda I uploaded a new change. It has:
- Use the exe_ctx version of python command, and HandleCommand
- Set a variable max_byte_width, and use that instead if "max_opcode_byte_size
* 3 + 1" in 3 different places
- Split up RISCVPrettyPrinter comment, pu
jimingham wrote:
I don't think the locking should be a real issue. You should only hold the
m_events mutex for a listener when adding or removing an event from the
Listener's event queue. But it doesn't make sense to actually do work when
handing off the event.
For instance, the primary p
https://github.com/tedwoodward updated
https://github.com/llvm/llvm-project/pull/145793
>From 1a7ee4297bb8e6b3fa08818e05cf245a2c768c2b Mon Sep 17 00:00:00 2001
From: Ted Woodward
Date: Wed, 25 Jun 2025 14:22:28 -0700
Subject: [PATCH 1/2] Support disassembling RISC-V proprietary insns
RISC-V su
https://github.com/DrSergei updated
https://github.com/llvm/llvm-project/pull/146950
>From 112050c1d826ef483b84d1067905ae10aabe31fb Mon Sep 17 00:00:00 2001
From: Druzhkov Sergei
Date: Wed, 2 Jul 2025 23:29:26 +0300
Subject: [PATCH] [lldb-dap] Add external terminal support
---
.../test/tools/
github-actions[bot] wrote:
:warning: Python code formatter, darker found issues in your code. :warning:
You can test this locally with the following command:
``bash
darker --check --diff -r HEAD~1...HEAD
lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py
lldb/test/
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (DrSergei)
Changes
Popular debugger extensions, such as cpptools (`externalConsole` option) and
codelldb (`terminal` option), support launching program in external console.
This patch change behavior of `runInTerminal` option similar
https://github.com/DrSergei created
https://github.com/llvm/llvm-project/pull/146950
Popular debugger extensions, such as cpptools (`externalConsole` option) and
codelldb (`terminal` option), support launching program in external console.
This patch change behavior of `runInTerminal` option s
https://github.com/jimingham approved this pull request.
I don't think we ever have a use case where the Hijack listener would only want
to see "new" events after the Hijack point. And that's certainly not what we
want for process events where the full sequence is important. So the behavior
tedwoodward wrote:
> For that matter, given that you're already requiring the use of a python
> command `fdis`, is this something that could be formatted from the
> SBInstructions in `fdis`? It does mean that you need to parse the arguments
> instead of passing them to `disassemble`, get back
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From 15f195fb304775578812836621fcf88ed9bff9db Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
cs01 wrote:
It has been a week since the last update was published. Friendly ping to
@labath @jeffreytan81
https://github.com/llvm/llvm-project/pull/145382
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
athierry-oct wrote:
I've just pushed a new version that moves the pending events from the previous
listener to the hijack listener when hijacking, and vice-versa when restoring
the previous listener.
In the patch:
- Transferring the events between listeners is done atomically with
adding/rem
https://github.com/athierry-oct updated
https://github.com/llvm/llvm-project/pull/144919
>From 52cb93996bf3d59036b84acce96c649724cf8711 Mon Sep 17 00:00:00 2001
From: Adrien Thierry
Date: Thu, 3 Jul 2025 10:13:28 -0400
Subject: [PATCH] [lldb] Transfer events from previous listener when hijackin
Jlalond wrote:
Alternative proposal and one @clayborg and I talked about for awhile. Why don't
we just put all the non-stacks into Memory64List? Originally I didn't want to
change this out of not being familiar with how everything works, but now that
we have a 64b list I think it makes sense t
chelcassanova wrote:
@DavidSpickett I think this is ready to go, I'd love if you could take another
look at this.
https://github.com/llvm/llvm-project/pull/138031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From 024f1bb0c0b8198f3ca16e54a1944d160d58a4cd Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/146602
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-07-03T11:17:19-07:00
New Revision: 378f248934d603e3fba9d958d2db997814d057d5
URL:
https://github.com/llvm/llvm-project/commit/378f248934d603e3fba9d958d2db997814d057d5
DIFF:
https://github.com/llvm/llvm-project/commit/378f248934d603e3fba9d958d2db997814d057d5.d
jimingham wrote:
> > I don't know how you are doing this, but if you are treating "hover over"
> > requests as expressions and presenting the result of some real expression
> > evaluation, you have to be quite careful about what you evaluate.
>
> The corresponding DAP request is called "expres
https://github.com/chelcassanova edited
https://github.com/llvm/llvm-project/pull/138031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@jeffreytan81 Sure, but I'll have to revisit after I return from vacation
https://github.com/llvm/llvm-project/pull/146777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
chelcassanova wrote:
The last test failure happening was this:
```
https://github.com/llvm/llvm-project/pull/138031
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From 761601040deae05ab7aa5314c09af5a47d92662b Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
JDevlieghere wrote:
> I don't know how you are doing this, but if you are treating "hover over"
> requests as expressions and presenting the result of some real expression
> evaluation, you have to be quite careful about what you evaluate.
The corresponding DAP request is called "expression" w
jeffreytan81 wrote:
Can you please split the PR into two? One for improving testing/diagnosibility,
the other for the real fix?
https://github.com/llvm/llvm-project/pull/146777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.l
https://github.com/jimingham approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/146602
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/146801
>From 1e71640c0bb0e3a680adf12679df6cbeda6c3aed Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 2 Jul 2025 15:31:54 -0700
Subject: [PATCH 1/2] [lldb] Extract DW_OP_deref evaluation code (NFC)
Th
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/146602
>From 6b5d9075cf7b1e6aec0b4969695f88613e715783 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Tue, 1 Jul 2025 16:02:21 -0700
Subject: [PATCH] [lldb] Add SB API to make a breakpoint a hardware breakp
@@ -860,6 +860,64 @@ ResolveLoadAddress(ExecutionContext *exe_ctx,
lldb::ModuleSP &module_sp,
return load_addr;
}
+static llvm::Error Evaluate_DW_OP_deref(DWARFExpression::Stack &stack,
+ExecutionContext *exe_ctx,
+
jimingham wrote:
I don't know how you are doing this, but if you are treating "hover over"
requests as expressions and presenting the result of some real expression
evaluation, you have to be quite careful about what you evaluate. For
instance, you want to make sure that hovering over
` i++
https://github.com/charles-zablit closed
https://github.com/llvm/llvm-project/pull/146903
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Charles Zablit
Date: 2025-07-03T18:22:42+01:00
New Revision: 8d3dbdb00f8f4b4953a7e2a13906dc3fce635d5d
URL:
https://github.com/llvm/llvm-project/commit/8d3dbdb00f8f4b4953a7e2a13906dc3fce635d5d
DIFF:
https://github.com/llvm/llvm-project/commit/8d3dbdb00f8f4b4953a7e2a13906dc3fce635d5d.diff
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/146578
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-07-03T10:21:49-07:00
New Revision: 2f75f658b18aed4bbcab391063bceb7ccaf8a6ec
URL:
https://github.com/llvm/llvm-project/commit/2f75f658b18aed4bbcab391063bceb7ccaf8a6ec
DIFF:
https://github.com/llvm/llvm-project/commit/2f75f658b18aed4bbcab391063bceb7ccaf8a6ec.d
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/146903
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -251,6 +251,44 @@ const lldb::TargetSP Breakpoint::GetTargetSP() {
bool Breakpoint::IsInternal() const { return LLDB_BREAK_ID_IS_INTERNAL(m_bid);
}
+llvm::Error Breakpoint::SetIsHardware(bool is_hardware) {
+ if (is_hardware == m_hardware)
+return llvm::Error::succes
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From 682d39236976acb0fed92a5b7347427c38789dc9 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
https://github.com/chelcassanova updated
https://github.com/llvm/llvm-project/pull/138031
>From a454d432e9030b85e0b6330ab3b6a110eee67c67 Mon Sep 17 00:00:00 2001
From: Chelsea Cassanova
Date: Wed, 30 Apr 2025 14:15:39 -0700
Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool
This commit up
https://github.com/jimingham approved this pull request.
I think only Enrico might know why he called it this, and he's not working on
lldb anymore.
https://github.com/llvm/llvm-project/pull/146784
___
lldb-commits mailing list
lldb-commits@lists.llvm
jimingham wrote:
> We can add a button to the variables UI or a context menu entry for running
> the description. I can switch to that instead.
I think that's the better way to go. If you do this, the View that's going to
display the description has to be expandable and scrollable, since thes
1 - 100 of 230 matches
Mail list logo
