jimingham wrote:

> > I don't know how you are doing this, but if you are treating "hover over" 
> > requests as expressions and presenting the result of some real expression 
> > evaluation, you have to be quite careful about what you evaluate.
> 
> The corresponding DAP request is called "expression" which is somewhat 
> confusing. The request includes a "context" (such as "repl" or "hover") which 
> allows us to do something different. Except for "repl", we always try 
> `GetValueForVariablePath` first, and only fall back to `EvaluateExpression` 
> if that fails. The exception is "hover" for which we don't do the fallback. 
> So I think we handle this correctly.

Excellent!

https://github.com/llvm/llvm-project/pull/146773
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to