[Lldb-commits] [lldb] [lldb][framework] Copy framework files correctly (PR #146425)

2025-07-01 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/146425 >From e199f4ece908cfe9454e4b4b61f04133a615f8d2 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Mon, 30 Jun 2025 14:51:43 -0700 Subject: [PATCH] [lldb][framework] Copy framework files correctly A bu

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146602 >From 656beb2df5f39604454af0e3f4a9f4b1b7e9c5f8 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 1 Jul 2025 16:02:21 -0700 Subject: [PATCH 1/2] [lldb] Add SB API to make a breakpoint a hardware b

[Lldb-commits] [lldb] [lldb] Support disassembling RISC-V proprietary instructions (PR #145793)

2025-07-01 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > > Doesn't seem the ideal format given that we have a known size, today most > > often 16/32/64, and I guess 48 for funsies. > > Standard instructions are right now only 16/32, but custom instructions can > be any multiple of 16. This was the change to llvm-objdump to grou

[Lldb-commits] [lldb] [lldb] Fixing warnings / win32 builds in MainLoop. (PR #146632)

2025-07-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Commit 1a7b7e24bcc1041ae0fb90abcfb73d36d76f4a07 introduced a few casting warnings and a build issue in Win32 platforms. Trying to correct the casts to c++ style casts instead of C style casts. --- Full diff:

[Lldb-commits] [lldb] [lldb] Fixing warnings / win32 builds in MainLoop. (PR #146632)

2025-07-01 Thread John Harrison via lldb-commits
https://github.com/ashgti ready_for_review https://github.com/llvm/llvm-project/pull/146632 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixing warnings / win32 builds in MainLoop. (PR #146632)

2025-07-01 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/146632 >From 3e0129934a74f9300a7d386797b63304a02b855f Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 1 Jul 2025 20:55:32 -0700 Subject: [PATCH] [lldb] Fixing warnings / win32 builds in MainLoop. Commit 1a7b7e2

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere converted_to_draft https://github.com/llvm/llvm-project/pull/146602 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fixing warnings / win32 builds in MainLoop. (PR #146632)

2025-07-01 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/146632 >From 14960a86f9d2f01b4ec175fe6539f8d359beaba7 Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 1 Jul 2025 20:55:32 -0700 Subject: [PATCH] [lldb] Fixing warnings / win32 builds in MainLoop. Commit 1a7b7e2

[Lldb-commits] [lldb] [lldb] Fixing warnings / win32 builds in MainLoop. (PR #146632)

2025-07-01 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- lldb/include/lldb/Host/windows/MainLoopWindows.h ll

[Lldb-commits] [lldb] [lldb] Fixing warnings / win32 builds in MainLoop. (PR #146632)

2025-07-01 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/146632 Commit 1a7b7e24bcc1041ae0fb90abcfb73d36d76f4a07 introduced a few casting warnings and a build issue in Win32 platforms. Trying to correct the casts to c++ style casts instead of C style casts. >From 7740b5aab05

[Lldb-commits] [lldb] [lldb] Support disassembling RISC-V proprietary instructions (PR #145793)

2025-07-01 Thread Sam Elliott via lldb-commits
lenary wrote: > I didn't realize that the riscv instructions had a scheme for indicating > their lengths, very convenient. It "doesn't". LLVM objdump implements the scheme described in the spec, but for >32-bit instructions, that scheme is not ratified so it could change in the future (the no

[Lldb-commits] [lldb] [lldb] Use llvm::erase_if (NFC) (PR #146624)

2025-07-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Kazu Hirata (kazutakahirata) Changes Note that erase_if combines erase and remove_if. --- Full diff: https://github.com/llvm/llvm-project/pull/146624.diff 1 Files Affected: - (modified) lldb/source/Plugins/Instruction/RISCV/EmulateInstr

[Lldb-commits] [lldb] [lldb] Use llvm::erase_if (NFC) (PR #146624)

2025-07-01 Thread Kazu Hirata via lldb-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/146624 Note that erase_if combines erase and remove_if. >From f284559ea2ba13678d65c6e68e3799e03e28a36a Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Tue, 1 Jul 2025 11:18:31 -0700 Subject: [PATCH] [lldb] Us

[Lldb-commits] [lldb] [lldb] Support disassembling RISC-V proprietary instructions (PR #145793)

2025-07-01 Thread Sam Elliott via lldb-commits
lenary wrote: > Doesn't seem the ideal format given that we have a known size, today most > often 16/32/64, and I guess 48 for funsies. Standard instructions are right now only 16/32, but custom instructions can be any multiple of 16. This was the change to llvm-objdump to group bytes like gnu

[Lldb-commits] [lldb] a87b27f - [lldb] Fix the hardware breakpoint decorator (#146609)

2025-07-01 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-01T18:01:19-07:00 New Revision: a87b27fd5161ec43527fc3356852046a321ea82c URL: https://github.com/llvm/llvm-project/commit/a87b27fd5161ec43527fc3356852046a321ea82c DIFF: https://github.com/llvm/llvm-project/commit/a87b27fd5161ec43527fc3356852046a321ea82c.d

[Lldb-commits] [lldb] [lldb] Fix the hardware breakpoint decorator (PR #146609)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/146609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix the hardware breakpoint decorator (PR #146609)

2025-07-01 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/146609 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-01 Thread via lldb-commits
jimingham wrote: I think SetIsHardware needs a return value. After all, you could have a software breakpoint set, and then make as many other hardware breakpoints as you have resources for, and THEN you go to change the software breakpoint to hardware. We need to tell the user that that didn

[Lldb-commits] [lldb] [lldb] Add SB API to make a breakpoint a hardware breakpoint (PR #146602)

2025-07-01 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: ah sure enough, ``` } else if (packet_cmd == 'z') { // remove switch (break_type) { case '0': // remove software breakpoint case '1': // remove hardware breakpoint if (DNBBreakpointClear(pid, addr)) { ``` there's no requirement to be correct about which

[Lldb-commits] [lldb] [lldb-dap] Prevent using an implicit `step-in`. (PR #143644)

2025-07-01 Thread Ebuka Ezike via lldb-commits
da-viper wrote: > The way I understand this, this patch isn't trying to fix the step over > problem (#144061). What it does is fix a different (but similar) problem in > lldb-dap where it would show the wrong source code for in cases where the > step operations ends up in a different file. And

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-07-01 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: I'm still seeing the `no job control` error in the pre-commit CI. As far as I know this error is not supposed to be happening, RPC should be getting built which should mean that the `lldb-rpc-gen` tool is available for use in the shell test. I can't repro locally, I'm wond

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-07-01 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138031 >From 1e10fc233cdf59299b3c1720838e89e6acfc07ad Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:15:39 -0700 Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool This commit up

[Lldb-commits] [lldb] When running OS Plugins from dSYM's, make sure start state is correct (PR #146441)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/146441 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] When running OS Plugins from dSYM's, make sure start state is correct (PR #146441)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/146441 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread via lldb-commits
@@ -239,122 +240,24 @@ VectorIteratorSyntheticFrontEnd::GetIndexOfChildWithName(ConstString name) { bool lldb_private::formatters::LibStdcppStringSummaryProvider( ValueObject &valobj, Stream &stream, const TypeSummaryOptions &options) { - const bool scalar_is_load_addr =

[Lldb-commits] [lldb] When running OS Plugins from dSYM's, make sure start state is correct (PR #146441)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/146441 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] When running OS Plugins from dSYM's, make sure start state is correct (PR #146441)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
@@ -9,6 +9,7 @@ #ifndef LLDB_HOST_HOSTTHREAD_H #define LLDB_HOST_HOSTTHREAD_H +#include "lldb/Host/HostNativeThreadBase.h" #include "lldb/Host/HostNativeThreadForward.h" JDevlieghere wrote: Guess this one can go now? Or we implement `HasThread` out-of-line.

[Lldb-commits] [lldb] When running OS Plugins from dSYM's, make sure start state is correct (PR #146441)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
@@ -3144,16 +3144,17 @@ void Process::CompleteAttach() { } } - if (!m_os_up) { + if (!m_os_up) LoadOperatingSystemPlugin(false); -if (m_os_up) { - // Somebody might have gotten threads before now, but we need to force the - // update after we've loa

[Lldb-commits] [clang] [lldb] [llvm] [lldb] Fix object format in the Triple of Mach-O files (approach 4) (PR #145157)

2025-07-01 Thread via lldb-commits
@@ -463,6 +463,27 @@ class Triple { const std::string &str() const { return Data; } + /// Return the triple string but only keep the first \p N components. + /// + /// The returned string will preserve the first \p N components exactly the + /// same as the original (in

[Lldb-commits] [clang] [lldb] [llvm] [lldb] Fix object format in the Triple of Mach-O files (approach 4) (PR #145157)

2025-07-01 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/145157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146578 >From a689f4c68949b7be48562295e8f2105e880a5b30 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 1 Jul 2025 10:38:22 -0700 Subject: [PATCH] [lldb] Take a sledgehammer approach to resizing the sta

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/146578 >From a57532d99ec1b46e76a388e1b2baa1f737838f62 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 1 Jul 2025 10:38:22 -0700 Subject: [PATCH] [lldb] Take a sledgehammer approach to resizing the sta

[Lldb-commits] [lldb] 3edae0d - [lldb] Use EL_REFRESH to refresh Editline

2025-07-01 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-07-01T11:08:11-07:00 New Revision: 3edae0d5e5b69a4613a0dfce32ef56eb3ffec2fb URL: https://github.com/llvm/llvm-project/commit/3edae0d5e5b69a4613a0dfce32ef56eb3ffec2fb DIFF: https://github.com/llvm/llvm-project/commit/3edae0d5e5b69a4613a0dfce32ef56eb3ffec2fb.d

[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

2025-07-01 Thread John Harrison via lldb-commits
https://github.com/ashgti edited https://github.com/llvm/llvm-project/pull/145621 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/146578 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Optimize statusline redrawing on terminal size change (PR #146435)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: Thanks for the report. I've reached the point where I'm skeptical that I'm able to get this right for every combination of OS/WM/Terminal so I think https://github.com/llvm/llvm-project/pull/146578 is the safest path forward. https://github.com/llvm/llvm-project/pull/146435

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Terminal resizing continues to be a source of statusline bugs, so much so that some users have started disabling it altogether. Different operating systems and terminal emulators exhibit subtly diff

[Lldb-commits] [lldb] [lldb][framework] Copy framework files correctly (PR #146425)

2025-07-01 Thread Chelsea Cassanova via lldb-commits
chelcassanova wrote: > My understanding was the -o ${output_header} here should place it in the > framework when ${output_header} is the right directory. So did I, but when I actually tried a build with the framework enabled the headers weren't there. Looking at this again copying the files *m

[Lldb-commits] [lldb] [lldb] Take a sledgehammer approach to resizing the statusline (PR #146578)

2025-07-01 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/146578 Terminal resizing continues to be a source of statusline bugs, so much so that some users have started disabling it altogether. Different operating systems and terminal emulators exhibit subtly different b

[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

2025-07-01 Thread John Harrison via lldb-commits
@@ -276,7 +276,7 @@ size_t ConnectionFileDescriptor::Read(void *dst, size_t dst_len, "%p ConnectionFileDescriptor::Read() fd = %" PRIu64 ", dst = %p, dst_len = %" PRIu64 ") => %" PRIu64 ", error = %s", static_cast(this), -

[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

2025-07-01 Thread John Harrison via lldb-commits
@@ -276,7 +276,7 @@ size_t ConnectionFileDescriptor::Read(void *dst, size_t dst_len, "%p ConnectionFileDescriptor::Read() fd = %" PRIu64 ", dst = %p, dst_len = %" PRIu64 ") => %" PRIu64 ", error = %s", static_cast(this), -

[Lldb-commits] [lldb] 98e6d5c - [lldb] Fix warnings

2025-07-01 Thread Kazu Hirata via lldb-commits
Author: Kazu Hirata Date: 2025-07-01T10:41:07-07:00 New Revision: 98e6d5cd47d4db020a1406032f96fd5cdfc56563 URL: https://github.com/llvm/llvm-project/commit/98e6d5cd47d4db020a1406032f96fd5cdfc56563 DIFF: https://github.com/llvm/llvm-project/commit/98e6d5cd47d4db020a1406032f96fd5cdfc56563.diff L

[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

2025-07-01 Thread James Y Knight via lldb-commits
@@ -276,7 +276,7 @@ size_t ConnectionFileDescriptor::Read(void *dst, size_t dst_len, "%p ConnectionFileDescriptor::Read() fd = %" PRIu64 ", dst = %p, dst_len = %" PRIu64 ") => %" PRIu64 ", error = %s", static_cast(this), -

[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

2025-07-01 Thread Pavel Labath via lldb-commits
labath wrote: > I was running my tests in `Release` mode, so I missed that one of the > `assert` calls had an invalid variable name. Fixed in > [a79404e](https://github.com/llvm/llvm-project/commit/a79404e50cf5308bb76cc4eaf36cb8eaea9ab66a) I recommend `cmake -DLLVM_ENABLE_ASSERTIONS=On` :) ht

[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

2025-07-01 Thread John Harrison via lldb-commits
ashgti wrote: I was running my tests in `Release` mode, so I missed that one of the `assert` calls had an invalid variable name. Fixed in https://github.com/llvm/llvm-project/commit/a79404e50cf5308bb76cc4eaf36cb8eaea9ab66a https://github.com/llvm/llvm-project/pull/145621 __

[Lldb-commits] [lldb] a79404e - [lldb] Correct an assertion name.

2025-07-01 Thread John Harrison via lldb-commits
Author: John Harrison Date: 2025-07-01T10:26:32-07:00 New Revision: a79404e50cf5308bb76cc4eaf36cb8eaea9ab66a URL: https://github.com/llvm/llvm-project/commit/a79404e50cf5308bb76cc4eaf36cb8eaea9ab66a DIFF: https://github.com/llvm/llvm-project/commit/a79404e50cf5308bb76cc4eaf36cb8eaea9ab66a.diff

[Lldb-commits] [lldb] [llvm] [lldb][NFC][MachO] Clean up LC_THREAD reading code, remove i386 corefile (PR #146480)

2025-07-01 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/146480 >From e0e19746256fa8db4b94d3b3f747b22487589be7 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 1 Jul 2025 00:32:21 -0700 Subject: [PATCH 1/2] [lldb][NFC][MachO] Clean up LC_THREAD reading code, rem

[Lldb-commits] [lldb] [llvm] [lldb][NFC][MachO] Clean up LC_THREAD reading code, remove i386 corefile (PR #146480)

2025-07-01 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > Sorry for going off-topic, but what does this say about the support for > `i386-apple-*` as a whole? I find the prospect of dropping that exciting, as > I believe that is the only target where eh_ and debug_frame register numbers > are different. I think we can remove i3

[Lldb-commits] [clang] [lldb] [llvm] [lldb] Fix object format in the Triple of Mach-O files (approach 4) (PR #145157)

2025-07-01 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/145157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][framework] Copy framework files correctly (PR #146425)

2025-07-01 Thread Alex Langford via lldb-commits
bulbazord wrote: > > If framework-header-fix.py already puts the header in the framework, why > > might we want to wholesale copy it into the framework beforehand? > > I don't think the script and build infrastructure was actually putting > everything in the framework itself, just the staging

[Lldb-commits] [clang] [lldb] [llvm] [lldb] Fix object format in the Triple of Mach-O files (approach 4) (PR #145157)

2025-07-01 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/145157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [lldb] Fix object format in the Triple of Mach-O files (approach 4) (PR #145157)

2025-07-01 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/145157 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [llvm] [lldb] Fix object format in the Triple of Mach-O files (approach 4) (PR #145157)

2025-07-01 Thread via lldb-commits
@@ -463,6 +463,27 @@ class Triple { const std::string &str() const { return Data; } + /// Return the triple string but only keep the first \p N components. + /// + /// The returned string will preserve the first \p N components exactly the + /// same as the original (in

[Lldb-commits] [lld] [lldb] [llvm] [AArch64] Support TLS variables in debug info (PR #146572)

2025-07-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Shivam Gupta (xgupta) Changes This adds an implementation of getDebugThreadLocalSymbol for AArch64 by using AArch::S_DTPREL. Fixes #83466 --- Full diff: https://github.com/llvm/llvm-project/pull/146572.diff 10 Files Affected: - (modifi

[Lldb-commits] [lld] [lldb] [llvm] [AArch64] Support TLS variables in debug info (PR #146572)

2025-07-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-mc @llvm/pr-subscribers-lld-elf Author: Shivam Gupta (xgupta) Changes This adds an implementation of getDebugThreadLocalSymbol for AArch64 by using AArch::S_DTPREL. Fixes #83466 --- Full diff: https://github.com/llvm/llvm-project/pull/146572.diff 10

[Lldb-commits] [lld] [lldb] [llvm] [AArch64] Support TLS variables in debug info (PR #146572)

2025-07-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lld Author: Shivam Gupta (xgupta) Changes This adds an implementation of getDebugThreadLocalSymbol for AArch64 by using AArch::S_DTPREL. Fixes #83466 --- Full diff: https://github.com/llvm/llvm-project/pull/146572.diff 10 Files Affected: - (modifie

[Lldb-commits] [lld] [lldb] [llvm] [AArch64] Support TLS variables in debug info (PR #146572)

2025-07-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Shivam Gupta (xgupta) Changes This adds an implementation of getDebugThreadLocalSymbol for AArch64 by using AArch::S_DTPREL. Fixes #83466 --- Full diff: https://github.com/llvm/llvm-project/pull/146572.diff 10 Files Affected: - (m

[Lldb-commits] [lld] [lldb] [llvm] [AArch64] Support TLS variables in debug info (PR #146572)

2025-07-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Shivam Gupta (xgupta) Changes This adds an implementation of getDebugThreadLocalSymbol for AArch64 by using AArch::S_DTPREL. Fixes #83466 --- Full diff: https://github.com/llvm/llvm-project/pull/146572.diff 10 Files Affected:

[Lldb-commits] [lld] [lldb] [llvm] [AArch64] Support TLS variables in debug info (PR #146572)

2025-07-01 Thread Shivam Gupta via lldb-commits
https://github.com/xgupta created https://github.com/llvm/llvm-project/pull/146572 This adds an implementation of getDebugThreadLocalSymbol for AArch64 by using AArch::S_DTPREL. Fixes #83466 >From 3be47f9a7f01b9549048722d8191ab1ff823e919 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Tue,

[Lldb-commits] [lldb] 0c124be - [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in one of its call site (#146062)

2025-07-01 Thread via lldb-commits
Author: Charles Zablit Date: 2025-07-01T16:23:23+01:00 New Revision: 0c124be33f8d2ed6ede41bcd3d8f0ca115921ef3 URL: https://github.com/llvm/llvm-project/commit/0c124be33f8d2ed6ede41bcd3d8f0ca115921ef3 DIFF: https://github.com/llvm/llvm-project/commit/0c124be33f8d2ed6ede41bcd3d8f0ca115921ef3.diff

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-07-01 Thread Chelsea Cassanova via lldb-commits
@@ -0,0 +1,6 @@ +# All tests for the tool need lldb-rpc-gen to be built. +# As far as I can see, you need to check all possible ways to +# say "no" in a CMake option. +negation_options = ["OFF", "NO", 0] +if not config.lldb_has_lldbrpc or config.lldb_has_lldbrpc in negation_option

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-07-01 Thread Chelsea Cassanova via lldb-commits
https://github.com/chelcassanova updated https://github.com/llvm/llvm-project/pull/138031 >From 63db109cdc1177b469ca695b504492623d268d13 Mon Sep 17 00:00:00 2001 From: Chelsea Cassanova Date: Wed, 30 Apr 2025 14:15:39 -0700 Subject: [PATCH] [lldb][RPC] Upstream lldb-rpc-gen tool This commit up

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread Michael Buch via lldb-commits
@@ -1372,6 +1373,37 @@ static void LoadLibCxxFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { "${var.__y_} ${var.__m_} ${var.__wdl_}"))); } +static void RegisterStdStringSummaryProvider( +const lldb::TypeCategoryImplSP &category_sp, llvm::StringRef string_

[Lldb-commits] [lldb] [lldb][DWARF][NFC] Reduce scope of ref_addr_size variable (PR #146557)

2025-07-01 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/146557 Follow-up to https://github.com/llvm/llvm-project/pull/145645#discussion_r2174948997 There's no need for this variable to be declared at the function-level. We reset it in all the cases where it's used anyw

[Lldb-commits] [lldb] [lldb][DWARF][NFC] Reduce scope of ref_addr_size variable (PR #146557)

2025-07-01 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/146557 >From 06ccadcfa44bbca9367eeff94a44aa6cfec2873a Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 1 Jul 2025 16:50:01 +0100 Subject: [PATCH 1/2] [lldb][DWARF][NFC] Reduce scope of ref_addr_size variable

[Lldb-commits] [lldb] 1a7b7e2 - [lldb] Adding pipe support to lldb_private::MainLoopWindows. (#145621)

2025-07-01 Thread via lldb-commits
Author: John Harrison Date: 2025-07-01T08:59:27-07:00 New Revision: 1a7b7e24bcc1041ae0fb90abcfb73d36d76f4a07 URL: https://github.com/llvm/llvm-project/commit/1a7b7e24bcc1041ae0fb90abcfb73d36d76f4a07 DIFF: https://github.com/llvm/llvm-project/commit/1a7b7e24bcc1041ae0fb90abcfb73d36d76f4a07.diff

[Lldb-commits] [lldb] [lldb] Adding pipe support to lldb_private::MainLoopWindows. (PR #145621)

2025-07-01 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/145621 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF][NFC] Reduce scope of ref_addr_size variable (PR #146557)

2025-07-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes Follow-up to https://github.com/llvm/llvm-project/pull/145645#discussion_r2174948997 There's no need for this variable to be declared at the function-level. We reset it in all the cases where it's used an

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM once https://github.com/llvm/llvm-project/pull/143177#discussion_r2177093572 is merged separately. https://github.com/llvm/llvm-project/pull/143177 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [lldb] [lldb][Commands] image lookup: avoid double type lookup into current module (PR #146554)

2025-07-01 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/146554 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Prevent using an implicit `step-in`. (PR #143644)

2025-07-01 Thread via lldb-commits
jimingham wrote: Cool. I wasn't so much commenting on this patch as noting in general that you can't know from an address where lldb's stepping machinery thinks the current frame is as that's history dependent. https://github.com/llvm/llvm-project/pull/143644 _

[Lldb-commits] [lldb] [LLDB] Simplify libstdc++ string summaries (PR #146562)

2025-07-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes >From #143177. This combines the summaries for the pre- and post C++ 11 >`std::string` as well as `std::wstring`. In all cases, the data pointer is >reachable through `_M_dataplus._M_p`. It has the correct type (i.e

[Lldb-commits] [lldb] [LLDB] Simplify libstdc++ string summaries (PR #146562)

2025-07-01 Thread via lldb-commits
https://github.com/Nerixyz created https://github.com/llvm/llvm-project/pull/146562 >From #143177. This combines the summaries for the pre- and post C++ 11 >`std::string` as well as `std::wstring`. In all cases, the data pointer is >reachable through `_M_dataplus._M_p`. It has the correct type

[Lldb-commits] [lldb] [lldb][Commands] image lookup: avoid double type lookup into current module (PR #146554)

2025-07-01 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes The `current_module` pointer here was never set, but we check it when looping over the `target_modules` list. Presumably the intention was to avoid calling `LookupInModule` if we already found the type in

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread Michael Buch via lldb-commits
@@ -0,0 +1,120 @@ +# coding=utf8 +""" +Test std::*string summaries with MSVC's STL. +""" Michael137 wrote: Sounds good. Will give it a shot later this week https://github.com/llvm/llvm-project/pull/143177 ___ lldb-comm

[Lldb-commits] [lldb] [lldb][Commands] image lookup: avoid double type lookup into current module (PR #146554)

2025-07-01 Thread Michael Buch via lldb-commits
@@ -0,0 +1,43 @@ +# REQUIRES: system-darwin Michael137 wrote: Wasn't sure how to create multiple modules which would work across all platforms. I'm sure there is a way, but was hoping someone to tell me :) https://github.com/llvm/llvm-project/pull/146554 __

[Lldb-commits] [lldb] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in one of its call site (PR #146062)

2025-07-01 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit closed https://github.com/llvm/llvm-project/pull/146062 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][DWARF][NFC] Reduce scope of ref_addr_size variable (PR #146557)

2025-07-01 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/146557 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Commands] image lookup: avoid double type lookup into current module (PR #146554)

2025-07-01 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/146554 The `current_module` pointer here was never set, but we check it when looping over the `target_modules` list. Presumably the intention was to avoid calling `LookupInModule` if we already found the type in th

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread via lldb-commits
@@ -239,122 +240,24 @@ VectorIteratorSyntheticFrontEnd::GetIndexOfChildWithName(ConstString name) { bool lldb_private::formatters::LibStdcppStringSummaryProvider( ValueObject &valobj, Stream &stream, const TypeSummaryOptions &options) { - const bool scalar_is_load_addr =

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread via lldb-commits
@@ -1372,6 +1373,37 @@ static void LoadLibCxxFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { "${var.__y_} ${var.__m_} ${var.__wdl_}"))); } +static void RegisterStdStringSummaryProvider( +const lldb::TypeCategoryImplSP &category_sp, llvm::StringRef string_

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread via lldb-commits
@@ -1629,6 +1630,80 @@ static void LoadLibStdcppFormatters(lldb::TypeCategoryImplSP cpp_category_sp) { "^std::optional<.+>(( )?&)?$", stl_summary_flags, true); } +static void LoadCommonStlFormatters(lldb::TypeCategoryImplSP cpp_category_sp) {

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread via lldb-commits
@@ -239,122 +240,24 @@ VectorIteratorSyntheticFrontEnd::GetIndexOfChildWithName(ConstString name) { bool lldb_private::formatters::LibStdcppStringSummaryProvider( ValueObject &valobj, Stream &stream, const TypeSummaryOptions &options) { - const bool scalar_is_load_addr =

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread via lldb-commits
@@ -152,6 +152,20 @@ class StringPrinter { template static bool ReadBufferAndDumpToStream(const ReadBufferAndDumpToStreamOptions &options); + + template + static constexpr uint64_t ElementByteSize() { Nerixyz wrote: Yes, done. https://github.com/llv

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/143177 >From df589845dbccef086d966e21e8183a3dbada041a Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Wed, 18 Jun 2025 21:49:16 +0200 Subject: [PATCH] [LLDB] Add type summaries for MSVC STL strings --- lldb/packages/Pyt

[Lldb-commits] [lldb] [llvm] [lldb] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread David Spickett via lldb-commits
DavidSpickett wrote: The above result is a flaky text, the next build was green so you can ignore it. https://github.com/llvm/llvm-project/pull/145645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in one of its call site (PR #146062)

2025-07-01 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/146062 >From b7700480aa7150237f73aa37b0cf39f592ac512d Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Fri, 27 Jun 2025 12:49:53 +0100 Subject: [PATCH 1/7] [lldb][NFC] Inline ResolveSDKPathFromDebugInfo in on

[Lldb-commits] [lldb] [llvm] [lldb] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running on `hip-vega20-0` while building `lldb,llvm` at step 3 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/22423 Here is the relevant piece of the build lo

[Lldb-commits] [lldb] [llvm] [lldb] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX closed https://github.com/llvm/llvm-project/pull/145645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] da0828b - [lldb] Enable support for DWARF64 format handling (#145645)

2025-07-01 Thread via lldb-commits
Author: Hemang Gadhavi Date: 2025-07-01T18:35:40+05:30 New Revision: da0828b1e93c0fb6266225d8e6d41b2d9ef1f346 URL: https://github.com/llvm/llvm-project/commit/da0828b1e93c0fb6266225d8e6d41b2d9ef1f346 DIFF: https://github.com/llvm/llvm-project/commit/da0828b1e93c0fb6266225d8e6d41b2d9ef1f346.diff

[Lldb-commits] [lldb] [llvm] [lldb] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/145645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread David Spickett via lldb-commits
DavidSpickett wrote: Please go ahead and merge this, or I can do so for you if you're happy with it. https://github.com/llvm/llvm-project/pull/145645 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] [lldb] Add linux test for the three-arg version of getProcFile (PR #146500)

2025-07-01 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/146500 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread Michael Buch via lldb-commits
@@ -18,11 +18,11 @@ namespace lldb_private { namespace formatters { bool LibStdcppStringSummaryProvider( ValueObject &valobj, Stream &stream, -const TypeSummaryOptions &options); // libcstdc++ c++11 std::string +const TypeSummaryOptions &options); // libcstdc++ std:

[Lldb-commits] [lldb] [lldb] Add linux test for the three-arg version of getProcFile (PR #146500)

2025-07-01 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/146500 >From 2b30e53ff0c1d03e3acfd10c06863463a99dec60 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Tue, 1 Jul 2025 12:06:23 +0200 Subject: [PATCH 1/2] [lldb] Add linux test for the three-arg version of getProcFile

[Lldb-commits] [lldb] [lldb] Add linux test for the three-arg version of getProcFile (PR #146500)

2025-07-01 Thread Pavel Labath via lldb-commits
@@ -21,9 +26,15 @@ TEST(Support, getProcFile_Pid) { } #endif // #ifndef __APPLE__ -#if defined(_AIX) && defined(LLVM_ENABLE_THREADING) +#if (defined(_AIX) || defined(__linux__)) && defined(LLVM_ENABLE_THREADING) labath wrote: Good question. I assumed that's b

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread Michael Buch via lldb-commits
@@ -239,122 +240,24 @@ VectorIteratorSyntheticFrontEnd::GetIndexOfChildWithName(ConstString name) { bool lldb_private::formatters::LibStdcppStringSummaryProvider( ValueObject &valobj, Stream &stream, const TypeSummaryOptions &options) { - const bool scalar_is_load_addr =

[Lldb-commits] [lldb] [llvm] [lldb][DWARF64] Enable support for DWARF64 format handling (PR #145645)

2025-07-01 Thread Hemang Gadhavi via lldb-commits
@@ -175,15 +174,16 @@ static FormSize g_form_sizes[] = { {1, 8}, // 0x14 DW_FORM_ref8 {0, 0}, // 0x15 DW_FORM_ref_udata {0, 0}, // 0x16 DW_FORM_indirect -{1, 4}, // 0x17 DW_FORM_sec_offset +{0, + 0}, // 0x17 DW_FORM_sec_offset (4 bytes for DWARF32, 8

[Lldb-commits] [lldb] [lldb] Optimize statusline redrawing on terminal size change (PR #146435)

2025-07-01 Thread Pavel Labath via lldb-commits
@@ -41,10 +41,26 @@ Statusline::Statusline(Debugger &debugger) Statusline::~Statusline() { Disable(); } void Statusline::TerminalSizeChanged() { - UpdateTerminalProperties(); + const uint64_t terminal_width = m_debugger.GetTerminalWidth(); + const uint64_t terminal_height =

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-07-01 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,120 @@ +# coding=utf8 +""" +Test std::*string summaries with MSVC's STL. +""" labath wrote: I think it's mainly historical. We have `data-formatter/data-formatter-stl/generic/`, but it's a fairly recent addition. I think it would be nice to move ever

  1   2   >