[Lldb-commits] [lldb] [lldb][AIX] Added base file for AIX Register Context (PR #144645)

2025-06-17 Thread Hemang Gadhavi via lldb-commits
https://github.com/HemangGadhavi created https://github.com/llvm/llvm-project/pull/144645 This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. https://github.com/llvm/llvm-project/issues/1

[Lldb-commits] [lldb] [lldb][AArch64] Correctly invalidate svg when vg is written (PR #140875)

2025-06-17 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > Sorry for missing this one earlier. I'm a little confused about earlier in > this method, > > At the end of the loops, `sme_regnum` is the index of the final SME register > we've added to `m_dynamic_reg_infos`. Then if we have the ZT0 register, we > reuse that index a

[Lldb-commits] [lldb] [lldb][AArch64] Correctly invalidate svg when vg is written (PR #140875)

2025-06-17 Thread Jason Molenda via lldb-commits
@@ -425,7 +425,7 @@ void RegisterInfoPOSIX_arm64::AddRegSetSME(bool has_zt) { // // This must be added now, rather than when vg is defined because SME is a // dynamic set that may or may not be present. - static uint32_t vg_invalidates[] = {sme_regnum + 1 /*svg*/, + sta

[Lldb-commits] [lldb] [lldb][AArch64] Correctly invalidate svg when vg is written (PR #140875)

2025-06-17 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: Sorry for missing this one earlier. I'm a little confused about earlier in this method, ``` for (uint32_t i = 0; i < k_num_sme_register; ++i, ++sme_regnum) { m_sme_regnum_collection.push_back(sme_regnum); m_dynamic_reg_infos.push_back(g_register_infos_sme[i]); m

[Lldb-commits] [lldb] [lldb][Mach-O] Allow "process metadata" LC_NOTE to supply registers (PR #144627)

2025-06-17 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/144627 >From 92348b28fb02901e9437b92c1ddf8cfed31c Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Tue, 17 Jun 2025 18:57:11 -0700 Subject: [PATCH 1/2] [lldb][Mach-O] Allow "process metadata" LC_NOTE to supp

[Lldb-commits] [lldb] [lldb][Mach-O] Allow "process metadata" LC_NOTE to supply registers (PR #144627)

2025-06-17 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: The API test case included in the PR makes it pretty easy to see what the format looks like, if the english description wasn't clear. https://github.com/llvm/llvm-project/pull/144627 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [lldb] [lldb][Mach-O] Allow "process metadata" LC_NOTE to supply registers (PR #144627)

2025-06-17 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: One design note. I wanted a format that describes the register layout for each thread separately, instead of coming up with a shared register set for all threads. In a JTAG style environment, a "thread" is really a core, and we may have cores with different capabilities a

[Lldb-commits] [lldb] [lldb][Mach-O] Allow "process metadata" LC_NOTE to supply registers (PR #144627)

2025-06-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions c,cpp,h -- lldb/source/Plugins/Process/mach-core/RegisterCon

[Lldb-commits] [lldb] [lldb][Mach-O] Allow "process metadata" LC_NOTE to supply registers (PR #144627)

2025-06-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes The "process metadata" LC_NOTE allows for thread IDs to be specified in a Mach-O corefile. This extends the JSON recognzied in that LC_NOTE to allow for additional registers to be supplied on a per-thr

[Lldb-commits] [lldb] [lldb][Mach-O] Allow "process metadata" LC_NOTE to supply registers (PR #144627)

2025-06-17 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda created https://github.com/llvm/llvm-project/pull/144627 The "process metadata" LC_NOTE allows for thread IDs to be specified in a Mach-O corefile. This extends the JSON recognzied in that LC_NOTE to allow for additional registers to be supplied on a per-thread

[Lldb-commits] [lldb] [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-06-17 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/136040 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a96a3f1 - [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (#136040)

2025-06-17 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-06-17T18:37:15-07:00 New Revision: a96a3f1b26baa8e5ee0abbac629f02566b7e9d1c URL: https://github.com/llvm/llvm-project/commit/a96a3f1b26baa8e5ee0abbac629f02566b7e9d1c DIFF: https://github.com/llvm/llvm-project/commit/a96a3f1b26baa8e5ee0abbac629f02566b7e9d1c.diff

[Lldb-commits] [lldb] Plugin toggle roadmap (PR #132876)

2025-06-17 Thread David Peixotto via lldb-commits
https://github.com/dmpots closed https://github.com/llvm/llvm-project/pull/132876 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Revert plugin manager changes to investigate failure (PR #134183)

2025-06-17 Thread David Peixotto via lldb-commits
https://github.com/dmpots closed https://github.com/llvm/llvm-project/pull/134183 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix `ObjectFileMachO` object format when missing version load commands (PR #144177)

2025-06-17 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > One idea is to add a new string method on the llvm::Triple class: > > ``` > const std::string strNoObjectFormat() const; > ``` > > And this would check if the object format is in the string in > `llvm::Triple::Data` and if so strip it and return it, else return the > `

[Lldb-commits] [lldb] [lldb] Fix `ObjectFileMachO` object format when missing version load commands (PR #144177)

2025-06-17 Thread Jason Molenda via lldb-commits
jasonmolenda wrote: > Hi @jasonmolenda, > > > I don't want to see -macho in a triple that we're creating for any of these > > modules; this is going to break things down the line with firmware > > environments, I'm sure of it. It's also ugly. > > For context, could you elaborate where/why are

[Lldb-commits] [lldb] 4e090b6 - [lldb] Re-insert code to search for a binary by filepath if provided

2025-06-17 Thread Jason Molenda via lldb-commits
Author: Jason Molenda Date: 2025-06-17T17:41:31-07:00 New Revision: 4e090b6e84e33e2a442e3951253ca570f8f842f8 URL: https://github.com/llvm/llvm-project/commit/4e090b6e84e33e2a442e3951253ca570f8f842f8 DIFF: https://github.com/llvm/llvm-project/commit/4e090b6e84e33e2a442e3951253ca570f8f842f8.diff

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-17 Thread via lldb-commits
https://github.com/qxy11 updated https://github.com/llvm/llvm-project/pull/144424 >From 57483ee0f44f8bbed325268e7d1d40b1a0403aa1 Mon Sep 17 00:00:00 2001 From: Janet Yang Date: Mon, 16 Jun 2025 11:06:24 -0700 Subject: [PATCH 1/4] Add counter for number of DWO files loaded in statistics --- ll

[Lldb-commits] [lldb] [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-06-17 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/136040 >From 08d31267245da41e6ad2c1d5dd32e242867fbb18 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 16 Apr 2025 14:33:04 -0700 Subject: [PATCH 1/3] Implement a range data vector for minidump memory ranges --

[Lldb-commits] [lldb] [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-06-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- lldb/source/Plugins/Process/minidump/MinidumpParser

[Lldb-commits] [lldb] [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-06-17 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/136040 >From 40ca59992a02a5d236263ea88d8f7c1569b5e6c2 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Wed, 16 Apr 2025 14:33:04 -0700 Subject: [PATCH 1/3] Implement a range data vector for minidump memory ranges --

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-17 Thread Greg Clayton via lldb-commits
@@ -353,6 +386,8 @@ llvm::json::Value DebuggerStats::ReportStatistics( for (const auto &symbol_module : symbol_modules.Modules()) module_stat.symfile_modules.push_back((intptr_t)symbol_module.get()); } + UpdateDwoFileCounts(sym_file, total_dwo_file_

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-17 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/144424 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-17 Thread Greg Clayton via lldb-commits
@@ -33,6 +33,37 @@ static void EmplaceSafeString(llvm::json::Object &obj, llvm::StringRef key, obj.try_emplace(key, llvm::json::fixUTF8(str)); } +static void UpdateDwoFileCounts(SymbolFile *sym_file, +uint32_t &total_dwo_file_count, +

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-17 Thread John Harrison via lldb-commits
ashgti wrote: Reverted in #144616 I'll take a look at fixing the python3.10 compatibility issue in a new patch. https://github.com/llvm/llvm-project/pull/143818 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[Lldb-commits] [lldb] Revert "[lldb-dap] Refactoring DebugCommunication to improve test con… (PR #144616)

2025-06-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes …sistency. (#143818)" This reverts commit 362b9d78b4ee9107da2b5e90b3764b0f0fa610fe. Buildbots using python3.10 are running into errors from this change. --- Patch is 65.43 KiB, truncated to 20.00 KiB below,

[Lldb-commits] [lldb] Revert "[lldb-dap] Refactoring DebugCommunication to improve test con… (PR #144616)

2025-06-17 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/144616 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] cb63b75 - Revert "[lldb-dap] Refactoring DebugCommunication to improve test consistency. (#143818)

2025-06-17 Thread via lldb-commits
Author: John Harrison Date: 2025-06-17T16:01:40-07:00 New Revision: cb63b75e32a415c9bfc298ed7fdcd67e8d9de54c URL: https://github.com/llvm/llvm-project/commit/cb63b75e32a415c9bfc298ed7fdcd67e8d9de54c DIFF: https://github.com/llvm/llvm-project/commit/cb63b75e32a415c9bfc298ed7fdcd67e8d9de54c.diff

[Lldb-commits] [lldb] Revert "[lldb-dap] Refactoring DebugCommunication to improve test con… (PR #144616)

2025-06-17 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/144616 …sistency. (#143818)" This reverts commit 362b9d78b4ee9107da2b5e90b3764b0f0fa610fe. Buildbots using python3.10 are running into errors from this change. >From 117982fb34200d307f9ce4c0e1907a441a05247e Mon Sep 17

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-17 Thread John Harrison via lldb-commits
ashgti wrote: Reverting this as it looks like python3.10 is giving an error with one of the TypedDict usages from this patch. https://github.com/llvm/llvm-project/pull/143818 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [lldb] [lldb] Support non-blocking reads in JSONRPCTransport (PR #144610)

2025-06-17 Thread John Harrison via lldb-commits
@@ -67,19 +67,22 @@ ReadFull(IOObject &descriptor, size_t length, return data.substr(0, length); } -static Expected -ReadUntil(IOObject &descriptor, StringRef delimiter, - std::optional timeout = std::nullopt) { - std::string buffer; - buffer.reserve(delimiter.siz

[Lldb-commits] [lldb] [lldb] Support non-blocking reads in JSONRPCTransport (PR #144610)

2025-06-17 Thread John Harrison via lldb-commits
@@ -67,19 +67,22 @@ ReadFull(IOObject &descriptor, size_t length, return data.substr(0, length); } -static Expected -ReadUntil(IOObject &descriptor, StringRef delimiter, - std::optional timeout = std::nullopt) { - std::string buffer; - buffer.reserve(delimiter.siz

[Lldb-commits] [lldb] [lldb] Support non-blocking reads in JSONRPCTransport (PR #144610)

2025-06-17 Thread John Harrison via lldb-commits
@@ -142,13 +147,43 @@ TEST_F(JSONRPCTransportTest, Write) { } TEST_F(JSONRPCTransportTest, InvalidTransport) { - transport = std::make_unique(nullptr, nullptr); + transport = std::make_unique(nullptr, nullptr); ASSERT_THAT_EXPECTED( transport->Read(std::chrono::mil

[Lldb-commits] [lldb] [lldb] Support non-blocking reads in JSONRPCTransport (PR #144610)

2025-06-17 Thread John Harrison via lldb-commits
@@ -85,7 +85,8 @@ class JSONTransport { /// Reads the next message from the input stream. template - llvm::Expected Read(const std::chrono::microseconds &timeout) { + llvm::Expected + Read(std::optional timeout = std::nullopt) { ashgti wrote: Since th

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-17 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-aarch64-ubuntu` running on `linaro-lldb-aarch64-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/19528 Here is the relevant piece of the b

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-17 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/17628 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/143628 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support non-blocking reads in JSONRPCTransport (PR #144610)

2025-06-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/144610 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Support non-blocking reads in JSONRPCTransport (PR #144610)

2025-06-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Support non-blocking reads for JSONRPCTransport so we can implement a multiplexed reader using the MainLoop. Pavel pointed out in #143628 that the implementation there (which was using blocking read

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-17 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,280 @@ +//===- ProtocolServerMCP.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Support non-blocking reads in JSONRPCTransport (PR #144610)

2025-06-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/144610 Support non-blocking reads for JSONRPCTransport so we can implement a multiplexed reader using the MainLoop. Pavel pointed out in #143628 that the implementation there (which was using blocking reads) can

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-17 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/143818 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 362b9d7 - [lldb-dap] Refactoring DebugCommunication to improve test consistency. (#143818)

2025-06-17 Thread via lldb-commits
Author: John Harrison Date: 2025-06-17T14:42:06-07:00 New Revision: 362b9d78b4ee9107da2b5e90b3764b0f0fa610fe URL: https://github.com/llvm/llvm-project/commit/362b9d78b4ee9107da2b5e90b3764b0f0fa610fe DIFF: https://github.com/llvm/llvm-project/commit/362b9d78b4ee9107da2b5e90b3764b0f0fa610fe.diff

[Lldb-commits] [lldb] [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-06-17 Thread Jacob Lalonde via lldb-commits
@@ -45,9 +49,16 @@ struct Range { friend bool operator==(const Range &lhs, const Range &rhs) { return lhs.start == rhs.start && lhs.range_ref == rhs.range_ref; } + + friend bool operator<(const Range &lhs, const Range &rhs) { +return lhs.start < rhs.start;

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-17 Thread David Peixotto via lldb-commits
@@ -512,6 +522,119 @@ def test_breakpoints(self): self.verify_keys( breakpoint, 'target_stats["breakpoints"]', bp_keys_exist, None ) +def test_non_split_dwarf_has_no_dwo_files(self): +""" +Test "statistics dump" and th

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-17 Thread David Peixotto via lldb-commits
https://github.com/dmpots edited https://github.com/llvm/llvm-project/pull/144424 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-17 Thread David Peixotto via lldb-commits
https://github.com/dmpots approved this pull request. LGTM! You should get approvals from @jeffreytan81 and @clayborg as well before merging. https://github.com/llvm/llvm-project/pull/144424 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-06-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: nerix (Nerixyz) Changes This PR adds type summaries for `std::{string,wstring,u8string,u16string,u32string}` from the MSVC STL. See https://github.com/llvm/llvm-project/issues/24834 for the MSVC STL issue. The following changes were made:

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-06-17 Thread via lldb-commits
https://github.com/Nerixyz ready_for_review https://github.com/llvm/llvm-project/pull/143177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add type summaries for MSVC STL strings (PR #143177)

2025-06-17 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/143177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] WIP: Add type summaries for MSVC STL strings (PR #143177)

2025-06-17 Thread via lldb-commits
Nerixyz wrote: I would love some general feedback on this PR. I updated the description to reflect the current state. For some reason, the Windows CI doesn't run on this PR, but I ran the STL tests locally. https://github.com/llvm/llvm-project/pull/143177 _

[Lldb-commits] [lldb] Add a python JIT loader class. (PR #142514)

2025-06-17 Thread Greg Clayton via lldb-commits
clayborg wrote: > It also seems architecturally wrong to try to guess and influence what > BreakpointResolvers do behind their backs. After all, the resolver might be > just some Python Code you know nothing about. How would you instrument that? > If I set a regular expression name breakpoint,

[Lldb-commits] [lldb] [LLDB] Add optional callback function to `TypeMatcher` (PR #143748)

2025-06-17 Thread via lldb-commits
Nerixyz wrote: Thank you for the feedback! Closing this, as it's not needed to allow different summary/synthetic providers for one type name. https://github.com/llvm/llvm-project/pull/143748 ___ lldb-commits mailing list lldb-commits@lists.llvm.org h

[Lldb-commits] [lldb] [LLDB] Add optional callback function to `TypeMatcher` (PR #143748)

2025-06-17 Thread via lldb-commits
https://github.com/Nerixyz closed https://github.com/llvm/llvm-project/pull/143748 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring DebugCommunication to improve test consistency. (PR #143818)

2025-06-17 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/143818 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] WIP: Add type summaries for MSVC STL strings (PR #143177)

2025-06-17 Thread via lldb-commits
https://github.com/Nerixyz edited https://github.com/llvm/llvm-project/pull/143177 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add support to list/enable/disable remaining plugin types. (PR #143970)

2025-06-17 Thread David Peixotto via lldb-commits
https://github.com/dmpots closed https://github.com/llvm/llvm-project/pull/143970 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] c677a11 - [lldb] Add support to list/enable/disable remaining plugin types. (#143970)

2025-06-17 Thread via lldb-commits
Author: David Peixotto Date: 2025-06-17T13:47:20-07:00 New Revision: c677a11c8d3223480cfe772e63fa0e7c09c76e2e URL: https://github.com/llvm/llvm-project/commit/c677a11c8d3223480cfe772e63fa0e7c09c76e2e DIFF: https://github.com/llvm/llvm-project/commit/c677a11c8d3223480cfe772e63fa0e7c09c76e2e.diff

[Lldb-commits] [lldb] [lldb] Fix FindProcessImpl() for iOS simulators (PR #139174)

2025-06-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/139174 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Splitting ProtocolTypesTest into parts. (PR #144595)

2025-06-17 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/144595 >From 212d503e9cde2c715b6f4d372ea3be8383a5fc1d Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 17 Jun 2025 13:10:07 -0700 Subject: [PATCH 1/3] [lldb-dap] Splitting ProtocolTypesTest into parts. Splitting

[Lldb-commits] [lldb] [lldb-dap] Splitting ProtocolTypesTest into parts. (PR #144595)

2025-06-17 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/144595 >From 212d503e9cde2c715b6f4d372ea3be8383a5fc1d Mon Sep 17 00:00:00 2001 From: John Harrison Date: Tue, 17 Jun 2025 13:10:07 -0700 Subject: [PATCH 1/2] [lldb-dap] Splitting ProtocolTypesTest into parts. Splitting

[Lldb-commits] [lldb] [lldb-dap] Splitting ProtocolTypesTest into parts. (PR #144595)

2025-06-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Splitting ProtocolTypesTest into separate files for ProtocolBase, ProtocolEvent, ProtocolRequests and ProtocolTypes. --- Patch is 20.32 KiB, truncated to 20.00 KiB below, full version: https://github.com/ll

[Lldb-commits] [lldb] [lldb-dap] Splitting ProtocolTypesTest into parts. (PR #144595)

2025-06-17 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/144595 Splitting ProtocolTypesTest into separate files for ProtocolBase, ProtocolEvent, ProtocolRequests and ProtocolTypes. >From 212d503e9cde2c715b6f4d372ea3be8383a5fc1d Mon Sep 17 00:00:00 2001 From: John Harrison D

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-17 Thread via lldb-commits
@@ -512,6 +517,32 @@ def test_breakpoints(self): self.verify_keys( breakpoint, 'target_stats["breakpoints"]', bp_keys_exist, None ) + +def test_loaded_dwo_file_count(self): +""" +Test "statistics dump" and the load

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-17 Thread via lldb-commits
https://github.com/qxy11 updated https://github.com/llvm/llvm-project/pull/144424 >From 57483ee0f44f8bbed325268e7d1d40b1a0403aa1 Mon Sep 17 00:00:00 2001 From: Janet Yang Date: Mon, 16 Jun 2025 11:06:24 -0700 Subject: [PATCH 1/3] Add counter for number of DWO files loaded in statistics --- ll

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for ReadMemory request (PR #144552)

2025-06-17 Thread John Harrison via lldb-commits
@@ -839,6 +839,43 @@ bool fromJSON(const llvm::json::Value &, DisassembleResponseBody &, llvm::json::Path); llvm::json::Value toJSON(const DisassembleResponseBody &); +/// Arguments for `readMemory` request. +struct ReadMemoryArguments { + /// Memory reference

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for ReadMemory request (PR #144552)

2025-06-17 Thread John Harrison via lldb-commits
@@ -839,6 +839,43 @@ bool fromJSON(const llvm::json::Value &, DisassembleResponseBody &, llvm::json::Path); llvm::json::Value toJSON(const DisassembleResponseBody &); +/// Arguments for `readMemory` request. +struct ReadMemoryArguments { + /// Memory reference

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for ReadMemory request (PR #144552)

2025-06-17 Thread John Harrison via lldb-commits
https://github.com/ashgti approved this pull request. https://github.com/llvm/llvm-project/pull/144552 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] WIP: Add type summaries for MSVC STL strings (PR #143177)

2025-06-17 Thread via lldb-commits
https://github.com/Nerixyz updated https://github.com/llvm/llvm-project/pull/143177 >From 3033eb61d7ae7fca0b63e7f125530e8d93d76567 Mon Sep 17 00:00:00 2001 From: Nerixyz Date: Fri, 6 Jun 2025 19:23:04 +0200 Subject: [PATCH] [LLDB] Add type summaries for MSVC STL strings --- .../lldb/DataForma

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-17 Thread John Harrison via lldb-commits
@@ -0,0 +1,186 @@ +//===-- CommandObjectProtocolServer.cpp +//--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-I

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-17 Thread Alex Langford via lldb-commits
@@ -0,0 +1,22 @@ +include(CheckCXXCompilerFlag) bulbazord wrote: What is this for? https://github.com/llvm/llvm-project/pull/138031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-17 Thread Alex Langford via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-17 Thread Alex Langford via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-17 Thread Alex Langford via lldb-commits
@@ -0,0 +1,535 @@ +//===-- RPCCommon.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-17 Thread Alex Langford via lldb-commits
https://github.com/bulbazord commented: Some comments. Overall looks ok to me, but I'm already familiar with most of it. https://github.com/llvm/llvm-project/pull/138031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [lldb] [lldb][RPC] Upstream lldb-rpc-gen tool (PR #138031)

2025-06-17 Thread Alex Langford via lldb-commits
https://github.com/bulbazord edited https://github.com/llvm/llvm-project/pull/138031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Implement priority system for symbol locator plugin (PR #144406)

2025-06-17 Thread via lldb-commits
https://github.com/GeorgeHuyubo closed https://github.com/llvm/llvm-project/pull/144406 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for ReadMemory request (PR #144552)

2025-06-17 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/144552 >From ba920b6232cc95820da4667fd94a7ca31bde54ff Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 17 Jun 2025 11:12:47 +0100 Subject: [PATCH 1/4] [lldb-dap] use protocol types for read memory --- .../tools

[Lldb-commits] [lldb] [lldb-dap] Use protocol types for ReadMemory request (PR #144552)

2025-06-17 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/144552 >From ba920b6232cc95820da4667fd94a7ca31bde54ff Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Tue, 17 Jun 2025 11:12:47 +0100 Subject: [PATCH 1/3] [lldb-dap] use protocol types for read memory --- .../tools

[Lldb-commits] [lldb] [llvm] [NFC] Separate high-level-dependent portions of DWARFExpression (revised) (PR #143170)

2025-06-17 Thread David Blaikie via lldb-commits
@@ -425,7 +425,7 @@ void CFIProgram::printOperand(raw_ostream &OS, DIDumpOptions DumpOpts, case OT_Expression: assert(Instr.Expression && "missing DWARFExpression object"); OS << " "; -Instr.Expression->print(OS, DumpOpts, nullptr); +DWARFExpressionPrinter::p

[Lldb-commits] [lldb] [lldb] Implement priority system for symbol locator plugin (PR #144406)

2025-06-17 Thread via lldb-commits
GeorgeHuyubo wrote: > I don't yet understand how changing the priority of the plugins prevents the > "double download" you mention. Your problem statements talks about the > callback and the debuginfod plugin, but your solution talks about the > debuginfod plugin and the default symbol locator

[Lldb-commits] [lldb] [lldb] Implement priority system for symbol locator plugin (PR #144406)

2025-06-17 Thread via lldb-commits
GeorgeHuyubo wrote: I like the "Scripted Symbol Locator" idea, it should solve all the problem I have. https://github.com/llvm/llvm-project/pull/144406 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-17 Thread David Peixotto via lldb-commits
@@ -353,6 +355,30 @@ llvm::json::Value DebuggerStats::ReportStatistics( for (const auto &symbol_module : symbol_modules.Modules()) module_stat.symfile_modules.push_back((intptr_t)symbol_module.get()); } + // Count DWO files from this symbol file usi

[Lldb-commits] [lldb] [llvm] [NFC] Separate high-level-dependent portions of DWARFExpression (revised) (PR #143170)

2025-06-17 Thread via lldb-commits
@@ -425,7 +425,7 @@ void CFIProgram::printOperand(raw_ostream &OS, DIDumpOptions DumpOpts, case OT_Expression: assert(Instr.Expression && "missing DWARFExpression object"); OS << " "; -Instr.Expression->print(OS, DumpOpts, nullptr); +DWARFExpressionPrinter::p

[Lldb-commits] [lldb] [llvm] [NFC] Separate high-level-dependent portions of DWARFExpression (revised) (PR #143170)

2025-06-17 Thread David Blaikie via lldb-commits
@@ -425,7 +425,7 @@ void CFIProgram::printOperand(raw_ostream &OS, DIDumpOptions DumpOpts, case OT_Expression: assert(Instr.Expression && "missing DWARFExpression object"); OS << " "; -Instr.Expression->print(OS, DumpOpts, nullptr); +DWARFExpressionPrinter::p

[Lldb-commits] [lldb] [lldb] Add Model Context Protocol (MCP) support to LLDB (PR #143628)

2025-06-17 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,186 @@ +//===-- CommandObjectProtocolServer.cpp +//--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-I

[Lldb-commits] [lldb] [lldb] Add count for number of DWO files loaded in statistics (PR #144424)

2025-06-17 Thread David Peixotto via lldb-commits
@@ -512,6 +517,32 @@ def test_breakpoints(self): self.verify_keys( breakpoint, 'target_stats["breakpoints"]', bp_keys_exist, None ) + +def test_loaded_dwo_file_count(self): +""" +Test "statistics dump" and the load

[Lldb-commits] [lldb] [LLDB] Expose enumerator for separate-debug-info in SBModule (PR #144119)

2025-06-17 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/144119 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Expose enumerator for separate-debug-info in SBModule (PR #144119)

2025-06-17 Thread Greg Clayton via lldb-commits
@@ -633,6 +633,14 @@ lldb::SBFileSpec SBModule::GetSymbolFileSpec() const { return sb_file_spec; } +lldb::SBFileSpecList SBModule::GetSeparateDebugInfoFiles() { clayborg wrote: lldb::SBModuleSpecList https://github.com/llvm/llvm-project/pull/144119 ___

[Lldb-commits] [lldb] [LLDB] Expose enumerator for separate-debug-info in SBModule (PR #144119)

2025-06-17 Thread Greg Clayton via lldb-commits
@@ -287,6 +287,14 @@ class LLDB_API SBModule { /// A const reference to the file specification object. lldb::SBFileSpec GetSymbolFileSpec() const; + /// Get a list of filespecs associated with all the separate symbol files + /// associated with this module. + /// +

[Lldb-commits] [lldb] [LLDB] Expose enumerator for separate-debug-info in SBModule (PR #144119)

2025-06-17 Thread Greg Clayton via lldb-commits
@@ -31,6 +31,11 @@ SBFileSpecList::SBFileSpecList(const SBFileSpecList &rhs) { m_opaque_up = clone(rhs.m_opaque_up); } +SBFileSpecList::SBFileSpecList(FileSpecList &&list) +: m_opaque_up(new FileSpecList(std::move(list))) { + LLDB_INSTRUMENT_VA(this); +} + -

[Lldb-commits] [lldb] [LLDB] Expose enumerator for separate-debug-info in SBModule (PR #144119)

2025-06-17 Thread Greg Clayton via lldb-commits
@@ -223,6 +223,10 @@ class SymbolFileOnDemand : public lldb_private::SymbolFile { return m_sym_file_impl->SetDebugInfoHadFrameVariableErrors(); } + lldb_private::FileSpecList GetSeparateDebugInfoFiles() override { clayborg wrote: ModuleSpecList https

[Lldb-commits] [lldb] [LLDB] Expose enumerator for separate-debug-info in SBModule (PR #144119)

2025-06-17 Thread Greg Clayton via lldb-commits
@@ -482,6 +482,8 @@ class Module : public std::enable_shared_from_this, const FileSpec &GetSymbolFileFileSpec() const { return m_symfile_spec; } + FileSpecList GetSeparateDebugInfoFiles(); clayborg wrote: ModuleSpecList https://github.com/llvm/llvm-proje

[Lldb-commits] [lldb] [LLDB] Expose enumerator for separate-debug-info in SBModule (PR #144119)

2025-06-17 Thread Greg Clayton via lldb-commits
@@ -472,6 +473,16 @@ class SymbolFile : public PluginInterface { return false; }; + /// Return a map of separate debug info files that are loaded. + /// + /// Unlike GetSeparateDebugInfo(), this function will only return the list of + /// files, if there are errors t

[Lldb-commits] [lldb] [lldb] move XcodeSDK's sysroot into a separate class (PR #144396)

2025-06-17 Thread Charles Zablit via lldb-commits
@@ -982,7 +982,7 @@ lldb::LanguageType SymbolFileDWARF::ParseLanguage(CompileUnit &comp_unit) { return eLanguageTypeUnknown; } -XcodeSDK SymbolFileDWARF::ParseXcodeSDK(CompileUnit &comp_unit) { +XcodeSDKPath SymbolFileDWARF::ParseXcodeSDK(CompileUnit &comp_unit) { ---

[Lldb-commits] [lldb] [lldb] Properly handle locate module callback when Target change arch (PR #143793)

2025-06-17 Thread Greg Clayton via lldb-commits
@@ -1706,6 +1706,8 @@ bool Target::SetArchitecture(const ArchSpec &arch_spec, bool set_platform, if (PlatformSP arch_platform_sp = GetDebugger().GetPlatformList().GetOrCreate(other, {}, &platfo

[Lldb-commits] [lldb] [lldb] move XcodeSDK's sysroot into a separate class (PR #144396)

2025-06-17 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/144396 >From 0d773d07856aeb5434d748f439a2a1c00361ed20 Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Mon, 16 Jun 2025 17:54:44 +0100 Subject: [PATCH 1/2] [lldb] move XcodeSDK's sysroot into a separate class

[Lldb-commits] [lldb] [lldb] Add support to list/enable/disable remaining plugin types. (PR #143970)

2025-06-17 Thread Greg Clayton via lldb-commits
clayborg wrote: No comments, good to merge IMHO. https://github.com/llvm/llvm-project/pull/143970 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Fix source references (PR #144364)

2025-06-17 Thread Ebuka Ezike via lldb-commits
@@ -46,21 +46,27 @@ static bool ShouldDisplayAssemblySource( return false; } -static protocol::Source CreateAssemblySource(const lldb::SBTarget &target, - lldb::SBAddress address) { - protocol::Source source; +std::optional Create

[Lldb-commits] [lldb] [lldb-dap] Fix source references (PR #144364)

2025-06-17 Thread Ebuka Ezike via lldb-commits
da-viper wrote: > I looked at the code some more and it seems like we return the address of the > symbol if there is one, and only use the actual address (i.e. the pc) when > there is none. I was trying to find the code that computes the line in that > case (i.e. `pc - symbol`) and I couldn't

  1   2   >