[Lldb-commits] [lldb] [lldb] Try to fix TestExprDiagnostics test (PR #136269)

2025-04-17 Thread Timm Baeder via lldb-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/136269 >From 080087a0b5b8a399aa633d1c1433f28ae83398c3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 18 Apr 2025 08:43:37 +0200 Subject: [PATCH] [lldb] Try to fix TestExprDiagnostics test ---

[Lldb-commits] [lldb] [lldb] Try to fix TestExprDiagnostics test (PR #136269)

2025-04-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/136269.diff 1 Files Affected: - (modified) lldb/test/API/commands/expression/diagnostics/TestExprDiagnostics.py (+4-4) ``diff diff --git

[Lldb-commits] [lldb] [lldb] Try to fix TestExprDiagnostics test (PR #136269)

2025-04-17 Thread Timm Baeder via lldb-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/136269 None >From 3af741ab0f57822e46be79b7d426d8b225755dbe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Fri, 18 Apr 2025 08:43:37 +0200 Subject: [PATCH] [lldb] Try to fix TestExprDiagnostics tes

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-17 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/136226 >From 4157b0d1426830a4c19af7401728ef86dbc2d8c9 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Wed, 16 Apr 2025 09:19:04 -0700 Subject: [PATCH 1/2] [lldb] Add new stats (# symbols loaded, # symbol tables loaded)

[Lldb-commits] [clang] [lldb] Fix filename parsing in clang-format-diff.py for paths with spaces (PR #135779)

2025-04-17 Thread Selim Keles via lldb-commits
https://github.com/selimkeles updated https://github.com/llvm/llvm-project/pull/135779 >From 235ef7b9d0e5f8cb9329400a01fa1b51c74626e7 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 15 Apr 2025 11:40:07 +0200 Subject: [PATCH] Fix filename parsing in clang-format-diff.py for paths with spac

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-17 Thread via lldb-commits
https://github.com/jimingham approved this pull request. Okay, that makes sense. https://github.com/llvm/llvm-project/pull/136065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-17 Thread via lldb-commits
@@ -749,10 +749,20 @@ TEST_F(SymtabTest, TestSymtabCreatedOnDemand) { ASSERT_THAT_EXPECTED(ExpectedFile, llvm::Succeeded()); auto module_sp = std::make_shared(ExpectedFile->moduleSpec()); - // The symbol table should not be loaded by default. + // The symbol file should

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-17 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/136236 >From 85cb8cca4fe41cf4080b3dbf7ce4f98c4b15a3c7 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 17 Apr 2025 15:03:00 -0700 Subject: [PATCH 1/3] [lldb] Do not parse symtab during statistics dump Summary: Test

[Lldb-commits] [lldb] [lldb-dap] Remove an incorrect assumption on reverse requests. (PR #136210)

2025-04-17 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/136210 Reverse requests do have a 'seq' set still from VSCode. I incorrectly interpreted https://github.com/microsoft/vscode/blob/dede7bb4b7e9c9ec69155a243bb84037a40588fe/src/vs/workbench/contrib/debug/common/abstractD

[Lldb-commits] [lldb] [lldb] Avoid force loading symbols in statistics collection (PR #136236)

2025-04-17 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/136236 >From 85cb8cca4fe41cf4080b3dbf7ce4f98c4b15a3c7 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Thu, 17 Apr 2025 15:03:00 -0700 Subject: [PATCH 1/2] [lldb] Do not parse symtab during statistics dump Summary: Test

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-17 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/136065 >From 41274f7632d13ab7ec83a420c6ad6258e6fe8c36 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 16 Apr 2025 17:18:02 -0700 Subject: [PATCH 1/3] [lldb][Mach-O corefiles] Don't init Target arch to cor

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-17 Thread David Peixotto via lldb-commits
@@ -168,23 +170,34 @@ def test_default_no_run(self): "totalSymbolTableIndexTime", "totalSymbolTablesLoadedFromCache", "totalSymbolTablesSavedToCache", +"totalSymbolsLoaded", "totalDebugInfoByteSize", "tot

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-17 Thread via lldb-commits
https://github.com/royitaqi created https://github.com/llvm/llvm-project/pull/136226 These stats are added or changed: 1. In summary: 1. Add `totalSymbolsLoaded`. The total number of symbols loaded in all modules. 2. Add `totalSymbolTablesLoaded `. The total number symbol tables loaded

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-17 Thread via lldb-commits
royitaqi wrote: Will wait until tomorrow morning/noon before landing, so that: 1. Give other folks a chance to review before merge. 2. Avoid failing tests after working hour so that folks can sleep. https://github.com/llvm/llvm-project/pull/136226 ___

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/136226 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-17 Thread Jacob Lalonde via lldb-commits
@@ -157,6 +162,23 @@ class CompletionRequest { size_t GetCursorIndex() const { return m_cursor_index; } + size_t GetMaxReturnElements() const { return m_max_return_elements; } + + /// Returns true if the maximum number of completions has not been reached + /// yet, hence

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-17 Thread David Peixotto via lldb-commits
https://github.com/dmpots approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/136226 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Do not create/parse symtab during `DebuggerStats::ReportStatistics()` (PR #136236)

2025-04-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: None (royitaqi) Changes # The change Currently, `DebuggerStats::ReportStatistics()` calls `Module::GetSymtab(/* can_create */ false)`, but then the latter calls `SymbolFile::GetSymtab()`. This will load symbols if haven't yet. The proble

[Lldb-commits] [lldb] [lldb] Do not create/parse symtab during `DebuggerStats::ReportStatistics()` (PR #136236)

2025-04-17 Thread via lldb-commits
https://github.com/royitaqi created https://github.com/llvm/llvm-project/pull/136236 # The change Currently, `DebuggerStats::ReportStatistics()` calls `Module::GetSymtab(/* can_create */ false)`, but then the latter calls `SymbolFile::GetSymtab()`. This will load symbols if haven't yet. The

[Lldb-commits] [lldb] Add download time for each module in statistics (PR #134563)

2025-04-17 Thread via lldb-commits
@@ -1217,28 +1217,36 @@ PluginManager::GetSymbolLocatorCreateCallbackAtIndex(uint32_t idx) { } ModuleSpec -PluginManager::LocateExecutableObjectFile(const ModuleSpec &module_spec) { +PluginManager::LocateExecutableObjectFile(const ModuleSpec &module_spec, +

[Lldb-commits] [lldb] Add symbol locator time for each module in statistics (PR #134563)

2025-04-17 Thread via lldb-commits
https://github.com/GeorgeHuyubo edited https://github.com/llvm/llvm-project/pull/134563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add download time for each module in statistics (PR #134563)

2025-04-17 Thread via lldb-commits
https://github.com/GeorgeHuyubo reopened https://github.com/llvm/llvm-project/pull/134563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add download time for each module in statistics (PR #134563)

2025-04-17 Thread via lldb-commits
https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/134563 >From 28e52ec264f088625410b7202b5de1e7f601f164 Mon Sep 17 00:00:00 2001 From: George Hu Date: Tue, 8 Apr 2025 18:12:29 -0700 Subject: [PATCH] Add symbol locator time for each module in statistics Summary:

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-17 Thread David Peixotto via lldb-commits
@@ -318,12 +321,15 @@ llvm::json::Value DebuggerStats::ReportStatistics( module_stat.symtab_index_time = module->GetSymtabIndexTime().get().count(); Symtab *symtab = module->GetSymtab(/*can_create=*/false); if (symtab) { + module_stat.num_symbols_loaded = symta

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/136226 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-17 Thread David Peixotto via lldb-commits
@@ -168,23 +170,34 @@ def test_default_no_run(self): "totalSymbolTableIndexTime", "totalSymbolTablesLoadedFromCache", "totalSymbolTablesSavedToCache", +"totalSymbolsLoaded", dmpots wrote: We should also check for

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-17 Thread via lldb-commits
https://github.com/royitaqi updated https://github.com/llvm/llvm-project/pull/136226 >From 4157b0d1426830a4c19af7401728ef86dbc2d8c9 Mon Sep 17 00:00:00 2001 From: Roy Shi Date: Wed, 16 Apr 2025 09:19:04 -0700 Subject: [PATCH] [lldb] Add new stats (# symbols loaded, # symbol tables loaded) to m

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-17 Thread via lldb-commits
https://github.com/royitaqi edited https://github.com/llvm/llvm-project/pull/136226 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add symbol/table count into statistics (PR #136226)

2025-04-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/test/API/commands/statistics/basic/TestStats.py `` View th

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-17 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/135565 >From 04e503abe160bc6a9214ad1f345ef90be1e8c7e0 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 13 Apr 2025 20:46:56 +0200 Subject: [PATCH 1/3] [lldb] returning command completions up to a maximum - Adding

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-17 Thread Ely Ronnen via lldb-commits
@@ -230,6 +232,9 @@ class SymbolCompleter : public Completer { // Now add the functions & symbols to the list - only add if unique: for (const SymbolContext &sc : sc_list) { +if (m_match_set.size() >= m_request.GetMaxNumberOfResultsToAdd())

[Lldb-commits] [lldb] [lldb] Create ThreadPlanStepOut ctor that never skips frames (PR #136163)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/136163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 12becff - [lldb] Create ThreadPlanStepOut ctor that never skips frames (#136163)

2025-04-17 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-04-17T14:13:28-07:00 New Revision: 12becfff035a33141a0b2fb3ea5d5558738ce7eb URL: https://github.com/llvm/llvm-project/commit/12becfff035a33141a0b2fb3ea5d5558738ce7eb DIFF: https://github.com/llvm/llvm-project/commit/12becfff035a33141a0b2fb3ea5d55587

[Lldb-commits] [lldb] [lldb][nfc] Remove unused parameters in ThreadPlanStepOut ctor (PR #136161)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/136161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Create ThreadPlanStepOut ctor that never skips frames (PR #136163)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Addressed review comments, rebased on top of main https://github.com/llvm/llvm-project/pull/136163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Create ThreadPlanStepOut ctor that never skips frames (PR #136163)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/136163 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Create ThreadPlanStepOut ctor that never skips frames (PR #136163)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/136163 >From d1f15f7a23b75d7b68989ac84b1c4b5991fb120d Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Thu, 17 Apr 2025 09:36:22 -0700 Subject: [PATCH 1/2] [lldb] Create ThreadPlanStepOut ctor tha

[Lldb-commits] [lldb] [lldb][nfc] Remove unused parameters in ThreadPlanStepOut ctor (PR #136161)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/136161 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] disable test on older compilers (PR #136186)

2025-04-17 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-x86_64-debian` running on `lldb-x86_64-debian` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/162/builds/20449 Here is the relevant piece of the build log

[Lldb-commits] [lldb] disable test on older compilers (PR #136186)

2025-04-17 Thread Shubham Sandeep Rastogi via lldb-commits
https://github.com/rastogishubham closed https://github.com/llvm/llvm-project/pull/136186 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 1042d99 - disable test on older compilers (#136186)

2025-04-17 Thread via lldb-commits
Author: Shubham Sandeep Rastogi Date: 2025-04-17T12:33:30-07:00 New Revision: 1042d9988764e16e5f6fd984d362042b2fadd0c6 URL: https://github.com/llvm/llvm-project/commit/1042d9988764e16e5f6fd984d362042b2fadd0c6 DIFF: https://github.com/llvm/llvm-project/commit/1042d9988764e16e5f6fd984d362042b2fad

[Lldb-commits] [lldb] disable test on older compilers (PR #136186)

2025-04-17 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl approved this pull request. https://github.com/llvm/llvm-project/pull/136186 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] disable test on older compilers (PR #136186)

2025-04-17 Thread Shubham Sandeep Rastogi via lldb-commits
https://github.com/rastogishubham created https://github.com/llvm/llvm-project/pull/136186 None >From fc70ee11fe2122c646ec20a61ae4b691902b1ce9 Mon Sep 17 00:00:00 2001 From: Shubham Sandeep Rastogi Date: Thu, 17 Apr 2025 12:31:03 -0700 Subject: [PATCH] disable test on older compilers --- ...

[Lldb-commits] [lldb] [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-04-17 Thread Miro Bucko via lldb-commits
@@ -429,62 +429,64 @@ MinidumpParser::GetExceptionStreams() { std::optional MinidumpParser::FindMemoryRange(lldb::addr_t addr) { - Log *log = GetLog(LLDBLog::Modules); + if (m_memory_ranges.IsEmpty()) +PopulateMemoryRanges(); + + MemoryRangeVector::Entry *entry = m_mem

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-17 Thread Jacob Lalonde via lldb-commits
@@ -230,6 +232,9 @@ class SymbolCompleter : public Completer { // Now add the functions & symbols to the list - only add if unique: for (const SymbolContext &sc : sc_list) { +if (m_match_set.size() >= m_request.GetMaxNumberOfResultsToAdd())

[Lldb-commits] [lldb] [lldb][nfc] Split the constructor of ThreadPlanStepOut (PR #136160)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan updated https://github.com/llvm/llvm-project/pull/136160 >From 42850d46b705c239b099be8d102a3756a8fd5283 Mon Sep 17 00:00:00 2001 From: Felipe de Azevedo Piovezan Date: Tue, 15 Apr 2025 10:20:41 -0700 Subject: [PATCH 1/3] [lldb][nfc] Factor out code from ThreadP

[Lldb-commits] [lldb] [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-04-17 Thread Miro Bucko via lldb-commits
@@ -35,6 +36,9 @@ namespace minidump { // Describes a range of memory captured in the Minidump struct Range { + // Default constructor required for range data vector + // but unusued. + Range() {} mbucko wrote: Range() = default; https://github.com/llvm/l

[Lldb-commits] [lldb] [lldb][Minidump Parser] Implement a range data vector for minidump memory ranges (PR #136040)

2025-04-17 Thread Miro Bucko via lldb-commits
@@ -429,62 +429,64 @@ MinidumpParser::GetExceptionStreams() { std::optional MinidumpParser::FindMemoryRange(lldb::addr_t addr) { - Log *log = GetLog(LLDBLog::Modules); + if (m_memory_ranges.IsEmpty()) +PopulateMemoryRanges(); + + MemoryRangeVector::Entry *entry = m_mem

[Lldb-commits] [lldb] [lldb][nfc] Split the constructor of ThreadPlanStepOut (PR #136160)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan edited https://github.com/llvm/llvm-project/pull/136160 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 9d5f163 - [lldb][nfc] Factor out code from ThreadPlanStepOut ctor (#136159)

2025-04-17 Thread via lldb-commits
Author: Felipe de Azevedo Piovezan Date: 2025-04-17T11:33:07-07:00 New Revision: 9d5f16308a2a1d778b9022c3a06a3cecc6d5e066 URL: https://github.com/llvm/llvm-project/commit/9d5f16308a2a1d778b9022c3a06a3cecc6d5e066 DIFF: https://github.com/llvm/llvm-project/commit/9d5f16308a2a1d778b9022c3a06a3cecc

[Lldb-commits] [lldb] [lldb][nfc] Factor out code from ThreadPlanStepOut ctor (PR #136159)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/136159 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][nfc] Factor out code from ThreadPlanStepOut ctor (PR #136159)

2025-04-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Felipe de Azevedo Piovezan (felipepiovezan) Changes A future patch will need to create a new constructor for this class, and extracting code out of its sole existing constructor will make this easier. This commit creates a helper function

[Lldb-commits] [lldb] [lldb][nfc] Factor out code from ThreadPlanStepOut ctor (PR #136159)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan created https://github.com/llvm/llvm-project/pull/136159 A future patch will need to create a new constructor for this class, and extracting code out of its sole existing constructor will make this easier. This commit creates a helper function for the code com

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-17 Thread Jason Molenda via lldb-commits
https://github.com/jasonmolenda updated https://github.com/llvm/llvm-project/pull/136065 >From 41274f7632d13ab7ec83a420c6ad6258e6fe8c36 Mon Sep 17 00:00:00 2001 From: Jason Molenda Date: Wed, 16 Apr 2025 17:18:02 -0700 Subject: [PATCH 1/2] [lldb][Mach-O corefiles] Don't init Target arch to cor

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-17 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff HEAD~1 HEAD --extensions cpp -- lldb/source/Plugins/Process/mach-core/ProcessMachCore

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
felipepiovezan wrote: Closing in favor of the stack: [[lldb][nfc] Factor out code from ThreadPlanStepOut ctor #136159](https://github.com/llvm/llvm-project/pull/136159) [[lldb][nfc] Split the constructor of ThreadPlanStepOut #136160](https://github.com/llvm/llvm-project/pull/136160) [[lldb][nfc

[Lldb-commits] [lldb] [lldb][nfc] Factor out code from ThreadPlanStepOut ctor (PR #136159)

2025-04-17 Thread via lldb-commits
https://github.com/jimingham approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/136159 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-17 Thread Jason Molenda via lldb-commits
@@ -578,20 +605,47 @@ Status ProcessMachCore::DoLoadCore() { SetCanJIT(false); + // If we have an executable binary in the Target already, + // use that to set the Target's ArchSpec. + // + // Don't initialize the ArchSpec based on the corefile's cputype/cpusubtype + /

[Lldb-commits] [lldb] [lldb][nfc] Add customization flags for ThreadPlanStepOut (PR #135866)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/135866 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Consider "hidden" frames in ThreadPlanShouldStopHere (PR #131800)

2025-04-17 Thread Felipe de Azevedo Piovezan via lldb-commits
https://github.com/felipepiovezan closed https://github.com/llvm/llvm-project/pull/131800 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix lock inversion between statusline mutex and output mutex (PR #135956)

2025-04-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/135956 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #136077)

2025-04-17 Thread Erich Keane via lldb-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/136077 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Stop the process for the threads request (PR #134456)

2025-04-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/134456 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-17 Thread Jonas Devlieghere via lldb-commits
@@ -578,20 +605,47 @@ Status ProcessMachCore::DoLoadCore() { SetCanJIT(false); + // If we have an executable binary in the Target already, + // use that to set the Target's ArchSpec. + // + // Don't initialize the ArchSpec based on the corefile's cputype/cpusubtype + /

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. LGTM modulo Jim's questions/suggestions. https://github.com/llvm/llvm-project/pull/136065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [lldb] [lldb][Telemetry] Fix unit test compile failure with LLVM_ENABLE_TELEMETRY=0 (PR #136115)

2025-04-17 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/136115 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #136077)

2025-04-17 Thread via lldb-commits
https://github.com/yronglin closed https://github.com/llvm/llvm-project/pull/136077 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [clang-tools-extra] [lldb] Reland [clang] Unify `SourceLocation` and `IdentifierInfo*` pair-like data structures to `IdentifierLoc` (PR #136077)

2025-04-17 Thread via lldb-commits
yronglin wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/136077 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove CompilerType::GetIndexOfFieldWithName (PR #135963)

2025-04-17 Thread via lldb-commits
github-actions[bot] wrote: @charles-zablit Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[Lldb-commits] [lldb] [lldb] Remove CompilerType::GetIndexOfFieldWithName (PR #135963)

2025-04-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 closed https://github.com/llvm/llvm-project/pull/135963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] f135ce6 - [lldb] Remove CompilerType::GetIndexOfFieldWithName (#135963)

2025-04-17 Thread via lldb-commits
Author: Charles Zablit Date: 2025-04-17T12:55:18+01:00 New Revision: f135ce6a9329124f1e508fcad2eedf5326a668fa URL: https://github.com/llvm/llvm-project/commit/f135ce6a9329124f1e508fcad2eedf5326a668fa DIFF: https://github.com/llvm/llvm-project/commit/f135ce6a9329124f1e508fcad2eedf5326a668fa.diff

[Lldb-commits] [lldb] [lldb] Remove CompilerType::GetIndexOfFieldWithName (PR #135963)

2025-04-17 Thread Michael Buch via lldb-commits
https://github.com/Michael137 approved this pull request. LGTM thanks! https://github.com/llvm/llvm-project/pull/135963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Remove CompilerType::GetIndexOfFieldWithName (PR #135963)

2025-04-17 Thread Charles Zablit via lldb-commits
charles-zablit wrote: Sorry I forgot to run `clang-format` I will configure a pre-commit hook. https://github.com/llvm/llvm-project/pull/135963 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [lldb] [lldb][Telemetry] Fix unit test compile failure with LLVM_ENABLE_TELEMETRY=0 (PR #136115)

2025-04-17 Thread Raul Tambre via lldb-commits
https://github.com/tambry created https://github.com/llvm/llvm-project/pull/136115 It needs to be `TEST_F` to access `received_entries`. Disabling also works based on the test not the fixture name. Build failure: ``` lldb/unittests/Core/TelemetryTest.cpp:110:17: error: use of undeclared identi

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #115331)

2025-04-17 Thread via lldb-commits
anjenner wrote: New PR for this: https://github.com/llvm/llvm-project/pull/136121 . https://github.com/llvm/llvm-project/pull/115331 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #136121)

2025-04-17 Thread via lldb-commits
https://github.com/anjenner created https://github.com/llvm/llvm-project/pull/136121 …Stream. CachedFileStream has previously performed the commit step in its destructor, but this means its only recourse for error handling is report_fatal_error. Modify this to add an explicit commit() method,

[Lldb-commits] [lldb] [lldb] Remove CompilerType::GetIndexOfFieldWithName (PR #135963)

2025-04-17 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/135963 >From 6dd67fe4ad03f0ec0623717715b8cfcc9537ab3f Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 16 Apr 2025 11:28:54 +0100 Subject: [PATCH 1/4] [lldb] Remove unused API CompilerType::GetIndexOfFi

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-17 Thread via lldb-commits
jimingham wrote: Beyond the question about the duplicate work, the approach seems reasonable to me. https://github.com/llvm/llvm-project/pull/136065 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] [lldb] Remove CompilerType::GetIndexOfFieldWithName (PR #135963)

2025-04-17 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/135963 >From 6dd67fe4ad03f0ec0623717715b8cfcc9537ab3f Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 16 Apr 2025 11:28:54 +0100 Subject: [PATCH 1/3] [lldb] Remove unused API CompilerType::GetIndexOfFi

[Lldb-commits] [lldb] [lldb] Remove CompilerType::GetIndexOfFieldWithName (PR #135963)

2025-04-17 Thread Charles Zablit via lldb-commits
charles-zablit wrote: > I think the test can just do this: > > ``` > uint64_t bit_offset; > std::string name; > field_type = field_type.GetFieldAtIndex( > field_type.GetIndexOfChildWithName(field_name, > /*omit_empty_base_classes=*/false), > name, &

[Lldb-commits] [lldb] [lldb] Remove CompilerType::GetIndexOfFieldWithName (PR #135963)

2025-04-17 Thread Charles Zablit via lldb-commits
https://github.com/charles-zablit updated https://github.com/llvm/llvm-project/pull/135963 >From 6dd67fe4ad03f0ec0623717715b8cfcc9537ab3f Mon Sep 17 00:00:00 2001 From: Charles Zablit Date: Wed, 16 Apr 2025 11:28:54 +0100 Subject: [PATCH 1/3] [lldb] Remove unused API CompilerType::GetIndexOfFi

[Lldb-commits] [lldb] [lldb][Mach-O corefiles] Don't init Target arch to corefile (PR #136065)

2025-04-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jason Molenda (jasonmolenda) Changes This patch is making three changes, when loading a Mach-O corefile: 1. At the start of `DoLoadCore`, if a binary was provided in addition to the corefile, initialize the Target's ArchSpec. 2. Before Pr

[Lldb-commits] [lldb] [lldb][Telemetry] Fix unit test compile failure with LLVM_ENABLE_TELEMETRY=0 (PR #136115)

2025-04-17 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Raul Tambre (tambry) Changes It needs to be `TEST_F` to access `received_entries`. Disabling also works based on the test not the fixture name. Build failure: ``` lldb/unittests/Core/TelemetryTest.cpp:110:17: error: use of undeclared ident