================ @@ -168,23 +170,34 @@ def test_default_no_run(self): "totalSymbolTableIndexTime", "totalSymbolTablesLoadedFromCache", "totalSymbolTablesSavedToCache", + "totalSymbolsLoaded", "totalDebugInfoByteSize", "totalDebugInfoIndexTime", "totalDebugInfoIndexLoadedFromCache", "totalDebugInfoIndexSavedToCache", "totalDebugInfoParseTime", ] self.verify_keys(debug_stats, '"debug_stats"', debug_stat_keys, None) - stats = debug_stats["targets"][0] - keys_exist = [ + + # Verify target stats keys. + target_stats = debug_stats["targets"][0] + target_stat_keys_exist = [ "expressionEvaluation", "frameVariable", "moduleIdentifiers", "targetCreateTime", ] - keys_missing = ["firstStopTime", "launchOrAttachTime"] - self.verify_keys(stats, '"stats"', keys_exist, keys_missing) - self.assertGreater(stats["targetCreateTime"], 0.0) + target_stat_keys_missing = ["firstStopTime", "launchOrAttachTime"] + self.verify_keys(target_stats, '"target_stats"', target_stat_keys_exist, target_stat_keys_missing) + self.assertGreater(target_stats["targetCreateTime"], 0.0) + + # Verify module stats keys. + for module_stats in debug_stats["modules"]: + module_stat_keys_exist = [ + "symbolsLoaded", + ] + self.verify_keys(module_stats, '"module_stats"', module_stat_keys_exist, None) ---------------- dmpots wrote:
Is there anything we can check about the expected value of these new stats? Like do we expect them to be > 0? https://github.com/llvm/llvm-project/pull/136226 _______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits