[Lldb-commits] [lldb] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #135033)

2025-04-09 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/135033 >From 5e365a86734b33f4ce31eb9199b88a4a772b5342 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Wed, 9 Apr 2025 17:06:49 +0400 Subject: [PATCH] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to br

[Lldb-commits] [lldb] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #135033)

2025-04-09 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: Note `Language::ForEach()` gives the following list: ``` cplusplus(eLanguageTypeC_plus_plus) objc(eLanguageTypeObjC) objcplusplus(eLanguageTypeObjC_plus_plus) cplusplus(eLanguageTypeC_plus_plus_03) cplusplus(eLanguageTypeC_plus_plus_11) cplusplus(eLanguageTypeC_plus_plus_14) cplus

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-09 Thread via lldb-commits
https://github.com/kusmour updated https://github.com/llvm/llvm-project/pull/134339 >From 2f8dc76a640368d958068bf1d0ea0bbdfaba117f Mon Sep 17 00:00:00 2001 From: Wanyi Ye Date: Thu, 3 Apr 2025 22:29:13 -0700 Subject: [PATCH 1/2] [lldb] Make SBProcess thread related actions listen to StopLocker

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-09 Thread via lldb-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r HEAD~1...HEAD lldb/packages/Python/lldbsuite/test/tools/lldb-dap/dap_server.py lldb/test/

[Lldb-commits] [lldb] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #135033)

2025-04-09 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman ready_for_review https://github.com/llvm/llvm-project/pull/135033 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #135033)

2025-04-09 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: With eh current path, `TestObjCBreakpoints.py` is still failing on macOS: ``` FAIL: test_break_dwarf (TestObjCBreakpoints.TestObjCBreakpoints) Test setting Objective-C specific breakpoints (DWARF in .o files). ---

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-09 Thread via lldb-commits
@@ -18,6 +18,22 @@ namespace lldb_private::dil { +static lldb::ValueObjectSP +ArrayToPointerConversion(lldb::ValueObjectSP valobj, + std::shared_ptr ctx) { + assert(valobj->IsArrayType() && + "an argument to array-to-pointer conversion must be

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-09 Thread Ilia Kuklin via lldb-commits
@@ -232,4 +263,105 @@ Interpreter::Visit(const IdentifierNode *node) { return identifier; } -} // namespace lldb_private::dil +llvm::Expected +Interpreter::Visit(const UnaryOpNode *node) { + FlowAnalysis rhs_flow( + /* address_of_is_pending */ node->kind() == UnaryOpKi

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-09 Thread Ilia Kuklin via lldb-commits
@@ -232,4 +263,105 @@ Interpreter::Visit(const IdentifierNode *node) { return identifier; } -} // namespace lldb_private::dil +llvm::Expected +Interpreter::Visit(const UnaryOpNode *node) { + FlowAnalysis rhs_flow( + /* address_of_is_pending */ node->kind() == UnaryOpKi

[Lldb-commits] [lldb] [lldb] Handle signals in a separate thread in the driver (PR #134956)

2025-04-09 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: @labath I originally used the MainLoop to handle `SIGINT` on non-Windows platforms and that didn't caused two test failures. I was able to reproduce the weird behavior by hand. With the current SIGINT handler: ``` (lldb) script Python Interactive Interpreter. To exit, typ

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-09 Thread via lldb-commits
https://github.com/GeorgeHuyubo edited https://github.com/llvm/llvm-project/pull/134563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-09 Thread via lldb-commits
@@ -111,7 +111,7 @@ struct ModuleStats { std::string uuid; std::string triple; // Path separate debug info file, or empty if none. - std::string symfile_path; + std::vector symfile_path; GeorgeHuyubo wrote: Since debuginfod could also provide dwp files

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-09 Thread Greg Clayton via lldb-commits
https://github.com/clayborg edited https://github.com/llvm/llvm-project/pull/134563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-09 Thread Greg Clayton via lldb-commits
@@ -422,6 +424,11 @@ class SymbolFile : public PluginInterface { /// hasn't been indexed yet, or a valid duration if it has. virtual StatsDuration::Duration GetDebugInfoIndexTime() { return {}; } + /// Return the time it took to locate any extra symbol files. + /// + //

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-09 Thread via lldb-commits
https://github.com/GeorgeHuyubo reopened https://github.com/llvm/llvm-project/pull/134563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-09 Thread Ilia Kuklin via lldb-commits
kuilpd wrote: > I'm also not very convinced by this "FlowAnalysis" thingy. Is it supposed to > be a performance optimization (collapsing *&foo to foo) or does it do > something more? FlowAnalysis is also used in subscript operator, to short-circuit getting an address of an element: `&arr[1]`,

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-09 Thread Ilia Kuklin via lldb-commits
@@ -232,4 +263,105 @@ Interpreter::Visit(const IdentifierNode *node) { return identifier; } -} // namespace lldb_private::dil +llvm::Expected +Interpreter::Visit(const UnaryOpNode *node) { + FlowAnalysis rhs_flow( + /* address_of_is_pending */ node->kind() == UnaryOpKi

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-09 Thread via lldb-commits
https://github.com/GeorgeHuyubo edited https://github.com/llvm/llvm-project/pull/134563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add unary operators Dereference and AddressOf to DIL (PR #134428)

2025-04-09 Thread Ilia Kuklin via lldb-commits
@@ -3,7 +3,12 @@ (* This is currently a subset of the final DIL Language, matching the current DIL implementation. *) -expression = primary_expression ; +expression = unary_expression ; + +unary_expression = unary_operator expression kuilpd wrote: We have

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-09 Thread via lldb-commits
https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/134563 >From 85bee8e66fcbc7b2001e2c06499b3458a197be25 Mon Sep 17 00:00:00 2001 From: George Hu Date: Tue, 8 Apr 2025 18:12:29 -0700 Subject: [PATCH 1/2] Add locate time for each module in statistics --- lldb/inc

[Lldb-commits] [lldb] [llvm] [dsymutil] Avoid copying binary swiftmodules built from textual (PR #134719)

2025-04-09 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `amdgpu-offload-rhel-9-cmake-build-only` running on `rocm-docker-rhel-9` while building `lldb,llvm` at step 4 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/205/builds/5802 Here is the re

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-09 Thread Greg Clayton via lldb-commits
@@ -355,6 +355,8 @@ class SymbolFile : public PluginInterface { virtual const ObjectFile *GetObjectFile() const = 0; virtual ObjectFile *GetMainObjectFile() = 0; + virtual std::vector GetAllObjectFiles(); + clayborg wrote: This call should be in `lldb_pr

[Lldb-commits] [lldb] [lldb] Handle signals in a separate thread in the driver (PR #134956)

2025-04-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/134956 >From 390942ce3a1cf6c51f95e8e2893f88807a48e745 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 8 Apr 2025 17:33:41 -0700 Subject: [PATCH] [lldb] Handle signals in a separate thread in the driver

[Lldb-commits] [lldb] Add download time for each module in statistics (PR #134563)

2025-04-09 Thread via lldb-commits
https://github.com/GeorgeHuyubo reopened https://github.com/llvm/llvm-project/pull/134563 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-09 Thread Greg Clayton via lldb-commits
@@ -4267,6 +4269,8 @@ const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile() { // find the correct DWP file, as the Debuginfod plugin uses *only* this // data to correctly match the DWP file with the binary. module_spec.GetUUID() = m_objfile_sp->GetUUID()

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-09 Thread Greg Clayton via lldb-commits
@@ -4250,11 +4250,13 @@ const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile() { ModuleSpec module_spec; module_spec.GetFileSpec() = m_objfile_sp->GetFileSpec(); FileSpec dwp_filespec; +StatsDuration duration; for (const auto &symfile : symfiles.files(

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-09 Thread Greg Clayton via lldb-commits
@@ -111,7 +111,7 @@ struct ModuleStats { std::string uuid; std::string triple; // Path separate debug info file, or empty if none. - std::string symfile_path; + std::vector symfile_path; clayborg wrote: This shouldn't be a vector. The `lldb_private::M

[Lldb-commits] [lldb] Add locate time and all symbol file path for each module in statistics (PR #134563)

2025-04-09 Thread Greg Clayton via lldb-commits
@@ -4267,6 +4269,8 @@ const std::shared_ptr &SymbolFileDWARF::GetDwpSymbolFile() { // find the correct DWP file, as the Debuginfod plugin uses *only* this // data to correctly match the DWP file with the binary. module_spec.GetUUID() = m_objfile_sp->GetUUID()

[Lldb-commits] [lldb] [lldb] Synchronize access to m_statusline in the Debugger (PR #134759)

2025-04-09 Thread Pavel Labath via lldb-commits
@@ -391,8 +392,13 @@ bool Debugger::SetTerminalWidth(uint64_t term_width) { if (auto handler_sp = m_io_handler_stack.Top()) handler_sp->TerminalSizeChanged(); - if (m_statusline) -m_statusline->TerminalSizeChanged(); + + { +// This might get called from a signa

[Lldb-commits] [lldb] Add download time for each module in statistics (PR #134563)

2025-04-09 Thread via lldb-commits
https://github.com/GeorgeHuyubo updated https://github.com/llvm/llvm-project/pull/134563 >From 85bee8e66fcbc7b2001e2c06499b3458a197be25 Mon Sep 17 00:00:00 2001 From: George Hu Date: Tue, 8 Apr 2025 18:12:29 -0700 Subject: [PATCH 1/2] Add locate time for each module in statistics --- lldb/inc

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-09 Thread Ebuka Ezike via lldb-commits
da-viper wrote: I think it should be. Most distributions are still on llvm 19 as llvm 20.1 was released last month. Maybe that's why there haven't been any reports. This only affects the 20 and 21 branches. https://github.com/llvm/llvm-project/pull/134626

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-09 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > I was also wondering if this should be backported as it also affects llvm > 20.x branch Given its low risk I'm okay back porting this, if you think it's important. That said, I haven't seen any other reports so I'm guessing this crash isn't particularly widespread. htt

[Lldb-commits] [lldb] [lldb] Fix SBTarget::ReadInstruction with flavor (PR #134626)

2025-04-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/134626 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Synchronize access to m_statusline in the Debugger (PR #134759)

2025-04-09 Thread Jonas Devlieghere via lldb-commits
@@ -391,8 +392,13 @@ bool Debugger::SetTerminalWidth(uint64_t term_width) { if (auto handler_sp = m_io_handler_stack.Top()) handler_sp->TerminalSizeChanged(); - if (m_statusline) -m_statusline->TerminalSizeChanged(); + + { +// This might get called from a signa

[Lldb-commits] [lldb] [lldb][debugserver] Fix an off-by-one error in watchpoint identification (PR #134314)

2025-04-09 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lldb-arm-ubuntu` running on `linaro-lldb-arm-ubuntu` while building `lldb` at step 6 "test". Full details are available at: https://lab.llvm.org/buildbot/#/builders/18/builds/14116 Here is the relevant piece of the build log

[Lldb-commits] [lldb] [lldb][FormatEntity][NFCI] Refactor FunctionNameWithArgs into helper functions and use LLVM style (PR #135031)

2025-04-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/135031 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-09 Thread Pavel Labath via lldb-commits
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef &format_str, return parent; } +/// Parses a single highlighting format specifier. +/// +/// Example syntax for such specifier: +/// \code +/// ${function.name-with-args:%highlight_basename(ansi.

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-09 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper created https://github.com/llvm/llvm-project/pull/135008 Fixes #131589 Add a new option to the RunCommands functions to control the echoing of commands >From 296019edb5edba4a21e040feb154b1ef83f1e64d Mon Sep 17 00:00:00 2001 From: Ebuka Ezike Date: Wed, 9 Apr 2025

[Lldb-commits] [lldb] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #135033)

2025-04-09 Thread Dmitry Vasilyev via lldb-commits
slydiman wrote: It seems the sorting of language plug-ins in CMakeLists.txt is not enough. I tested #132274 locally and it passed, but failed on the buildbot [lldb-aarch64-windows](https://lab.llvm.org/buildbot/#/builders/141). I have updated LookupInfo::LookupInfo() close to the current code

[Lldb-commits] [lldb] e98d138 - [NFC][LLDB] Clean up comments/some code in MinidumpFileBuilder (#134961)

2025-04-09 Thread via lldb-commits
Author: Jacob Lalonde Date: 2025-04-09T10:55:30-07:00 New Revision: e98d1380a0e7282ef23d1f583f0a4e02d608eb1d URL: https://github.com/llvm/llvm-project/commit/e98d1380a0e7282ef23d1f583f0a4e02d608eb1d DIFF: https://github.com/llvm/llvm-project/commit/e98d1380a0e7282ef23d1f583f0a4e02d608eb1d.diff

[Lldb-commits] [lldb] [NFC][LLDB] Clean up comments/some code in MinidumpFileBuilder (PR #134961)

2025-04-09 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond closed https://github.com/llvm/llvm-project/pull/134961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [NFC][LLDB] Clean up comments/some code in MinidumpFileBuilder (PR #134961)

2025-04-09 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: > LGTM, though the comment in `AddData` seemed useful, even though it had a > couple of typos. Why remove it? I recently landed changes that did add chunking of the data so the comment was no longer accurate. Now we'll only ever get chunks up to the `MAX_CHUNK_SIZE` https://git

[Lldb-commits] [lldb] [NFC][LLDB] Clean up comments/some code in MinidumpFileBuilder (PR #134961)

2025-04-09 Thread Tom Yang via lldb-commits
https://github.com/zhyty approved this pull request. LGTM, though the comment in `AddData` seemed useful, even though it had a couple of typos. Why remove it? https://github.com/llvm/llvm-project/pull/134961 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [lldb] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #135033)

2025-04-09 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman edited https://github.com/llvm/llvm-project/pull/135033 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #135033)

2025-04-09 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman converted_to_draft https://github.com/llvm/llvm-project/pull/135033 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #135033)

2025-04-09 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/135033 >From d89b0242152002161b90d29e275a68e0e3f51dfe Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Wed, 9 Apr 2025 17:06:49 +0400 Subject: [PATCH] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to br

[Lldb-commits] [lldb] [lldb] Handle signals in a separate thread in the driver (PR #134956)

2025-04-09 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/134956 >From 3943112f5182065eed43d72e2960ed166737b237 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 8 Apr 2025 17:33:41 -0700 Subject: [PATCH] [lldb] Handle signals in a separate thread in the driver

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-09 Thread Michael Buch via lldb-commits
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef &format_str, return parent; } +/// Parses a single highlighting format specifier. +/// +/// Example syntax for such specifier: +/// \code +/// ${function.name-with-args:%highlight_basename(ansi.

[Lldb-commits] [lldb] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #135033)

2025-04-09 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman updated https://github.com/llvm/llvm-project/pull/135033 >From 75c47b9b6ff38150ee7ddd47c9b0be05681bc499 Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Wed, 9 Apr 2025 17:06:49 +0400 Subject: [PATCH] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to br

[Lldb-commits] [lldb] [lldb] Handle signals in a separate thread in the driver (PR #134956)

2025-04-09 Thread Jonas Devlieghere via lldb-commits
@@ -824,5 +834,11 @@ int main(int argc, char const *argv[]) { future.wait(); } + // Stop the signal handler thread. Do this after calling SBDebugger::Terminate + // so that impatient users can send a SIGSTOP if they don't want to wait for JDevlieghere

[Lldb-commits] [lldb] [lldb] Handle signals in a separate thread in the driver (PR #134956)

2025-04-09 Thread Jonas Devlieghere via lldb-commits
JDevlieghere wrote: > You need to actually let the main loop handle the signals > (MainLoopPosix::RegisterSignal), as it knows how to do that safely. The > function is not available on windows, so you'd need to `#ifdef` it, but that > should be fine because the current code is conditionalized

[Lldb-commits] [lldb] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #135033)

2025-04-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Dmitry Vasilyev (slydiman) Changes The original PR is #132274. --- Patch is 38.35 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/135033.diff 16 Files Affected: - (modified) lldb/include/lldb/

[Lldb-commits] [lldb] [LLDB] Reapply refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #135033)

2025-04-09 Thread Dmitry Vasilyev via lldb-commits
https://github.com/slydiman created https://github.com/llvm/llvm-project/pull/135033 The original PR is #132274. >From 08b6d2b832d3f40ed56f05e7e7da26d6f3f0a8cc Mon Sep 17 00:00:00 2001 From: Dmitry Vasilyev Date: Wed, 9 Apr 2025 17:06:49 +0400 Subject: [PATCH] [LLDB] Reapply refactored CPlusPl

[Lldb-commits] [lldb] [llvm] [dsymutil] Avoid copying binary swiftmodules built from textual (PR #134719)

2025-04-09 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `lld-x86_64-win` running on `as-worker-93` while building `lldb,llvm` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/146/builds/2673 Here is the relevan

[Lldb-commits] [lldb] [LLDB][NFC]Also includes the error in log msg. (PR #134922)

2025-04-09 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo closed https://github.com/llvm/llvm-project/pull/134922 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][FormatEntity][NFCI] Refactor FunctionNameWithArgs into helper functions and use LLVM style (PR #135031)

2025-04-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes I've always found this hard to read. Some upcoming changes make similar computations, so I thought it's a good time to factor out this logic into re-usable helpers and clean it up using LLVM's preferred ea

[Lldb-commits] [lldb] e3f5a1b - [LLDB][NFC]Also includes the error in log msg. (#134922)

2025-04-09 Thread via lldb-commits
Author: Vy Nguyen Date: 2025-04-09T10:23:48-04:00 New Revision: e3f5a1bfc58b5c8db8ff8ac8390e790c7a396d4a URL: https://github.com/llvm/llvm-project/commit/e3f5a1bfc58b5c8db8ff8ac8390e790c7a396d4a DIFF: https://github.com/llvm/llvm-project/commit/e3f5a1bfc58b5c8db8ff8ac8390e790c7a396d4a.diff LOG

[Lldb-commits] [lldb] [LLDB][NFC]Also includes the error in log msg. (PR #134922)

2025-04-09 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/134922 >From ab50c89574613178ba2bf79455eaa8aba0f2205d Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 8 Apr 2025 15:58:10 -0400 Subject: [PATCH 1/2] [LLDB][NFC]Also includes the error in log msg. --- lldb/include

[Lldb-commits] [lldb] [lldb][lldb-dap] fix repeating commands in repl mode (PR #135008)

2025-04-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Ebuka Ezike (da-viper) Changes Fixes #131589 Add a new option to the RunCommands functions to control the echoing of commands --- Full diff: https://github.com/llvm/llvm-project/pull/135008.diff 8 Files Affected: - (modified) lldb/test

[Lldb-commits] [lldb] Revert "[LLDB] Refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies" (PR #134995)

2025-04-09 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: David Spickett (DavidSpickett) Changes Reverts llvm/llvm-project#132274 Broke a test on LLDB Widows on Arm: https://lab.llvm.org/buildbot/#/builders/141/builds/7726 ``` FAIL: test_dwarf (lldbsuite.test.lldbtest.TestExternCSymbols.test_dwarf

[Lldb-commits] [lldb] [LLDB] Refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies (PR #132274)

2025-04-09 Thread David Spickett via lldb-commits
DavidSpickett wrote: The above failure is legit, this is the relevant bit of the log: ``` FAIL: test_dwarf (lldbsuite.test.lldbtest.TestExternCSymbols.test_dwarf) -- Traceback (most recent call last): File "C:\Users\tcwg\ll

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-09 Thread Michael Buch via lldb-commits
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef &format_str, return parent; } +/// Parses a single highlighting format specifier. +/// +/// Example syntax for such specifier: +/// \code +/// ${function.name-with-args:%highlight_basename(ansi.

[Lldb-commits] [lldb] [lldb] Handle signals in a separate thread in the driver (PR #134956)

2025-04-09 Thread Pavel Labath via lldb-commits
@@ -794,6 +800,10 @@ int main(int argc, char const *argv[]) { signal(SIGTSTP, sigtstp_handler); #endif + // Run the signal handling MainLoop on a separate thread. + std::thread signal_thread([] { g_signal_loop.Run(); }); + signal_thread.detach(); labath w

[Lldb-commits] [lldb] Revert "[LLDB] Refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies" (PR #134995)

2025-04-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/134995 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] a29be9f - Revert "[LLDB] Refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies" (#134995)

2025-04-09 Thread via lldb-commits
Author: David Spickett Date: 2025-04-09T13:16:23+01:00 New Revision: a29be9f28e8e0d4ca7a8a3cfdffe616ac780c754 URL: https://github.com/llvm/llvm-project/commit/a29be9f28e8e0d4ca7a8a3cfdffe616ac780c754 DIFF: https://github.com/llvm/llvm-project/commit/a29be9f28e8e0d4ca7a8a3cfdffe616ac780c754.diff

[Lldb-commits] [lldb] Revert "[LLDB] Refactored CPlusPlusLanguage::MethodName to break lldb-server dependencies" (PR #134995)

2025-04-09 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/134995 Reverts llvm/llvm-project#132274 Broke a test on LLDB Widows on Arm: https://lab.llvm.org/buildbot/#/builders/141/builds/7726 ``` FAIL: test_dwarf (lldbsuite.test.lldbtest.TestExternCSymbols.test_dwarf) <.

[Lldb-commits] [lldb] [lldb] Support negative function offsets in UnwindPlans (PR #134662)

2025-04-09 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/134662 >From 26b46c0f0e3bdb56afed5fb1e9ab1dd577a3ad66 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 4 Apr 2025 11:37:34 +0200 Subject: [PATCH 1/2] [lldb] Support negative function offsets in UnwindPlans These

[Lldb-commits] [lldb] [lldb] Remove unused UnwindPlan functions (PR #134630)

2025-04-09 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/134630 >From ab6dc42c00fd52a0551ec59cfddb012bc56da277 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 4 Apr 2025 12:05:18 +0200 Subject: [PATCH] [lldb] Remove unused UnwindPlan functions `GetLSDAAddress` and `Ge

[Lldb-commits] [lldb] [lldb] Do not bump memory modificator ID when "internal" debugger memory is updated (PR #129092)

2025-04-09 Thread Mikhail Zakharov via lldb-commits
real-mikhail wrote: Hi, I added the new option key `target.process.track-memory-cache-changes` (which defaults to `true`, meaning bulletproof behaviour). Setting it to `false` enables the optimization I initially suggested. I also added a new dump command and ensured with test that MemoryID i

[Lldb-commits] [libcxxabi] [lldb] [llvm] [lldb] Add frame-format option to highlight function names in backtraces (PR #131836)

2025-04-09 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/131836 >From 96901b4937a7cfe14b2f595484c95178176dc178 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Tue, 11 Mar 2025 08:57:13 + Subject: [PATCH 1/5] [llvm][ItaniumDemangle] Add printLeft/printRight APIs to

[Lldb-commits] [lldb] [lldb] Make SBProcess thread related actions listen to StopLocker (PR #134339)

2025-04-09 Thread via lldb-commits
https://github.com/kusmour edited https://github.com/llvm/llvm-project/pull/134339 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][MIPS] Fix signal SIGBUS number mismatch error on mips target (PR #132688)

2025-04-09 Thread Pavel Labath via lldb-commits
labath wrote: The patch (still) looks good. I think what you need is for someone to push the submit button, so I'll do that now. https://github.com/llvm/llvm-project/pull/132688 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] [lldb] Remove unused UnwindPlan functions (PR #134630)

2025-04-09 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/134630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] ea7dd70 - [lldb] Remove unused UnwindPlan functions (#134630)

2025-04-09 Thread via lldb-commits
Author: Pavel Labath Date: 2025-04-09T11:04:45+02:00 New Revision: ea7dd70b5326706141be2a768f2fd47ae71ee6a8 URL: https://github.com/llvm/llvm-project/commit/ea7dd70b5326706141be2a768f2fd47ae71ee6a8 DIFF: https://github.com/llvm/llvm-project/commit/ea7dd70b5326706141be2a768f2fd47ae71ee6a8.diff

[Lldb-commits] [lldb] [lldb] Remove unused UnwindPlan functions (PR #134630)

2025-04-09 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/134630 >From 5f226bc5fa08e1b098ee95ba860954079a71c83c Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Fri, 4 Apr 2025 12:05:18 +0200 Subject: [PATCH] [lldb] Remove unused UnwindPlan functions `GetLSDAAddress` and `Ge

[Lldb-commits] [lldb] [lldb] Handle signals in a separate thread in the driver (PR #134956)

2025-04-09 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/134956 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle signals in a separate thread in the driver (PR #134956)

2025-04-09 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/134956 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Handle signals in a separate thread in the driver (PR #134956)

2025-04-09 Thread Pavel Labath via lldb-commits
@@ -637,48 +641,50 @@ void Driver::UpdateWindowSize() { } void sigwinch_handler(int signo) { - if (g_driver != nullptr) -g_driver->UpdateWindowSize(); + g_signal_loop.AddPendingCallback([](MainLoopBase &loop) { +if (g_driver != nullptr) + g_driver->UpdateWindowS

[Lldb-commits] [lldb] [LLDB][MIPS] Fix signal SIGBUS number mismatch error on mips target (PR #132688)

2025-04-09 Thread via lldb-commits
@@ -8,7 +8,10 @@ #include "LinuxSignals.h" -#ifdef __linux__ +// Now, because we do not support mips debugging, if we compile LLVM on mips +// target, would report error `static assertion failed:Value mismatch for signal +// number SIGBUS`, so add this condition to avoid err

[Lldb-commits] [lldb] [lldb] Remove UnwindPlan::Row shared_ptrs, lite (PR #134081)

2025-04-09 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/134081 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits