@@ -3109,7 +3104,10 @@ bool Target::RunStopHooks() {
auto result = cur_hook_sp->HandleStop(exc_ctx, output_sp);
switch (result) {
case StopHook::StopHookResult::KeepStopped:
yln wrote:
Should the "auto continue" override only apply to `KeepSt
https://github.com/satyajanga ready_for_review
https://github.com/llvm/llvm-project/pull/130841
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/satyajanga updated
https://github.com/llvm/llvm-project/pull/130841
>From e949d2ee19408c43d9067075d2436f8549132830 Mon Sep 17 00:00:00 2001
From: satya janga
Date: Tue, 11 Mar 2025 13:39:08 -0700
Subject: [PATCH 1/4] Make breakpoint stop reason more accurate
---
.../test/to
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/131203.diff
1 Files Affected:
- (modified) lldb/unittests/Core/TelemetryTest.cpp (+16-19)
``diff
diff --git a/lldb/unittests/Core/TelemetryT
matthewbastien wrote:
I refactored the UI logic so that we don't have to pass `userInteractive`
everywhere and can share common buttons with different parts of the app. I also
added where the lldb-dap path comes from in the error message.
Probably worth another review before merging.
CC @JDev
DanielCChen wrote:
I will check all those failures and push an update soon.
https://github.com/llvm/llvm-project/pull/131200
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,330 @@
+//===-- NativeProcessAIX.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/ashgti edited
https://github.com/llvm/llvm-project/pull/130090
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Tom Yang (zhyty)
Changes
This patch improves LLDB launch time on Linux machines for **preload
scenarios**, particularly for executables with a lot of shared library
dependencies (or modules). Specifically:
* Launching a binary with `target
https://github.com/vogelsgesang closed
https://github.com/llvm/llvm-project/pull/125843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
llvmbot wrote:
@llvm/pr-subscribers-libcxx
Author: Daniel Chen (DanielCChen)
Changes
We don't plan to support it on AIX.
This change will make it as if it is set to OFF.
---
Full diff: https://github.com/llvm/llvm-project/pull/131200.diff
9 Files Affected:
- (modified) compiler-rt/cmak
@@ -0,0 +1,120 @@
+//===-- GoToTargetsRequestHandler.cpp
+//--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier:
https://github.com/jasonmolenda approved this pull request.
lgtm
https://github.com/llvm/llvm-project/pull/131073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dmpots closed
https://github.com/llvm/llvm-project/pull/129614
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: David Peixotto
Date: 2025-03-13T15:54:45-07:00
New Revision: d1deaed0d284f16870f3236ec2efe7d29308a56a
URL:
https://github.com/llvm/llvm-project/commit/d1deaed0d284f16870f3236ec2efe7d29308a56a
DIFF:
https://github.com/llvm/llvm-project/commit/d1deaed0d284f16870f3236ec2efe7d29308a56a.diff
Author: Adrian Vogelsgesang
Date: 2025-03-13T23:49:05+01:00
New Revision: 8b9031f245a268c6acb331de5ea68da20be37051
URL:
https://github.com/llvm/llvm-project/commit/8b9031f245a268c6acb331de5ea68da20be37051
DIFF:
https://github.com/llvm/llvm-project/commit/8b9031f245a268c6acb331de5ea68da20be37051
jimingham wrote:
You should also check that the update succeeded before getting its value.
https://github.com/llvm/llvm-project/pull/131233
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/131077
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/da-viper edited
https://github.com/llvm/llvm-project/pull/130503
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-03-13T15:12:19-07:00
New Revision: 998511c8ef577f330c90bf32db37d5f8305c53f3
URL:
https://github.com/llvm/llvm-project/commit/998511c8ef577f330c90bf32db37d5f8305c53f3
DIFF:
https://github.com/llvm/llvm-project/commit/998511c8ef577f330c90bf32db37d5f8305c53f3.d
cmtice wrote:
> > > Didn't quite finish, but this is what I have so far. I am wondering about
> > > the usefulness of the `IdentifierInfo`. It started out its existence in a
> > > completely different world than what we have now -- where the operations
> > > were mainly defined on types instea
https://github.com/zhyty ready_for_review
https://github.com/llvm/llvm-project/pull/130912
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jasonmolenda approved this pull request.
Yes looks correct to me.
https://github.com/llvm/llvm-project/pull/131077
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DanielCChen wrote:
> Wouldn't it be more maintainable to just force the value to OFF for AIX where
> the `option()` is defined?
Unfortunately, the cmake command line option `-D
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR=ON` overrides the `option()` in the cmake
file.
https://github.com/llvm/llvm-pro
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/131077
>From 4d27dc4928cfd57b2c2bc8b3059d2cb773cfc7ca Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 12 Mar 2025 22:25:09 -0700
Subject: [PATCH 1/3] [debugserver] Fix mutex scope in
RNBRemote::CommDa
jimingham wrote:
If the result of `frame var` is 30 pointer variables, I would not be happy if
that went from 30 lines I could parse and find the variable I was interested in
to 30 x num_ivars lines, and now I've got many pages of much more noisy output
to scan.
When I'm listing multiple vari
jasonmolenda wrote:
I was worried about the timing in `MachProcess::PrivateResume` versus
`Interrupt` but I think it will be OK. `PrivateResume` does
```
void MachProcess::PrivateResume() {
PTHREAD_MUTEX_LOCKER(locker, m_exception_messages_mutex);
// Set our state accordingly
if (m_thre
https://github.com/matthewbastien updated
https://github.com/llvm/llvm-project/pull/129262
>From f687fdfeda083587bd8f2a874d34c0f9dba1e31a Mon Sep 17 00:00:00 2001
From: Matthew Bastien
Date: Fri, 28 Feb 2025 11:08:25 -0500
Subject: [PATCH 1/8] allow providing debug adapter arguments
---
lldb/
Author: Jonas Devlieghere
Date: 2025-03-13T13:54:13-07:00
New Revision: e823449f66acb39ce5a11dde6283ffd11731fe6a
URL:
https://github.com/llvm/llvm-project/commit/e823449f66acb39ce5a11dde6283ffd11731fe6a
DIFF:
https://github.com/llvm/llvm-project/commit/e823449f66acb39ce5a11dde6283ffd11731fe6a.d
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/131073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1559,10 +1560,29 @@ void Target::DidExec() {
void Target::SetExecutableModule(ModuleSP &executable_sp,
LoadDependentFiles load_dependent_files) {
+ telemetry::ScopedDispatcher helper(&m_debugger);
Log *log = GetLog(LLDBLog::Target);
https://github.com/arichardson edited
https://github.com/llvm/llvm-project/pull/131200
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/arichardson requested changes to this pull request.
Wouldn't it be more maintainable to just set the value to off for AIX where the
`option()` is defined?
https://github.com/llvm/llvm-project/pull/131200
___
lldb-commits mailing lis
@@ -0,0 +1,121 @@
+//===-- GoToTargetsRequestHandler.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/131203
None
>From cff4bbc4ff68e77e3093a880f55d2e17116e6f37 Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Thu, 13 Mar 2025 15:57:48 -0400
Subject: [PATCH] [LLDB][NFC]Refactor common test setup into SetUp method
---
llvmbot wrote:
@llvm/pr-subscribers-libunwind
Author: Daniel Chen (DanielCChen)
Changes
We don't plan to support it on AIX.
This change will make it as if it is set to OFF.
---
Full diff: https://github.com/llvm/llvm-project/pull/131200.diff
9 Files Affected:
- (modified) compiler-rt/c
llvmbot wrote:
@llvm/pr-subscribers-libcxxabi
Author: Daniel Chen (DanielCChen)
Changes
We don't plan to support it on AIX.
This change will make it as if it is set to OFF.
---
Full diff: https://github.com/llvm/llvm-project/pull/131200.diff
9 Files Affected:
- (modified) compiler-rt/c
https://github.com/DanielCChen created
https://github.com/llvm/llvm-project/pull/131200
We don't plan to support it on AIX.
This change will make it as if it is set to OFF.
>From 37eb6964a176dd566b3600c0fb15a1d426551729 Mon Sep 17 00:00:00 2001
From: Daniel Chen
Date: Thu, 13 Mar 2025 15:52:23
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/130503
>From 63c0d5071146893b485dd4d2665e55fc697e1352 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 9 Mar 2025 12:46:54 +
Subject: [PATCH 01/17] [lldb-dap] implement jump to cursor.
---
lldb/cmake/module
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/130503
>From 63c0d5071146893b485dd4d2665e55fc697e1352 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 9 Mar 2025 12:46:54 +
Subject: [PATCH 01/16] [lldb-dap] implement jump to cursor.
---
lldb/cmake/module
https://github.com/da-viper updated
https://github.com/llvm/llvm-project/pull/130503
>From 63c0d5071146893b485dd4d2665e55fc697e1352 Mon Sep 17 00:00:00 2001
From: Ezike Ebuka
Date: Sun, 9 Mar 2025 12:46:54 +
Subject: [PATCH 01/14] [lldb-dap] implement jump to cursor.
---
lldb/cmake/module
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/131077
>From 4d27dc4928cfd57b2c2bc8b3059d2cb773cfc7ca Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 12 Mar 2025 22:25:09 -0700
Subject: [PATCH 1/2] [debugserver] Fix mutex scope in
RNBRemote::CommDa
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Vy Nguyen (oontvoo)
Changes
The field is currently un-initialised and can cause a crash in some build
configs (where it got random values)
---
Full diff: https://github.com/llvm/llvm-project/pull/131191.diff
1 Files Affected:
- (modifie
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/131073
>From 48ab516f56328fe101fe3fe1cd22a06ec1a033e2 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Wed, 12 Mar 2025 22:07:41 -0700
Subject: [PATCH 1/2] [lldb] Synchronize interrupt and resume signals in
@@ -1573,6 +1576,8 @@ static uint64_t bits(uint64_t value, uint32_t msbit,
uint32_t lsbit) {
}
bool MachProcess::Interrupt() {
+ PTHREAD_MUTEX_LOCKER(locker, m_exception_and_signal_mutex);
+
JDevlieghere wrote:
I was worried about lock order inversion betwe
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127834
>From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 19 Feb 2025 12:47:57 -0500
Subject: [PATCH 01/21] [LLDB][Telemetry]Define TargetInfo for collecting data
about
https://github.com/oontvoo updated
https://github.com/llvm/llvm-project/pull/127834
>From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001
From: Vy Nguyen
Date: Wed, 19 Feb 2025 12:47:57 -0500
Subject: [PATCH 01/20] [LLDB][Telemetry]Define TargetInfo for collecting data
about
@@ -1054,7 +1054,7 @@ rnb_err_t RNBRemote::HandleReceivedPacket(PacketEnum
*type) {
void RNBRemote::CommDataReceived(const std::string &new_data) {
// DNBLogThreadedIf (LOG_RNB_REMOTE, "%8d RNBRemote::%s called",
// (uint32_t)m_comm.Timer().ElapsedMicroSeconds(true), __F
@@ -1064,6 +1065,29 @@ const char *Process::GetExitDescription() {
bool Process::SetExitStatus(int status, llvm::StringRef exit_string) {
// Use a mutex to protect setting the exit status.
std::lock_guard guard(m_exit_status_mutex);
+ telemetry::ScopedDispatcher helper;
+
@@ -1064,6 +1065,29 @@ const char *Process::GetExitDescription() {
bool Process::SetExitStatus(int status, llvm::StringRef exit_string) {
// Use a mutex to protect setting the exit status.
std::lock_guard guard(m_exit_status_mutex);
+ telemetry::ScopedDispatcher helper;
+
@@ -0,0 +1,119 @@
+//===-- GoToRequestHandler.cpp --===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.
Author: Jason Molenda
Date: 2025-03-13T10:08:09-07:00
New Revision: 09a36c82793ba32b87faf11fbfc2e7624f25e92e
URL:
https://github.com/llvm/llvm-project/commit/09a36c82793ba32b87faf11fbfc2e7624f25e92e
DIFF:
https://github.com/llvm/llvm-project/commit/09a36c82793ba32b87faf11fbfc2e7624f25e92e.diff
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/125843
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1054,7 +1054,7 @@ rnb_err_t RNBRemote::HandleReceivedPacket(PacketEnum
*type) {
void RNBRemote::CommDataReceived(const std::string &new_data) {
// DNBLogThreadedIf (LOG_RNB_REMOTE, "%8d RNBRemote::%s called",
// (uint32_t)m_comm.Timer().ElapsedMicroSeconds(true), __F
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/130773
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/walter-erquinigo approved this pull request.
https://github.com/llvm/llvm-project/pull/129262
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1573,6 +1576,8 @@ static uint64_t bits(uint64_t value, uint32_t msbit,
uint32_t lsbit) {
}
bool MachProcess::Interrupt() {
+ PTHREAD_MUTEX_LOCKER(locker, m_exception_and_signal_mutex);
+
jimingham wrote:
Would it be better to put this mutex lock after t
https://github.com/walter-erquinigo approved this pull request.
all good then!
https://github.com/llvm/llvm-project/pull/129919
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/130090
>From f26c9a79ca234bee77ec1a9694bf8be2d0e3745c Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 6 Mar 2025 13:21:10 +0100
Subject: [PATCH 1/7] [lldb-dap] Updating RequestHandler to encode/decode
arguments
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 5929de8c7731748bf58ad9b1fedfed75e7aae455
b9e3f25cfd11e396b80a4624bff6953e73a53334 --e
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/130090
>From f26c9a79ca234bee77ec1a9694bf8be2d0e3745c Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 6 Mar 2025 13:21:10 +0100
Subject: [PATCH 1/6] [lldb-dap] Updating RequestHandler to encode/decode
arguments
ashgti wrote:
> What is your overall plan for this PR?
>
> I assume the first step is to get buy-in from all reviewers into the new
> structure for our JSON types. But what comes after? Are you planning to
> update this PR to cover all JSON types / requests / responses? Are you
> planning to
@@ -57,235 +68,288 @@ class RequestHandler {
DAP &dap;
};
-class AttachRequestHandler : public RequestHandler {
-public:
- using RequestHandler::RequestHandler;
+/// Base class for handling DAP requests. Handlers should declare their
+/// arguments and response body types l
@@ -240,6 +240,137 @@ using Message = std::variant;
bool fromJSON(const llvm::json::Value &, Message &, llvm::json::Path);
llvm::json::Value toJSON(const Message &);
+// MARK: Types
+
+// "Source": {
+// "type": "object",
+// "description": "A `Source` is a descriptor for
https://github.com/ashgti updated
https://github.com/llvm/llvm-project/pull/130090
>From f26c9a79ca234bee77ec1a9694bf8be2d0e3745c Mon Sep 17 00:00:00 2001
From: John Harrison
Date: Thu, 6 Mar 2025 13:21:10 +0100
Subject: [PATCH 1/5] [lldb-dap] Updating RequestHandler to encode/decode
arguments
@@ -0,0 +1,256 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/JDevlieghere approved this pull request.
https://github.com/llvm/llvm-project/pull/130987
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -30,216 +30,170 @@ namespace lldb_dap::protocol {
// MARK: Base Protocol
-// "Request": {
-// "allOf": [ { "$ref": "#/definitions/ProtocolMessage" }, {
-// "type": "object",
-// "description": "A client or debug adapter initiated request.",
-// "properties":
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
In most places, the rows are copied anyway (because they are generated by
cumulating modifications) immediately after adding them to the unwind plans. In
others, they can be moved into the unwind plan. This le
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/131150
In most places, the rows are copied anyway (because they are generated by
cumulating modifications) immediately after adding them to the unwind plans. In
others, they can be moved into the unwind plan. This lets
@@ -0,0 +1,256 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,138 @@
+"""
+Test lldb-dap gotoTarget request
+"""
+
+from typing import Dict, Any
+from unittest import SkipTest
+
+from lldbsuite.test.lldbtest import line_number
+import lldbdap_testcase
+import os
+
+
+class TestDAP_gotoTargets(lldbdap_testcase.DAPTestCaseBase):
+
@@ -0,0 +1,138 @@
+"""
+Test lldb-dap gotoTarget request
+"""
+
+from typing import Dict, Any
+from unittest import SkipTest
+
+from lldbsuite.test.lldbtest import line_number
+import lldbdap_testcase
+import os
+
+
+class TestDAP_gotoTargets(lldbdap_testcase.DAPTestCaseBase):
+
@@ -0,0 +1,138 @@
+"""
+Test lldb-dap gotoTarget request
+"""
+
+from typing import Dict, Any
+from unittest import SkipTest
+
+from lldbsuite.test.lldbtest import line_number
+import lldbdap_testcase
+import os
+
+
+class TestDAP_gotoTargets(lldbdap_testcase.DAPTestCaseBase):
+
@@ -0,0 +1,138 @@
+"""
+Test lldb-dap gotoTarget request
+"""
+
+from typing import Dict, Any
+from unittest import SkipTest
+
+from lldbsuite.test.lldbtest import line_number
+import lldbdap_testcase
+import os
+
+
+class TestDAP_gotoTargets(lldbdap_testcase.DAPTestCaseBase):
+
https://github.com/labath edited
https://github.com/llvm/llvm-project/pull/127834
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -30,216 +30,170 @@ namespace lldb_dap::protocol {
// MARK: Base Protocol
-// "Request": {
-// "allOf": [ { "$ref": "#/definitions/ProtocolMessage" }, {
-// "type": "object",
-// "description": "A client or debug adapter initiated request.",
-// "properties":
vogelsgesang wrote:
What is your overall plan for this PR?
I assume the first step is to get buy-in from all reviewers into the new
structure for our JSON types. But what comes after? Are you planning to update
this PR to cover all JSON types / requests / responses? Are you planning to
land t
@@ -30,216 +30,170 @@ namespace lldb_dap::protocol {
// MARK: Base Protocol
-// "Request": {
-// "allOf": [ { "$ref": "#/definitions/ProtocolMessage" }, {
-// "type": "object",
-// "description": "A client or debug adapter initiated request.",
-// "properties":
@@ -57,235 +68,288 @@ class RequestHandler {
DAP &dap;
};
-class AttachRequestHandler : public RequestHandler {
-public:
- using RequestHandler::RequestHandler;
+/// Base class for handling DAP requests. Handlers should declare their
+/// arguments and response body types l
@@ -240,6 +240,137 @@ using Message = std::variant;
bool fromJSON(const llvm::json::Value &, Message &, llvm::json::Path);
llvm::json::Value toJSON(const Message &);
+// MARK: Types
+
+// "Source": {
+// "type": "object",
+// "description": "A `Source` is a descriptor for
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/130987
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1559,10 +1560,29 @@ void Target::DidExec() {
void Target::SetExecutableModule(ModuleSP &executable_sp,
LoadDependentFiles load_dependent_files) {
+ telemetry::ScopedDispatcher helper(&m_debugger);
Log *log = GetLog(LLDBLog::Target);
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/130987
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/118160
>From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 30 Nov 2024 01:14:15 -0600
Subject: [PATCH 01/12] Added base files for NativeProcess for AIX
--
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/129614
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DavidSpickett approved this pull request.
LGTM with the folder name changed as suggested.
It'll be easier to find everything this way as well.
https://github.com/llvm/llvm-project/pull/129614
___
lldb-commits mailing list
lldb-commi
@@ -552,28 +552,35 @@ void Disassembler::PrintInstructions(Debugger &debugger,
const ArchSpec &arch,
bool Disassembler::Disassemble(Debugger &debugger, const ArchSpec &arch,
StackFrame &frame, Stream &strm) {
- AddressRange range;
SymbolCont
https://github.com/DavidSpickett approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/130987
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,64 @@
+"""
+Make sure 'frame var' using DIL parser/evaultor works for local variables.
+"""
+
+import lldb
+from lldbsuite.test.lldbtest import *
+from lldbsuite.test.decorators import *
+from lldbsuite.test import lldbutil
+
+import os
+import shutil
+import time
+
+
+
@@ -1064,6 +1065,29 @@ const char *Process::GetExitDescription() {
bool Process::SetExitStatus(int status, llvm::StringRef exit_string) {
// Use a mutex to protect setting the exit status.
std::lock_guard guard(m_exit_status_mutex);
+ telemetry::ScopedDispatcher helper;
+
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/131073
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,256 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
kastiglione wrote:
@jimingham this is the PR I mentioned in person on Tuesday.
https://github.com/llvm/llvm-project/pull/117500
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -172,6 +172,14 @@ let Definition = "debugger" in {
Global,
DefaultStringValue<"${ansi.normal}">,
Desc<"When displaying progress in a color-enabled terminal, use the ANSI
terminal code specified in this format immediately after the progress
message.">;
+ def Sh
@@ -0,0 +1,256 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/118160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1064,6 +1065,29 @@ const char *Process::GetExitDescription() {
bool Process::SetExitStatus(int status, llvm::StringRef exit_string) {
// Use a mutex to protect setting the exit status.
std::lock_guard guard(m_exit_status_mutex);
+ telemetry::ScopedDispatcher helper;
+
https://github.com/labath commented:
This is better, though I'm not particularly fond of the addition of the new
Target field. I'd like to see if we could remove that.
https://github.com/llvm/llvm-project/pull/127834
___
lldb-commits mailing list
lldb
@@ -0,0 +1,256 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
1 - 100 of 110 matches
Mail list logo
