https://github.com/oontvoo created
https://github.com/llvm/llvm-project/pull/131203
None
>From cff4bbc4ff68e77e3093a880f55d2e17116e6f37 Mon Sep 17 00:00:00 2001
From: Vy Nguyen <v...@google.com>
Date: Thu, 13 Mar 2025 15:57:48 -0400
Subject: [PATCH] [LLDB][NFC]Refactor common test setup into SetUp method
---
lldb/unittests/Core/TelemetryTest.cpp | 35 ++++++++++++---------------
1 file changed, 16 insertions(+), 19 deletions(-)
diff --git a/lldb/unittests/Core/TelemetryTest.cpp
b/lldb/unittests/Core/TelemetryTest.cpp
index 72db8c17f09ea..f7dab948faba1 100644
--- a/lldb/unittests/Core/TelemetryTest.cpp
+++ b/lldb/unittests/Core/TelemetryTest.cpp
@@ -81,6 +81,20 @@ using namespace lldb_private::telemetry;
class TelemetryTest : public testing::Test {
public:
lldb_private::SubsystemRAII<lldb_private::FakePlugin> subsystems;
+ std::vector<std::unique_ptr<::llvm::telemetry::TelemetryInfo>>
+ received_entries;
+
+ void SetUp() override {
+ // This would have been called by the plugin reg in a "real" pluging
+ // For tests, we just call it directly.
+ lldb_private::FakePlugin::Initialize();
+
+ auto *ins = lldb_private::telemetry::TelemetryManager::GetInstance();
+ ASSERT_NE(ins, nullptr);
+
+ ins->addDestination(
+ std::make_unique<lldb_private::TestDestination>(&received_entries));
+ }
};
#if LLVM_ENABLE_TELEMETRY
@@ -90,17 +104,8 @@ class TelemetryTest : public testing::Test {
#endif
TELEMETRY_TEST(TelemetryTest, PluginTest) {
- // This would have been called by the plugin reg in a "real" plugin
- // For tests, we just call it directly.
- lldb_private::FakePlugin::Initialize();
-
- auto *ins = lldb_private::telemetry::TelemetryManager::GetInstance();
- ASSERT_NE(ins, nullptr);
-
- std::vector<std::unique_ptr<::llvm::telemetry::TelemetryInfo>>
- received_entries;
- ins->addDestination(
- std::make_unique<lldb_private::TestDestination>(&received_entries));
+ lldb_private::telemetry::TelemetryManager *ins =
+ lldb_private::telemetry::TelemetryManager::GetInstance();
lldb_private::FakeTelemetryInfo entry;
entry.msg = "";
@@ -115,14 +120,6 @@ TELEMETRY_TEST(TelemetryTest, PluginTest) {
}
TELEMETRY_TEST(TelemetryTest, ScopedDispatcherTest) {
- lldb_private::FakePlugin::Initialize();
- auto *ins = TelemetryManager::GetInstance();
- ASSERT_NE(ins, nullptr);
- std::vector<std::unique_ptr<::llvm::telemetry::TelemetryInfo>>
- received_entries;
- ins->addDestination(
- std::make_unique<lldb_private::TestDestination>(&received_entries));
-
{
ScopedDispatcher<lldb_private::FakeTelemetryInfo> helper(
[](lldb_private::FakeTelemetryInfo *info) { info->num = 0; });
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
