[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-11 Thread via lldb-commits
@@ -0,0 +1,273 @@ +//===-- DILEval.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-11 Thread via lldb-commits
@@ -0,0 +1,273 @@ +//===-- DILEval.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-11 Thread via lldb-commits
@@ -0,0 +1,273 @@ +//===-- DILEval.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-11 Thread via lldb-commits
@@ -0,0 +1,273 @@ +//===-- DILEval.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-11 Thread via lldb-commits
@@ -0,0 +1,102 @@ +//===-- DILEval.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-11 Thread via lldb-commits
@@ -0,0 +1,102 @@ +//===-- DILEval.h ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-11 Thread via lldb-commits
@@ -43,6 +44,18 @@ class Token { bool IsOneOf(Kind kind1, Kind kind2) const { return Is(kind1) || Is(kind2); } + bool IsOneOf(std::vector kinds) const { +if (kinds.empty()) + return false; + +if (kinds.size() == 1) + return Is(kinds[0]); + +Kind k = k

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-11 Thread via lldb-commits
@@ -0,0 +1,103 @@ +//===-- DILParser.h -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-11 Thread via lldb-commits
@@ -511,7 +514,9 @@ ValueObjectSP StackFrame::GetValueForVariableExpressionPath( VariableSP &var_sp, Status &error) { ExecutionContext exe_ctx; CalculateExecutionContext(exe_ctx); + bool use_DIL = exe_ctx.GetTargetRef().GetUseDIL(&exe_ctx); + cmtice

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-11 Thread via lldb-commits
@@ -0,0 +1,23 @@ +//===-- DILAST.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-11 Thread via lldb-commits
@@ -523,10 +528,43 @@ ValueObjectSP StackFrame::GetValueForVariableExpressionPath( ValueObjectSP StackFrame::DILGetValueForVariableExpressionPath( llvm::StringRef var_expr, lldb::DynamicValueType use_dynamic, uint32_t options, lldb::VariableSP &var_sp, Status &error) {

[Lldb-commits] [lldb] [lldb-dap] Validate server mode support prior to invoking lldb-dap. (PR #130855)

2025-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/130855 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add DIL code for handling plain variable names. (PR #120971)

2025-03-11 Thread via lldb-commits
@@ -0,0 +1,273 @@ +//===-- DILEval.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb] Implement ANSI & Unicode aware string stripping & padding (PR #130878)

2025-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/130878 >From e50c6aec3cdb5d30fa12b19709329b49036ae924 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Tue, 11 Mar 2025 18:59:50 -0700 Subject: [PATCH] [lldb] Implement ANSI & Unicode aware string stripping

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread Jonas Devlieghere via lldb-commits
@@ -0,0 +1,200 @@ +//===-- Statusline.cpp ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apac

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-03-11 Thread Julius Alexandre via lldb-commits
https://github.com/wizardengineer updated https://github.com/llvm/llvm-project/pull/130516 >From 161bdb32b284d2370b138e72a8a1ad560b258ba9 Mon Sep 17 00:00:00 2001 From: medievalghoul <61852278+medievalgh...@users.noreply.github.com> Date: Sun, 9 Mar 2025 16:20:47 -0400 Subject: [PATCH 1/7] Chang

[Lldb-commits] [lldb] [lldb] Implement ANSI & Unicode aware string stripping & padding (PR #130878)

2025-03-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes This PR implements a unicode and ANSI escape code aware function to trim and pad strings. This is a break-out from #121860. --- Full diff: https://github.com/llvm/llvm-project/pull/130878.diff 2 F

[Lldb-commits] [lldb] [lldb] Implement ANSI & Unicode aware string stripping & padding (PR #130878)

2025-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/130878 This PR implements a unicode and ANSI escape code aware function to trim and pad strings. This is a break-out from #121860. >From f6287805c5aab3d5b7b998afe9db4fc1acb3760a Mon Sep 17 00:00:00 2001 From: Jon

[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

2025-03-11 Thread via lldb-commits
@@ -969,6 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const { return error; } +Status MinidumpFileBuilder::ReadWriteMemoryInChunks( +const std::unique_ptr &data_up, +const lldb_private::CoreFileMemoryRange &range, uint64_t *bytes_read) { + if (!data_up)

[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

2025-03-11 Thread via lldb-commits
@@ -969,6 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const { return error; } +Status MinidumpFileBuilder::ReadWriteMemoryInChunks( +const std::unique_ptr &data_up, +const lldb_private::CoreFileMemoryRange &range, uint64_t *bytes_read) { + if (!data_up)

[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

2025-03-11 Thread via lldb-commits
@@ -969,6 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const { return error; } +Status MinidumpFileBuilder::ReadWriteMemoryInChunks( +const std::unique_ptr &data_up, +const lldb_private::CoreFileMemoryRange &range, uint64_t *bytes_read) { + if (!data_up)

[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

2025-03-11 Thread via lldb-commits
@@ -969,6 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const { return error; } +Status MinidumpFileBuilder::ReadWriteMemoryInChunks( +const std::unique_ptr &data_up, +const lldb_private::CoreFileMemoryRange &range, uint64_t *bytes_read) { + if (!data_up)

[Lldb-commits] [lldb] [LLDB][Minidump]Update MinidumpFileBuilder to read and write in chunks (PR #129307)

2025-03-11 Thread via lldb-commits
https://github.com/jeffreytan81 requested changes to this pull request. https://github.com/llvm/llvm-project/pull/129307 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap]Return optional from json utils (PR #129919)

2025-03-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/129919 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Mangled] Use early-return style in GetDemangledName (PR #130622)

2025-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/130622 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][Mangled] Use early-return style in GetDemangledName (PR #130622)

2025-03-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch refactors `Mangled::GetDemangledName` to use LLVM's preferred early-return style. I'm planning on introducing a way to force re-demangling of names in a future patch, and this stylisitc cleanup

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-11 Thread via lldb-commits
@@ -125,21 +125,21 @@ struct Variables { struct StartDebuggingRequestHandler : public lldb::SBCommandPluginInterface { DAP &dap; - explicit StartDebuggingRequestHandler(DAP &d) : dap(d) {}; + explicit StartDebuggingRequestHandler(DAP &d) : dap(d){}; bool DoExecute(lldb:

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-11 Thread via lldb-commits
https://github.com/satyajanga converted_to_draft https://github.com/llvm/llvm-project/pull/130841 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-11 Thread via lldb-commits
@@ -383,6 +383,12 @@ struct DAP { InstructionBreakpoint *GetInstructionBPFromStopReason(lldb::SBThread &thread); + FunctionBreakpoint *GetFunctionBPFromStopReason(lldb::SBThread &thread); + + FunctionBreakpoint *GetFunctionBreakPoint(const lldb::break_id_t bp_id); + + v

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-11 Thread via lldb-commits
@@ -967,17 +967,23 @@ llvm::json::Value CreateThreadStopped(DAP &dap, lldb::SBThread &thread, body.try_emplace("reason", "exception"); EmplaceSafeString(body, "description", exc_bp->label); } else { + std::string reason = "breakpoint"; jef

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-11 Thread via lldb-commits
@@ -1128,6 +1128,32 @@ DAP::GetInstructionBPFromStopReason(lldb::SBThread &thread) { return inst_bp; } +FunctionBreakpoint *DAP::GetFunctionBPFromStopReason(lldb::SBThread &thread) { + const auto num = thread.GetStopReasonDataCount(); + FunctionBreakpoint *func_bp = nullp

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-11 Thread via lldb-commits
https://github.com/jeffreytan81 requested changes to this pull request. > tools/lldb-dap/attach/TestDAP_attach.py : creates function breakpoints tests > that they are hit. tools/lldb-dap/breakpoint/TestDAP_setFunctionBreakpoints.py also creates breakpoints tests that they are hit. Are these tw

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-11 Thread via lldb-commits
https://github.com/jeffreytan81 edited https://github.com/llvm/llvm-project/pull/130841 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/130435 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-11 Thread Matthew Bastien via lldb-commits
@@ -517,6 +520,16 @@ "cwd": "^\"\\${workspaceRoot}\"" } }, + { +"label": "LLDB: Attach to Process", +"description": "", +"body": { + "type": "lldb-dap", + "request": "atta

[Lldb-commits] [lldb] [lldb][AIX] Host.cpp for AIX (PR #130582)

2025-03-11 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,27 @@ +//===-- source/Host/aix/Host.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache

[Lldb-commits] [lldb] [lldb] Make ELF files able to load section headers from memory. (PR #129166)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -1477,32 +1506,32 @@ size_t ObjectFileELF::GetSectionHeaderInfo(SectionHeaderColl §ion_headers, } if (idx < section_headers.size()) section_headers.resize(idx); + // Sometimes we are able to read the section header memory from an in memory labath w

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-11 Thread via lldb-commits
https://github.com/satyajanga edited https://github.com/llvm/llvm-project/pull/130841 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Make breakpoint stop reason more accurate for function breakpoints (PR #130841)

2025-03-11 Thread via lldb-commits
https://github.com/satyajanga edited https://github.com/llvm/llvm-project/pull/130841 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Migrating terminated statistics to the event body. (PR #130454)

2025-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere approved this pull request. https://github.com/llvm/llvm-project/pull/130454 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] setVariable request should send the correct response (PR #130773)

2025-03-11 Thread Ebuka Ezike via lldb-commits
da-viper wrote: No, how do I get it ? https://github.com/llvm/llvm-project/pull/130773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] setVariable request should send the correct response (PR #130773)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: @da-viper do you have commit access by now? https://github.com/llvm/llvm-project/pull/130773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][lldb-dap] setVariable request should send the correct response (PR #130773)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang approved this pull request. https://github.com/llvm/llvm-project/pull/130773 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
vogelsgesang wrote: > should we also have feature flags for things like this in lldb-dap? IMO, `lldb-dap` itself should exit with an error code in case of unsupported command line options. We might want to use a dedicated exit code for that, in order to differentiate it from other errors, wher

[Lldb-commits] [lldb] [lldb][AIX] Host.cpp for AIX (PR #130582)

2025-03-11 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX created https://github.com/llvm/llvm-project/pull/130582 This PR is in reference to porting LLDB on AIX. Link to discussions on llvm discourse and github: 1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640 2. https://github.com/llvm/llvm-project/issu

[Lldb-commits] [lldb] [lldb][Expression] Allow specifying a preferred ModuleList for lookup during expression evaluation (PR #129733)

2025-03-11 Thread Michael Buch via lldb-commits
Michael137 wrote: > > > You should complete the module -> symbol_context mutatis mutandis. Other > > > than that this seems like the right foundation for adding a user way to > > > control the symbol lookups. > > > > > > I kept the list of preferred contexts as a `ModuleList` in > > `IRExecu

[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
@@ -57,235 +68,288 @@ class RequestHandler { DAP &dap; }; -class AttachRequestHandler : public RequestHandler { -public: - using RequestHandler::RequestHandler; +/// Base class for handling DAP requests. Handlers should declare their +/// arguments and response body types l

[Lldb-commits] [lldb] [lldb][AIX] Host.cpp for AIX (PR #130582)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,66 @@ +//===-- source/Host/aix/Host.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache

[Lldb-commits] [lldb] [lldb] Objective-C runtime: Work around a bug in the shared cache builder (PR #130209)

2025-03-11 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl closed https://github.com/llvm/llvm-project/pull/130209 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread John Harrison via lldb-commits
ashgti wrote: Apparently rebasing my changes on a main caused GH to not let me reply to some comments directly (still learning GH's PR nuances...). >From labath > That probably fine, but I am pretty sure that being abstract doesn't prevent > you from [forming a reference](https://godbolt.org/z

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/130026 >From c340c38a82880114471938b19512670d7f94245e Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 6 Mar 2025 10:18:36 +0100 Subject: [PATCH 1/6] [lldb-dap] Refactoring IOStream into Transport handler. Inste

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,290 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][DWARFASTParserClang] Adjust language type for conflicting Objective-C++ forward declarations (PR #130768)

2025-03-11 Thread Zequan Wu via lldb-commits
ZequanWu wrote: Since this makes lldb to do type searching more aggressively, I want to get a sense of performance impact on simplified template names from this PR. When I running the a test program with LLDB (with this PR), LLDB crashes. I don't have a reduced test case yet, will probably wor

[Lldb-commits] [lldb] [lldb][AIX] Host.cpp for AIX (PR #130582)

2025-03-11 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,109 @@ +//===-- source/Host/aix/Host.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][Mangled] Use early-return style in GetDemangledName (PR #130622)

2025-03-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/130622 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-11 Thread Matthew Bastien via lldb-commits
matthewbastien wrote: One more thing that crossed my mind: given that the LLDB DAP extension will automatically be updated to the latest version by VS Code, should we also have feature flags for things like this in lldb-dap? (or is there some way already to detect which features are available?

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-11 Thread Matthew Bastien via lldb-commits
https://github.com/matthewbastien edited https://github.com/llvm/llvm-project/pull/129262 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [clang] [lldb] [C++20][Modules] Do not update the declaration generation number if the redeclaration chain completion was delayed. (PR #129982)

2025-03-11 Thread Michael Park via lldb-commits
https://github.com/mpark edited https://github.com/llvm/llvm-project/pull/129982 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #115331)

2025-03-11 Thread via lldb-commits
@@ -0,0 +1,116 @@ +//===- Caching.cpp ===// anjenner wrote: Yes - I have added a test in my latest commit. https://github.com/llvm/llvm-project/pull/115331 ___ l

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,290 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,119 @@ +//===-- NativeProcessAIX.h -- -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb-dap] Add process picker command to VS Code extension (PR #128943)

2025-03-11 Thread Matthew Bastien via lldb-commits
matthewbastien wrote: > I am not sure I understand that concern. Looking at the [commit log of > swiftlang/llvm-project](https://github.com/swiftlang/llvm-project/commits/next/lldb/tools/lldb-dap), > it seems that they are picking up changes to lldb-dap very quickly. Or am I > missing somethin

[Lldb-commits] [lldb] [lldb][AIX] Host.cpp for AIX (PR #130582)

2025-03-11 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/130582 >From 21fe9850c99b3eae4be65ac34c1f4f9c2d06ab2c Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Mon, 10 Mar 2025 05:39:52 -0500 Subject: [PATCH 1/3] Host.cpp base for AIX --- lldb/source/Host/CMa

[Lldb-commits] [lldb] [lldb][AIX] Added base files for NativeProcess Support for AIX (PR #118160)

2025-03-11 Thread Dhruv Srivastava via lldb-commits
@@ -0,0 +1,265 @@ +//===-- NativeProcessAIX.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-11 Thread Jonas Devlieghere via lldb-commits
@@ -1,5 +1,6 @@ add_lldb_unittest(APITests SBCommandInterpreterTest.cpp +SBLineEntryTest.cpp JDevlieghere wrote: ```suggestion SBLineEntryTest.cpp ``` https://github.com/llvm/llvm-project/pull/130435 ___

[Lldb-commits] [lldb] [lldb] Split TestGdbRemoteFork test to avoid timeout (PR #129614)

2025-03-11 Thread Pavel Labath via lldb-commits
labath wrote: The test really is big and splitting it up is a good idea, but instead of an arbitrary 1/2/3 split, I think it be better to do it by functionality. Looking at the part of the code you moved, I can see several "themes" that we could use to split this up. One of them is "memory ope

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread John Harrison via lldb-commits
@@ -0,0 +1,144 @@ +//===-- Transport.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread John Harrison via lldb-commits
@@ -838,19 +770,12 @@ llvm::Error DAP::Loop() { StopEventHandlers(); }); while (!disconnecting) { -llvm::json::Object object; -lldb_dap::PacketStatus status = GetNextObject(object); - -if (status == lldb_dap::PacketStatus::EndOfFile) { +std::optional nex

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread John Harrison via lldb-commits
@@ -315,23 +316,19 @@ serveConnection(const Socket::SocketProtocol &protocol, const std::string &name, &dap_sessions_mutex, &dap_sessions, &clientCount](

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/130026 >From c340c38a82880114471938b19512670d7f94245e Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 6 Mar 2025 10:18:36 +0100 Subject: [PATCH 1/5] [lldb-dap] Refactoring IOStream into Transport handler. Inste

[Lldb-commits] [lldb] [lldb-dap] Updating RequestHandler to encode/decode arguments and response. (PR #130090)

2025-03-11 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/130090 This is a work in progress refactor to add explicit types instead of generic 'llvm::json::Value' types to the DAP protocol. This updates RequestHandler to have take the type of the arguments and response body for

[Lldb-commits] [lldb] [lldb][XcodeSDK] Simplify logic that adjusts sysroot during XcodeSDK merging (PR #130640)

2025-03-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes The `DW_AT_APPLE_sdk` should always be equal to the filename of the `DW_AT_LLVM_sysroot`. We can use this property to simplify `XcodeSDK::Merge` to no longer manually adjust the sysroot filename. Instead w

[Lldb-commits] [lldb] [lldb][XcodeSDK] Simplify logic that adjusts sysroot during XcodeSDK merging (PR #130640)

2025-03-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/130640 The `DW_AT_APPLE_sdk` should always be equal to the filename of the `DW_AT_LLVM_sysroot`. We can use this property to simplify `XcodeSDK::Merge` to no longer manually adjust the sysroot filename. Instead we

[Lldb-commits] [lldb] [lldb][AIX] Host.cpp for AIX (PR #130582)

2025-03-11 Thread Dhruv Srivastava via lldb-commits
https://github.com/DhruvSrivastavaX updated https://github.com/llvm/llvm-project/pull/130582 >From 21fe9850c99b3eae4be65ac34c1f4f9c2d06ab2c Mon Sep 17 00:00:00 2001 From: Dhruv-Srivastava Date: Mon, 10 Mar 2025 05:39:52 -0500 Subject: [PATCH 1/4] Host.cpp base for AIX --- lldb/source/Host/CMa

[Lldb-commits] [lldb] [lldb][Mangled] Use early-return style in GetDemangledName (PR #130622)

2025-03-11 Thread Michael Buch via lldb-commits
Michael137 wrote: > This looks good, although the "re-demangling" part sounds scary :) :D I'm trying to provide a way for the demangler to tell LLDB about individual bits of a demangled name (like where the basename starts/ends for example), which we can use in the frame name formatting. Turn

[Lldb-commits] [lldb] [lldb][tests] Add ability to run API tests with qemu-user simulator (PR #89765)

2025-03-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/89765 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix compile error. (PR #130091)

2025-03-11 Thread Adrian Kuegel via lldb-commits
https://github.com/akuegel created https://github.com/llvm/llvm-project/pull/130091 Followup to https://github.com/llvm/llvm-project/commit/878a64f94a264ea4b564d6063614ddb0b5da3f6c >From a07b4420127fab0008bb0111dc5f49baac6e050e Mon Sep 17 00:00:00 2001 From: Adrian Kuegel Date: Thu, 6 Mar 202

[Lldb-commits] [lldb] [lldb-dap] Adding support for cancelling a request. (PR #130169)

2025-03-11 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/130169 Adding support for cancelling requests. There are two forms of request cancellation. * Preemptively cancelling a request that is in the queue. * Actively cancelling the in progress request as a best effort attem

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread John Harrison via lldb-commits
@@ -0,0 +1,58 @@ +//===-- DAPLog.h --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[Lldb-commits] [lldb] [lldb] fix set SBLineEntryColumn (PR #130435)

2025-03-11 Thread Ebuka Ezike via lldb-commits
https://github.com/da-viper updated https://github.com/llvm/llvm-project/pull/130435 >From 02c34e87db59a0b87887aba479afbab70925241b Mon Sep 17 00:00:00 2001 From: Ezike Ebuka Date: Sat, 8 Mar 2025 19:47:17 + Subject: [PATCH 1/3] [lldb] fix set SBLineEntryColumn --- lldb/source/API/SBLineE

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-11 Thread Matthew Bastien via lldb-commits
@@ -66,19 +70,17 @@ async function findDAPExecutable(): Promise { } async function getDAPExecutable( - session: vscode.DebugSession, + folder: vscode.WorkspaceFolder | undefined, matthewbastien wrote: Done. https://github.com/llvm/llvm-project/pull/129262

[Lldb-commits] [lldb] [lldb-dap] Allow providing debug adapter arguments in the extension (PR #129262)

2025-03-11 Thread Matthew Bastien via lldb-commits
https://github.com/matthewbastien updated https://github.com/llvm/llvm-project/pull/129262 >From b40c3e7e4ebb154c5f231676451acbd17e1f39f7 Mon Sep 17 00:00:00 2001 From: Matthew Bastien Date: Fri, 28 Feb 2025 11:08:25 -0500 Subject: [PATCH 1/7] allow providing debug adapter arguments --- lldb/

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread John Harrison via lldb-commits
https://github.com/ashgti updated https://github.com/llvm/llvm-project/pull/130026 >From c340c38a82880114471938b19512670d7f94245e Mon Sep 17 00:00:00 2001 From: John Harrison Date: Thu, 6 Mar 2025 10:18:36 +0100 Subject: [PATCH 1/4] [lldb-dap] Refactoring IOStream into Transport handler. Inste

[Lldb-commits] [lldb] [lldb] Implement a statusline in LLDB (PR #121860)

2025-03-11 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/121860 >From 13524447f9af1c8d1923e9ef8cc3693a1c53253a Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 17 Jan 2025 17:10:36 -0800 Subject: [PATCH 1/2] [lldb] Implement a statusline in LLDB MIME-Version:

[Lldb-commits] [clang] [flang] [lldb] [llvm] [mlir] [polly] [IR] Store Triple in Module (NFC) (PR #129868)

2025-03-11 Thread LLVM Continuous Integration via lldb-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-nvptx64-nvidia-ubuntu` running on `as-builder-7` while building `clang,flang,lldb,llvm,mlir,offload,polly` at step 5 "build-unified-tree". Full details are available at: https://lab.llvm.org/buildbot/#/builders/160/build

[Lldb-commits] [lldb] [lldb-dap] Migrating terminated statistics to the event body. (PR #130454)

2025-03-11 Thread John Harrison via lldb-commits
https://github.com/ashgti closed https://github.com/llvm/llvm-project/pull/130454 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add more ARM checks in TestLldbGdbServer.py (PR #130277)

2025-03-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/130277 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
https://github.com/vogelsgesang edited https://github.com/llvm/llvm-project/pull/130026 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][AIX] Host.cpp for AIX (PR #130582)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,66 @@ +//===-- source/Host/aix/Host.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache

[Lldb-commits] [lldb] [lldb] Objective-C runtime: Work around a bug in the shared cache builder (PR #130209)

2025-03-11 Thread Adrian Prantl via lldb-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/130209 >From 1dc911414f8bf6441fec6384de046f45e7049870 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Thu, 6 Mar 2025 16:33:35 -0800 Subject: [PATCH] [lldb] Objective-C runtime: Work around a bug in the shared

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread John Harrison via lldb-commits
https://github.com/ashgti created https://github.com/llvm/llvm-project/pull/130026 Instead of having two discrete InputStream and OutputStream helpers, this merges the two into a unifed 'Transport' handler. This handler is responsible for reading the DAP message headers, parsing the resulting

[Lldb-commits] [lldb] [lldb][XcodeSDK] Simplify logic that adjusts sysroot during XcodeSDK merging (PR #130640)

2025-03-11 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/130640 >From 4761db28d9c58f633de502cb5fb772e64902a98e Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Mon, 10 Mar 2025 17:00:11 + Subject: [PATCH] [lldb][XcodeSDK] Simplify logic that adjusts sysroot during X

[Lldb-commits] [lldb] draft: [lldb] Upgrade ValueObject::GetData to return llvm::Expected (PR #130516)

2025-03-11 Thread Adrian Prantl via lldb-commits
@@ -247,13 +247,15 @@ static lldb::addr_t GetVTableAddress(Process &process, // We have an object already read from process memory, // so just extract VTable pointer from it - DataExtractor data; - Status err; - auto size = valobj.GetData(data, err); - if (err.Fail() |

[Lldb-commits] [lldb] 6a9df5b - Revert "[lldb][asan] Add temporary logging to ReportRetriever"

2025-03-11 Thread Michael Buch via lldb-commits
Author: Michael Buch Date: 2025-03-10T11:37:13Z New Revision: 6a9df5b4dd2ac1b00cdc3880c210cc0d2e917f04 URL: https://github.com/llvm/llvm-project/commit/6a9df5b4dd2ac1b00cdc3880c210cc0d2e917f04 DIFF: https://github.com/llvm/llvm-project/commit/6a9df5b4dd2ac1b00cdc3880c210cc0d2e917f04.diff LOG:

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread Adrian Vogelsgesang via lldb-commits
@@ -722,40 +683,9 @@ void DAP::SetTarget(const lldb::SBTarget target) { } } -PacketStatus DAP::GetNextObject(llvm::json::Object &object) { - std::string json = ReadJSON(); - if (json.empty()) -return PacketStatus::EndOfFile; - - llvm::StringRef json_sref(json); - llv

[Lldb-commits] [lldb] [lldb-dap] Refactoring IOStream into Transport handler. (PR #130026)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,146 @@ +//===-- Transport.cpp -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[Lldb-commits] [lldb] 414e5c5 - [lldb-dap] Migrating terminated statistics to the event body. (#130454)

2025-03-11 Thread via lldb-commits
Author: John Harrison Date: 2025-03-10T10:00:10-07:00 New Revision: 414e5c58cb5ca48e86e30150790bdcdaa2cc306e URL: https://github.com/llvm/llvm-project/commit/414e5c58cb5ca48e86e30150790bdcdaa2cc306e DIFF: https://github.com/llvm/llvm-project/commit/414e5c58cb5ca48e86e30150790bdcdaa2cc306e.diff

[Lldb-commits] [lldb] [lldb] Remove an extraneous `printf` statement. (PR #130453)

2025-03-11 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/130453 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Adding logging helpers. (PR #130653)

2025-03-11 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: John Harrison (ashgti) Changes Improving logging by defining new helpers for more uniform log handling. This should help us clearly identify log messages and helps abstract the underlying log type within the macro in case we want to update

[Lldb-commits] [lldb] [lldb][AIX] Host.cpp for AIX (PR #130582)

2025-03-11 Thread Pavel Labath via lldb-commits
@@ -0,0 +1,27 @@ +//===-- source/Host/aix/Host.cpp ===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache

  1   2   3   >