================
@@ -1477,32 +1506,32 @@ size_t
ObjectFileELF::GetSectionHeaderInfo(SectionHeaderColl §ion_headers,
}
if (idx < section_headers.size())
section_headers.resize(idx);
+ // Sometimes we are able to read the section header memory from an in memory
----------------
labath wrote:
I'm worried about this check as it's untested and its basically impossible to
prove it's safe to remove, ever. Can explain how this comes to be and why
leaving those SHT_NULL sections in the list is a problem? (I'm thinking whether
e.g., we could leave those in, but change the code which consumes them to
ignore them)
https://github.com/llvm/llvm-project/pull/129166
_______________________________________________
lldb-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
