[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-19 Thread via lldb-commits
https://github.com/kper updated https://github.com/llvm/llvm-project/pull/124475 >From d44dd60bc7ae5deeed91fd9389b164e441164edc Mon Sep 17 00:00:00 2001 From: Kevin Per Date: Sun, 26 Jan 2025 17:34:17 + Subject: [PATCH] [lldb] Extended if conditions to support alias names for registers ---

[Lldb-commits] [lldb] [lldb] Store StreamAsynchronousIO in a unique_ptr (NFC) (PR #127961)

2025-02-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Jonas Devlieghere (JDevlieghere) Changes Make StreamAsynchronousIO an unique_ptr instead of a shared_ptr. I tried passing the class by value, but the llvm::raw_ostream forwarder stored in the Stream parent class isn't movable and I don't t

[Lldb-commits] [lldb] [lldb] Store StreamAsynchronousIO in a unique_ptr (NFC) (PR #127961)

2025-02-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere created https://github.com/llvm/llvm-project/pull/127961 Make StreamAsynchronousIO an unique_ptr instead of a shared_ptr. I tried passing the class by value, but the llvm::raw_ostream forwarded stored in the Stream parent class isn't movable and I don't think it

[Lldb-commits] [lldb] [lldb] Store StreamAsynchronousIO in a unique_ptr (NFC) (PR #127961)

2025-02-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/127961 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 57bac14 - [lldb] Fix header include order in ScriptInterpreterPython.cpp

2025-02-19 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2025-02-19T21:09:32-08:00 New Revision: 57bac14f4bcc8b43edc3e27be3d93609f7f4037b URL: https://github.com/llvm/llvm-project/commit/57bac14f4bcc8b43edc3e27be3d93609f7f4037b DIFF: https://github.com/llvm/llvm-project/commit/57bac14f4bcc8b43edc3e27be3d93609f7f4037b.d

[Lldb-commits] [lldb] 58279d1 - [lldb] Synchronize the debuggers output & error streams

2025-02-19 Thread via lldb-commits
Author: Jonas Devlieghere Date: 2025-02-19T20:32:00-08:00 New Revision: 58279d1ee1b567e8ca793d6d1eb6e0f1d5e7279e URL: https://github.com/llvm/llvm-project/commit/58279d1ee1b567e8ca793d6d1eb6e0f1d5e7279e DIFF: https://github.com/llvm/llvm-project/commit/58279d1ee1b567e8ca793d6d1eb6e0f1d5e7279e.d

[Lldb-commits] [lldb] [lldb] Synchronize the debugger's stdout and stderr streams (PR #126630)

2025-02-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere closed https://github.com/llvm/llvm-project/pull/126630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-19 Thread Greg Clayton via lldb-commits
https://github.com/clayborg requested changes to this pull request. https://github.com/llvm/llvm-project/pull/124648 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-19 Thread Greg Clayton via lldb-commits
@@ -68,10 +78,23 @@ def __call__(self, debugger, command, exe_ctx, result): return total = cmd_options.total -progress = lldb.SBProgress("Progress tester", "Detail", total, debugger) +if total == -1: +progress = lldb.SBProgress(

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-19 Thread Greg Clayton via lldb-commits
@@ -428,14 +453,35 @@ void ProgressEventThreadFunction(DAP &dap) { done = true; } } else { -uint64_t progress_id = 0; -uint64_t completed = 0; -uint64_t total = 0; -bool is_debugger_specific = false; -const char *m

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-19 Thread Greg Clayton via lldb-commits
@@ -428,14 +453,35 @@ void ProgressEventThreadFunction(DAP &dap) { done = true; } } else { -uint64_t progress_id = 0; -uint64_t completed = 0; -uint64_t total = 0; -bool is_debugger_specific = false; -const char *m

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-19 Thread Greg Clayton via lldb-commits
@@ -428,14 +453,35 @@ void ProgressEventThreadFunction(DAP &dap) { done = true; } } else { -uint64_t progress_id = 0; -uint64_t completed = 0; -uint64_t total = 0; -bool is_debugger_specific = false; -const char *m

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-19 Thread Greg Clayton via lldb-commits
@@ -37,7 +37,10 @@ def create_options(cls): ) parser.add_option( -"--total", dest="total", help="Total to count up.", type="int" +"--total", +dest="total", +help="Total to count up, use -1 to identify as indetermi

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-19 Thread Greg Clayton via lldb-commits
@@ -37,7 +37,10 @@ def create_options(cls): ) parser.add_option( -"--total", dest="total", help="Total to count up.", type="int" +"--total", +dest="total", +help="Total to count up, use -1 to identify as indetermi

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-19 Thread Greg Clayton via lldb-commits
@@ -68,10 +78,23 @@ def __call__(self, debugger, command, exe_ctx, result): return total = cmd_options.total -progress = lldb.SBProgress("Progress tester", "Detail", total, debugger) +if total == -1: clayborg wrote: Defaul

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-19 Thread Greg Clayton via lldb-commits
@@ -428,14 +453,35 @@ void ProgressEventThreadFunction(DAP &dap) { done = true; } } else { -uint64_t progress_id = 0; -uint64_t completed = 0; -uint64_t total = 0; -bool is_debugger_specific = false; -const char *m

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-19 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/124648 >From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Mon, 27 Jan 2025 13:41:58 -0800 Subject: [PATCH 1/6] Only include title on the first message --- lldb/include/l

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-19 Thread Jonas Devlieghere via lldb-commits
@@ -761,12 +767,29 @@ void Debugger::InstanceInitialize() { DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback, void *baton) { +#ifdef LLVM_BUILD_TELEMETRY + lldb_private::telemetry::SteadyTimePoint start_time = +

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/127696 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-19 Thread Jonas Devlieghere via lldb-commits
@@ -56,13 +60,83 @@ struct LLDBBaseTelemetryInfo : public llvm::telemetry::TelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +/// Describes the exit status of a debugger. +struct ExitDescription { + int exit_code; + std::string des

[Lldb-commits] [lldb] [lldb] Synchronize the debugger's stdout and stderr streams (PR #126630)

2025-02-19 Thread Jonas Devlieghere via lldb-commits
https://github.com/JDevlieghere updated https://github.com/llvm/llvm-project/pull/126630 >From 8471301ad9dd694e1e6f3116d4e4ee0422c9b1dd Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Wed, 19 Feb 2025 14:30:29 -0800 Subject: [PATCH] [lldb] Synchronize the debugger's output & error stream

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-19 Thread via lldb-commits
@@ -652,6 +652,153 @@ def haltReason(self): ) self.match("register read s31", ["s31 = 128"]) +@skipIfXmlSupportMissing +@skipIfRemote +@skipIfLLVMTargetMissing("RISCV") +def test_riscv64_regs(self): +"""Test grabbing various riscv64 regi

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-19 Thread Jacob Lalonde via lldb-commits
Jlalond wrote: @clayborg DAP with a detail and a total ![image](https://github.com/user-attachments/assets/c4981158-9a19-487c-8c9b-29e55f545b37) Indeterminate with an increment detail ![image](https://github.com/user-attachments/assets/031bcdc8-f8e5-4dde-8068-668e5dde6f5b) Then with an indete

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-19 Thread via lldb-commits
https://github.com/kper updated https://github.com/llvm/llvm-project/pull/124475 >From d44dd60bc7ae5deeed91fd9389b164e441164edc Mon Sep 17 00:00:00 2001 From: Kevin Per Date: Sun, 26 Jan 2025 17:34:17 + Subject: [PATCH] [lldb] Extended if conditions to support alias names for registers ---

[Lldb-commits] [lldb] [LLDB-DAP] SBDebugger don't prefix title on progress updates (PR #124648)

2025-02-19 Thread Jacob Lalonde via lldb-commits
https://github.com/Jlalond updated https://github.com/llvm/llvm-project/pull/124648 >From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001 From: Jacob Lalonde Date: Mon, 27 Jan 2025 13:41:58 -0800 Subject: [PATCH 1/6] Only include title on the first message --- lldb/include/l

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-19 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5ecce45ea2980aff35d1283d4dd3feb8f74de16c 11efc09e1ab9ffcca8e965906530af995f5c8c83 --e

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-19 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo updated https://github.com/llvm/llvm-project/pull/127696 >From 24e9f78744f98ecf3ac01f1f719f1eac9b3479f0 Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Tue, 18 Feb 2025 15:58:08 -0500 Subject: [PATCH 1/3] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related metho

[Lldb-commits] [lldb] [WIP] [lldb][TypeSystemClang] Create clang::SourceLocation from DWARF and attach to AST (PR #127829)

2025-02-19 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/127829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Add terminfo dependency for ncurses support (PR #126810)

2025-02-19 Thread Jordan R AW via lldb-commits
ajordanr-google wrote: > Okay, I think I understand what's going on with fuchsia: they manually set > CURSES_INCLUDE_DIRS, CURSES_LIBRARIES, and PANEL_LIBRARIES. On line 17 we go > into the else-case because TINFO_LIBRARIES is not set. That's correct! > So next we check if the provided CURSES

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-19 Thread Vy Nguyen via lldb-commits
@@ -761,12 +767,29 @@ void Debugger::InstanceInitialize() { DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback, void *baton) { +#ifdef LLVM_BUILD_TELEMETRY + lldb_private::telemetry::SteadyTimePoint start_time = +

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-19 Thread Vy Nguyen via lldb-commits
@@ -56,13 +60,83 @@ struct LLDBBaseTelemetryInfo : public llvm::telemetry::TelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +/// Describes the exit status of a debugger. +struct ExitDescription { + int exit_code; + std::string des

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-02-19 Thread via lldb-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5ecce45ea2980aff35d1283d4dd3feb8f74de16c 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac --e

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-02-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vy Nguyen (oontvoo) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/127834.diff 2 Files Affected: - (modified) lldb/include/lldb/Core/Telemetry.h (+84-2) - (modified) lldb/source/Core/Telemetry.cpp (+86-13)

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-02-19 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo converted_to_draft https://github.com/llvm/llvm-project/pull/127834 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry]Define TargetInfo for collecting data about a target (PR #127834)

2025-02-19 Thread Vy Nguyen via lldb-commits
https://github.com/oontvoo created https://github.com/llvm/llvm-project/pull/127834 None >From 0d6a36d84df50ccb9eef9ef3dd6f59d4299edeac Mon Sep 17 00:00:00 2001 From: Vy Nguyen Date: Wed, 19 Feb 2025 12:47:57 -0500 Subject: [PATCH] [LLDB][Telemetry]Define TargetInfo for collecting data about

[Lldb-commits] [lldb] [lldb] Store the return SBValueList in the CommandReturnObject (PR #127566)

2025-02-19 Thread via lldb-commits
jimingham wrote: > > > * what about commands (I don't know if we have any) whose output consists > > > of more than formatting a single value (which, I guess would be lost if > > > the IDE decides to ignore the output). Are we fine with not supporting > > > that? (we could say that if a comman

[Lldb-commits] [lldb] [WIP] [lldb][TypeSystemClang] Create clang::SourceLocation from DWARF and attach to AST (PR #127829)

2025-02-19 Thread Michael Buch via lldb-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/127829 >From 1aabc8a93ffac06755cbaf5e6c1fa8913cd63729 Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Wed, 19 Feb 2025 12:47:30 + Subject: [PATCH 1/3] [lldb][TypeSystemClang] Create MainFileID for TypeSystemC

[Lldb-commits] [lldb] [WIP] [lldb][TypeSystemClang] Create clang::SourceLocation from DWARF and attach to AST (PR #127829)

2025-02-19 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/127829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] [lldb][TypeSystemClang] Create clang::SourceLocation from DWARF and attach to AST (PR #127829)

2025-02-19 Thread Michael Buch via lldb-commits
https://github.com/Michael137 edited https://github.com/llvm/llvm-project/pull/127829 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [WIP] [lldb][TypeSystemClang] Create clang::SourceLocation from DWARF and attach to AST (PR #127829)

2025-02-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Michael Buch (Michael137) Changes This patch revives https://reviews.llvm.org/D78095 with some changes. This patch uses the `DW_AT_decl_XXX` DWARF attributes to create `clang::SourceLocation`s and attach them to the Clang decls that LLDB c

[Lldb-commits] [lldb] [WIP] [lldb][TypeSystemClang] Create clang::SourceLocation from DWARF and attach to AST (PR #127829)

2025-02-19 Thread Michael Buch via lldb-commits
https://github.com/Michael137 created https://github.com/llvm/llvm-project/pull/127829 This patch revives https://reviews.llvm.org/D78095 with some changes. This patch uses the `DW_AT_decl_XXX` DWARF attributes to create `clang::SourceLocation`s and attach them to the Clang decls that LLDB cre

[Lldb-commits] [lldb] [lldb] Replace LineTable::upper_bound with GetLineEntryIndexRange (PR #127806)

2025-02-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes After (too) much deliberation, I came to the conclusion that this isn't the right abstraction, as it doesn't behave completely like the standard upper_bound method. What I really wanted was to get the range of

[Lldb-commits] [lldb] [lldb] Replace LineTable::upper_bound with GetLineEntryIndexRange (PR #127806)

2025-02-19 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/127806 After (too) much deliberation, I came to the conclusion that this isn't the right abstraction, as it doesn't behave completely like the standard upper_bound method. What I really wanted was to get the range of l

[Lldb-commits] [lldb] [lldb] Renaissance LineTable sequences (PR #127800)

2025-02-19 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/127800 LineSeqeunce is basically a vector, except that users aren't supposed to know that. This implements the same concept in a slightly simpler fashion. >From b82a233736efc391aaa408513cbea257871ab7b5 Mon Sep 17 00:00

[Lldb-commits] [lldb] [lldb] Renaissance LineTable sequences (PR #127800)

2025-02-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes LineSeqeunce is basically a vector, except that users aren't supposed to know that. This implements the same concept in a slightly simpler fashion. --- Patch is 21.79 KiB, truncated to 20.00 KiB below, full v

[Lldb-commits] [lldb] [lldb] Reimplement LineTable::FindLineEntryByAddress on top of lower_bound (PR #127799)

2025-02-19 Thread via lldb-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Pavel Labath (labath) Changes I *think* this should be equivalent to the original implementation for all line tables occurring in practice. One difference I'm aware of is that the original implementation tried to return the first line entr

[Lldb-commits] [lldb] [lldb] Reimplement LineTable::FindLineEntryByAddress on top of lower_bound (PR #127799)

2025-02-19 Thread Pavel Labath via lldb-commits
https://github.com/labath created https://github.com/llvm/llvm-project/pull/127799 I *think* this should be equivalent to the original implementation for all line tables occurring in practice. One difference I'm aware of is that the original implementation tried to return the first line entry

[Lldb-commits] [clang] [lldb] [lldb][TypeSystemClang] Initialize ClassTemplateSpecializationDecl's StrictPackMatch field (PR #126215)

2025-02-19 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: But there is reason to cherry-pick https://github.com/llvm/llvm-project/pull/125791, as it fixes a regression which would otherwise be introduced in 20.x. https://github.com/llvm/llvm-project/pull/126215 ___ lldb-commits mailing list

[Lldb-commits] [lldb] [lldb] Add LineTable::{upper, lower}_bound (PR #127519)

2025-02-19 Thread Pavel Labath via lldb-commits
https://github.com/labath closed https://github.com/llvm/llvm-project/pull/127519 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fadbc33 - [lldb] Add LineTable::{upper, lower}_bound (#127519)

2025-02-19 Thread via lldb-commits
Author: Pavel Labath Date: 2025-02-19T12:58:55+01:00 New Revision: fadbc33b01d6815bf05d802d1323322262b54d42 URL: https://github.com/llvm/llvm-project/commit/fadbc33b01d6815bf05d802d1323322262b54d42 DIFF: https://github.com/llvm/llvm-project/commit/fadbc33b01d6815bf05d802d1323322262b54d42.diff

[Lldb-commits] [lldb] [lldb] Make GetOutputStreamSP and GetErrorStreamSP protected (PR #127682)

2025-02-19 Thread Pavel Labath via lldb-commits
@@ -2837,8 +2837,8 @@ void CommandInterpreter::HandleCommandsFromFile( } if (flags & eHandleCommandFlagPrintResult) { -debugger.GetOutputFile().Printf("Executing commands in '%s'.\n", -cmd_file_path.c_str()); +debugger.GetOutputF

[Lldb-commits] [clang] [lldb] [lldb][TypeSystemClang] Initialize ClassTemplateSpecializationDecl's StrictPackMatch field (PR #126215)

2025-02-19 Thread Pavel Labath via lldb-commits
labath wrote: Okay, nevermind me then. :) Thanks for the explanation. https://github.com/llvm/llvm-project/pull/126215 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Synchronize the debugger's stdout and stderr streams (PR #126630)

2025-02-19 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. LGTM. Thanks for bearing with me. https://github.com/llvm/llvm-project/pull/126630 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] [lldb] Make GetOutputStreamSP and GetErrorStreamSP protected (PR #127682)

2025-02-19 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/127682 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Make GetOutputStreamSP and GetErrorStreamSP protected (PR #127682)

2025-02-19 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. LGTM. I am not saying that you have to do anything about this, but there are two things that caught my eye: - Debugger::GetOutputFileSP is now the biggest backdoor into our locking mechanism. In a way, it's even worse than GetOutputStreamSP,

[Lldb-commits] [lldb] [lldb] Fix RangeDataVector::CombineConsecutiveEntriesWithEqualData (PR #127059)

2025-02-19 Thread Pavel Labath via lldb-commits
https://github.com/labath updated https://github.com/llvm/llvm-project/pull/127059 >From 450371c5fd3ecce3ec54237379fef751fba45751 Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Thu, 13 Feb 2025 14:08:25 +0100 Subject: [PATCH 1/2] [lldb] Fix RangeDataVector::CombineConsecutiveEntriesWithEqua

[Lldb-commits] [lldb] [lldb] Fix RangeDataVector::CombineConsecutiveEntriesWithEqualData (PR #127059)

2025-02-19 Thread Pavel Labath via lldb-commits
@@ -493,36 +493,27 @@ class RangeDataVector { #ifdef ASSERT_RANGEMAP_ARE_SORTED assert(IsSorted()); #endif -typename Collection::iterator pos; -typename Collection::iterator end; -typename Collection::iterator prev; -bool can_combine = false; -// First w

[Lldb-commits] [lldb] [lldb] Fix RangeDataVector::CombineConsecutiveEntriesWithEqualData (PR #127059)

2025-02-19 Thread Pavel Labath via lldb-commits
@@ -493,36 +493,27 @@ class RangeDataVector { #ifdef ASSERT_RANGEMAP_ARE_SORTED assert(IsSorted()); #endif -typename Collection::iterator pos; -typename Collection::iterator end; -typename Collection::iterator prev; -bool can_combine = false; -// First w

[Lldb-commits] [lldb] [lldb] Fix RangeDataVector::CombineConsecutiveEntriesWithEqualData (PR #127059)

2025-02-19 Thread Pavel Labath via lldb-commits
@@ -493,36 +493,27 @@ class RangeDataVector { #ifdef ASSERT_RANGEMAP_ARE_SORTED assert(IsSorted()); #endif -typename Collection::iterator pos; -typename Collection::iterator end; -typename Collection::iterator prev; -bool can_combine = false; -// First w

[Lldb-commits] [clang] [lldb] [lldb][TypeSystemClang] Initialize ClassTemplateSpecializationDecl's StrictPackMatch field (PR #126215)

2025-02-19 Thread Pavel Labath via lldb-commits
labath wrote: > Cherry picking this onto the 20.x release branch requires #125791 to be > cherry-picked first. But this is just a bugfix for that PR, right? (IOW, if there's no reason to cherry-pick that PR, then there's also no reason cherry-pick this fix) https://github.com/llvm/llvm-projec

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-19 Thread Pavel Labath via lldb-commits
@@ -56,16 +54,107 @@ void LLDBBaseTelemetryInfo::serialize(Serializer &serializer) const { return UUID(random_bytes).GetAsString(); } +void LLDBBaseTelemetryInfo::serialize(Serializer &serializer) const { + serializer.write("entry_kind", getKind()); + serializer.write("se

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-19 Thread Pavel Labath via lldb-commits
@@ -56,16 +54,107 @@ void LLDBBaseTelemetryInfo::serialize(Serializer &serializer) const { return UUID(random_bytes).GetAsString(); } +void LLDBBaseTelemetryInfo::serialize(Serializer &serializer) const { + serializer.write("entry_kind", getKind()); + serializer.write("se

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-19 Thread Pavel Labath via lldb-commits
@@ -56,16 +54,107 @@ void LLDBBaseTelemetryInfo::serialize(Serializer &serializer) const { return UUID(random_bytes).GetAsString(); } +void LLDBBaseTelemetryInfo::serialize(Serializer &serializer) const { + serializer.write("entry_kind", getKind()); + serializer.write("se

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-19 Thread Pavel Labath via lldb-commits
@@ -56,16 +54,107 @@ void LLDBBaseTelemetryInfo::serialize(Serializer &serializer) const { return UUID(random_bytes).GetAsString(); } +void LLDBBaseTelemetryInfo::serialize(Serializer &serializer) const { + serializer.write("entry_kind", getKind()); + serializer.write("se

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-19 Thread Pavel Labath via lldb-commits
@@ -56,16 +54,107 @@ void LLDBBaseTelemetryInfo::serialize(Serializer &serializer) const { return UUID(random_bytes).GetAsString(); } +void LLDBBaseTelemetryInfo::serialize(Serializer &serializer) const { + serializer.write("entry_kind", getKind()); + serializer.write("se

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-19 Thread Pavel Labath via lldb-commits
@@ -761,12 +767,29 @@ void Debugger::InstanceInitialize() { DebuggerSP Debugger::CreateInstance(lldb::LogOutputCallback log_callback, void *baton) { +#ifdef LLVM_BUILD_TELEMETRY + lldb_private::telemetry::SteadyTimePoint start_time = +

[Lldb-commits] [clang] [lldb] Reland: [clang] fix P3310 overload resolution flag propagation (PR #125791)

2025-02-19 Thread via lldb-commits
llvmbot wrote: /pull-request llvm/llvm-project#127779 https://github.com/llvm/llvm-project/pull/125791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-19 Thread Pavel Labath via lldb-commits
@@ -56,13 +60,83 @@ struct LLDBBaseTelemetryInfo : public llvm::telemetry::TelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +/// Describes the exit status of a debugger. +struct ExitDescription { + int exit_code; + std::string des

[Lldb-commits] [clang] [lldb] [lldb][TypeSystemClang] Initialize ClassTemplateSpecializationDecl's StrictPackMatch field (PR #126215)

2025-02-19 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: Cherry picking this onto the 20.x release branch requires https://github.com/llvm/llvm-project/pull/125791 to be cherry-picked first. https://github.com/llvm/llvm-project/pull/126215 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [clang] [lldb] Reland: [clang] fix P3310 overload resolution flag propagation (PR #125791)

2025-02-19 Thread Matheus Izvekov via lldb-commits
mizvekov wrote: /cherry-pick 08bda1cc6b0d2f1d31a89a76b5c154a11086c420 https://github.com/llvm/llvm-project/pull/125791 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-19 Thread Pavel Labath via lldb-commits
@@ -73,6 +147,10 @@ class TelemetryManager : public llvm::telemetry::Manager { private: std::unique_ptr m_config; + // Each debugger is assigned a unique ID (session_id). + // All TelemetryInfo entries emitted for the same debugger instance + // will get the same session_

[Lldb-commits] [lldb] [LLDB][Telemetry]Define DebuggerTelemetryInfo and related methods (PR #127696)

2025-02-19 Thread Pavel Labath via lldb-commits
@@ -56,13 +60,83 @@ struct LLDBBaseTelemetryInfo : public llvm::telemetry::TelemetryInfo { void serialize(llvm::telemetry::Serializer &serializer) const override; }; +/// Describes the exit status of a debugger. +struct ExitDescription { + int exit_code; + std::string des

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-19 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-02-19 Thread David Spickett via lldb-commits
DavidSpickett wrote: Everything in the PR at the moment is fine, just need the extra test case. https://github.com/llvm/llvm-project/pull/124059 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [lldb] [lldb][LoongArch] Complete register alias name in `AugmentRegisterInfo` (PR #124059)

2025-02-19 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett requested changes to this pull request. Please add a test like `lldb/test/Shell/Register/aarch64-gp-read.test` which tests the normal and alias names using a live process. Note that the main "trick" of that test is to manually insert a breakpoint instruction: `

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-19 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-19 Thread David Spickett via lldb-commits
@@ -0,0 +1,37 @@ +# REQUIRES: native && target-riscv64 +# RUN: %clangxx_host %p/Inputs/riscv64-gp-read.cpp -o %t +# RUN: %lldb -b -s %s %t | FileCheck %s +process launch + +register read --all +# CHECK-DAG: x0 = 0x0 +# CHECK-DAG: x1 = 0x1 +# CHECK-DAG: x2 = 0x2 +# CHECK-DAG: x3 =

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-19 Thread David Spickett via lldb-commits
@@ -652,6 +652,153 @@ def haltReason(self): ) self.match("register read s31", ["s31 = 128"]) +@skipIfXmlSupportMissing +@skipIfRemote +@skipIfLLVMTargetMissing("RISCV") +def test_riscv64_regs(self): +"""Test grabbing various riscv64 regi

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-19 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett commented: I'm somewhat professionally restricted from getting too involved in RISC-V ,as much as I would like to see it actually work normally, just to save others hassle. But I can see this pretty obviously fixes the bug, so I don't have a problem letting th

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-19 Thread David Spickett via lldb-commits
@@ -148,6 +148,7 @@ def __init__(self, lit_config, config): features.add("long_tests") if target_triple: +print(target_triple) DavidSpickett wrote: Remove this https://github.com/llvm/llvm-project/pull/124475 _

[Lldb-commits] [lldb] [llvm] [lldb] Extended if conditions to support alias names for registers (PR #124475)

2025-02-19 Thread David Spickett via lldb-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/124475 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Allow option to ignore module load errors in ScriptedProcess (PR #127153)

2025-02-19 Thread Pavel Labath via lldb-commits
labath wrote: > It's never the case on Darwin that you know nothing about a loaded shared > library. You will always know at least its name, UUID, and load addresses. It > doesn't matter whether the binary exists on disk or not, we will always be > able to reconstruct at least a skeleton form

[Lldb-commits] [lldb] [lldb] Prepare UnwindPlans for discontinuous functions (PR #127661)

2025-02-19 Thread Pavel Labath via lldb-commits
https://github.com/labath edited https://github.com/llvm/llvm-project/pull/127661 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Prepare UnwindPlans for discontinuous functions (PR #127661)

2025-02-19 Thread Pavel Labath via lldb-commits
@@ -564,9 +557,8 @@ class UnwindPlan { } private: - typedef std::vector collection; - collection m_row_list; - AddressRange m_plan_valid_address_range; + std::map m_rows; labath wrote: It won't work, since the order of entries is important. What I can i

[Lldb-commits] [lldb] [lldb] Gardening in StreamAsynchronousIO (NFC) (PR #127717)

2025-02-19 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/127717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Store the return SBValueList in the CommandReturnObject (PR #127566)

2025-02-19 Thread Pavel Labath via lldb-commits
labath wrote: > > * what about commands (I don't know if we have any) whose output consists > > of more than formatting a single value (which, I guess would be lost if the > > IDE decides to ignore the output). Are we fine with not supporting that? > > (we could say that if a command wants to

[Lldb-commits] [lldb] [lldb] Store the return SBValueList in the CommandReturnObject (PR #127566)

2025-02-19 Thread Pavel Labath via lldb-commits
https://github.com/labath approved this pull request. https://github.com/llvm/llvm-project/pull/127566 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits