================
@@ -56,13 +60,83 @@ struct LLDBBaseTelemetryInfo : public 
llvm::telemetry::TelemetryInfo {
   void serialize(llvm::telemetry::Serializer &serializer) const override;
 };
 
+/// Describes the exit status of a debugger.
+struct ExitDescription {
+  int exit_code;
+  std::string description;
+};
+
+struct DebuggerTelemetryInfo : public LLDBBaseTelemetryInfo {
----------------
oontvoo wrote:

I still don't understand how it would be much simpler filter out some structs. 
Then we would still have to make the decision which fields go into the the 
so-called "sensitive data struct". 

I imagine the vendor-specific code would look something like this

```
static DebuggerInfo* sanitizeFields(DebuggerInfo* entry) {
    // null out any fields you dont want to store
   // ....
}

Error VendorDestination::receiveEntry(DebuggerInfo* entry) {
    auto* newEntry = sanitizeFields(entry);
    storeToInternalStorage(entry);
}

```

And yes, it's more convenient to group all the context together (otherwise in 
downstream data structure, we'd need to do a bunch of joining to build a 
complete "picture").



https://github.com/llvm/llvm-project/pull/127696
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to