@@ -0,0 +1,284 @@
+//===-- DILEval.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/127566
>From 6f59b1116dd83b9cce526103cca98a5d2056720f Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Mon, 17 Feb 2025 20:58:30 -0800
Subject: [PATCH] [lldb] Store the return ValueObject in the
CommandRetu
https://github.com/JDevlieghere created
https://github.com/llvm/llvm-project/pull/127566
There are a lot of lldb commands whose result is really a ValueObject that we
then print with the ValueObjectPrinter. Now that we have the ability to access
the SBCommandReturnObject through a callback (#1
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff f71b83b3593588c56fd4ab3e1347ad9c7bec624f
9c290f5d55e888c2674030da9ea06778573332da --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Jonas Devlieghere (JDevlieghere)
Changes
There are a lot of lldb commands whose result is really a ValueObject that we
then print with the ValueObjectPrinter. Now that we have the ability to access
the SBCommandReturnObject through a callb
rchamala wrote:
> I'd like to get a better understanding of what you're trying to achieve:
>
> Does the child elf-core process doesn't have any module loaded ? Are they
> only described in the tombstone and require to be downloaded which could
> potentially fail ?
Child elf-core process has m
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (dlav-sc)
Changes
lldb-server didn't consider that LR instruction may be followed not only by BNE
instruction (takes 4 bytes), but by BNEZ too, which is a compressed instruction
(takes 2 bytes). As a result, after BNEZ lldb-server res
@@ -0,0 +1,308 @@
+//===-- DILParser.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,308 @@
+//===-- DILParser.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/cmtice edited
https://github.com/llvm/llvm-project/pull/120971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
medismailben wrote:
I'd like to get a better understanding of what you're trying to achieve:
Does the child elf-core process doesn't have any module loaded ? Are they only
described in the tombstone and require to be downloaded which could potentially
fail ?
https://github.com/llvm/llvm-proje
Author: Jonas Devlieghere
Date: 2025-02-17T16:25:13-08:00
New Revision: 2b41277a09820bc47dc533ad37b5213edc2e8d52
URL:
https://github.com/llvm/llvm-project/commit/2b41277a09820bc47dc533ad37b5213edc2e8d52
DIFF:
https://github.com/llvm/llvm-project/commit/2b41277a09820bc47dc533ad37b5213edc2e8d52.d
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lldb-aarch64-windows`
running on `linaro-armv8-windows-msvc-05` while building `lldb` at step 6
"test".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/141/builds/6383
Here is the relevant piece of t
@@ -0,0 +1,284 @@
+//===-- DILEval.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,284 @@
+//===-- DILEval.cpp
---===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
rchamala wrote:
> I'm not convinced of that this change needs to be happen in ScriptedProcess ..
Just so that we’re on the same page, the logic to skip loading modules upon a
module load error is part of ScriptedProcess conversion logic in
“scriptedprocess::GetLoadedDynamicLibrariesInfos”. The
https://github.com/JDevlieghere closed
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jonas Devlieghere
Date: 2025-02-17T15:44:41-08:00
New Revision: a3dc77c00a012bb613cb08e669dab4fadf88e935
URL:
https://github.com/llvm/llvm-project/commit/a3dc77c00a012bb613cb08e669dab4fadf88e935
DIFF:
https://github.com/llvm/llvm-project/commit/a3dc77c00a012bb613cb08e669dab4fadf88e935.d
medismailben wrote:
I'm not convinced of that this change needs to be happen in ScriptedProcess ...
May be we could have a setting to not discard all modules loaded in case 1 of
them failed to load that would also work with other Process plugins. @jimingham
what do you think ?
https://github.
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/127419
>From c533d71a56fa7d6347b1698c63c8626513e70ab0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sun, 16 Feb 2025 13:27:07 -0800
Subject: [PATCH 01/10] [lldb] Support stepping over C++ thunks
This PR
https://github.com/jimingham approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/127419
>From c533d71a56fa7d6347b1698c63c8626513e70ab0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sun, 16 Feb 2025 13:27:07 -0800
Subject: [PATCH 1/9] [lldb] Support stepping over C++ thunks
This PR fi
@@ -0,0 +1,285 @@
+//===-- LineTableTest.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,285 @@
+//===-- LineTableTest.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,285 @@
+//===-- LineTableTest.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/JDevlieghere edited
https://github.com/llvm/llvm-project/pull/127519
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/JDevlieghere approved this pull request.
Thanks for taking the time to add the `FakeSymbolFile`, I'm sure that'll be
valuable in the future. LGTM.
https://github.com/llvm/llvm-project/pull/127519
___
lldb-commits mailing list
lldb-
@@ -185,6 +185,48 @@ bool LineTable::GetLineEntryAtIndex(uint32_t idx,
LineEntry &line_entry) {
return false;
}
+uint32_t LineTable::lower_bound(const Address &so_addr) const {
+ if (so_addr.GetModule() != m_comp_unit->GetModule())
+return GetSize();
+
+ Entry search_
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/127419
>From c533d71a56fa7d6347b1698c63c8626513e70ab0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sun, 16 Feb 2025 13:27:07 -0800
Subject: [PATCH 1/8] [lldb] Support stepping over C++ thunks
This PR fi
Author: Michael Buch
Date: 2025-02-17T22:03:53Z
New Revision: a377cdd23db180b881f54fc7f88bf3aa85de21cc
URL:
https://github.com/llvm/llvm-project/commit/a377cdd23db180b881f54fc7f88bf3aa85de21cc
DIFF:
https://github.com/llvm/llvm-project/commit/a377cdd23db180b881f54fc7f88bf3aa85de21cc.diff
LOG:
https://github.com/Michael137 closed
https://github.com/llvm/llvm-project/pull/127206
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
JDevlieghere wrote:
> That said, not needing to replicate the locking logic in every IOHandler
> would definitely be nice. However, I'm not certain about the feasibility of
> that. In a way, I think that the PrintAsync approach is better because it
> lets the IOHandler know that some async pri
labath wrote:
The buffering doesn't sound like a problem to me. Basically it means you have
to use the stream like an RAII object, which is sort of what we have here
anyway. We also have the same problem with not being able to get everything to
use the RAII locker object from this patch (due t
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/127519
>From 627bb23342ee22dd263f0142ea43f644afd6faae Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 17 Feb 2025 17:29:40 +0100
Subject: [PATCH] [lldb] Add LineTable::{upper,lower}_bound
The motivation is #1236
@@ -574,10 +581,10 @@ int Editline::GetCharacter(EditLineGetCharType *c) {
// indefinitely. This gives a chance for someone to interrupt us. After
// Read returns, immediately lock the mutex again and check if we were
// interrupted.
-m_output_mutex.unlock();
+
https://github.com/labath created
https://github.com/llvm/llvm-project/pull/127519
The motivation is #123622 and the fact that is hard to fine the last line entry
in a given range. `FindLineEntryByAddress(range_end-1)` is the best we have,
but it's not ideal because it has a magic -1 and that
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/127419
>From c533d71a56fa7d6347b1698c63c8626513e70ab0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sun, 16 Feb 2025 13:27:07 -0800
Subject: [PATCH 1/7] [lldb] Support stepping over C++ thunks
This PR fi
@@ -476,3 +476,12 @@ CPPLanguageRuntime::GetStepThroughTrampolinePlan(Thread
&thread,
return ret_plan_sp;
}
+
+bool CPPLanguageRuntime::IsSymbolARuntimeThunk(const Symbol &symbol) {
+ // Virtual function override thunks come in two forms. Those overriding from
a
+ // non
https://github.com/medismailben edited
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/medismailben approved this pull request.
Nice! LGTM with comment.
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -76,6 +77,18 @@ bool ThreadPlanShouldStopHere::DefaultShouldStopHereCallback(
}
}
+ // Check whether the frame we are in is a language runtime thunk, only for
+ // step out:
+ if (operation == eFrameCompareOlder) {
+Symbol *symbol = frame->GetSymbolContext(eSym
https://github.com/kastiglione closed
https://github.com/llvm/llvm-project/pull/119977
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Dave Lee
Date: 2025-02-17T11:19:14-08:00
New Revision: 6fde8fe9adc835df50ea57b710781ffe8a6657e8
URL:
https://github.com/llvm/llvm-project/commit/6fde8fe9adc835df50ea57b710781ffe8a6657e8
DIFF:
https://github.com/llvm/llvm-project/commit/6fde8fe9adc835df50ea57b710781ffe8a6657e8.diff
LOG:
https://github.com/dlav-sc edited
https://github.com/llvm/llvm-project/pull/127505
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -5669,6 +5673,10 @@ bool ObjectFileMachO::GetCorefileMainBinaryInfo(addr_t
&value,
type = eBinaryTypeStandalone;
typestr = "standalone";
break;
+ case 4:
+type = eBinaryTypeUserAllImageInfos;
+typestr = "u
jimingham wrote:
This looks fine.
The one thing that we might want to also test is that if we step through the
thunk, and then stop in some code that we don't want to stop in (i.e. the
target of the thunk doesn't have debug information) we step back out correctly.
This should work by compo
JDevlieghere wrote:
> That's okay. I thought it might not work out. Thanks for giving it a shot.
>
> I feel bad about bringing this up after you did all the work, but there is
> one more thing going through my head. I now have a very awkward feeling about
> this because it seems like this is s
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/labath approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/127206
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -574,10 +581,10 @@ int Editline::GetCharacter(EditLineGetCharType *c) {
// indefinitely. This gives a chance for someone to interrupt us. After
// Read returns, immediately lock the mutex again and check if we were
// interrupted.
-m_output_mutex.unlock();
+
labath wrote:
> > > A random idea, I don't know if it's a good one: have one object
> > > (LockableStreamPair?) that holds the two streams and their mutex. One
> > > less argument to pass around?
> >
> >
> > Sounds good, that simplifies the signatures (which this PR is already
> > touching)
https://github.com/labath updated
https://github.com/llvm/llvm-project/pull/127519
>From 2e363a1c0653f7a35d2cdcbc79353badf9fa86f0 Mon Sep 17 00:00:00 2001
From: Pavel Labath
Date: Mon, 17 Feb 2025 17:29:40 +0100
Subject: [PATCH] [lldb] Add LineTable::{upper,lower}_bound
The motivation is #1236
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/127419
>From c533d71a56fa7d6347b1698c63c8626513e70ab0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sun, 16 Feb 2025 13:27:07 -0800
Subject: [PATCH 1/5] [lldb] Support stepping over C++ thunks
This PR fi
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6812fc02fbb81d679f95d5c3e15768ae11e1bad8
b5904f01c64b2c6005f986886ce00ac507172bd2 --e
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: Pavel Labath (labath)
Changes
The motivation is #123622 and the fact that is hard to fine the last
line entry in a given range. `FindLineEntryByAddress(range_end-1)` is the best
we have, but it's not ideal because it has a magic -1 and tha
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/127419
>From c533d71a56fa7d6347b1698c63c8626513e70ab0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sun, 16 Feb 2025 13:27:07 -0800
Subject: [PATCH 1/4] [lldb] Support stepping over C++ thunks
This PR fi
@@ -476,3 +476,12 @@ CPPLanguageRuntime::GetStepThroughTrampolinePlan(Thread
&thread,
return ret_plan_sp;
}
+
+bool CPPLanguageRuntime::IsSymbolARuntimeThunk(const Symbol &symbol) {
+ // Virtual function override thunks come in two forms. Those overriding from
a
+ // non
tedwoodward wrote:
@JDevlieghere would you mind getting rid of the nullptr in the testcase,
main.cpp line 13?
Base2 *b = nullptr;
*b is set to nullptr per language standard, and those of use stuck in c++03 on
embedded targets would appreciate it!
https://github.com/llvm/llvm-project/pull/1274
Michael137 wrote:
Makes sense to me but I'll defer to @jimingham and co. for the stepping bits
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/ll
levy wrote:
I'm the one who recently added an example reproducing the #43413 issue. I
compiled this PR version of lldb and related tools and tested it against the
simple reproduction I added to the issue, and also with our complex project
where I first faced this issue. In both cases lldb work
https://github.com/JDevlieghere updated
https://github.com/llvm/llvm-project/pull/127419
>From c533d71a56fa7d6347b1698c63c8626513e70ab0 Mon Sep 17 00:00:00 2001
From: Jonas Devlieghere
Date: Sun, 16 Feb 2025 13:27:07 -0800
Subject: [PATCH 1/2] [lldb] Support stepping over C++ thunks
This PR fi
https://github.com/JDevlieghere approved this pull request.
I suspect the LLDB classes preceded their LLVM counterparts, but the latter are
much more complete and there's definitely no point having both. LGTM.
https://github.com/llvm/llvm-project/pull/127507
___
https://github.com/dlav-sc updated
https://github.com/llvm/llvm-project/pull/127507
>From 9ac7f03648a41e1ffbd17e11485fa7f717708c50 Mon Sep 17 00:00:00 2001
From: Daniil Avdeev
Date: Wed, 5 Feb 2025 13:20:24 +
Subject: [PATCH] [lldb][NFC] remove AdaptedConstIterator and AdaptedIterable
Adap
https://github.com/dlav-sc edited
https://github.com/llvm/llvm-project/pull/127507
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/dlav-sc updated
https://github.com/llvm/llvm-project/pull/127505
>From 244a67ec597d74df382825fce475b269e27a18ef Mon Sep 17 00:00:00 2001
From: Daniil Avdeev
Date: Tue, 11 Feb 2025 16:38:53 +
Subject: [PATCH] [lldb][RISCV] fix LR/SC handling in lldb-server
lldb-server did
https://github.com/dlav-sc updated
https://github.com/llvm/llvm-project/pull/127505
>From 8691dc941dab6c04e980b0b84098d665833209ea Mon Sep 17 00:00:00 2001
From: Daniil Avdeev
Date: Tue, 11 Feb 2025 16:38:53 +
Subject: [PATCH] [lldb] fix LR/SC handling in lldb-server
lldb-server didn't con
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (dlav-sc)
Changes
AdaptedConstIterator currently doesn't have iterator traits, so I can't use STL
algorithms with containers like WatchpointList.
This patch replaces AdaptedConstIterator and AdaptedIterable with
llvm::iterator_adaped
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 4d7192a5ecabb36263a2cacd4e9243b958424805
2ab6cea7391b00ec865e6b7838452511320a2eee --e
https://github.com/dlav-sc created
https://github.com/llvm/llvm-project/pull/127507
AdaptedConstIterator currently doesn't have iterator traits, so I can't use STL
algorithms with containers like WatchpointList.
This patch replaces AdaptedConstIterator and AdaptedIterable with
llvm::iterator_
llvmbot wrote:
@llvm/pr-subscribers-lldb
Author: None (dlav-sc)
Changes
I have encountered with the issue that sometimes lldb-server can't remove
internal software breakpoints in a multithread process and as a result the
process freezes.
The source of the issue was that lldb-server trie
https://github.com/dlav-sc created
https://github.com/llvm/llvm-project/pull/127506
I have encountered with the issue that sometimes lldb-server can't remove
internal software breakpoints in a multithread process and as a result the
process freezes.
The source of the issue was that lldb-serve
https://github.com/dlav-sc created
https://github.com/llvm/llvm-project/pull/127505
lldb-server didn't consider that LR instruction may be followed not only by BNE
instruction (takes 4 bytes), but by BNEZ too, which is a compressed instruction
(takes 2 bytes). As a result, after BNEZ lldb-serv
@@ -476,3 +476,9 @@ CPPLanguageRuntime::GetStepThroughTrampolinePlan(Thread
&thread,
return ret_plan_sp;
}
+
+bool CPPLanguageRuntime::IsSymbolARuntimeThunk(const Symbol &symbol) {
+ llvm::outs() << symbol.GetMangled().GetMangledName().GetStringRef() << '\n';
+ return sym
@@ -544,7 +545,7 @@ bool operator==(const CompilerType &lhs, const CompilerType
&rhs);
bool operator!=(const CompilerType &lhs, const CompilerType &rhs);
struct CompilerType::IntegralTemplateArgument {
- llvm::APSInt value;
+ clang::APValue value;
Michael13
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/127206
>From 759f0569807d00a059a78aeb3bd1eddeffcbdf36 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 14 Feb 2025 11:43:20 +
Subject: [PATCH 01/10] Init
---
lldb/include/lldb/Symbol/CompilerType.h
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/127206
>From 759f0569807d00a059a78aeb3bd1eddeffcbdf36 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 14 Feb 2025 11:43:20 +
Subject: [PATCH 1/9] Init
---
lldb/include/lldb/Symbol/CompilerType.h |
@@ -119,7 +119,7 @@
lldb_private::formatters::LibcxxStdSpanSyntheticFrontEnd::Update() {
} else if (auto arg =
m_backend.GetCompilerType().GetIntegralTemplateArgument(1))
{
- m_num_elements = arg->value.getLimitedValue();
+ m_num_elements = a
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/127206
>From 759f0569807d00a059a78aeb3bd1eddeffcbdf36 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 14 Feb 2025 11:43:20 +
Subject: [PATCH 1/8] Init
---
lldb/include/lldb/Symbol/CompilerType.h |
https://github.com/Michael137 updated
https://github.com/llvm/llvm-project/pull/127206
>From 759f0569807d00a059a78aeb3bd1eddeffcbdf36 Mon Sep 17 00:00:00 2001
From: Michael Buch
Date: Fri, 14 Feb 2025 11:43:20 +
Subject: [PATCH 1/7] Init
---
lldb/include/lldb/Symbol/CompilerType.h |
@@ -476,3 +476,9 @@ CPPLanguageRuntime::GetStepThroughTrampolinePlan(Thread
&thread,
return ret_plan_sp;
}
+
+bool CPPLanguageRuntime::IsSymbolARuntimeThunk(const Symbol &symbol) {
+ llvm::outs() << symbol.GetMangled().GetMangledName().GetStringRef() << '\n';
-
https://github.com/Michael137 edited
https://github.com/llvm/llvm-project/pull/127419
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
labath wrote:
> Given that they also need to support (1) they'd always have to be full blown
> plugins, right? So it's not like they could be migrated over to a "plugin
> light" if we came up with something like that?
Sort of. There would have to be *a* full-blown plugin. But there's no reason
https://github.com/labath approved this pull request.
https://github.com/llvm/llvm-project/pull/126757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1973,6 +1973,30 @@ class DWARFASTParserClang::DelayedAddObjCClassProperty {
ClangASTMetadata m_metadata;
};
+static std::optional MakeAPValue(const clang::ASTContext &ast,
+ CompilerType clang_type,
+
@@ -2061,17 +2082,22 @@ bool DWARFASTParserClang::ParseTemplateDIE(
std::optional size = clang_type.GetBitSize(nullptr);
if (!size)
return false;
labath wrote:
It looks like this exists only to be passed to `MakeAPValue`. Since it alr
@@ -544,7 +545,7 @@ bool operator==(const CompilerType &lhs, const CompilerType
&rhs);
bool operator!=(const CompilerType &lhs, const CompilerType &rhs);
struct CompilerType::IntegralTemplateArgument {
- llvm::APSInt value;
+ clang::APValue value;
labath wr
86 matches
Mail list logo
