jimingham wrote:

This looks fine.  

The one thing that we might want to also test is that if we step through the 
thunk, and then stop in some code that we don't want to stop in (i.e. the 
target of the thunk doesn't have debug information) we step back out correctly. 
 This should work by composition, but thunks can be funny and harder to trace 
out of...

I don't remember whether we had tests for this on the swift side, but it 
shouldn't be too hard to have the target of the thunk in a separate .cpp file, 
and strip that one.  Then make sure we don't leave the user stranded there.

https://github.com/llvm/llvm-project/pull/127419
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Reply via email to